Skip to contentSkip to conversation

ACPI: button: Drop no longer necessary Acer SW5-012 lid_init_state quirk

PATCH Applied Hans de Goede 2 participants 2 messages Oct 26, 2020 – Oct 27, 2020 ACPI

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ACPI: button: Drop no longer necessary Acer SW5-012 lid_init_state quirk

Commit 78a5b53e9fb4 ("Input: soc_button_array - work around DSDTs which modify the irqflags") adds a workaround for DSDTs with a _LID method which play tricks with the irqflags, assuming that the OS is using an irq-type of IRQ_TYPE_LEVEL_LOW.

Now that this workaround is in place, we no longer need to disable the lid functionality on the Acer SW5-012.

Fixes 78a5b53e9fb4 ("Input: soc_button_array - Work around DSDTs which modify the irqflags")
---
 drivers/acpi/button.c | 13 -------------
 1 file changed, 13 deletions(-)
drivers/acpi/button.c +0 -13
index da4b125ab4c3..0761529cac05 100644
@@ -73,19 +73,6 @@ MODULE_DEVICE_TABLE(acpi, button_device_ids);
 
 /* Please keep this list sorted alphabetically by vendor and model */
 static const struct dmi_system_id dmi_lid_quirks[] = {
-	{
-		/*
-		 * Acer Switch 10 SW5-012. _LID method messes with home and
-		 * power button GPIO IRQ settings causing an interrupt storm on
-		 * both GPIOs. This is unfixable without a DSDT override, so we
-		 * have to disable the lid-switch functionality altogether :|
-		 */
-		.matches = {
-			DMI_MATCH(DMI_SYS_VENDOR, "Acer"),
-			DMI_MATCH(DMI_PRODUCT_NAME, "Aspire SW5-012"),
-		},
-		.driver_data = (void *)(long)ACPI_BUTTON_LID_INIT_DISABLED,
-	},
 	{
 		/* GP-electronic T701, _LID method points to a floating GPIO */
 		.matches = {
Signature · 1 line
2.28.0
maintainer Applied
#1 lore raw
Quoted 30 lines · Hans de Goede

Commit 78a5b53e9fb4 ("Input: soc_button_array - work around DSDTs which modify the irqflags") adds a workaround for DSDTs with a _LID method which play tricks with the irqflags, assuming that the OS is using an irq-type of IRQ_TYPE_LEVEL_LOW.

Now that this workaround is in place, we no longer need to disable the lid functionality on the Acer SW5-012.

Fixes 78a5b53e9fb4 ("Input: soc_button_array - Work around DSDTs which modify the irqflags")
---
 drivers/acpi/button.c | 13 -------------
 1 file changed, 13 deletions(-)
drivers/acpi/button.c +0 -7
index da4b125ab4c3..0761529cac05 100644
@@ -73,19 +73,6 @@ MODULE_DEVICE_TABLE(acpi, button_device_ids);
 
 /* Please keep this list sorted alphabetically by vendor and model */
 static const struct dmi_system_id dmi_lid_quirks[] = {
-       {
-               /*
-                * Acer Switch 10 SW5-012. _LID method messes with home and
-                * power button GPIO IRQ settings causing an interrupt storm on
-                * both GPIOs. This is unfixable without a DSDT override, so we
-                * have to disable the lid-switch functionality altogether :|
-                */

drivers/acpi/button.c MODULE_DEVICE_TABLE(acpi, button_device_ids);

Quoted 10 lines
drivers/acpi/button.c +0 -7
-               .matches = {
-                       DMI_MATCH(DMI_SYS_VENDOR, "Acer"),
-                       DMI_MATCH(DMI_PRODUCT_NAME, "Aspire SW5-012"),
-               },
-               .driver_data = (void *)(long)ACPI_BUTTON_LID_INIT_DISABLED,
-       },
        {
                /* GP-electronic T701, _LID method points to a floating GPIO */
                .matches = {
--

Applied as 5.10-rc material, thanks!