Skip to contentSkip to conversation

ARM: kprobes: fix arch_init_kprobes() prototype

PATCH In review Arnd Bergmann 2 participants 2 messages Oct 26, 2020 – Oct 27, 2020 Arm (32-bit)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: kprobes: fix arch_init_kprobes() prototype

From: Arnd Bergmann <[email protected]>

With extra warnings enabled, gcc complains about this function definition:

arch/arm/probes/kprobes/core.c: In function 'arch_init_kprobes':
arch/arm/probes/kprobes/core.c:465:12: warning: old-style function definition [-Wold-style-definition]
465 | int __init arch_init_kprobes()

Fixes 24ba613c9d6c ("ARM kprobes: core code")
---
 arch/arm/probes/kprobes/core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/probes/kprobes/core.c +1 -1
index a9653117ca0d..e513d8a46776 100644
@@ -462,7 +462,7 @@ static struct undef_hook kprobes_arm_break_hook = {
 
 #endif /* !CONFIG_THUMB2_KERNEL */
 
-int __init arch_init_kprobes()
+int __init arch_init_kprobes(void)
 {
 	arm_probes_decode_init();
 #ifdef CONFIG_THUMB2_KERNEL
Signature · 1 line
2.27.0
Acked-by on v1 1/1
#1 lore raw
Quoted 11 lines · On Mon, 26 Oct 2020 23:12:00 +0100 Arnd Bergmann <[email protected]> wrote:

From: Arnd Bergmann <[email protected]>

With extra warnings enabled, gcc complains about this function definition:

arch/arm/probes/kprobes/core.c: In function 'arch_init_kprobes':
arch/arm/probes/kprobes/core.c:465:12: warning: old-style function definition [-Wold-style-definition]
465 | int __init arch_init_kprobes()

Fixes 24ba613c9d6c ("ARM kprobes: core code")

Looks good to me.

Thanks Arnd!

Quoted 20 lines
---
 arch/arm/probes/kprobes/core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/probes/kprobes/core.c +1 -1
index a9653117ca0d..e513d8a46776 100644
@@ -462,7 +462,7 @@ static struct undef_hook kprobes_arm_break_hook = {
 
 #endif /* !CONFIG_THUMB2_KERNEL */
 
-int __init arch_init_kprobes()
+int __init arch_init_kprobes(void)
 {
 	arm_probes_decode_init();
 #ifdef CONFIG_THUMB2_KERNEL
Signature · 1 line
2.27.0
Signature · 1 line
Masami Hiramatsu <[email protected]>