configs/qcom_db410c: Add support for Dragonboard410c SBC Adds basic support for the DB410c SBC. Builds the qualcomm kernel version 5.4 arm64. Adds the device's graphics firmware.
PATCH 1/3 configs/qcom_db410c: Add support for Dragonboard410c SBC Adds basic support for the DB410c SBC. Builds the qualcomm kernel version 5.4 arm64. Adds the device's graphics firmware.
--- configs/qcom_db410c_defconfig | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+) create mode 100644 configs/qcom_db410c_defconfig
configs/qcom_db410c_defconfig new file +24 -0
@@ -0,0 +1,24 @@ +# Architecture +BR2_aarch64=y + +# Toolchain options +BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_5_4=y + +# Firmware +BR2_PACKAGE_LINUX_FIRMWARE=y +BR2_PACKAGE_LINUX_FIRMWARE_QCOM_VENUS=y +BR2_PACKAGE_LINUX_FIRMWARE_QCOM_ADRENO=y + +# Kernel +BR2_LINUX_KERNEL=y +BR2_LINUX_KERNEL_CUSTOM_GIT=y +BR2_LINUX_KERNEL_CUSTOM_REPO_URL="https://git.linaro.org/landing-teams/working/qualcomm/kernel.git" +BR2_LINUX_KERNEL_CUSTOM_REPO_VERSION="release/qcomlt-5.4" +BR2_LINUX_KERNEL_USE_ARCH_DEFAULT_CONFIG=y +BR2_LINUX_KERNEL_DTS_SUPPORT=y +BR2_LINUX_KERNEL_DTB_IS_SELF_BUILT=y +BR2_LINUX_KERNEL_INTREE_DTS_NAME="apq8016-sbc" + +# Filesystem +BR2_TARGET_ROOTFS_EXT2=y +
Signature · 1 line
2.25.1
PATCH 2/3 package/qcom-db410c-firmware: add support for DB410c Wifi Added new package. Installs required Wifi firmware blobs on the target.
--- configs/qcom_db410c_defconfig | 1 + package/Config.in | 1 + package/qcom-db410c-firmware/Config.in | 5 ++++ .../qcom-db410c-firmware.mk | 28 +++++++++++++++++++ 4 files changed, 35 insertions(+) create mode 100644 package/qcom-db410c-firmware/Config.in create mode 100644 package/qcom-db410c-firmware/qcom-db410c-firmware.mk
configs/qcom_db410c_defconfig +1 -0
@@ -8,6 +8,7 @@ BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_5_4=y BR2_PACKAGE_LINUX_FIRMWARE=y BR2_PACKAGE_LINUX_FIRMWARE_QCOM_VENUS=y BR2_PACKAGE_LINUX_FIRMWARE_QCOM_ADRENO=y +BR2_PACKAGE_QCOM_DB410C_FIRMWARE=y # Kernel BR2_LINUX_KERNEL=y
package/Config.in +1 -0
@@ -400,6 +400,7 @@ menu "Firmware" source "package/b43-firmware/Config.in" source "package/linux-firmware/Config.in" source "package/murata-cyw-fw/Config.in" + source "package/qcom-db410c-firmware/Config.in" source "package/rpi-bt-firmware/Config.in" source "package/rpi-firmware/Config.in" source "package/rpi-wifi-firmware/Config.in"
package/qcom-db410c-firmware/Config.in new file +5 -0
@@ -0,0 +1,5 @@ +config BR2_PACKAGE_QCOM_DB410C_FIRMWARE + bool "qcom-db410c-firmware" + help + Wifi/BT firmware for Qualcomm Dragonboard 410c SBC. +
package/qcom-db410c-firmware/qcom-db410c-firmware.mk new file +28 -0
@@ -0,0 +1,28 @@ + +QCOM_DB410C_FIRMWARE_VERSION = r1034.2.1 +QCOM_DB410C_FIRMWARE_BASE = linux-board-support-package-$(QCOM_DB410C_FIRMWARE_VERSION) +QCOM_DB410C_FIRMWARE_SOURCE = $(QCOM_DB410C_FIRMWARE_BASE).zip +QCOM_DB410C_FIRMWARE_SITE = https://releases.linaro.org/96boards/dragonboard410c/qualcomm/firmware + +QCOM_DB410C_FIRMWARE_LICENCE = Qualcomm firmware license +QCOM_DB410C_FIRMWARE_LICENSE_FILES = LICENSE + +QCOM_DB410C_FIRMWARE_INSTALL_TARGET = YES + +define QCOM_DB410C_FIRMWARE_EXTRACT_CMDS + $(UNZIP) -d $(@D) $(QCOM_DB410C_FIRMWARE_DL_DIR)/$(QCOM_DB410C_FIRMWARE_SOURCE) +endef + +define QCOM_DB410C_FIRMWARE_INSTALL_TARGET_CMDS + $(INSTALL) -d $(TARGET_DIR)/boot + cp $(@D)/$(QCOM_DB410C_FIRMWARE_BASE)/efs-seed/fs_image_linux.tar.gz.mbn.img $(TARGET_DIR)/boot/modem_fsg + + $(INSTALL) -d $(TARGET_DIR)/lib/firmware + cp -r $(@D)/$(QCOM_DB410C_FIRMWARE_BASE)/proprietary-linux/wlan $(TARGET_DIR)/lib/firmware/ + + $(INSTALL) -d $(TARGET_DIR)/lib/firmware/qcom/msm8916 + MTOOLS_SKIP_CHECK=1 mcopy -i $(@D)/$(QCOM_DB410C_FIRMWARE_BASE)/bootloaders-linux/NON-HLOS.bin \ + ::image/modem.* ::image/mba.mbn ::image/wcnss.* $(TARGET_DIR)/lib/firmware/qcom/msm8916 +endef + +$(eval $(generic-package))
Signature · 1 line
2.25.1
PATCH 2/3 package/qcom-db410c-firmware: add support for DB410c Wifi Added new package. Installs required Wifi firmware blobs on the target.
Hello Mike,
Quoted 7 lines · On Tue, 27 Oct 2020 20:50:55 +1300 Mike Frampton <[email protected]> wrote:
Signed-off-by Mike Frampton <[email protected]>--- configs/qcom_db410c_defconfig | 1 + package/Config.in | 1 + package/qcom-db410c-firmware/Config.in | 5 ++++ .../qcom-db410c-firmware.mk | 28 +++++++++++++++++++ 4 files changed, 35 insertions(+)
You are adding a new package: we need an entry in the DEVELOPERS file for it.
Also, please add a hash file for this package.
The commit title should be:
package/qcom-db410c-firmware: new package
it would perhaps be nice to have a bit of explanation in the commit log about the oddities of this package. Or even better: a few comments above the install target commands.
configs/qcom_db410c_defconfig BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_5_4=y · line 11
Quoted 12 lines
create mode 100644 package/qcom-db410c-firmware/Config.in create mode 100644 package/qcom-db410c-firmware/qcom-db410c-firmware.mkconfigs/qcom_db410c_defconfig +1
-0@@ -8,6 +8,7 @@ BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_5_4=y BR2_PACKAGE_LINUX_FIRMWARE=y BR2_PACKAGE_LINUX_FIRMWARE_QCOM_VENUS=y BR2_PACKAGE_LINUX_FIRMWARE_QCOM_ADRENO=y +BR2_PACKAGE_QCOM_DB410C_FIRMWARE=y
This should be in the patch adding the defconfig. In fact, your patch 1/3 adding the defconfig should be the last one in the series.
Quoted 29 lines
package/Config.in +1
-0@@ -400,6 +400,7 @@ menu "Firmware" source "package/b43-firmware/Config.in" source "package/linux-firmware/Config.in" source "package/murata-cyw-fw/Config.in" + source "package/qcom-db410c-firmware/Config.in" source "package/rpi-bt-firmware/Config.in" source "package/rpi-firmware/Config.in" source "package/rpi-wifi-firmware/Config.in"package/qcom-db410c-firmware/Config.in new file +5
-0@@ -0,0 +1,5 @@ +config BR2_PACKAGE_QCOM_DB410C_FIRMWARE + bool "qcom-db410c-firmware" + help + Wifi/BT firmware for Qualcomm Dragonboard 410c SBC. +package/qcom-db410c-firmware/qcom-db410c-firmware.mk new file +0
-0
package/qcom-db410c-firmware/qcom-db410c-firmware.mk line 1
Quoted 1 line
package/qcom-db410c-firmware/qcom-db410c-firmware.mk new file +1
-0@@ -0,0 +1,28 @@ +
We like to have our traditional header here, like this:
################################################################################
#
# qcom-db410c-firmware # ################################################################################
yes, this is silly, but consistency wins over silliness :-)
package/qcom-db410c-firmware/qcom-db410c-firmware.mk line 2
Quoted 1 line
package/qcom-db410c-firmware/qcom-db410c-firmware.mk new file +1
-0+QCOM_DB410C_FIRMWARE_VERSION = r1034.2.1
Please set the version to just 1034.2.1, and encode the "r" in the _SOURCE and _BASE variables.
package/qcom-db410c-firmware/qcom-db410c-firmware.mk line 10
Quoted 8 lines
package/qcom-db410c-firmware/qcom-db410c-firmware.mk new file +8
-0+QCOM_DB410C_FIRMWARE_BASE = linux-board-support-package-$(QCOM_DB410C_FIRMWARE_VERSION) +QCOM_DB410C_FIRMWARE_SOURCE = $(QCOM_DB410C_FIRMWARE_BASE).zip +QCOM_DB410C_FIRMWARE_SITE = https://releases.linaro.org/96boards/dragonboard410c/qualcomm/firmware + +QCOM_DB410C_FIRMWARE_LICENCE = Qualcomm firmware license +QCOM_DB410C_FIRMWARE_LICENSE_FILES = LICENSE + +QCOM_DB410C_FIRMWARE_INSTALL_TARGET = YES
Not needed, this is the default.
package/qcom-db410c-firmware/qcom-db410c-firmware.mk line 17
Quoted 6 lines
package/qcom-db410c-firmware/qcom-db410c-firmware.mk new file +6
-0+define QCOM_DB410C_FIRMWARE_EXTRACT_CMDS + $(UNZIP) -d $(@D) $(QCOM_DB410C_FIRMWARE_DL_DIR)/$(QCOM_DB410C_FIRMWARE_SOURCE) +endef + +define QCOM_DB410C_FIRMWARE_INSTALL_TARGET_CMDS + $(INSTALL) -d $(TARGET_DIR)/boot
Not needed if you change a bit the next line.
package/qcom-db410c-firmware/qcom-db410c-firmware.mk line 18
Quoted 1 line
package/qcom-db410c-firmware/qcom-db410c-firmware.mk new file +1
-0+ cp $(@D)/$(QCOM_DB410C_FIRMWARE_BASE)/efs-seed/fs_image_linux.tar.gz.mbn.img $(TARGET_DIR)/boot/modem_fsg
Change to:
$(INSTALL) -D -m 0644 \ $(@D)/$(QCOM_DB410C_FIRMWARE_BASE)/efs-seed/fs_image_linux.tar.gz.mbn.img \ $(TARGET_DIR)/boot/modem_fsg
package/qcom-db410c-firmware/qcom-db410c-firmware.mk line 25
Quoted 6 lines
package/qcom-db410c-firmware/qcom-db410c-firmware.mk new file +6
-0+ $(INSTALL) -d $(TARGET_DIR)/lib/firmware + cp -r $(@D)/$(QCOM_DB410C_FIRMWARE_BASE)/proprietary-linux/wlan $(TARGET_DIR)/lib/firmware/ + + $(INSTALL) -d $(TARGET_DIR)/lib/firmware/qcom/msm8916 + MTOOLS_SKIP_CHECK=1 mcopy -i $(@D)/$(QCOM_DB410C_FIRMWARE_BASE)/bootloaders-linux/NON-HLOS.bin \ + ::image/modem.* ::image/mba.mbn ::image/wcnss.* $(TARGET_DIR)/lib/firmware/qcom/msm8916
Doh, why are you using mcopy here? The files you need are burried inside NON-HLOS.bin which is a FAT filesystem image ?
If you need mcopy, then you'll need a dependency on host-mtools, and use $(HOST_DIR)/bin/mcopy instead, as you can't rely on mcopy being available system-wide.
Thanks!
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
PATCH 3/3 package/abootimg: add host build for abootimg Build abootimg on the host, and use it to build a kernel image for the DB410c.
In reply to Mike Frampton--- board/qcom/db410c/post-image.sh | 21 +++++++++++++++++++++ configs/qcom_db410c_defconfig | 4 ++++ package/Config.in.host | 1 + package/abootimg/Config.in.host | 8 ++++++++ package/abootimg/abootimg.mk | 12 ++++++++++++ 5 files changed, 46 insertions(+) create mode 100755 board/qcom/db410c/post-image.sh create mode 100644 package/abootimg/Config.in.host
board/qcom/db410c/post-image.sh new file +21 -0
@@ -0,0 +1,21 @@ +#!/bin/bash + +set -e + +OUTIMG=$BINARIES_DIR/boot-db410c.img +KERNEL_BUILD=$BUILD_DIR/linux-release_qcomlt-5.4 + +cp $KERNEL_BUILD/arch/arm64/boot/dts/qcom/apq8016-sbc.dtb $BINARIES_DIR +cp $KERNEL_BUILD/arch/arm64/boot/Image.gz $BINARIES_DIR + +# now assemble the bootimg +#cd $BINARIES_DIR +cat $BINARIES_DIR/Image.gz $BINARIES_DIR/apq8016-sbc.dtb > $BINARIES_DIR/Image.gz+dtb +echo "not a ramdisk" > $BINARIES_DIR/ramdisk.img + +abootimg --create $OUTIMG -k $BINARIES_DIR/Image.gz+dtb -r $BINARIES_DIR/ramdisk.img \ + -c pagesize=2048 -c kerneladdr=0x80008000 -c ramdiskaddr=0x81000000 \ + -c cmdline="root=/dev/mmcblk1p13 rw rootwait console=tty0 console=ttyMSM0,115200n8" + +echo "boot img written to $OUTIMG" +
configs/qcom_db410c_defconfig +4 -0
@@ -10,6 +10,10 @@ BR2_PACKAGE_LINUX_FIRMWARE_QCOM_VENUS=y BR2_PACKAGE_LINUX_FIRMWARE_QCOM_ADRENO=y BR2_PACKAGE_QCOM_DB410C_FIRMWARE=y +# Bootloader/boot image +BR2_PACKAGE_HOST_ABOOTIMG=y +BR2_ROOTFS_POST_IMAGE_SCRIPT="board/qcom/db410c/post-image.sh" + # Kernel BR2_LINUX_KERNEL=y BR2_LINUX_KERNEL_CUSTOM_GIT=y
package/Config.in.host +1 -0
@@ -1,5 +1,6 @@ menu "Host utilities" + source "package/abootimg/Config.in.host" source "package/aespipe/Config.in.host" source "package/android-tools/Config.in.host" source "package/btrfs-progs/Config.in.host"
package/abootimg/Config.in.host new file +8 -0
@@ -0,0 +1,8 @@ +config BR2_PACKAGE_HOST_ABOOTIMG + bool "host abootimg" + select BR2_PACKAGE_HOST_UTIL_LINUX + help + Tool to manipulate Android Boot Images, either on files + or directly on /dev block devices. + + https://github.com/ggrandou/abootimg
package/abootimg/abootimg.mk +12 -0
@@ -11,6 +11,7 @@ ABOOTIMG_LICENSE_FILES = LICENSE # depends on libblkid from util-linux ABOOTIMG_DEPENDENCIES = util-linux +ABOOTIMG_HOST_DEPENDENCIES = host-util-linux define ABOOTIMG_BUILD_CMDS $(TARGET_MAKE_ENV) $(MAKE) $(TARGET_CONFIGURE_OPTS) -C $(@D)
@@ -20,4 +21,15 @@ define ABOOTIMG_INSTALL_TARGET_CMDS $(INSTALL) -m 0755 $(@D)/abootimg $(TARGET_DIR)/usr/bin/abootimg endef +# host build + +define HOST_ABOOTIMG_BUILD_CMDS + $(MAKE) $(HOST_CONFIGURE_OPTS) -C $(@D) +endef + +define HOST_ABOOTIMG_INSTALL_CMDS + $(INSTALL) -m 0755 $(@D)/abootimg $(HOST_DIR)/usr/bin/abootimg +endef + $(eval $(generic-package)) +$(eval $(host-generic-package))
Signature · 1 line
2.25.1
PATCH 3/3 package/abootimg: add host build for abootimg Build abootimg on the host, and use it to build a kernel image for the DB410c.
Hello,
Quoted 10 lines · On Tue, 27 Oct 2020 20:50:56 +1300 Mike Frampton <[email protected]> wrote:
Signed-off-by Mike Frampton <[email protected]>--- board/qcom/db410c/post-image.sh | 21 +++++++++++++++++++++ configs/qcom_db410c_defconfig | 4 ++++ package/Config.in.host | 1 + package/abootimg/Config.in.host | 8 ++++++++ package/abootimg/abootimg.mk | 12 ++++++++++++ 5 files changed, 46 insertions(+) create mode 100755 board/qcom/db410c/post-image.sh create mode 100644 package/abootimg/Config.in.host
There should be one commit adding support for abootimg as a host package, and then the commit adding the defconfig file together with its post-image script.
Quoted 6 lines
board/qcom/db410c/post-image.sh new file +0
-0
board/qcom/db410c/post-image.sh line 9
Quoted 9 lines
board/qcom/db410c/post-image.sh new file +9
-0@@ -0,0 +1,21 @@ +#!/bin/bash + +set -e + +OUTIMG=$BINARIES_DIR/boot-db410c.img +KERNEL_BUILD=$BUILD_DIR/linux-release_qcomlt-5.4 + +cp $KERNEL_BUILD/arch/arm64/boot/dts/qcom/apq8016-sbc.dtb $BINARIES_DIR +cp $KERNEL_BUILD/arch/arm64/boot/Image.gz $BINARIES_DIR
This shouldn't be necessary: the linux package already installs the kernel image and DTB in BINARIES_DIR. And this would avoid the need to hardcode the KERNEL_BUILD directory.
board/qcom/db410c/post-image.sh line 12
Quoted 2 lines
board/qcom/db410c/post-image.sh new file +2
-0+# now assemble the bootimg +#cd $BINARIES_DIR
Line commented, not needed.
board/qcom/db410c/post-image.sh line 20
Quoted 8 lines
board/qcom/db410c/post-image.sh new file +8
-0+cat $BINARIES_DIR/Image.gz $BINARIES_DIR/apq8016-sbc.dtb > $BINARIES_DIR/Image.gz+dtb +echo "not a ramdisk" > $BINARIES_DIR/ramdisk.img + +abootimg --create $OUTIMG -k $BINARIES_DIR/Image.gz+dtb -r $BINARIES_DIR/ramdisk.img \ + -c pagesize=2048 -c kerneladdr=0x80008000 -c ramdiskaddr=0x81000000 \ + -c cmdline="root=/dev/mmcblk1p13 rw rootwait console=tty0 console=ttyMSM0,115200n8" + +echo "boot img written to $OUTIMG"
This last line is not needed.
Instead, what we like is to have a board/qcom/db410c/readme.txt file that explains how to use/build/flash this defconfig. See other readme.txt files in board/ for a number of examples.
Quoted 13 lines
package/abootimg/abootimg.mk +1
-0@@ -11,6 +11,7 @@ ABOOTIMG_LICENSE_FILES = LICENSE # depends on libblkid from util-linux ABOOTIMG_DEPENDENCIES = util-linux +ABOOTIMG_HOST_DEPENDENCIES = host-util-linux define ABOOTIMG_BUILD_CMDS $(TARGET_MAKE_ENV) $(MAKE) $(TARGET_CONFIGURE_OPTS) -C $(@D)
package/abootimg/abootimg.mk define ABOOTIMG_INSTALL_TARGET_CMDS · line 24
Quoted 4 lines
package/abootimg/abootimg.mk +1
-0@@ -20,4 +21,15 @@ define ABOOTIMG_INSTALL_TARGET_CMDS $(INSTALL) -m 0755 $(@D)/abootimg $(TARGET_DIR)/usr/bin/abootimg endef +# host build
This comment is not needed, it's pretty obvious.
package/abootimg/abootimg.mk define ABOOTIMG_INSTALL_TARGET_CMDS · line 35
Quoted 10 lines
package/abootimg/abootimg.mk +9
-0+define HOST_ABOOTIMG_BUILD_CMDS + $(MAKE) $(HOST_CONFIGURE_OPTS) -C $(@D) +endef + +define HOST_ABOOTIMG_INSTALL_CMDS + $(INSTALL) -m 0755 $(@D)/abootimg $(HOST_DIR)/usr/bin/abootimg +endef + $(eval $(generic-package)) +$(eval $(host-generic-package))
Otherwise, looks good!
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
PATCH 1/3 configs/qcom_db410c: Add support for Dragonboard410c SBC Adds basic support for the DB410c SBC. Builds the qualcomm kernel version 5.4 arm64. Adds the device's graphics firmware.
In reply to Mike FramptonHello Mike,
Quoted 5 lines · On Tue, 27 Oct 2020 20:50:54 +1300 Mike Frampton <[email protected]> wrote:
Signed-off-by Mike Frampton <[email protected]>--- configs/qcom_db410c_defconfig | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+) create mode 100644 configs/qcom_db410c_defconfig
This looks good overall, but as explained in the review of the other patches, this patch should come last in the series, once all the preparation is done (adding a package for the firmware, host-abootimg support). Also:
- The commit title shoudld be just "configs/qcom_db410c: new defconfig"
- An entry in the DEVELOPERS file should be added for the defconfig file and the board/qcom/db410c/ directory
- A readme.txt should be added in board/qcom/db410c/readme.txt.
configs/qcom_db410c_defconfig line 2
Quoted 8 lines
configs/qcom_db410c_defconfig new file +2
-0@@ -0,0 +1,24 @@ +# Architecture +BR2_aarch64=y
Perhaps set the specific sub-architecture being used ?
Quoted 12 lines
configs/qcom_db410c_defconfig new file +12
-0+ +# Toolchain options +BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_5_4=y + +# Firmware +BR2_PACKAGE_LINUX_FIRMWARE=y +BR2_PACKAGE_LINUX_FIRMWARE_QCOM_VENUS=y +BR2_PACKAGE_LINUX_FIRMWARE_QCOM_ADRENO=y + +# Kernel +BR2_LINUX_KERNEL=y +BR2_LINUX_KERNEL_CUSTOM_GIT=y
configs/qcom_db410c_defconfig line 24
Quoted 10 lines
configs/qcom_db410c_defconfig new file +10
-0+BR2_LINUX_KERNEL_CUSTOM_REPO_URL="https://git.linaro.org/landing-teams/working/qualcomm/kernel.git" +BR2_LINUX_KERNEL_CUSTOM_REPO_VERSION="release/qcomlt-5.4" +BR2_LINUX_KERNEL_USE_ARCH_DEFAULT_CONFIG=y +BR2_LINUX_KERNEL_DTS_SUPPORT=y +BR2_LINUX_KERNEL_DTB_IS_SELF_BUILT=y +BR2_LINUX_KERNEL_INTREE_DTS_NAME="apq8016-sbc" + +# Filesystem +BR2_TARGET_ROOTFS_EXT2=y +
Thanks!
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
PATCH 1/3 configs/qcom_db410c: Add support for Dragonboard410c SBC Adds basic support for the DB410c SBC. Builds the qualcomm kernel version 5.4 arm64. Adds the device's graphics firmware.
Hi Thomas,
Thanks very much for the feedback! I'll post an updated patch soon which addresses your comments.
Cheers,
--Mike
Quoted 65 lines · Thomas Petazzoni
Hello Mike,
Quoted 5 lines · On Tue, 27 Oct 2020 20:50:54 +1300 Mike Frampton <[email protected]> wrote:
Signed-off-by Mike Frampton <[email protected]>--- configs/qcom_db410c_defconfig | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+) create mode 100644 configs/qcom_db410c_defconfigThis looks good overall, but as explained in the review of the other patches, this patch should come last in the series, once all the preparation is done (adding a package for the firmware, host-abootimg support). Also:
- The commit title shoudld be just "configs/qcom_db410c: new defconfig"
- An entry in the DEVELOPERS file should be added for the defconfig file and the board/qcom/db410c/ directory
- A readme.txt should be added in
board/qcom/db410c/readme.txt.configs/qcom_db410c_defconfig line 2
Quoted 8 lines
configs/qcom_db410c_defconfig new file +2
-0@@ -0,0 +1,24 @@ +# Architecture +BR2_aarch64=yPerhaps set the specific sub-architecture being used ?
Quoted 12 lines
configs/qcom_db410c_defconfig new file +12
-0+ +# Toolchain options +BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_5_4=y + +# Firmware +BR2_PACKAGE_LINUX_FIRMWARE=y +BR2_PACKAGE_LINUX_FIRMWARE_QCOM_VENUS=y +BR2_PACKAGE_LINUX_FIRMWARE_QCOM_ADRENO=y + +# Kernel +BR2_LINUX_KERNEL=y +BR2_LINUX_KERNEL_CUSTOM_GIT=yconfigs/qcom_db410c_defconfig line 24
Quoted 10 lines
configs/qcom_db410c_defconfig new file +10
-0+BR2_LINUX_KERNEL_CUSTOM_REPO_URL="https://git.linaro.org/landing-teams/working/qualcomm/kernel.git" +BR2_LINUX_KERNEL_CUSTOM_REPO_VERSION="release/qcomlt-5.4" +BR2_LINUX_KERNEL_USE_ARCH_DEFAULT_CONFIG=y +BR2_LINUX_KERNEL_DTS_SUPPORT=y +BR2_LINUX_KERNEL_DTB_IS_SELF_BUILT=y +BR2_LINUX_KERNEL_INTREE_DTS_NAME="apq8016-sbc" + +# Filesystem +BR2_TARGET_ROOTFS_EXT2=y +Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com