Skip to contentSkip to conversation

fs/pstore/zone.c:1339 register_pstore_zone() warn: variable dereferenced before check 'info->ops' (see line 1311)

PATCH New Dan Carpenter 1 participant 1 message Oct 27, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 4/6 fs/pstore/zone.c:1339 register_pstore_zone() warn: variable dereferenced before check 'info->ops' (see line 1311)

tree:   git://git.infradead.org/users/hch/misc.git pstore
head:   b85058aa7221e22b991350b5153fbb086a3f586e
commit: a275f3bc2fb9b2e83ae41c35332c54b78ca907c0 [4/6] pstore/zone: split struct pstore_zone_info
config: x86_64-randconfig-m031-20201016 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0

If you fix the issue, kindly add following tag as appropriate

New smatch warnings:
fs/pstore/zone.c:1339 register_pstore_zone() warn: variable dereferenced before check 'info->ops' (see line 1311)

vim +1339 fs/pstore/zone.c

d26c3321fe18dc7 WeiXiong Liao     2020-03-25  1295  int register_pstore_zone(struct pstore_zone_info *info)
d26c3321fe18dc7 WeiXiong Liao     2020-03-25  1296  {
d26c3321fe18dc7 WeiXiong Liao     2020-03-25  1297  	int err = -EINVAL;
d26c3321fe18dc7 WeiXiong Liao     2020-03-25  1298  	struct psz_context *cxt = &pstore_zone_cxt;
d26c3321fe18dc7 WeiXiong Liao     2020-03-25  1299  
d26c3321fe18dc7 WeiXiong Liao     2020-03-25  1300  	if (info->total_size < 4096) {
d26c3321fe18dc7 WeiXiong Liao     2020-03-25  1301  		pr_warn("total_size must be >= 4096\n");
d26c3321fe18dc7 WeiXiong Liao     2020-03-25  1302  		return -EINVAL;
d26c3321fe18dc7 WeiXiong Liao     2020-03-25  1303  	}
d26c3321fe18dc7 WeiXiong Liao     2020-03-25  1304  
34327e9fd213414 WeiXiong Liao     2020-03-25  1305  	if (!info->kmsg_size && !info->pmsg_size && !info->console_size &&
34327e9fd213414 WeiXiong Liao     2020-03-25  1306  	    !info->ftrace_size) {
d26c3321fe18dc7 WeiXiong Liao     2020-03-25  1307  		pr_warn("at least one record size must be non-zero\n");
d26c3321fe18dc7 WeiXiong Liao     2020-03-25  1308  		return -EINVAL;
d26c3321fe18dc7 WeiXiong Liao     2020-03-25  1309  	}
d26c3321fe18dc7 WeiXiong Liao     2020-03-25  1310  
a275f3bc2fb9b2e Christoph Hellwig 2020-10-15 @1311  	if (!info->ops->name || !info->ops->name[0])
                                                             ^^^^^^^^^^^^^^^     ^^^^^^^^^^^^^^^

info->ops derferenced.

d26c3321fe18dc7 WeiXiong Liao     2020-03-25  1312  		return -EINVAL;
d26c3321fe18dc7 WeiXiong Liao     2020-03-25  1313  
d26c3321fe18dc7 WeiXiong Liao     2020-03-25  1314  #define check_size(name, size) {					\
d26c3321fe18dc7 WeiXiong Liao     2020-03-25  1315  		if (info->name > 0 && info->name < (size)) {		\
d26c3321fe18dc7 WeiXiong Liao     2020-03-25  1316  			pr_err(#name " must be over %d\n", (size));	\
d26c3321fe18dc7 WeiXiong Liao     2020-03-25  1317  			return -EINVAL;					\
d26c3321fe18dc7 WeiXiong Liao     2020-03-25  1318  		}							\
d26c3321fe18dc7 WeiXiong Liao     2020-03-25  1319  		if (info->name & (size - 1)) {				\
d26c3321fe18dc7 WeiXiong Liao     2020-03-25  1320  			pr_err(#name " must be a multiple of %d\n",	\
d26c3321fe18dc7 WeiXiong Liao     2020-03-25  1321  					(size));			\
d26c3321fe18dc7 WeiXiong Liao     2020-03-25  1322  			return -EINVAL;					\
d26c3321fe18dc7 WeiXiong Liao     2020-03-25  1323  		}							\
d26c3321fe18dc7 WeiXiong Liao     2020-03-25  1324  	}
d26c3321fe18dc7 WeiXiong Liao     2020-03-25  1325  
d26c3321fe18dc7 WeiXiong Liao     2020-03-25  1326  	check_size(total_size, 4096);
d26c3321fe18dc7 WeiXiong Liao     2020-03-25  1327  	check_size(kmsg_size, SECTOR_SIZE);
0dc068265a1c592 WeiXiong Liao     2020-03-25  1328  	check_size(pmsg_size, SECTOR_SIZE);
cc9c4d1b5597167 WeiXiong Liao     2020-03-25  1329  	check_size(console_size, SECTOR_SIZE);
34327e9fd213414 WeiXiong Liao     2020-03-25  1330  	check_size(ftrace_size, SECTOR_SIZE);
d26c3321fe18dc7 WeiXiong Liao     2020-03-25  1331  
d26c3321fe18dc7 WeiXiong Liao     2020-03-25  1332  #undef check_size
d26c3321fe18dc7 WeiXiong Liao     2020-03-25  1333  
d26c3321fe18dc7 WeiXiong Liao     2020-03-25  1334  	/*
d26c3321fe18dc7 WeiXiong Liao     2020-03-25  1335  	 * the @read and @write must be applied.
d26c3321fe18dc7 WeiXiong Liao     2020-03-25  1336  	 * if no @read, pstore may mount failed.
d26c3321fe18dc7 WeiXiong Liao     2020-03-25  1337  	 * if no @write, pstore do not support to remove record file.
d26c3321fe18dc7 WeiXiong Liao     2020-03-25  1338  	 */
a275f3bc2fb9b2e Christoph Hellwig 2020-10-15 @1339  	if (!info->ops || !info->ops->read || !info->ops->write) {
                                                            ^^^^^^^^^^

Checked too late.

d26c3321fe18dc7 WeiXiong Liao     2020-03-25  1340  		pr_err("no valid general read/write interface\n");
d26c3321fe18dc7 WeiXiong Liao     2020-03-25  1341  		return -EINVAL;
d26c3321fe18dc7 WeiXiong Liao     2020-03-25  1342  	}
d26c3321fe18dc7 WeiXiong Liao     2020-03-25  1343  
d26c3321fe18dc7 WeiXiong Liao     2020-03-25  1344  	mutex_lock(&cxt->pstore_zone_info_lock);

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org