Skip to contentSkip to conversation

package/gst-omx: fix gstomx.conf installation for raspberry

PATCH New Augustin Thiercelin 3 participants 3 messages Oct 27, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/gst-omx: fix gstomx.conf installation for raspberry

The commit 7e6f4e5 introduces a new bug when building the gst-omx package for the raspberry.

GST_OMX_VARIANT variable in gst-omx.mk was shadowed to 'generic' after being set well for raspberry. It results having the gstomx.conf not being installed, and thus having gst-omx installed but none of its features available.

---
 package/gstreamer1/gst-omx/gst-omx.mk | 1 +
 1 file changed, 1 insertion(+)
package/gstreamer1/gst-omx/gst-omx.mk +1 -0
index cdd0e86b04..9e35ff3d04 100644
@@ -20,6 +20,7 @@ GST_OMX_CONF_OPTS = \
 ifeq ($(BR2_PACKAGE_RPI_USERLAND),y)
 GST_OMX_VARIANT = rpi
 GST_OMX_CONF_OPTS += -Dheader_path=$(STAGING_DIR)/usr/include/IL
+else
 GST_OMX_VARIANT = generic
 endif
 
Signature · 1 line
2.29.1
#1 lore raw

PATCH 1/1 package/gst-omx: fix gstomx.conf installation for raspberry

Hello Augustin,

Quoted 23 lines

Gesendet: Dienstag, 27. Oktober 2020 um 12:30 Uhr
Von: "Augustin Thiercelin" <[email protected]>
An: buildroot at buildroot.org
Cc: "Augustin Thiercelin" <[email protected]>
Betreff: [Buildroot] [PATCH 1/1] package/gst-omx: fix gstomx.conf installation for raspberry

The commit 7e6f4e5 introduces a new bug when building the gst-omx package for the raspberry.

GST_OMX_VARIANT variable in gst-omx.mk was shadowed to 'generic' after being set well for raspberry. It results having the gstomx.conf not being installed, and thus having gst-omx installed but none of its features available.

---
 package/gstreamer1/gst-omx/gst-omx.mk | 1 +
 1 file changed, 1 insertion(+)
package/gstreamer1/gst-omx/gst-omx.mk +0 -0
index cdd0e86b04..9e35ff3d04 100644

package/gstreamer1/gst-omx/gst-omx.mk GST_OMX_CONF_OPTS = \ · line 26

Quoted 7 lines
package/gstreamer1/gst-omx/gst-omx.mk +1 -0
@@ -20,6 +20,7 @@ GST_OMX_CONF_OPTS = \
 ifeq ($(BR2_PACKAGE_RPI_USERLAND),y)
 GST_OMX_VARIANT = rpi
 GST_OMX_CONF_OPTS += -Dheader_path=$(STAGING_DIR)/usr/include/IL
+else
 GST_OMX_VARIANT = generic
 endif
 

Thanks for the patch iteration:

Regards,
Peter

Quoted 8 lines

--
2.29.1

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

#2 lore raw

PATCH 1/1 package/gst-omx: fix gstomx.conf installation for raspberry

In reply to Augustin Thiercelin

Augustin, All,

On 2020-10-27 12:30 +0100, Augustin Thiercelin spake thusly:

Quoted 8 lines

The commit 7e6f4e5 introduces a new bug when building the gst-omx package for the raspberry.

GST_OMX_VARIANT variable in gst-omx.mk was shadowed to 'generic' after being set well for raspberry. It results having the gstomx.conf not being installed, and thus having gst-omx installed but none of its features available.

Applied to master, thanks.

Regards,
Yann E. MORIN.

Quoted 23 lines
---
 package/gstreamer1/gst-omx/gst-omx.mk | 1 +
 1 file changed, 1 insertion(+)
package/gstreamer1/gst-omx/gst-omx.mk +1 -0
index cdd0e86b04..9e35ff3d04 100644
@@ -20,6 +20,7 @@ GST_OMX_CONF_OPTS = \
 ifeq ($(BR2_PACKAGE_RPI_USERLAND),y)
 GST_OMX_VARIANT = rpi
 GST_OMX_CONF_OPTS += -Dheader_path=$(STAGING_DIR)/usr/include/IL
+else
 GST_OMX_VARIANT = generic
 endif
 
Signature · 6 lines
2.29.1

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'