Skip to contentSkip to conversation

drivers/net/mlx: do not enforce RSS hash offload

PATCH Superseded Alexander Kozyrev 2 participants 3 messages Sep 29, 2020 – Oct 27, 2020 Network drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drivers/net/mlx: do not enforce RSS hash offload

From: Alexander Kozyrev <[email protected]>

Rx RSS hash offload should be controlled by the user and should not be enforced by RSS multi-queue Rx mode.

Fixes 8b945a7f7dcb ("drivers/net: update Rx RSS hash offload capabilities")

Author: Andrew Rybchenko <[email protected]>

---
 drivers/net/mlx4/mlx4.c        | 3 ---
 drivers/net/mlx5/mlx5_ethdev.c | 3 ---
 2 files changed, 6 deletions(-)
drivers/net/mlx4/mlx4.c +0 -3
index 71061a720f..318580bd73 100644
@@ -249,9 +249,6 @@ mlx4_dev_configure(struct rte_eth_dev *dev)
 	struct rte_flow_error error;
 	int ret;
 
-	if (dev->data->dev_conf.rxmode.mq_mode & ETH_MQ_RX_RSS_FLAG)
-		dev->data->dev_conf.rxmode.offloads |= DEV_RX_OFFLOAD_RSS_HASH;
-
 	/* Prepare internal flow rules. */
 	ret = mlx4_flow_sync(priv, &error);
 	if (ret) {
drivers/net/mlx5/mlx5_ethdev.c +0 -3
index 7631f644b2..09b93405d3 100644
@@ -86,9 +86,6 @@ mlx5_dev_configure(struct rte_eth_dev *dev)
 		return -rte_errno;
 	}
 
-	if (dev->data->dev_conf.rxmode.mq_mode & ETH_MQ_RX_RSS_FLAG)
-		dev->data->dev_conf.rxmode.offloads |= DEV_RX_OFFLOAD_RSS_HASH;
-
 	memcpy(priv->rss_conf.rss_key,
 	       use_app_rss_key ?
 	       dev->data->dev_conf.rx_adv_conf.rss_conf.rss_key :
Signature · 1 line
2.24.1
#1 lore raw

PATCH v2 1/1 drivers/net: do not enforce RSS hash offload

From: Alexander Kozyrev <[email protected]>

Rx RSS hash offload should be controlled by the user and should not be enforced by RSS multi-queue Rx mode.

Fixes 8b945a7f7dcb ("drivers/net: update Rx RSS hash offload capabilities")

Author: Andrew Rybchenko <[email protected]>

---
 drivers/net/mlx4/mlx4.c        | 3 ---
 drivers/net/mlx5/mlx5_ethdev.c | 3 ---
 2 files changed, 6 deletions(-)
drivers/net/mlx4/mlx4.c +0 -3
index 34c2bbb373..d5d8c96351 100644
@@ -249,9 +249,6 @@ mlx4_dev_configure(struct rte_eth_dev *dev)
 	struct rte_flow_error error;
 	int ret;
 
-	if (dev->data->dev_conf.rxmode.mq_mode & ETH_MQ_RX_RSS_FLAG)
-		dev->data->dev_conf.rxmode.offloads |= DEV_RX_OFFLOAD_RSS_HASH;
-
 	/* Prepare internal flow rules. */
 	ret = mlx4_flow_sync(priv, &error);
 	if (ret) {
drivers/net/mlx5/mlx5_ethdev.c +0 -3
index fc04fc8224..6cadfe3eb0 100644
@@ -86,9 +86,6 @@ mlx5_dev_configure(struct rte_eth_dev *dev)
 		return -rte_errno;
 	}
 
-	if (dev->data->dev_conf.rxmode.mq_mode & ETH_MQ_RX_RSS_FLAG)
-		dev->data->dev_conf.rxmode.offloads |= DEV_RX_OFFLOAD_RSS_HASH;
-
 	memcpy(priv->rss_conf.rss_key,
 	       use_app_rss_key ?
 	       dev->data->dev_conf.rx_adv_conf.rss_conf.rss_key :
Signature · 1 line
2.24.1
#2 lore raw

Re: [dpdk-dev] [PATCH v2] drivers/net: do not enforce RSS hash offload

Hi,

Quoted 59 lines

-----Original Message-----
From: Alexander Kozyrev <[email protected]>
Sent: Tuesday, October 27, 2020 5:15 PM
To: [email protected]
Cc: [email protected]; Raslan Darawsheh <[email protected]>; Slava Ovsiienko <[email protected]>; [email protected]; Matan Azrad <[email protected]>; Alexander Kozyrev <[email protected]>
Subject: [PATCH v2] drivers/net: do not enforce RSS hash offload

From: Alexander Kozyrev <[email protected]>

Rx RSS hash offload should be controlled by the user and should not be enforced by RSS multi-queue Rx mode.

Fixes 8b945a7f7dcb ("drivers/net: update Rx RSS hash offload capabilities")

Author: Andrew Rybchenko <[email protected]>

---
 drivers/net/mlx4/mlx4.c        | 3 ---
 drivers/net/mlx5/mlx5_ethdev.c | 3 ---
 2 files changed, 6 deletions(-)
drivers/net/mlx4/mlx4.c +0 -3
index 34c2bbb373..d5d8c96351 100644
@@ -249,9 +249,6 @@ mlx4_dev_configure(struct rte_eth_dev *dev)
 	struct rte_flow_error error;
 	int ret;
 
-	if (dev->data->dev_conf.rxmode.mq_mode &
 ETH_MQ_RX_RSS_FLAG)
-		dev->data->dev_conf.rxmode.offloads |=
 DEV_RX_OFFLOAD_RSS_HASH;
-
 	/* Prepare internal flow rules. */
drivers/net/mlx4/mlx4.c +0 -0
 	ret = mlx4_flow_sync(priv, &error);
 	if (ret) {
drivers/net/mlx5/mlx5_ethdev.c +0 -3
index fc04fc8224..6cadfe3eb0 100644
@@ -86,9 +86,6 @@ mlx5_dev_configure(struct rte_eth_dev *dev)
 		return -rte_errno;
 	}
 
-	if (dev->data->dev_conf.rxmode.mq_mode &
 ETH_MQ_RX_RSS_FLAG)
-		dev->data->dev_conf.rxmode.offloads |=
 DEV_RX_OFFLOAD_RSS_HASH;
-
 	memcpy(priv->rss_conf.rss_key,
drivers/net/mlx5/mlx5_ethdev.c +0 -1
 	       use_app_rss_key ?
 	       dev->data->dev_conf.rx_adv_conf.rss_conf.rss_key :
--
Quoted 1 line

2.24.1

Patch applied to next-net-mlx,

Kindest regards,
Raslan Darawsheh