Skip to contentSkip to conversation

examples: fix linking against specific drivers

PATCH Applied Bruce Richardson 2 participants 3 messages Oct 27, 2020 – Nov 2, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 examples: fix linking against specific drivers

Some example apps rely on driver-specific functionality and link explicitly against those drivers. These apps need their makefiles updated to take account of the renaming of the driver libs.

Fixes a20b2c01a7a1 ("build: standardize component names and defines")
---
 examples/bond/Makefile             | 2 +-
 examples/ethtool/lib/Makefile      | 2 +-
 examples/vm_power_manager/Makefile | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)
examples/bond/Makefile +1 -1
index 4e560f574c..8700b589fb 100644
@@ -19,7 +19,7 @@ shared: build/$(APP)-shared
 static: build/$(APP)-static
 	ln -sf $(APP)-static build/$(APP)
 
-LDFLAGS += -lrte_pmd_bond
+LDFLAGS += -lrte_net_bond
 
 PKGCONF ?= pkg-config
 
examples/ethtool/lib/Makefile +1 -1
index 3bc2b9d8ba..b4af9b0c91 100644
@@ -27,7 +27,7 @@ LDFLAGS += -Wl,--no-undefined $(LDFLAGS_SHARED)
 
 # check for ixgbe by grepping pre-processor output
 ifneq ($(shell $(CC) $(CFLAGS) -dM -E - < /dev/null | grep IXGBE),)
-LDFLAGS += -lrte_pmd_ixgbe
+LDFLAGS += -lrte_net_ixgbe
 endif
 
 .PHONY: all clean static shared
examples/vm_power_manager/Makefile +1 -1
index 87b9744d8c..027d17c7ef 100644
@@ -44,7 +44,7 @@ CFLAGS += -DUSE_JANSSON
 endif
 
 # for shared library builds, we need to explicitly link these PMDs
-LDFLAGS_SHARED += -lrte_pmd_ixgbe -lrte_pmd_i40e -lrte_pmd_bnxt
+LDFLAGS_SHARED += -lrte_net_ixgbe -lrte_net_i40e -lrte_net_bnxt
 
 build/$(APP)-shared: $(SRCS-y) Makefile $(PC_FILE) | build
 	$(CC) $(CFLAGS) $(SRCS-y) -o $@ $(LDFLAGS) $(LDFLAGS_SHARED)
Signature · 1 line
2.25.1
Reviewed-by on v1 1/1 Applied
#1 lore raw
Quoted 8 lines · Bruce Richardson

Some example apps rely on driver-specific functionality and link explicitly against those drivers. These apps need their makefiles updated to take account of the renaming of the driver libs.

Fixes a20b2c01a7a1 ("build: standardize component names and defines")

Applied, thanks Bruce.

I think the documentation would also need some fixes as I can see a lot of references to librte_pmd_.

Signature · 1 line
David Marchand
#2 lore raw
Quoted 20 lines

-----Original Message-----
From: David Marchand <[email protected]>
Sent: Friday, October 30, 2020 1:36 PM
To: Richardson, Bruce <[email protected]>
Cc: dev <[email protected]>; Thomas Monjalon <[email protected]>
Subject: Re: [dpdk-dev] [PATCH] examples: fix linking against specific drivers

Quoted 2 lines · Bruce Richardson

Some example apps rely on driver-specific functionality and link

explicitly

Quoted 5 lines

against those drivers. These apps need their makefiles updated to take account of the renaming of the driver libs.

Fixes a20b2c01a7a1 ("build: standardize component names and defines")
Quoted 9 lines
Quoted 1 line

Applied, thanks Bruce.

I think the documentation would also need some fixes as I can see a lot of references to librte_pmd_.

First draft patchset sent, based off grepping the docs for "librte_pmd_".

http://patches.dpdk.org/project/dpdk/list/?series=13578

/Bruce