dmaengine: ti: k3-udma: fix -Wenum-conversion warning
Subsystems (2)
PATCH 1/1 dmaengine: ti: k3-udma: fix -Wenum-conversion warning
From: Arnd Bergmann <[email protected]>
gcc warns about a mismatch argument type when passing 'false' into a function that expects an enum:
drivers/dma/ti/k3-udma-private.c: In function 'xudma_tchan_get':drivers/dma/ti/k3-udma-private.c:86:34: warning: implicit conversion from 'enum <anonymous>' to 'enum udma_tp_level' [-Wenum-conversion]
86 | return __udma_reserve_##res(ud, false, id); \
| ^~~~~drivers/dma/ti/k3-udma-private.c:95:1: note: in expansion of macro 'XUDMA_GET_PUT_RESOURCE'
95 | XUDMA_GET_PUT_RESOURCE(tchan);
| ^~~~~~~~~~~~~~~~~~~~~~In this case, false has the same numerical value as UDMA_TP_NORMAL, so passing that is most likely the correct way to avoid the warning without changing the behavior.
--- drivers/dma/ti/k3-udma-private.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/dma/ti/k3-udma-private.c +1 -1
@@ -83,7 +83,7 @@ EXPORT_SYMBOL(xudma_rflow_is_gp);#define XUDMA_GET_PUT_RESOURCE (res) \ struct udma_##res *xudma_##res##_get(struct udma_dev *ud, int id) \ { \ - return __udma_reserve_##res(ud, false, id); \ + return __udma_reserve_##res(ud, UDMA_TP_NORMAL, id); \ } \ EXPORT_SYMBOL(xudma_##res##_get); \ \
Signature · 1 line
2.27.0
Quoted 4 lines · Arnd Bergmann
From: Arnd Bergmann <[email protected]>
gcc warns about a mismatch argument type when passing 'false' into a function that expects an enum:
Strange enough, but my gcc does not warn me (Gentoo 10.2.0-r2 p3).
Quoted 7 lines
drivers/dma/ti/k3-udma-private.c: In function 'xudma_tchan_get':drivers/dma/ti/k3-udma-private.c:86:34: warning: implicit conversion from 'enum <anonymous>' to 'enumudma_tp_level' [-Wenum-conversion]
86 | return __udma_reserve_##res(ud, false, id); \
| ^~~~~drivers/dma/ti/k3-udma-private.c:95:1: note: in expansion of macro 'XUDMA_GET_PUT_RESOURCE'95 | XUDMA_GET_PUT_RESOURCE(tchan); | ^~~~~~~~~~~~~~~~~~~~~~
But this is valid. The Throughput Levels got expanded with j721e from 2 to three and I failed to update this.
Quoted 3 lines
In this case, false has the same numerical value as
UDMA_TP_NORMAL, so passing that is most likely the correct way to avoid the warning without changing the behavior.
Yes, that's correct, thanks for fixing it!
Quoted 12 lines
Fixes d70241913413 ("dmaengine: ti: k3-udma: Add glue layer for non DMAengine users")Signed-off-by Arnd Bergmann <[email protected]>--- drivers/dma/ti/k3-udma-private.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/dma/ti/k3-udma-private.c +0
-0
drivers/dma/ti/k3-udma-private.c EXPORT_SYMBOL(xudma_rflow_is_gp); · line 89
Quoted 8 lines
drivers/dma/ti/k3-udma-private.c +1
-1@@ -83,7 +83,7 @@ EXPORT_SYMBOL(xudma_rflow_is_gp);#define XUDMA_GET_PUT_RESOURCE (res) \ struct udma_##res *xudma_##res##_get(struct udma_dev *ud, int id) \ { \ - return __udma_reserve_##res(ud, false, id); \ + return __udma_reserve_##res(ud, UDMA_TP_NORMAL, id); \ } \ EXPORT_SYMBOL(xudma_##res##_get); \ \
- Péter
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
Quoted 10 lines · Arnd Bergmann
From: Arnd Bergmann <[email protected]>
gcc warns about a mismatch argument type when passing 'false' into a function that expects an enum:
drivers/dma/ti/k3-udma-private.c: In function 'xudma_tchan_get':drivers/dma/ti/k3-udma-private.c:86:34: warning: implicit conversion from 'enum <anonymous>' to 'enumudma_tp_level' [-Wenum-conversion]
86 | return __udma_reserve_##res(ud, false, id); \
| ^~~~~drivers/dma/ti/k3-udma-private.c:95:1: note: in expansion of macro 'XUDMA_GET_PUT_RESOURCE'
Quoted 6 lines
95 | XUDMA_GET_PUT_RESOURCE(tchan); | ^~~~~~~~~~~~~~~~~~~~~~In this case, false has the same numerical value as
UDMA_TP_NORMAL, so passing that is most likely the correct way to avoid the warning without changing the behavior.
Applied, thanks
Signature · 1 line
~Vinod