Skip to contentSkip to conversation

dmaengine: pl330: Remove unreachable code

PATCH Applied Surendran K 2 participants 2 messages Oct 20, 2020 – Oct 28, 2020 1 message not in the archive dmaengine

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): CGME20201016110722epcas5p3e1bc44be4c2b35654b440276448b7c4f@epcas5p3.samsung.com

#1 lore raw

PATCH v2 1/1 dmaengine: pl330: Remove unreachable code

_setup_req(..) never returns negative value.
Hence the condition ret < 0 is never met

---
Commit tag is changed

 drivers/dma/pl330.c | 2 --
 1 file changed, 2 deletions(-)
drivers/dma/pl330.c +0 -2
index e9f0101d92fa..8355586c9788 100644
@@ -1527,8 +1527,6 @@ static int pl330_submit_req(struct pl330_thread *thrd,
 
 	/* First dry run to check if req is acceptable */
 	ret = _setup_req(pl330, 1, thrd, idx, &xs);
-	if (ret < 0)
-		goto xfer_exit;
 
 	if (ret > pl330->mcbufsz / 2) {
 		dev_info(pl330->ddma.dev, "%s:%d Try increasing mcbufsz (%i/%i)\n",

--
2.17.1

maintainer Applied
#2 lore raw
Quoted 2 lines · Surendran K

_setup_req(..) never returns negative value.
Hence the condition ret < 0 is never met

Applied, thanks

Signature · 1 line
~Vinod