Skip to contentSkip to conversation

ath10k: remove repeated words in comments

PATCH In review Kalle Valo 1 participant 4 messages Oct 27, 2020 – Oct 29, 2020 Qualcomm Atheros ATH10K wireless driver

lore
Share & tools
lore

Kalle Valo

author
#0 lore raw

PATCH 1/2 ath10k: remove repeated words in comments

Found by latest checkpatch.

---
 drivers/net/wireless/ath/ath10k/core.c    | 2 +-
 drivers/net/wireless/ath/ath10k/debug.c   | 2 +-
 drivers/net/wireless/ath/ath10k/mac.c     | 2 +-
 drivers/net/wireless/ath/ath10k/rx_desc.h | 2 +-
 drivers/net/wireless/ath/ath10k/sdio.c    | 2 +-
 drivers/net/wireless/ath/ath10k/wmi.h     | 4 ++--
 6 files changed, 7 insertions(+), 7 deletions(-)
drivers/net/wireless/ath/ath10k/core.c +1 -1
index d73ad60b571c..419b06b974c5 100644
@@ -2636,7 +2636,7 @@ int ath10k_core_start(struct ath10k *ar, enum ath10k_firmware_mode mode,
 		if (status)
 			goto err;
 
-		/* Some of of qca988x solutions are having global reset issue
+		/* Some of qca988x solutions are having global reset issue
 		 * during target initialization. Bypassing PLL setting before
 		 * downloading firmware and letting the SoC run on REF_CLK is
 		 * fixing the problem. Corresponding firmware change is also
drivers/net/wireless/ath/ath10k/debug.c +1 -1
index e8250a665433..b72cd81fdc79 100644
@@ -1764,7 +1764,7 @@ static ssize_t ath10k_write_simulate_radar(struct file *file,
 	struct ath10k *ar = file->private_data;
 	struct ath10k_vif *arvif;
 
-	/* Just check for for the first vif alone, as all the vifs will be
+	/* Just check for the first vif alone, as all the vifs will be
 	 * sharing the same channel and if the channel is disabled, all the
 	 * vifs will share the same 'is_started' state.
 	 */
drivers/net/wireless/ath/ath10k/mac.c +1 -1
index 2e3eb5bbe49c..c857cf46832d 100644
@@ -5457,7 +5457,7 @@ static int ath10k_add_interface(struct ieee80211_hw *hw,
 	/* Some firmware revisions don't wait for beacon tx completion before
 	 * sending another SWBA event. This could lead to hardware using old
 	 * (freed) beacon data in some cases, e.g. tx credit starvation
-	 * combined with missed TBTT. This is very very rare.
+	 * combined with missed TBTT. This is very rare.
 	 *
 	 * On non-IOMMU-enabled hosts this could be a possible security issue
 	 * because hw could beacon some random data on the air.  On
drivers/net/wireless/ath/ath10k/rx_desc.h +1 -1
index dec1582005b9..f2b6bf8f0d60 100644
@@ -68,7 +68,7 @@ struct rx_attention {
  *		first_msdu is set.
  *
  * peer_idx_invalid
- *		Indicates no matching entries within the the max search
+ *		Indicates no matching entries within the max search
  *		count.  Only set when first_msdu is set.
  *
  * peer_idx_timeout
drivers/net/wireless/ath/ath10k/sdio.c +1 -1
index 81ddaafb6721..59043ec44ca3 100644
@@ -1248,7 +1248,7 @@ static int ath10k_sdio_bmi_exchange_msg(struct ath10k *ar,
 	 *        Wait for first 4 bytes to be in FIFO
 	 *        If CONSERVATIVE_BMI_READ is enabled, also wait for
 	 *        a BMI command credit, which indicates that the ENTIRE
-	 *        response is available in the the FIFO
+	 *        response is available in the FIFO
 	 *
 	 *  CASE 3: length > 128
 	 *        Wait for the first 4 bytes to be in FIFO
drivers/net/wireless/ath/ath10k/wmi.h +2 -2
index 4898e19b0af6..11300b1320a9 100644
@@ -3832,7 +3832,7 @@ enum wmi_pdev_param {
 	WMI_PDEV_PARAM_BEACON_TX_MODE,
 	/*
 	 * Resource manager off chan mode .
-	 * 0: turn off off chan mode. 1: turn on offchan mode
+	 * 0: turn off offchan mode. 1: turn on offchan mode
 	 */
 	WMI_PDEV_PARAM_RESMGR_OFFCHAN_MODE,
 	/*
@@ -3936,7 +3936,7 @@ enum wmi_10x_pdev_param {
 	WMI_10X_PDEV_PARAM_BEACON_TX_MODE,
 	/*
 	 * Resource manager off chan mode .
-	 * 0: turn off off chan mode. 1: turn on offchan mode
+	 * 0: turn off offchan mode. 1: turn on offchan mode
 	 */
 	WMI_10X_PDEV_PARAM_RESMGR_OFFCHAN_MODE,
 	/*
Signature · 1 line
2.7.4
author
#1 lore raw

PATCH 2/2 ath10k: ath10k_pci_init_irq(): workaround for checkpatch fallthrough warning

Latest checkpatch complains about use of fall-through comment. But as this is a switch statement just reword the comment to workaround the problem.

---
 drivers/net/wireless/ath/ath10k/pci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/wireless/ath/ath10k/pci.c +1 -1
index 36426efdb2ea..8ab262931dce 100644
@@ -3236,7 +3236,7 @@ static int ath10k_pci_init_irq(struct ath10k *ar)
 		if (ret == 0)
 			return 0;
 
-		/* fall-through */
+		/* MHI failed, try legacy irq next */
 	}
 
 	/* Try legacy irq
Signature · 7 lines
2.7.4


_______________________________________________
ath10k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath10k
author
#2 lore raw
In reply to Kalle Valo
Quoted 3 lines · Kalle Valo

Found by latest checkpatch.

2 patches applied to ath-next branch of ath.git, thanks.

762fd1aec588 ath10k: remove repeated words in comments
d2f3f68864a4 ath10k: ath10k_pci_init_irq(): workaround for checkpatch fallthrough warning

Signature · 9 lines
https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches


_______________________________________________
ath10k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath10k
author
#3 lore raw
In reply to Kalle Valo
Quoted 3 lines · Kalle Valo

Found by latest checkpatch.

2 patches applied to ath-next branch of ath.git, thanks.

762fd1aec588 ath10k: remove repeated words in comments
d2f3f68864a4 ath10k: ath10k_pci_init_irq(): workaround for checkpatch fallthrough warning

Signature · 3 lines
https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches