IB/isert: add module param to set sg_tablesize for IO cmd
Subsystems (2)
PATCH v2 1/1 IB/isert: add module param to set sg_tablesize for IO cmd
Currently, iser target support max IO size of 16MiB by default. For some adapters, allocating this amount of resources might reduce the total number of possible connections that can be created. For those adapters, it's preferred to reduce the max IO size to be able to create more connections. Since there is no handshake procedure for max IO size in iser protocol, set the default max IO size to 1MiB and add a module parameter for enabling the option to control it for suitable adapters.
---
changes from v1:
- added "Fixes" line (Sagi)
- renamed ISCSI_ISER_SG_TABLESIZE to ISCSI_ISER_DEF_SG_TABLESIZE (Sagi)
- added "Reviewed-by" signature
--- drivers/infiniband/ulp/isert/ib_isert.c | 27 ++++++++++++++++++++++++- drivers/infiniband/ulp/isert/ib_isert.h | 6 ++++++ 2 files changed, 32 insertions(+), 1 deletion(-)
drivers/infiniband/ulp/isert/ib_isert.c +26 -1
@@ -28,6 +28,18 @@ static int isert_debug_level;module_param_named (debug_level, isert_debug_level, int,0644 );MODULE_PARM_DESC (debug_level,"Enable debug tracing if > 0 (default:0)" ); +static int isert_sg_tablesize_set (const char *val, +const struct kernel_param *kp); +static const struct kernel_param_ops sg_tablesize_ops = { + .set = isert_sg_tablesize_set, + .get = param_get_int, +}; + +static int isert_sg_tablesize =ISCSI_ISER_DEF_SG_TABLESIZE ; +module_param_cb (sg_tablesize, &sg_tablesize_ops, &isert_sg_tablesize,0644 ); +MODULE_PARM_DESC (sg_tablesize, +"Number of gather/scatter entries in a single scsi command, should >= 128 (default: 256, max: 4096)" ); +static DEFINE_MUTEX (device_list_mutex);static LIST_HEAD (device_list);static struct workqueue_struct *isert_comp_wq;
@@ -47,6 +59,19 @@ static void isert_send_done(struct ib_cq *cq, struct ib_wc *wc);static void isert_login_recv_done (struct ib_cq *cq,struct ib_wc *wc);static void isert_login_send_done (struct ib_cq *cq,struct ib_wc *wc); +static int isert_sg_tablesize_set (const char *val,const struct kernel_param *kp) +{ +int n =0 , ret; + + ret =kstrtoint (val,10 , &n); +if (ret !=0 || n <ISCSI_ISER_MIN_SG_TABLESIZE || + n >ISCSI_ISER_MAX_SG_TABLESIZE ) +return -EINVAL ; + +return param_set_int (val, kp); +} + +static inline bool isert_prot_cmd (struct isert_conn *conn,struct se_cmd *cmd) {
@@ -101,7 +126,7 @@ isert_create_qp(struct isert_conn *isert_conn, attr.cap.max_send_wr =ISERT_QP_MAX_REQ_DTOS +1 ; attr.cap.max_recv_wr =ISERT_QP_MAX_RECV_DTOS +1 ; factor =rdma_rw_mr_factor (device->ib_device, cma_id->port_num, -ISCSI_ISER_MAX_SG_TABLESIZE ); + isert_sg_tablesize); attr.cap.max_rdma_ctxs =ISCSI_DEF_XMIT_CMDS_MAX * factor; attr.cap.max_send_sge = device->ib_device->attrs.max_send_sge; attr.cap.max_recv_sge =1 ;
drivers/infiniband/ulp/isert/ib_isert.h +6 -0
@@ -65,6 +65,12 @@*/ #define ISER_RX_SIZE (ISCSI_DEF_MAX_RECV_SEG_LEN + 1024) +/* Default I/O size is 1MB */ +#define ISCSI_ISER_DEF_SG_TABLESIZE 256 + +/* Minimum I/O size is 512KB */ +#define ISCSI_ISER_MIN_SG_TABLESIZE 128 +/* Maximum support is 16MB I/O size */ #define ISCSI_ISER_MAX_SG_TABLESIZE 4096
Signature · 1 line
2.18.1
Quoted 19 lines · Max Gurtovoy
Currently, iser target support max IO size of 16MiB by default. For some adapters, allocating this amount of resources might reduce the total number of possible connections that can be created. For those adapters, it's preferred to reduce the max IO size to be able to create more connections. Since there is no handshake procedure for max IO size in iser protocol, set the default max IO size to 1MiB and add a module parameter for enabling the option to control it for suitable adapters.
Fixes 317000b926b0 ("IB/isert: allocate RW ctxs according to max IO size")Reported-by Krishnamraju Eraparaju <[email protected]>Reviewed-by Sagi Grimberg <[email protected]>Signed-off-by Max Gurtovoy <[email protected]>---
changes from v1:
- added "Fixes" line (Sagi)
- renamedISCSI_ISER_SG_TABLESIZEtoISCSI_ISER_DEF_SG_TABLESIZE(Sagi)
- added "Reviewed-by" signature
Quoted 4 lines
--- drivers/infiniband/ulp/isert/ib_isert.c | 27 ++++++++++++++++++++++++- drivers/infiniband/ulp/isert/ib_isert.h | 6 ++++++ 2 files changed, 32 insertions(+), 1 deletion(-)
Applied to for-next, thanks
Jason