drm: xlnx: Use dma_request_chan for DMA channel request
Subsystems (4)
PATCH 1/1 drm: xlnx: Use dma_request_chan for DMA channel request
There is no need to use the of_dma_request_slave_channel() directly as dma_request_chan() is going to try to get the channel via OF as well.
--- drivers/gpu/drm/xlnx/zynqmp_disp.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/gpu/drm/xlnx/zynqmp_disp.c +1 -3
@@ -28,7 +28,6 @@#include <linux/dmaengine.h> #include <linux/module.h> #include <linux/of.h> -#include <linux/of_dma.h> #include <linux/platform_device.h> #include <linux/pm_runtime.h> #include <linux/spinlock.h>
@@ -1316,8 +1315,7 @@ static int zynqmp_disp_layer_request_dma(struct zynqmp_disp *disp,snprintf (dma_channel_name,sizeof (dma_channel_name),"%s%u" , dma_names[layer->id], i); - dma->chan =of_dma_request_slave_channel (disp->dev->of_node, - dma_channel_name); + dma->chan =dma_request_chan (disp->dev, dma_channel_name);if (IS_ERR (dma->chan)) {dev_err (disp->dev,"failed to request dma channel\n" ); ret =PTR_ERR (dma->chan);
Signature · 4 lines
Peter Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
Hi Peter,
Thanks for the patch.
Quoted 4 lines · Peter Ujfalusi
There is no need to use the
of_dma_request_slave_channel()directly asdma_request_chan()is going to try to get the channel via OF as well.Signed-off-by Peter Ujfalusi <[email protected]>
So now dma_request_chan() has sysfs / debugfs registrations, and this looks good to me. I'll commit this within next couple days and keep it posted here.
Thanks,
-hyun
Quoted 32 lines
--- drivers/gpu/drm/xlnx/zynqmp_disp.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)drivers/gpu/drm/xlnx/zynqmp_disp.c +1
-3@@ -28,7 +28,6 @@#include <linux/dmaengine.h> #include <linux/module.h> #include <linux/of.h> -#include <linux/of_dma.h> #include <linux/platform_device.h> #include <linux/pm_runtime.h> #include <linux/spinlock.h> @@ -1316,8 +1315,7 @@ static int zynqmp_disp_layer_request_dma(struct zynqmp_disp *disp,snprintf (dma_channel_name,sizeof (dma_channel_name),"%s%u" , dma_names[layer->id], i); - dma->chan =of_dma_request_slave_channel (disp->dev->of_node, - dma_channel_name); + dma->chan =dma_request_chan (disp->dev, dma_channel_name);if (IS_ERR (dma->chan)) {dev_err (disp->dev,"failed to request dma channel\n" ); ret =PTR_ERR (dma->chan);Signature · 4 lines
Peter Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Hyun Kwon
AppliedQuoted 4 lines · Hyun Kwon
Hi Peter,
Thanks for the patch.
Quoted 9 lines
Quoted 4 lines · Peter Ujfalusi
There is no need to use the
of_dma_request_slave_channel()directly asdma_request_chan()is going to try to get the channel via OF as well.Signed-off-by Peter Ujfalusi <[email protected]>So now
dma_request_chan()has sysfs / debugfs registrations, and this looks good to me. I'll commit this within next couple days and keep it posted here.
Applied to drm-misc-next.
Thanks!
-hyun
Quoted 32 lines
Thanks,
-hyunQuoted 29 lines
--- drivers/gpu/drm/xlnx/zynqmp_disp.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)drivers/gpu/drm/xlnx/zynqmp_disp.c +1
-3@@ -28,7 +28,6 @@#include <linux/dmaengine.h> #include <linux/module.h> #include <linux/of.h> -#include <linux/of_dma.h> #include <linux/platform_device.h> #include <linux/pm_runtime.h> #include <linux/spinlock.h> @@ -1316,8 +1315,7 @@ static int zynqmp_disp_layer_request_dma(struct zynqmp_disp *disp,snprintf (dma_channel_name,sizeof (dma_channel_name),"%s%u" , dma_names[layer->id], i); - dma->chan =of_dma_request_slave_channel (disp->dev->of_node, - dma_channel_name); + dma->chan =dma_request_chan (disp->dev, dma_channel_name);if (IS_ERR (dma->chan)) {dev_err (disp->dev,"failed to request dma channel\n" ); ret =PTR_ERR (dma->chan);Signature · 1 line
Peter
Quoted 3 lines
Quoted 3 lines
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Hi Peter.
Quoted 4 lines · Peter Ujfalusi
There is no need to use the
of_dma_request_slave_channel()directly asdma_request_chan()is going to try to get the channel via OF as well.Signed-off-by Peter Ujfalusi <[email protected]>
I took a look at this and agree on your analysis.
I expect the maintainers to pick up this patch.
Sam
Quoted 36 lines
--- drivers/gpu/drm/xlnx/zynqmp_disp.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)drivers/gpu/drm/xlnx/zynqmp_disp.c +1
-3@@ -28,7 +28,6 @@#include <linux/dmaengine.h> #include <linux/module.h> #include <linux/of.h> -#include <linux/of_dma.h> #include <linux/platform_device.h> #include <linux/pm_runtime.h> #include <linux/spinlock.h> @@ -1316,8 +1315,7 @@ static int zynqmp_disp_layer_request_dma(struct zynqmp_disp *disp,snprintf (dma_channel_name,sizeof (dma_channel_name),"%s%u" , dma_names[layer->id], i); - dma->chan =of_dma_request_slave_channel (disp->dev->of_node, - dma_channel_name); + dma->chan =dma_request_chan (disp->dev, dma_channel_name);if (IS_ERR (dma->chan)) {dev_err (disp->dev,"failed to request dma channel\n" ); ret =PTR_ERR (dma->chan);Signature · 9 lines
Peter Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel