iio: accel: remove unnecessary CONFIG_PM_SLEEP
Subsystems (3)
PATCH 1/15 iio: accel: remove unnecessary CONFIG_PM_SLEEP
SIMPLE_DEV_PM_OPS has already took good care of CONFIG_PM_CONFIG.
--- drivers/iio/accel/da311.c | 2 -- 1 file changed, 2 deletions(-)
drivers/iio/accel/da311.c +0 -2
@@ -263,7 +263,6 @@ static int da311_remove(struct i2c_client *client)return da311_enable (client, false); } -#ifdef CONFIG_PM_SLEEP static int da311_suspend (struct device *dev) {return da311_enable (to_i2c_client (dev), false);
@@ -273,7 +272,6 @@ static int da311_resume(struct device *dev) {return da311_enable (to_i2c_client (dev), true); } -#endif static SIMPLE_DEV_PM_OPS(da311_pm_ops, da311_suspend, da311_resume);
Signature · 1 line
2.28.0
PATCH 2/15 iio: accel: remove unnecessary CONFIG_PM_SLEEP
SIMPLE_DEV_PM_OPS has already took good care of CONFIG_PM_CONFIG.
--- drivers/iio/accel/da280.c | 2 -- 1 file changed, 2 deletions(-)
drivers/iio/accel/da280.c +0 -2
@@ -160,7 +160,6 @@ static int da280_remove(struct i2c_client *client)return da280_enable (client, false); } -#ifdef CONFIG_PM_SLEEP static int da280_suspend (struct device *dev) {return da280_enable (to_i2c_client (dev), false);
@@ -170,7 +169,6 @@ static int da280_resume(struct device *dev) {return da280_enable (to_i2c_client (dev), true); } -#endif static SIMPLE_DEV_PM_OPS(da280_pm_ops, da280_suspend, da280_resume);
Signature · 1 line
2.28.0
PATCH 3/15 iio: accel: remove unnecessary CONFIG_PM_SLEEP
In reply to Coiby XuSET_SYSTEM_SLEEP_PM_OPS has already took good care of CONFIG_PM_CONFIG.
--- drivers/iio/accel/mma9553.c | 2 -- 1 file changed, 2 deletions(-)
drivers/iio/accel/mma9553.c +0 -2
@@ -1197,7 +1197,6 @@ static int mma9553_runtime_resume(struct device *dev) }#endif -#ifdef CONFIG_PM_SLEEP static int mma9553_suspend (struct device *dev) {struct iio_dev *indio_dev =i2c_get_clientdata (to_i2c_client (dev));
@@ -1223,7 +1222,6 @@ static int mma9553_resume(struct device *dev)return ret; } -#endif static const struct dev_pm_ops mma9553_pm_ops = {SET_SYSTEM_SLEEP_PM_OPS (mma9553_suspend, mma9553_resume)
Signature · 1 line
2.28.0
PATCH 4/15 iio: accel: remove unnecessary CONFIG_PM_SLEEP
In reply to Coiby XuSIMPLE_DEV_PM_OPS has already took good care of CONFIG_PM_CONFIG.
--- drivers/iio/accel/mc3230.c | 2 -- 1 file changed, 2 deletions(-)
drivers/iio/accel/mc3230.c +0 -2
@@ -160,7 +160,6 @@ static int mc3230_remove(struct i2c_client *client)return mc3230_set_opcon (iio_priv (indio_dev),MC3230_MODE_OPCON_STANDBY ); } -#ifdef CONFIG_PM_SLEEP static int mc3230_suspend (struct device *dev) {struct mc3230_data *data;
@@ -178,7 +177,6 @@ static int mc3230_resume(struct device *dev)return mc3230_set_opcon (data,MC3230_MODE_OPCON_WAKE ); } -#endif static SIMPLE_DEV_PM_OPS(mc3230_pm_ops, mc3230_suspend, mc3230_resume);
Signature · 1 line
2.28.0
PATCH 5/15 iio: accel: remove unnecessary CONFIG_PM_SLEEP
In reply to Coiby XuSET_SYSTEM_SLEEP_PM_OPS has already took good care of CONFIG_PM_CONFIG.
--- drivers/iio/accel/mma9551.c | 2 -- 1 file changed, 2 deletions(-)
drivers/iio/accel/mma9551.c +0 -2
@@ -558,7 +558,6 @@ static int mma9551_runtime_resume(struct device *dev) }#endif -#ifdef CONFIG_PM_SLEEP static int mma9551_suspend (struct device *dev) {struct iio_dev *indio_dev =i2c_get_clientdata (to_i2c_client (dev));
@@ -584,7 +583,6 @@ static int mma9551_resume(struct device *dev)return ret; } -#endif static const struct dev_pm_ops mma9551_pm_ops = {SET_SYSTEM_SLEEP_PM_OPS (mma9551_suspend, mma9551_resume)
Signature · 1 line
2.28.0
Quoted 2 lines · Coiby Xu
SET_SYSTEM_SLEEP_PM_OPShas already took good care ofCONFIG_PM_CONFIG.
Correct grammar and rethink about them.
NAK for all of them.
Signature · 2 lines
With Best Regards, Andy Shevchenko
Quoted 8 lines · Andy Shevchenko
Quoted 2 lines · Coiby Xu
SET_SYSTEM_SLEEP_PM_OPShas already took good care ofCONFIG_PM_CONFIG.Correct grammar and rethink about them.
NAK for all of them.
I'll add __maybe_unused, do the compiling testing for each changed driver and also correct the typo in v2. Thank you for the feedback!
Quoted 3 lines
--
With Best Regards,
Andy Shevchenko
--
Best regards,
Coiby
PATCH 6/15 iio: accel: remove unnecessary CONFIG_PM_SLEEP
In reply to Coiby XuSIMPLE_DEV_PM_OPS has already took good care of CONFIG_PM_CONFIG.
--- drivers/iio/accel/dmard10.c | 2 -- 1 file changed, 2 deletions(-)
drivers/iio/accel/dmard10.c +0 -2
@@ -224,7 +224,6 @@ static int dmard10_remove(struct i2c_client *client)return dmard10_shutdown (client); } -#ifdef CONFIG_PM_SLEEP static int dmard10_suspend (struct device *dev) {return dmard10_shutdown (to_i2c_client (dev));
@@ -234,7 +233,6 @@ static int dmard10_resume(struct device *dev) {return dmard10_reset (to_i2c_client (dev)); } -#endif static SIMPLE_DEV_PM_OPS(dmard10_pm_ops, dmard10_suspend, dmard10_resume);
Signature · 1 line
2.28.0
PATCH 7/15 iio: ssp: remove unnecessary CONFIG_PM_SLEEP
In reply to Coiby XuSET_SYSTEM_SLEEP_PM_OPS has already took good care of CONFIG_PM_CONFIG.
--- drivers/iio/common/ssp_sensors/ssp_dev.c | 2 -- 1 file changed, 2 deletions(-)
drivers/iio/common/ssp_sensors/ssp_dev.c +0 -2
@@ -612,7 +612,6 @@ static int ssp_remove(struct spi_device *spi)return 0 ; } -#ifdef CONFIG_PM_SLEEP static int ssp_suspend (struct device *dev) {int ret;
@@ -661,7 +660,6 @@ static int ssp_resume(struct device *dev)return 0 ; } -#endif /* CONFIG_PM_SLEEP */ static const struct dev_pm_ops ssp_pm_ops = {SET_SYSTEM_SLEEP_PM_OPS (ssp_suspend, ssp_resume)
Signature · 1 line
2.28.0
PATCH 8/15 iio: magnetometer: mmc35240: remove unnecessary CONFIG_PM_SLEEP
In reply to Coiby XuSET_SYSTEM_SLEEP_PM_OPS has already took good care of CONFIG_PM_CONFIG.
--- drivers/iio/magnetometer/mmc35240.c | 2 -- 1 file changed, 2 deletions(-)
drivers/iio/magnetometer/mmc35240.c +0 -2
@@ -521,7 +521,6 @@ static int mmc35240_probe(struct i2c_client *client,return devm_iio_device_register (&client->dev, indio_dev); } -#ifdef CONFIG_PM_SLEEP static int mmc35240_suspend (struct device *dev) {struct iio_dev *indio_dev =i2c_get_clientdata (to_i2c_client (dev));
@@ -548,7 +547,6 @@ static int mmc35240_resume(struct device *dev)return 0 ; } -#endif static const struct dev_pm_ops mmc35240_pm_ops = {SET_SYSTEM_SLEEP_PM_OPS (mmc35240_suspend, mmc35240_resume)
Signature · 1 line
2.28.0
PATCH 9/15 iio: adc: palmas_gpadc: remove unnecessary CONFIG_PM_SLEEP
In reply to Coiby XuSET_SYSTEM_SLEEP_PM_OPS has already took good care of CONFIG_PM_CONFIG.
--- drivers/iio/adc/palmas_gpadc.c | 2 -- 1 file changed, 2 deletions(-)
drivers/iio/adc/palmas_gpadc.c +0 -2
@@ -643,7 +643,6 @@ static int palmas_gpadc_remove(struct platform_device *pdev)return 0 ; } -#ifdef CONFIG_PM_SLEEP static int palmas_adc_wakeup_configure (struct palmas_gpadc *adc) {int adc_period, conv;
@@ -812,7 +811,6 @@ static int palmas_gpadc_resume(struct device *dev)return 0 ; }; -#endif static const struct dev_pm_ops palmas_pm_ops = { SET_SYSTEM_SLEEP_PM_OPS(palmas_gpadc_suspend,
Signature · 1 line
2.28.0
PATCH 10/15 iio: adc: stm32: remove unnecessary CONFIG_PM_SLEEP
In reply to Coiby XuSET_SYSTEM_SLEEP_PM_OPS has already took good care of CONFIG_PM_CONFIG.
--- drivers/iio/adc/stm32-adc.c | 2 -- 1 file changed, 2 deletions(-)
drivers/iio/adc/stm32-adc.c +0 -2
@@ -1988,7 +1988,6 @@ static int stm32_adc_remove(struct platform_device *pdev)return 0 ; } -#if defined(CONFIG_PM_SLEEP )static int stm32_adc_suspend (struct device *dev) {struct iio_dev *indio_dev =dev_get_drvdata (dev);
@@ -2018,7 +2017,6 @@ static int stm32_adc_resume(struct device *dev)return stm32_adc_buffer_postenable (indio_dev); } -#endif #if defined(CONFIG_PM )static int stm32_adc_runtime_suspend (struct device *dev)
Signature · 7 lines
2.28.0 _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Re: [PATCH 10/15] iio: adc: stm32: remove unnecessary CONFIG_PM_SLEEP
Quoted 12 lines · Coiby Xu
SET_SYSTEM_SLEEP_PM_OPShas already took good care ofCONFIG_PM_CONFIG.Signed-off-by Coiby Xu <[email protected]>--- drivers/iio/adc/stm32-adc.c | 2 -- 1 file changed, 2 deletions(-)drivers/iio/adc/stm32-adc.c +0
-0
drivers/iio/adc/stm32-adc.c static int stm32_adc_remove(struct platform_device *pdev) · line 1991
Quoted 4 lines
drivers/iio/adc/stm32-adc.c +0
-1@@ -1988,7 +1988,6 @@ static int stm32_adc_remove(struct platform_device *pdev)return 0 ; } -#if defined(CONFIG_PM_SLEEP )
Hi Coiby,
This generates warnings when building with W=1 and CONFIG_PM_SLEEP=n. Could you please add also "__maybe_unused" attribute in suspend / resume routines below.
drivers/iio/adc/stm32-adc.c static int stm32_adc_remove(struct platform_device *pdev) · line 1991
Quoted 1 line
drivers/iio/adc/stm32-adc.c +0
-0static int stm32_adc_suspend (struct device *dev)
^
e.g. like: static int __maybe_unused stm32_adc_...
drivers/iio/adc/stm32-adc.c static int stm32_adc_resume(struct device *dev) · line 2021
Quoted 9 lines
drivers/iio/adc/stm32-adc.c +0
-1{struct iio_dev *indio_dev =dev_get_drvdata (dev);@@ -2018,7 +2017,6 @@ static int stm32_adc_resume(struct device *dev)return stm32_adc_buffer_postenable (indio_dev); } -#endif #if defined(CONFIG_PM )
Same could be done also for runtime PM routines. For my own curiosity, do you plan to do this as well ?
Best regards,
Fabrice
Quoted 2 lines
drivers/iio/adc/stm32-adc.c +0
-0static int stm32_adc_runtime_suspend (struct device *dev)
PATCH 11/15 iio: adc: at91_adc: remove unnecessary CONFIG_PM_SLEEP
In reply to Coiby XuSIMPLE_DEV_PM_OPS has already took good care of CONFIG_PM_CONFIG.
--- drivers/iio/adc/at91_adc.c | 2 -- 1 file changed, 2 deletions(-)
drivers/iio/adc/at91_adc.c +0 -2
@@ -1350,7 +1350,6 @@ static int at91_adc_remove(struct platform_device *pdev)return 0 ; } -#ifdef CONFIG_PM_SLEEP static int at91_adc_suspend (struct device *dev) {struct iio_dev *idev =dev_get_drvdata (dev);
@@ -1372,7 +1371,6 @@ static int at91_adc_resume(struct device *dev)return 0 ; } -#endif static SIMPLE_DEV_PM_OPS(at91_adc_pm_ops, at91_adc_suspend, at91_adc_resume);
Signature · 7 lines
2.28.0 _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
PATCH 12/15 iio: imu: kmx61: remove unnecessary CONFIG_PM_SLEEP
In reply to Coiby XuSET_SYSTEM_SLEEP_PM_OPS has already took good care of CONFIG_PM_CONFIG.
--- drivers/iio/imu/kmx61.c | 2 -- 1 file changed, 2 deletions(-)
drivers/iio/imu/kmx61.c +0 -2
@@ -1448,7 +1448,6 @@ static int kmx61_remove(struct i2c_client *client)return 0 ; } -#ifdef CONFIG_PM_SLEEP static int kmx61_suspend (struct device *dev) {int ret;
@@ -1474,7 +1473,6 @@ static int kmx61_resume(struct device *dev)return kmx61_set_mode (data, stby,KMX61_ACC |KMX61_MAG , true); } -#endif #ifdef CONFIG_PM static int kmx61_runtime_suspend (struct device *dev)
Signature · 1 line
2.28.0
PATCH 13/15 iio: light: us5182d: remove unnecessary CONFIG_PM_SLEEP
In reply to Coiby XuSET_SYSTEM_SLEEP_PM_OPS has already took good care of CONFIG_PM_CONFIG.
--- drivers/iio/light/us5182d.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/iio/light/us5182d.c +1 -1
@@ -918,7 +918,7 @@ static int us5182d_remove(struct i2c_client *client)return us5182d_shutdown_en (data,US5182D_CFG0_SHUTDOWN_EN ); } -#if defined(CONFIG_PM_SLEEP ) || defined(CONFIG_PM ) +#if defined(CONFIG_PM )static int us5182d_suspend (struct device *dev) {struct iio_dev *indio_dev =i2c_get_clientdata (to_i2c_client (dev));
Signature · 1 line
2.28.0
PATCH 14/15 iio: light: remove unnecessary CONFIG_PM_SLEEP
In reply to Coiby XuSET_SYSTEM_SLEEP_PM_OPS has already took good care of CONFIG_PM_CONFIG.
--- drivers/iio/light/pa12203001.c | 2 -- 1 file changed, 2 deletions(-)
drivers/iio/light/pa12203001.c +0 -2
@@ -417,14 +417,12 @@ static int pa12203001_suspend(struct device *dev) }#endif -#ifdef CONFIG_PM_SLEEP static int pa12203001_resume (struct device *dev) {struct iio_dev *indio_dev =i2c_get_clientdata (to_i2c_client (dev));return pa12203001_power_chip (indio_dev,PA12203001_CHIP_ENABLE ); } -#endif #ifdef CONFIG_PM static int pa12203001_runtime_resume (struct device *dev)
Signature · 1 line
2.28.0
PATCH 15/15 iio: proximity: remove unnecessary CONFIG_PM_SLEEP
In reply to Coiby XuSET_SYSTEM_SLEEP_PM_OPS has already took good care of CONFIG_PM_CONFIG.
--- drivers/iio/proximity/sx9500.c | 2 -- 1 file changed, 2 deletions(-)
drivers/iio/proximity/sx9500.c +0 -2
@@ -994,7 +994,6 @@ static int sx9500_remove(struct i2c_client *client)return 0 ; } -#ifdef CONFIG_PM_SLEEP static int sx9500_suspend (struct device *dev) {struct iio_dev *indio_dev =i2c_get_clientdata (to_i2c_client (dev));
@@ -1031,7 +1030,6 @@ static int sx9500_resume(struct device *dev)return ret; } -#endif /* CONFIG_PM_SLEEP */ static const struct dev_pm_ops sx9500_pm_ops = {SET_SYSTEM_SLEEP_PM_OPS (sx9500_suspend, sx9500_resume)
Signature · 1 line
2.28.0
Jonathan Cameron
maintainerQuoted 3 lines · On Thu, 29 Oct 2020 15:48:56 +0800 Coiby Xu <[email protected]> wrote:
SIMPLE_DEV_PM_OPShas already took good care ofCONFIG_PM_CONFIG.Signed-off-by Coiby Xu <[email protected]>
Hi Coiby,
Please put a cover letter on your next series explaining the context. In this particular case some of the replies you have gotten are general at it is a lot easier to find these sorts of things via replying to the cover letter.
Jonathan
Quoted 24 lines
--- drivers/iio/accel/da311.c | 2 -- 1 file changed, 2 deletions(-)drivers/iio/accel/da311.c +0
-2@@ -263,7 +263,6 @@ static int da311_remove(struct i2c_client *client)return da311_enable (client, false); } -#ifdef CONFIG_PM_SLEEP static int da311_suspend (struct device *dev) {return da311_enable (to_i2c_client (dev), false);@@ -273,7 +272,6 @@ static int da311_resume(struct device *dev) {return da311_enable (to_i2c_client (dev), true); } -#endif static SIMPLE_DEV_PM_OPS(da311_pm_ops, da311_suspend, da311_resume);
HI Jonathan,
Quoted 5 lines · Jonathan Cameron
Quoted 2 lines · On Thu, 29 Oct 2020 15:48:56 +0800 Coiby Xu <[email protected]> wrote:
SIMPLE_DEV_PM_OPShas already took good care ofCONFIG_PM_CONFIG.
Quoted 8 lines
Quoted 1 line
Signed-off-by Coiby Xu <[email protected]>Hi Coiby,
Please put a cover letter on your next series explaining the context. In this particular case some of the replies you have gotten are general at it is a lot easier to find these sorts of things via replying to the cover letter.
I will do it in v2. Thank you for the suggestion!
Quoted 24 lines
Jonathan
Quoted 22 lines
--- drivers/iio/accel/da311.c | 2 -- 1 file changed, 2 deletions(-)drivers/iio/accel/da311.c +0
-2@@ -263,7 +263,6 @@ static int da311_remove(struct i2c_client *client)return da311_enable (client, false); } -#ifdef CONFIG_PM_SLEEP static int da311_suspend (struct device *dev) {return da311_enable (to_i2c_client (dev), false);@@ -273,7 +272,6 @@ static int da311_resume(struct device *dev) {return da311_enable (to_i2c_client (dev), true); } -#endif
Quoted 3 lines
drivers/iio/accel/da311.c static int da311_resume(struct device *dev) · line 277
Quoted 2 lines
drivers/iio/accel/da311.c +0
-0static SIMPLE_DEV_PM_OPS(da311_pm_ops, da311_suspend, da311_resume);
--
Best regards,
Coiby
Quoted 7 lines · Jonathan Cameron
On Thu, 29 Oct 2020 15:48:56 +0800
Coiby Xu <[email protected]> wrote:Please put a cover letter on your next series explaining the context. In this particular case some of the replies you have gotten are general at it is a lot easier to find these sorts of things via replying to the cover letter.
Looking at the number of duplicate messages I would suggest that one needs to go through documentation on how to use git format-patch and git send-email.
Signature · 2 lines
With Best Regards, Andy Shevchenko
Quoted 4 lines · Andy Shevchenko
Quoted 2 lines · Jonathan Cameron
On Thu, 29 Oct 2020 15:48:56 +0800
Coiby Xu <[email protected]> wrote:
Quoted 9 lines
Quoted 4 lines
Please put a cover letter on your next series explaining the context. In this particular case some of the replies you have gotten are general at it is a lot easier to find these sorts of things via replying to the cover letter.
Looking at the number of duplicate messages I would suggest that one needs to go through documentation on how to use git format-patch and git send-email.
Thank you for the suggestion! Actually it's a tree-wide change and it seems the kernel community prefer individual patches or series for subsystems having the same maintainer over a huge patch set so I wrote some scripts to automate the process. That's why you see ~50 emails with almost the same commit message. The only difference of these commit messages is the name of PM macro.
Quoted 3 lines
--
With Best Regards,
Andy Shevchenko
--
Best regards,
Coiby
Jonathan Cameron
maintainerQuoted 15 lines · On Fri, 30 Oct 2020 22:34:10 +0800 Coiby Xu <[email protected]> wrote:
Quoted 4 lines · Andy Shevchenko
Quoted 2 lines · Jonathan Cameron
On Thu, 29 Oct 2020 15:48:56 +0800
Coiby Xu <[email protected]> wrote:Quoted 9 lines
Quoted 4 lines
Please put a cover letter on your next series explaining the context. In this particular case some of the replies you have gotten are general at it is a lot easier to find these sorts of things via replying to the cover letter.
Looking at the number of duplicate messages I would suggest that one needs to go through documentation on how to use git format-patch and git send-email.
Quoted 6 lines
Thank you for the suggestion! Actually it's a tree-wide change and it seems the kernel community prefer individual patches or series for subsystems having the same maintainer over a huge patch set so I wrote some scripts to automate the process. That's why you see ~50 emails with almost the same commit message. The only difference of these commit messages is the name of PM macro.
When doing a bit set like this, it's worth sending out a small subset first to shake out issue like those seen here.
Once those get merged then send out out the reset.
Thanks,
Jonathan
Quoted 8 lines
Quoted 4 lines
--
With Best Regards,
Andy Shevchenko--
Best regards,
Coiby
Quoted 25 lines · Jonathan Cameron
Quoted 15 lines · On Fri, 30 Oct 2020 22:34:10 +0800 Coiby Xu <[email protected]> wrote:
Quoted 4 lines · Andy Shevchenko
Quoted 2 lines · Jonathan Cameron
On Thu, 29 Oct 2020 15:48:56 +0800
Coiby Xu <[email protected]> wrote:Quoted 9 lines
Quoted 4 lines
Please put a cover letter on your next series explaining the context. In this particular case some of the replies you have gotten are general at it is a lot easier to find these sorts of things via replying to the cover letter.
Looking at the number of duplicate messages I would suggest that one needs to go through documentation on how to use git format-patch and git send-email.
Quoted 6 lines
Thank you for the suggestion! Actually it's a tree-wide change and it seems the kernel community prefer individual patches or series for subsystems having the same maintainer over a huge patch set so I wrote some scripts to automate the process. That's why you see ~50 emails with almost the same commit message. The only difference of these commit messages is the name of PM macro.
Quoted 5 lines
When doing a bit set like this, it's worth sending out a small subset first to shake out issue like those seen here.
Once those get merged then send out out the reset.
Thank you for the suggestion! Actually I've held off another ~150 emails and these ~200 emails were only part of work. I thought it's better to reach 4 or 5 subsystem to collect sufficient feedbacks considering some subsystems may respond slow. But I didn't realize a better way is to cut down the size of patch set sent to a subsystem.
Quoted 13 lines
Thanks,
Jonathan
Quoted 8 lines
Quoted 4 lines
--
With Best Regards,
Andy Shevchenko--
Best regards,
Coiby
--
Best regards,
Coiby
Jonathan Cameron
maintainerQuoted 29 lines · On Sun, 1 Nov 2020 06:47:35 +0800 Coiby Xu <[email protected]> wrote:
Quoted 28 lines · Jonathan Cameron
Quoted 15 lines · On Fri, 30 Oct 2020 22:34:10 +0800 Coiby Xu <[email protected]> wrote:
Quoted 4 lines · Andy Shevchenko
Quoted 2 lines · Jonathan Cameron
On Thu, 29 Oct 2020 15:48:56 +0800
Coiby Xu <[email protected]> wrote:Quoted 9 lines
Quoted 4 lines
Please put a cover letter on your next series explaining the context. In this particular case some of the replies you have gotten are general at it is a lot easier to find these sorts of things via replying to the cover letter.
Looking at the number of duplicate messages I would suggest that one needs to go through documentation on how to use git format-patch and git send-email.
Quoted 6 lines
Thank you for the suggestion! Actually it's a tree-wide change and it seems the kernel community prefer individual patches or series for subsystems having the same maintainer over a huge patch set so I wrote some scripts to automate the process. That's why you see ~50 emails with almost the same commit message. The only difference of these commit messages is the name of PM macro.
When doing a bit set like this, it's worth sending out a small subset first to shake out issue like those seen here.
Quoted 7 lines
Quoted 2 lines
Once those get merged then send out out the reset.
Thank you for the suggestion! Actually I've held off another ~150 emails and these ~200 emails were only part of work. I thought it's better to reach 4 or 5 subsystem to collect sufficient feedbacks considering some subsystems may respond slow. But I didn't realize a better way is to cut down the size of patch set sent to a subsystem.
Keep it sub 20 per subsystem and it shouldn't matter too much, but perhaps always send to just one subsystem first as you may get very fast responses!
Then if it looks good after a few days, your approach of targeting a few more subsystems would make sense.
Jonathan
Quoted 17 lines
Quoted 13 lines
Thanks,
Jonathan
Quoted 8 lines
Quoted 4 lines
--
With Best Regards,
Andy Shevchenko--
Best regards,
Coiby--
Best regards,
Coiby