Input: pmic8xxx-keypad: remove unnecessary CONFIG_PM_SLEEP
Subsystems (2)
PATCH 1/3 Input: pmic8xxx-keypad: remove unnecessary CONFIG_PM_SLEEP
SIMPLE_DEV_PM_OPS has already took good care of CONFIG_PM_CONFIG.
Signed-off-by Coiby Xu <[email protected]>
--- drivers/input/keyboard/pmic8xxx-keypad.c | 2 -- 1 file changed, 2 deletions(-)
drivers/input/keyboard/pmic8xxx-keypad.c +0 -2
@@ -621,7 +621,6 @@ static int pmic8xxx_kp_probe(struct platform_device *pdev)return 0 ; } -#ifdef CONFIG_PM_SLEEP static int pmic8xxx_kp_suspend (struct device *dev) {struct platform_device *pdev =to_platform_device (dev);
@@ -661,7 +660,6 @@ static int pmic8xxx_kp_resume(struct device *dev)return 0 ; } -#endif static SIMPLE_DEV_PM_OPS(pm8xxx_kp_pm_ops, pmic8xxx_kp_suspend, pmic8xxx_kp_resume);
Signature · 1 line
2.28.0
PATCH 2/3 Input: adp5589: remove unnecessary CONFIG_PM_SLEEP
SIMPLE_DEV_PM_OPS has already took good care of CONFIG_PM_CONFIG.
Signed-off-by Coiby Xu <[email protected]>
--- drivers/input/keyboard/adp5589-keys.c | 2 -- 1 file changed, 2 deletions(-)
drivers/input/keyboard/adp5589-keys.c +0 -2
@@ -1077,7 +1077,6 @@ static int adp5589_remove(struct i2c_client *client)return 0 ; } -#ifdef CONFIG_PM_SLEEP static int adp5589_suspend (struct device *dev) {struct adp5589_kpad *kpad =dev_get_drvdata (dev);
@@ -1109,7 +1108,6 @@ static int adp5589_resume(struct device *dev)return 0 ; } -#endif static SIMPLE_DEV_PM_OPS(adp5589_dev_pm_ops, adp5589_suspend, adp5589_resume);
Signature · 1 line
2.28.0
PATCH 3/3 Input: nomadik-ske-keypad: remove unnecessary CONFIG_PM_SLEEP
In reply to Coiby XuSIMPLE_DEV_PM_OPS has already took good care of CONFIG_PM_CONFIG.
Signed-off-by Coiby Xu <[email protected]>
--- drivers/input/keyboard/nomadik-ske-keypad.c | 2 -- 1 file changed, 2 deletions(-)
drivers/input/keyboard/nomadik-ske-keypad.c +0 -2
@@ -386,7 +386,6 @@ static int ske_keypad_remove(struct platform_device *pdev)return 0 ; } -#ifdef CONFIG_PM_SLEEP static int ske_keypad_suspend (struct device *dev) {struct platform_device *pdev =to_platform_device (dev);
@@ -414,7 +413,6 @@ static int ske_keypad_resume(struct device *dev)return 0 ; } -#endif static SIMPLE_DEV_PM_OPS(ske_keypad_dev_pm_ops, ske_keypad_suspend, ske_keypad_resume);
Signature · 1 line
2.28.0
Dmitry Torokhov
maintainerQuoted 1 line · Coiby Xu
SIMPLE_DEV_PM_OPShas already took good care ofCONFIG_PM_CONFIG.
Doesn't it result in "defined but not used" warnings if you compile without CONFIG_PM? I believe if you are dropping #ifdef guards you need to add __maybe_unused annotations.
Quoted 28 lines
Signed-off-by Coiby Xu <[email protected]>--- drivers/input/keyboard/pmic8xxx-keypad.c | 2 -- 1 file changed, 2 deletions(-)drivers/input/keyboard/pmic8xxx-keypad.c +0
-2@@ -621,7 +621,6 @@ static int pmic8xxx_kp_probe(struct platform_device *pdev)return 0 ; } -#ifdef CONFIG_PM_SLEEP static int pmic8xxx_kp_suspend (struct device *dev) {struct platform_device *pdev =to_platform_device (dev);@@ -661,7 +660,6 @@ static int pmic8xxx_kp_resume(struct device *dev)return 0 ; } -#endif static SIMPLE_DEV_PM_OPS(pm8xxx_kp_pm_ops, pmic8xxx_kp_suspend, pmic8xxx_kp_resume);Signature · 1 line
2.28.0
Thanks.
Signature · 1 line
Dmitry