Skip to contentSkip to conversation

test: fix GMAC SGL test

dpdk-dev Applied Fan Zhang 4 participants 5 messages Oct 29, 2020 – Nov 4, 2020

lore
Share & tools
lore

Fan Zhang

author
#0 lore raw

This ptach fixes the GMAC SGL test that fails to bypass unsupported PMDs.

Fixes dcdd01691f39 ("test/crypto: add GMAC SGL")
---
 app/test/test_cryptodev.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
app/test/test_cryptodev.c +2 -2
index 0fed124d3..130719d67 100644
@@ -11069,8 +11069,8 @@ test_AES_GMAC_authentication_SGL(const struct gmac_test_data *tdata,
 	rte_cryptodev_info_get(ts_params->valid_devs[0], &dev_info);
 	feature_flags = dev_info.feature_flags;
 
-	if ((!(feature_flags & RTE_CRYPTODEV_FF_IN_PLACE_SGL)) &&
-			(!(feature_flags & RTE_CRYPTODEV_FF_OOP_SGL_IN_LB_OUT)) &&
+	if ((!(feature_flags & RTE_CRYPTODEV_FF_IN_PLACE_SGL)) ||
+			(!(feature_flags & RTE_CRYPTODEV_FF_OOP_SGL_IN_LB_OUT)) ||
 			(!(feature_flags & RTE_CRYPTODEV_FF_OOP_SGL_IN_SGL_OUT)))
 		return -ENOTSUP;
 
Signature · 1 line
2.26.2
author
#1 lore raw

PATCH v2 1/1 test: fix GMAC SGL test

This patch fixes the GMAC SGL test that fails to bypass unsupported PMDs.

Fixes dcdd01691f39 ("test/crypto: add GMAC SGL")

---
v2:
- fix typo

 app/test/test_cryptodev.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
app/test/test_cryptodev.c +2 -2
index 0fed124d3..130719d67 100644
@@ -11069,8 +11069,8 @@ test_AES_GMAC_authentication_SGL(const struct gmac_test_data *tdata,
 	rte_cryptodev_info_get(ts_params->valid_devs[0], &dev_info);
 	feature_flags = dev_info.feature_flags;
 
-	if ((!(feature_flags & RTE_CRYPTODEV_FF_IN_PLACE_SGL)) &&
-			(!(feature_flags & RTE_CRYPTODEV_FF_OOP_SGL_IN_LB_OUT)) &&
+	if ((!(feature_flags & RTE_CRYPTODEV_FF_IN_PLACE_SGL)) ||
+			(!(feature_flags & RTE_CRYPTODEV_FF_OOP_SGL_IN_LB_OUT)) ||
 			(!(feature_flags & RTE_CRYPTODEV_FF_OOP_SGL_IN_SGL_OUT)))
 		return -ENOTSUP;
 
Signature · 1 line
2.26.2
Tested-by on v2 1/1
#2 lore raw

Best Regards
Jiang yu

Quoted 41 lines

-----Original Message-----
From: dev [mailto:[email protected]] On Behalf Of Fan Zhang
Sent: Thursday, October 29, 2020 10:47 PM
To: [email protected]
Cc: [email protected]; Zhang, Roy Fan <[email protected]>; De Lara Guarch, Pablo <[email protected]>
Subject: [dpdk-dev] [dpdk-dev v2] test: fix GMAC SGL test

This patch fixes the GMAC SGL test that fails to bypass unsupported PMDs.

Fixes dcdd01691f39 ("test/crypto: add GMAC SGL")

---
v2:
- fix typo

 app/test/test_cryptodev.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
app/test/test_cryptodev.c index renamed from app/test/test_cryptodev.c +0 -0

0fed124d3..130719d67 100644

app/test/test_cryptodev.c +0 -2
@@ -11069,8 +11069,8 @@ test_AES_GMAC_authentication_SGL(const
 struct gmac_test_data *tdata,
 	rte_cryptodev_info_get(ts_params->valid_devs[0], &dev_info);
 	feature_flags = dev_info.feature_flags;
 
-	if ((!(feature_flags & RTE_CRYPTODEV_FF_IN_PLACE_SGL)) &&
-			(!(feature_flags &

RTE_CRYPTODEV_FF_OOP_SGL_IN_LB_OUT)) &&

app/test/test_cryptodev.c +2 -0
+	if ((!(feature_flags & RTE_CRYPTODEV_FF_IN_PLACE_SGL)) ||
+			(!(feature_flags &

RTE_CRYPTODEV_FF_OOP_SGL_IN_LB_OUT)) ||
(!(feature_flags &
RTE_CRYPTODEV_FF_OOP_SGL_IN_SGL_OUT)))
return -ENOTSUP;

--
2.26.2

Acked-by on v2 1/1
#3 lore raw
In reply to Fan Zhang
Quoted 10 lines

-----Original Message-----
From: Zhang, Roy Fan <[email protected]>
Sent: Thursday, October 29, 2020 2:47 PM
To: [email protected]
Cc: [email protected]; Zhang, Roy Fan <[email protected]>; De Lara Guarch, Pablo <[email protected]>
Subject: [dpdk-dev v2] test: fix GMAC SGL test

Quoted 6 lines

This patch fixes the GMAC SGL test that fails to bypass unsupported PMDs.

Fixes dcdd01691f39 ("test/crypto: add GMAC SGL")

Commit message can be changed to "test/crypto: fix GMAC SGL", but I think it can be changed when applying the patch.

Applied
#4 lore raw
Quoted 7 lines
Quoted 7 lines

Subject: [dpdk-dev v2] test: fix GMAC SGL test

This patch fixes the GMAC SGL test that fails to bypass unsupported PMDs.

Fixes dcdd01691f39 ("test/crypto: add GMAC SGL")
Quoted 6 lines
Quoted 1 line

Commit message can be changed to "test/crypto: fix GMAC SGL", but I think it can be changed when applying the patch.

Applied to dpdk-next-crypto

Thanks.