Skip to contentSkip to conversation

linux-next: build failure after merge of the akpm-current tree

PATCH Stephen Rothwell 2 participants 2 messages Oct 29, 2020 Linux-next tree

lore
Share & tools
lore
#0 lore raw

Hi all,

After merging the akpm-current tree, today's linux-next build (powerpc ppc64_defconfig) failed like this:

lib/math/div64.c: In function 'mul_u64_u64_div_u64':
lib/math/div64.c:202:6: error: implicit declaration of function 'ilog2' [-Werror=implicit-function-declaration]

  202 |  if (ilog2(a) + ilog2(b) > 62) {
      |      ^~~~~

Caused by commit

4ec993a18ff6 ("kernel.h: Split out mathematical helpers")

I have applied the following patch for today:

From: Stephen Rothwell <[email protected]>
Date: Thu, 29 Oct 2020 15:03:58 +1100
Subject: [PATCH] kernel.h: Split out mathematical helpers fix

---
 lib/math/div64.c | 1 +
 1 file changed, 1 insertion(+)
lib/math/div64.c +1 -0
index dcc826c40ca1..064d68a5391a 100644
@@ -22,6 +22,7 @@
 #include <linux/export.h>
 #include <linux/math.h>
 #include <linux/math64.h>
+#include <linux/log2.h>
 
 /* Not needed on 64bit architectures */
 #if BITS_PER_LONG == 32
Signature · 5 lines
2.28.0

-- 
Cheers,
Stephen Rothwell
#1 lore raw
Quoted 5 lines · Stephen Rothwell

After merging the akpm-current tree, today's linux-next build (powerpc ppc64_defconfig) failed like this:

lib/math/div64.c: In function 'mul_u64_u64_div_u64':
lib/math/div64.c:202:6: error: implicit declaration of function 'ilog2' [-Werror=implicit-function-declaration]

Quoted 8 lines
  202 |  if (ilog2(a) + ilog2(b) > 62) {
      |      ^~~~~

Caused by commit

4ec993a18ff6 ("kernel.h: Split out mathematical helpers")

I have applied the following patch for today:

Right, thanks! It seems x86 has this inclusion somewhere else and my patch reveals this on PPC which has cleaner inclusion chain.

Andrew, can you attach this fix to your tree?

Signature · 2 lines
With Best Regards,
Andy Shevchenko