imx: mx6cuboxi: Disable CONFIG_IMX_THERMAL
PATCH 1/1 imx: mx6cuboxi: Disable CONFIG_IMX_THERMAL
This feature is incompatble with of-platdata since it uses the U_BOOT_DEVICE() macro. With of-platdata the only devices permitted are those created by dtoc.
Drop this option for now, until the driver can be corrected.
---
include/configs/mx6cuboxi.h | 2 -- 1 file changed, 2 deletions(-)
include/configs/mx6cuboxi.h +0 -2
@@ -13,8 +13,6 @@#include "imx6_spl.h" -#define CONFIG_IMX_THERMAL -#define CONFIG_SYS_MALLOC_LEN (10 * SZ_1M)/* MMC Configs */
Signature · 1 line
2.29.1.341.ge80a0c044ae-goog
PATCH 1/1 imx: mx6cuboxi: Disable CONFIG_IMX_THERMAL
Hi Simon,
Adding Walter to Cc.
Quoted 5 lines · Simon Glass
This feature is incompatble with of-platdata since it uses the
U_BOOT_DEVICE()macro. With of-platdata the only devices permitted are those created by dtoc.Drop this option for now, until the driver can be corrected.
As I understand, of-platdata is only enabled in SPL. Is there a way to limit imx_thermal drop to SPL? The thermal driver in not very useful in SPL anyway, right?
Thanks,
baruch
Quoted 19 lines
Signed-off-by Simon Glass <[email protected]>---
include/configs/mx6cuboxi.h | 2 -- 1 file changed, 2 deletions(-)include/configs/mx6cuboxi.h +0
-2@@ -13,8 +13,6 @@#include "imx6_spl.h" -#define CONFIG_IMX_THERMAL -#define CONFIG_SYS_MALLOC_LEN (10 * SZ_1M)/* MMC Configs */
Signature · 3 lines
~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -PATCH 1/1 imx: mx6cuboxi: Disable CONFIG_IMX_THERMAL
Quoted 9 lines · Baruch Siach
Hi Simon,
Adding Walter to Cc.
Quoted 4 lines · Simon Glass
This feature is incompatble with of-platdata since it uses the
U_BOOT_DEVICE()macro. With of-platdata the only devices permitted are those created by dtoc.
Quoted 5 lines
Quoted 1 line
Drop this option for now, until the driver can be corrected.
As I understand, of-platdata is only enabled in SPL. Is there a way to limit
imx_thermaldrop to SPL? The thermal driver in not very useful in SPL anyway, right?
Well, sigh, step one is to finish the migration to Kconfig for IMX_THERMAL as it has a symbol, but it's still set in a ton of board config files. We only build thermal in SPL when SPL_THERMAL is set, so I assume this is about trying to use of-platdata in U-Boot proper too, to keep / further reduce the size of U-Boot itself to stay within size limits.
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 659 bytes Desc: not available URL: <https://lists.denx.de/pipermail/u-boot/attachments/20201029/1e7307bb/attachment.sig>
PATCH 1/1 imx: mx6cuboxi: Disable CONFIG_IMX_THERMAL
Quoted 6 lines · Tom Rini
Quoted 5 lines · Baruch Siach
Hi Simon,
Adding Walter to Cc.
On Thu, Oct 29 2020, Simon Glass wrote:
Quoted 8 lines
Quoted 8 lines
Quoted 5 lines
This feature is incompatble with of-platdata since it uses the
U_BOOT_DEVICE()macro. With of-platdata the only devices permitted are those created by dtoc.Drop this option for now, until the driver can be corrected.
As I understand, of-platdata is only enabled in SPL. Is there a way to limit
imx_thermaldrop to SPL? The thermal driver in not very useful in SPL anyway, right?
As you pointed of-platdata is intended for TPL/SPL to avoid the overhead of DTB and libraries. If this option is enabled and the driver does not support it, the device won't be created in TPL/SPL but is should on U-Boot. In order to limit the drop to SPL can CONFIG_SPL_BUILD be used?
Regarding the usefulness of im_thermal in SPL I can't comment.
Quoted 7 lines
Well, sigh, step one is to finish the migration to
KconfigforIMX_THERMALas it has a symbol, but it's still set in a ton of board config files. We only build thermal in SPL whenSPL_THERMALis set, so I assume this is about trying to use of-platdata in U-Boot proper too, to keep / further reduce the size of U-Boot itself to stay within size limits.
Regards,
Walter
PATCH 1/1 imx: mx6cuboxi: Disable CONFIG_IMX_THERMAL
Quoted 17 lines · Walter Lozano
Quoted 6 lines · Tom Rini
Quoted 5 lines · Baruch Siach
Hi Simon,
Adding Walter to Cc.
On Thu, Oct 29 2020, Simon Glass wrote:
Quoted 8 lines
Quoted 8 lines
Quoted 5 lines
This feature is incompatble with of-platdata since it uses the
U_BOOT_DEVICE()macro. With of-platdata the only devices permitted are those created by dtoc.Drop this option for now, until the driver can be corrected.
As I understand, of-platdata is only enabled in SPL. Is there a way to limit
imx_thermaldrop to SPL? The thermal driver in not very useful in SPL anyway, right?
Quoted 13 lines
As you pointed of-platdata is intended for TPL/SPL to avoid the overhead of DTB and libraries. If this option is enabled and the driver does not support it, the device won't be created in TPL/SPL but is should on U-Boot. In order to limit the drop to SPL can
CONFIG_SPL_BUILDbe used?Regarding the usefulness of
im_thermalin SPL I can't comment.Quoted 6 lines
Well, sigh, step one is to finish the migration to
KconfigforIMX_THERMALas it has a symbol, but it's still set in a ton of board config files. We only build thermal in SPL whenSPL_THERMALis set, so I assume this is about trying to use of-platdata in U-Boot proper too, to keep / further reduce the size of U-Boot itself to stay within size limits.
Well, I suspect maybe part of the problem is that since the symbol isn't migrated properly, it's not being not built when we don't need it. I did the migration and queued up a build, I should have some answers later today.
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 659 bytes Desc: not available URL: <https://lists.denx.de/pipermail/u-boot/attachments/20201029/b7f17b01/attachment.sig>
PATCH 1/1 imx: mx6cuboxi: Disable CONFIG_IMX_THERMAL
Hi,
Quoted 33 lines · Tom Rini
Quoted 17 lines · Walter Lozano
Quoted 6 lines · Tom Rini
Quoted 5 lines · Baruch Siach
Hi Simon,
Adding Walter to Cc.
On Thu, Oct 29 2020, Simon Glass wrote:
Quoted 8 lines
Quoted 8 lines
Quoted 5 lines
This feature is incompatble with of-platdata since it uses the
U_BOOT_DEVICE()macro. With of-platdata the only devices permitted are those created by dtoc.Drop this option for now, until the driver can be corrected.
As I understand, of-platdata is only enabled in SPL. Is there a way to limit
imx_thermaldrop to SPL? The thermal driver in not very useful in SPL anyway, right?Quoted 13 lines
As you pointed of-platdata is intended for TPL/SPL to avoid the overhead of DTB and libraries. If this option is enabled and the driver does not support it, the device won't be created in TPL/SPL but is should on U-Boot. In order to limit the drop to SPL can
CONFIG_SPL_BUILDbe used?Regarding the usefulness of
im_thermalin SPL I can't comment.Quoted 6 lines
Well, sigh, step one is to finish the migration to
KconfigforIMX_THERMALas it has a symbol, but it's still set in a ton of board config files. We only build thermal in SPL whenSPL_THERMALis set, so I assume this is about trying to use of-platdata in U-Boot proper too, to keep / further reduce the size of U-Boot itself to stay within size limits.
Quoted 4 lines
Well, I suspect maybe part of the problem is that since the symbol isn't migrated properly, it's not being not built when we don't need it. I did the migration and queued up a build, I should have some answers later today.
In the meantime I'll send a v2 patch which just disables the driver in SPL.
Regards,
Simon