net/mlx5: fix CQE decompression for ARM and PowerPC
PATCH 1/1 net/mlx5: fix CQE decompression for ARM and PowerPC
The recent Rx code refactoring moved the incrementing of the CQ completion index out of the rxq_cq_decompress_v() function to the rxq_burst_v() function.
The advancing of CQ completion index was removed in SSE version only causing Neon and Altivec Rx bursts to stall.
Remove the incrementation of CQ completion index for all the architectures in order to fix the stall.
--- drivers/net/mlx5/mlx5_rxtx_vec_altivec.h | 1 - drivers/net/mlx5/mlx5_rxtx_vec_neon.h | 1 - 2 files changed, 2 deletions(-)
drivers/net/mlx5/mlx5_rxtx_vec_altivec.h +0 -1
@@ -301,7 +301,6 @@ rxq_cq_decompress_v(struct mlx5_rxq_data *rxq, volatile struct mlx5_cqe *cq, rxq->stats.ibytes += rcvd_byte;#endif - rxq->cq_ci += mcqe_n;return mcqe_n; }
drivers/net/mlx5/mlx5_rxtx_vec_neon.h +0 -1
@@ -240,7 +240,6 @@ rxq_cq_decompress_v(struct mlx5_rxq_data *rxq, volatile struct mlx5_cqe *cq, rxq->stats.ipackets += mcqe_n; rxq->stats.ibytes += rcvd_byte;#endif - rxq->cq_ci += mcqe_n;return mcqe_n; }
Signature · 1 line
2.24.1
Quoted 15 lines
-----Original Message-----
From: Alexander Kozyrev <[email protected]>
Sent: Thursday, October 29, 2020 19:58
To: [email protected]
Cc: Raslan Darawsheh <[email protected]>; Slava Ovsiienko <[email protected]>; Matan Azrad <[email protected]>
Subject: [PATCH] net/mlx5: fix CQE decompression for ARM and PowerPCThe recent Rx code refactoring moved the incrementing of the CQ completion index out of the
rxq_cq_decompress_v()function to therxq_burst_v()function.The advancing of CQ completion index was removed in SSE version only causing Neon and Altivec Rx bursts to stall.
Quoted 6 lines
Remove the incrementation of CQ completion index for all the architectures in order to fix the stall.
Fixes bf7d5157ed ("net/mlx5: refactor vectorized Rx")Signed-off-by Alexander Kozyrev <[email protected]>
Hi,
Quoted 7 lines
-----Original Message-----
From: Alexander Kozyrev <[email protected]>
Sent: Thursday, October 29, 2020 7:58 PM
To: [email protected]
Cc: Raslan Darawsheh <[email protected]>; Slava Ovsiienko <[email protected]>; Matan Azrad <[email protected]>
Subject: [PATCH] net/mlx5: fix CQE decompression for ARM and PowerPC
Fixed styling issue ARM->Arm
Quoted 5 lines
The recent Rx code refactoring moved the incrementing of the CQ completion index out of the
rxq_cq_decompress_v()function to therxq_burst_v()function.
Quoted 7 lines
The advancing of CQ completion index was removed in SSE version only causing Neon and Altivec Rx bursts to stall.
Remove the incrementation of CQ completion index for all the architectures in order to fix the stall.
Fixes bf7d5157ed ("net/mlx5: refactor vectorized Rx")
Fixed commit id
Quoted 3 lines
Signed-off-by Alexander Kozyrev <[email protected]>---
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh