Skip to contentSkip to conversation

net/mlx5: fix CQE decompression for ARM and PowerPC

PATCH In review Alexander Kozyrev 3 participants 3 messages Oct 29, 2020 – Nov 2, 2020 Network drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net/mlx5: fix CQE decompression for ARM and PowerPC

The recent Rx code refactoring moved the incrementing of the CQ completion index out of the rxq_cq_decompress_v() function to the rxq_burst_v() function.

The advancing of CQ completion index was removed in SSE version only causing Neon and Altivec Rx bursts to stall.

Remove the incrementation of CQ completion index for all the architectures in order to fix the stall.

Fixes bf7d5157ed ("net/mlx5: refactor vectorized Rx")
---
 drivers/net/mlx5/mlx5_rxtx_vec_altivec.h | 1 -
 drivers/net/mlx5/mlx5_rxtx_vec_neon.h    | 1 -
 2 files changed, 2 deletions(-)
drivers/net/mlx5/mlx5_rxtx_vec_altivec.h +0 -1
index cf3a795843..4af4ccafca 100644
@@ -301,7 +301,6 @@ rxq_cq_decompress_v(struct mlx5_rxq_data *rxq, volatile struct mlx5_cqe *cq,
 	rxq->stats.ibytes += rcvd_byte;
 #endif
 
-	rxq->cq_ci += mcqe_n;
 	return mcqe_n;
 }
 
drivers/net/mlx5/mlx5_rxtx_vec_neon.h +0 -1
index 47b6692942..f194cc99b7 100644
@@ -240,7 +240,6 @@ rxq_cq_decompress_v(struct mlx5_rxq_data *rxq, volatile struct mlx5_cqe *cq,
 	rxq->stats.ipackets += mcqe_n;
 	rxq->stats.ibytes += rcvd_byte;
 #endif
-	rxq->cq_ci += mcqe_n;
 	return mcqe_n;
 }
 
Signature · 1 line
2.24.1
Acked-by on v1 1/1
#1 lore raw
Quoted 15 lines

-----Original Message-----
From: Alexander Kozyrev <[email protected]>
Sent: Thursday, October 29, 2020 19:58
To: [email protected]
Cc: Raslan Darawsheh <[email protected]>; Slava Ovsiienko <[email protected]>; Matan Azrad <[email protected]>
Subject: [PATCH] net/mlx5: fix CQE decompression for ARM and PowerPC

The recent Rx code refactoring moved the incrementing of the CQ completion index out of the rxq_cq_decompress_v() function to the rxq_burst_v() function.

The advancing of CQ completion index was removed in SSE version only causing Neon and Altivec Rx bursts to stall.

Quoted 6 lines

Remove the incrementation of CQ completion index for all the architectures in order to fix the stall.

Fixes bf7d5157ed ("net/mlx5: refactor vectorized Rx")
#2 lore raw
In reply to Alexander Kozyrev

Hi,

Quoted 7 lines

-----Original Message-----
From: Alexander Kozyrev <[email protected]>
Sent: Thursday, October 29, 2020 7:58 PM
To: [email protected]
Cc: Raslan Darawsheh <[email protected]>; Slava Ovsiienko <[email protected]>; Matan Azrad <[email protected]>
Subject: [PATCH] net/mlx5: fix CQE decompression for ARM and PowerPC

Fixed styling issue ARM->Arm

Quoted 5 lines

The recent Rx code refactoring moved the incrementing of the CQ completion index out of the rxq_cq_decompress_v() function to the rxq_burst_v() function.

Quoted 7 lines

The advancing of CQ completion index was removed in SSE version only causing Neon and Altivec Rx bursts to stall.

Remove the incrementation of CQ completion index for all the architectures in order to fix the stall.

Fixes bf7d5157ed ("net/mlx5: refactor vectorized Rx")

Fixed commit id

Quoted 3 lines

---

Patch applied to next-net-mlx,

Kindest regards,
Raslan Darawsheh