Skip to contentSkip to conversation

ARM: dts: CCMX51: Increase kernel partition size

PATCH In review Alexander Shiyan 3 participants 4 messages Oct 30, 2020 – Nov 2, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: dts: CCMX51: Increase kernel partition size

---
 arch/arm/dts/imx51-ccxmx51.dts | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
arch/arm/dts/imx51-ccxmx51.dts +3 -3
index efe5dbf63..4aa32e4c8 100644
@@ -31,11 +31,11 @@
 
 	partition@c0000 {
 		label = "kernel";
-		reg = <0xc0000 0x340000>;
+		reg = <0xc0000 0x400000>;
 	};
 
-	partition@400000 {
+	partition@4c0000 {
 		label = "root";
-		reg = <0x400000 0>;
+		reg = <0x4c0000 0>;
 	};
 };
Signature · 7 lines
2.26.2


_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox
#1 lore raw

On Fri, Oct 30, 2020 at 10:31:57AM +0300, Alexander Shiyan wrote:
A few words about the motivation here would be great. Is 0x340000 to small for a current kernel? Is this following some upstream change? Why not install the kernel in the rootfs and get rid of the kernel partition?

Best regards
Uwe

Quoted 33 lines
---
 arch/arm/dts/imx51-ccxmx51.dts | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
arch/arm/dts/imx51-ccxmx51.dts +3 -3
index efe5dbf63..4aa32e4c8 100644
@@ -31,11 +31,11 @@
 
 	partition@c0000 {
 		label = "kernel";
-		reg = <0xc0000 0x340000>;
+		reg = <0xc0000 0x400000>;
 	};
 
-	partition@400000 {
+	partition@4c0000 {
 		label = "root";
-		reg = <0x400000 0>;
+		reg = <0x4c0000 0>;
 	};
 };
Signature · 7 lines
2.26.2


_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox
Signature · 2 lines
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox

#2 lore raw
Quoted 7 lines

Пятница, 30 октября 2020, 23:02 +03:00 от Uwe Kleine-König <[email protected]>:

On Fri, Oct 30, 2020 at 10:31:57AM +0300, Alexander Shiyan wrote:
A few words about the motivation here would be great. Is 0x340000 to small for a current kernel? Is this following some upstream change? Why not install the kernel in the rootfs and get rid of the kernel partition?

Hello.

The current size of the kernel partition is sufficient to place i.MX51-dependent code only, but if the kernel was compiled with support for other boards / drivers, the space is too small. Installing the kernel in rootfs might be a good idea, but that means that rootfs is a UBIFS, and resulting ubifs image will be NAND type dependent. In order to use the same rootfs on different systems, I prefer to use the squashfs root filesystem on top of the UBI volume.

Let's just drop this patch.

Quoted 17 lines
Quoted 17 lines

---
arch/arm/dts/imx51-ccxmx51.dts | 6 +++---

1 file changed, 3 insertions(+), 3 deletions(-)
arch/arm/dts/imx51-ccxmx51.dts +1 -1
index efe5dbf63..4aa32e4c8 100644
@@ -31,11 +31,11 @@
 
 partition@c0000 {
 label = "kernel";
-reg = <0xc0000 0x340000>;
+reg = <0xc0000 0x400000>;
 };
 
Quoted 9 lines
Quoted 9 lines
arch/arm/dts/imx51-ccxmx51.dts +2 -3
-partition@400000 {
+partition@4c0000 {
 label = "root";
-reg = <0x400000 0>;
+reg = <0x4c0000 0>;
 };
 };
--

2.26.2

---
_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox

maintainer
#3 lore raw
In reply to Alexander Shiyan
Quoted 10 lines · Alexander Shiyan
---
 arch/arm/dts/imx51-ccxmx51.dts | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
arch/arm/dts/imx51-ccxmx51.dts +0 -0
index efe5dbf63..4aa32e4c8 100644

arch/arm/dts/imx51-ccxmx51.dts line 35

Quoted 6 lines
arch/arm/dts/imx51-ccxmx51.dts +1 -1
@@ -31,11 +31,11 @@
 
 	partition@c0000 {
 		label = "kernel";
-		reg = <0xc0000 0x340000>;
+		reg = <0xc0000 0x400000>;
 	};

This is an incompatible change to the partitioning, so a board won't boot anymore when only barebox is updated. If you do the step, wouldn't it make sense to increase the kernel partition a bit more to be future proof for a bit longer?

Sascha

Signature · 9 lines
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox