Skip to contentSkip to conversation

target/unicore32/translate: Add missing fallthrough annotations

PATCH In review Thomas Huth 2 participants 2 messages Oct 30, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 target/unicore32/translate: Add missing fallthrough annotations

Looking at the way the code is formatted here (there is an empty line after break statements, but none where the break is missing), the fallthrough is very likely intended here. So add a fallthrough comment to make the it compilable with -Werror=implicit-fallthrough.

---
 target/unicore32/translate.c | 2 ++
 1 file changed, 2 insertions(+)
target/unicore32/translate.c +2 -0
index d4b06df672..962f9877a0 100644
@@ -1801,6 +1801,7 @@ static void disas_uc32_insn(CPUUniCore32State *env, DisasContext *s)
             do_misc(env, s, insn);
             break;
         }
+        /* fallthrough */
     case 0x1:
         if (((UCOP_OPCODES >> 2) == 2) && !UCOP_SET_S) {
             do_misc(env, s, insn);
@@ -1817,6 +1818,7 @@ static void disas_uc32_insn(CPUUniCore32State *env, DisasContext *s)
         if (UCOP_SET(8) || UCOP_SET(5)) {
             ILLEGAL;
         }
+        /* fallthrough */
     case 0x3:
         do_ldst_ir(env, s, insn);
         break;
Signature · 1 line
2.18.2
Reviewed-by on v1 1/1
#1 lore raw
Quoted 9 lines · Thomas Huth

Looking at the way the code is formatted here (there is an empty line after break statements, but none where the break is missing), the fallthrough is very likely intended here. So add a fallthrough comment to make the it compilable with -Werror=implicit-fallthrough.

---
 target/unicore32/translate.c | 2 ++
 1 file changed, 2 insertions(+)

We don't need to guess based on blank lines.
This matches with the instruction set overview at

https://en.wikipedia.org/wiki/Unicore

r~