Skip to contentSkip to conversation

ide: Prevent some negative shifts in ide_set_ignore_cable()

PATCH New Dan Carpenter 1 participant 1 message Oct 30, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ide: Prevent some negative shifts in ide_set_ignore_cable()

Shifting by a negative number is undefined. These values come from the module parameter, so it's not a big deal from a practical perspective.

Fixes 9fd91d959f1a ("ide: add "ignore_cable" parameter (take 2)")
---
 drivers/ide/ide.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/ide/ide.c +1 -1
index 9a9c64fd1032..dcfb8a187c46 100644
@@ -338,7 +338,7 @@ static int ide_set_ignore_cable(const char *s, const struct kernel_param *kp)
 	if (sscanf(s, "%d:%d", &i, &j) != 2 && sscanf(s, "%d", &i) != 1)
 		return -EINVAL;
 
-	if (i >= MAX_HWIFS || j < 0 || j > 1)
+	if (i < 0 || i >= MAX_HWIFS || j < 0 || j > 1)
 		return -EINVAL;
 
 	if (j)
Signature · 1 line
2.28.0