b4 ty : wrong patch number when cherrypicking
Hello,
I cherrypicked patch 4 and 5 of
https://lore.kernel.org/linux-amlogic/[email protected]/
using:
b4 am -p linux-arm-kernel -c -t -s -l -P 4-5 -o - [email protected]
After applying to my tree, b4 ty generated the message I sent (without checking, my bad):
https://lore.kernel.org/linux-amlogic/[email protected]/
Where it had 1/2 and 2/2 instead of 04/12 and 05/12.
Is this too awful to fix? :)
Regards,
Signature · 3 lines
Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
Quoted 6 lines · Alexandre Belloni
I cherrypicked patch 4 and 5 of
https://lore.kernel.org/linux-amlogic/[email protected]/
using:b4 am -p linux-arm-kernel -c -t -s -l -P 4-5 -o - [email protected]
Quoted 8 lines
After applying to my tree, b4 ty generated the message I sent (without checking, my bad):
https://lore.kernel.org/linux-amlogic/[email protected]/
Where it had 1/2 and 2/2 instead of 04/12 and 05/12.
Is this too awful to fix? :)
It shouldn't be -- I have a similar request in the following thread:
https://lore.kernel.org/r/[email protected]
-K
A message that is not in the archive (sent off-list or not yet received): [email protected]
Quoted 10 lines · Konstantin Ryabitsev via linux.kernel.org
Quoted 9 lines · Alexandre Belloni
I cherrypicked patch 4 and 5 of
https://lore.kernel.org/linux-amlogic/[email protected]/
using:b4 am -p linux-arm-kernel -c -t -s -l -P 4-5 -o - [email protected]
After applying to my tree, b4 ty generated the message I sent (without checking, my bad):
Quoted 8 lines
Quoted 5 lines
https://lore.kernel.org/linux-amlogic/[email protected]/
Where it had 1/2 and 2/2 instead of 04/12 and 05/12.
Is this too awful to fix? :)
It shouldn't be -- I have a similar request in the following thread:
https://lore.kernel.org/r/[email protected]
There is a fix in the latest master that more properly handles these situations:
- we record actual patch prefixes when we start tracking a series, so when we send a thank you report, the actual counters will be shown
- when we send a reply for a subset of the series, we will now insert a "(subset)" into the subject to more clearly indicate to the submitter that the series only got applied partially
Note, that this will only start working for *new* series you grab with "b4 am" -- anything you've grab previously will exhibit previous behaviour.
-K
Quoted 21 lines · Konstantin Ryabitsev
Quoted 10 lines · Konstantin Ryabitsev via linux.kernel.org
Quoted 9 lines · Alexandre Belloni
I cherrypicked patch 4 and 5 of
https://lore.kernel.org/linux-amlogic/[email protected]/
using:b4 am -p linux-arm-kernel -c -t -s -l -P 4-5 -o - [email protected]
After applying to my tree, b4 ty generated the message I sent (without checking, my bad):
Quoted 8 lines
Quoted 5 lines
https://lore.kernel.org/linux-amlogic/[email protected]/
Where it had 1/2 and 2/2 instead of 04/12 and 05/12.
Is this too awful to fix? :)
It shouldn't be -- I have a similar request in the following thread:
https://lore.kernel.org/r/[email protected]
Quoted 8 lines
There is a fix in the latest master that more properly handles these situations:
- we record actual patch prefixes when we start tracking a series, so when we send a thank you report, the actual counters will be shown
- when we send a reply for a subset of the series, we will now insert a "(subset)" into the subject to more clearly indicate to the submitter that the series only got applied partially
Could we not modify subjects as that breaks gmail 'threading'. Yes, gmail is broken, but there's more than a few users...
Rob
Quoted 7 lines · Rob Herring
Quoted 7 lines
Quoted 3 lines
It shouldn't be -- I have a similar request in the following thread:
https://lore.kernel.org/r/[email protected]There is a fix in the latest master that more properly handles these situations:
Quoted 8 lines
Quoted 5 lines
- we record actual patch prefixes when we start tracking a series, so when we send a thank you report, the actual counters will be shown
- when we send a reply for a subset of the series, we will now insert a "(subset)" into the subject to more clearly indicate to the submitter that the series only got applied partiallyCould we not modify subjects as that breaks gmail 'threading'. Yes, gmail is broken, but there's more than a few users...
Well, the goal is to make it extremely obvious for the submitter that only a subset of their patch series got applied -- so I would argue that Gmail thread-breaking only helps here.
Overall, this would be an very rare situation, so I doubt anyone would care enough to get annoyed.
-K
Quoted 9 lines · Konstantin Ryabitsev
Quoted 6 lines · Rob Herring
Quoted 3 lines
- when we send a reply for a subset of the series, we will now insert a "(subset)" into the subject to more clearly indicate to the submitter that the series only got applied partially
Could we not modify subjects as that breaks gmail 'threading'. Yes, gmail is broken, but there's more than a few users...
Quoted 6 lines
Well, the goal is to make it extremely obvious for the submitter that only a subset of their patch series got applied -- so I would argue that Gmail thread-breaking only helps here.
Overall, this would be an very rare situation, so I doubt anyone would care enough to get annoyed.
This is actually a pretty common situation - the two most frequent situations are people doing cleanup work who decide to thread a bunch of patches to different subsystems with no interdependencies together and people adding new drivers that cross multiple subsystems (eg, a driver plus DTS updates adding it to some platform or a MFD with several subfunctions).
Quoted 8 lines · Mark Brown
Quoted 7 lines
Well, the goal is to make it extremely obvious for the submitter that only a subset of their patch series got applied -- so I would argue that
Gmail thread-breaking only helps here.Overall, this would be an very rare situation, so I doubt anyone would care enough to get annoyed.
Quoted 6 lines
This is actually a pretty common situation - the two most frequent situations are people doing cleanup work who decide to thread a bunch of patches to different subsystems with no interdependencies together and people adding new drivers that cross multiple subsystems (eg, a driver plus DTS updates adding it to some platform or a MFD with several subfunctions).
Okay, good to know. I'm still sticking with "(subset)" in the subject, as this hopefully avoids more problems than it causes.
-K
Quoted 15 lines · Konstantin Ryabitsev
Quoted 13 lines · Rob Herring
Quoted 12 lines
Quoted 3 lines
It shouldn't be -- I have a similar request in the following thread:
https://lore.kernel.org/r/[email protected]There is a fix in the latest master that more properly handles these situations:
- we record actual patch prefixes when we start tracking a series, so when we send a thank you report, the actual counters will be shown
- when we send a reply for a subset of the series, we will now insert a "(subset)" into the subject to more clearly indicate to the submitter that the series only got applied partially
Quoted 6 lines
Quoted 2 lines
Could we not modify subjects as that breaks gmail 'threading'. Yes, gmail is broken, but there's more than a few users...
Well, the goal is to make it extremely obvious for the submitter that only a subset of their patch series got applied -- so I would argue that Gmail thread-breaking only helps here.
If you manually label things in gmail (or just look at 'Sent'), replies don't get the label (and in turn aren't in the corresponding IMAP folder). But they will still show up the gmail thread unless the subject is changed. So the reply could just be missed completely rather than be unclear to people that don't read the body.
Quoted 2 lines
Overall, this would be an very rare situation, so I doubt anyone would care enough to get annoyed.
I'm annoyed, hence why I raised it. But if no one else cares, then fine. I'm using mutt now in most situations I care about. I was more concerned with less active submitters only using gmail.
Rob