pwm: tiehrpwm: handle deferred probe with dev_err_probe()
PATCH 1/1 pwm: tiehrpwm: handle deferred probe with dev_err_probe()
The devm_clk_get() may return -EPROBE_DEFER which is not handled properly by TI EHRPWM driver and causes unnecessary boot log messages.
Hence, add proper deferred probe handling with new dev_err_probe() API.
--- drivers/pwm/pwm-tiehrpwm.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-)
drivers/pwm/pwm-tiehrpwm.c +4 -8
@@ -437,10 +437,8 @@ static int ehrpwm_pwm_probe(struct platform_device *pdev) } } -if (IS_ERR (clk)) { -dev_err (&pdev->dev,"failed to get clock\n" ); -return PTR_ERR (clk); - } +if (IS_ERR (clk)) +return dev_err_probe (&pdev->dev,PTR_ERR (clk),"Failed to get fck\n" ); pc->clk_rate =clk_get_rate (clk);if (!pc->clk_rate) {
@@ -462,10 +460,8 @@ static int ehrpwm_pwm_probe(struct platform_device *pdev)/* Acquire tbclk for Time Base EHRPWM submodule */ pc->tbclk =devm_clk_get (&pdev->dev,"tbclk" ); -if (IS_ERR (pc->tbclk)) { -dev_err (&pdev->dev,"Failed to get tbclk\n" ); -return PTR_ERR (pc->tbclk); - } +if (IS_ERR (pc->tbclk)) +return dev_err_probe (&pdev->dev,PTR_ERR (pc->tbclk),"Failed to get tbclk\n" ); ret =clk_prepare (pc->tbclk);if (ret <0 ) {
Signature · 1 line
2.17.1
Quoted 7 lines · Grygorii Strashko
The
devm_clk_get()may return -EPROBE_DEFER which is not handled properly by TI EHRPWM driver and causes unnecessary boot log messages.Hence, add proper deferred probe handling with new
dev_err_probe()API.Signed-off-by Grygorii Strashko <[email protected]>---
Quoted 34 lines
drivers/pwm/pwm-tiehrpwm.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-)drivers/pwm/pwm-tiehrpwm.c +4
-8@@ -437,10 +437,8 @@ static int ehrpwm_pwm_probe(struct platform_device *pdev) } } -if (IS_ERR (clk)) { -dev_err (&pdev->dev,"failed to get clock\n" ); -return PTR_ERR (clk); - } +if (IS_ERR (clk)) +return dev_err_probe (&pdev->dev,PTR_ERR (clk),"Failed to get fck\n" ); pc->clk_rate =clk_get_rate (clk);if (!pc->clk_rate) {@@ -462,10 +460,8 @@ static int ehrpwm_pwm_probe(struct platform_device *pdev)/* Acquire tbclk for Time Base EHRPWM submodule */ pc->tbclk =devm_clk_get (&pdev->dev,"tbclk" ); -if (IS_ERR (pc->tbclk)) { -dev_err (&pdev->dev,"Failed to get tbclk\n" ); -return PTR_ERR (pc->tbclk); - } +if (IS_ERR (pc->tbclk)) +return dev_err_probe (&pdev->dev,PTR_ERR (pc->tbclk),"Failed to get tbclk\n" ); ret =clk_prepare (pc->tbclk);if (ret <0 ) {
Quoted 6 lines · Grygorii Strashko
The
devm_clk_get()may return -EPROBE_DEFER which is not handled properly by TI EHRPWM driver and causes unnecessary boot log messages.Hence, add proper deferred probe handling with new
dev_err_probe()API.Signed-off-by Grygorii Strashko <[email protected]>
Thanks
Uwe
Signature · 2 lines
Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ |
Thierry Reding
AppliedQuoted 9 lines · Grygorii Strashko
The
devm_clk_get()may return -EPROBE_DEFER which is not handled properly by TI EHRPWM driver and causes unnecessary boot log messages.Hence, add proper deferred probe handling with new
dev_err_probe()API.Signed-off-by Grygorii Strashko <[email protected]>--- drivers/pwm/pwm-tiehrpwm.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-)
Applied, thanks.
Thierry