Skip to contentSkip to conversation

memstick: mspro_block: remove unneeded semicolon

PATCH In review [email protected] 3 participants 5 messages Oct 31, 2020 – Nov 5, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 memstick: mspro_block: remove unneeded semicolon

From: Tom Rix <[email protected]>

A semicolon is not needed after a switch statement.

---
 drivers/memstick/core/mspro_block.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/memstick/core/mspro_block.c +1 -1
index cd6b8d4f2335..afb892e7ffc6 100644
@@ -276,7 +276,7 @@ static const char *mspro_block_attr_name(unsigned char tag)
 		return "attr_devinfo";
 	default:
 		return NULL;
-	};
+	}
 }
 
 typedef ssize_t (*sysfs_show_t)(struct device *dev,
Signature · 1 line
2.18.1
#1 lore raw
Quoted 3 lines · On 10/31/20 7:18 PM, [email protected] wrote:

From: Tom Rix <[email protected]>

A semicolon is not needed after a switch statement.

Hi Tom,
I was checking this patch. Not sure if it will come under as fix patch. Since this is not fixing
any logical issue do we still need to add fix tag?

Thanks,
Kajol Jain

Quoted 20 lines
---
 drivers/memstick/core/mspro_block.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/memstick/core/mspro_block.c +1 -1
index cd6b8d4f2335..afb892e7ffc6 100644
@@ -276,7 +276,7 @@ static const char *mspro_block_attr_name(unsigned char tag)
 		return "attr_devinfo";
 	default:
 		return NULL;
-	};
+	}
 }
 
 typedef ssize_t (*sysfs_show_t)(struct device *dev,
author
#2 lore raw
Quoted 8 lines · kajoljain
Quoted 3 lines · On 10/31/20 7:18 PM, [email protected] wrote:

From: Tom Rix <[email protected]>

A semicolon is not needed after a switch statement.

Hi Tom,
I was checking this patch. Not sure if it will come under as fix patch. Since this is not fixing
any logical issue do we still need to add fix tag?

My rule of thumb is a fix means the kernel needs to be recompiled.

This isn't a fix.

Tom

Quoted 22 lines

Thanks,
Kajol Jain

Quoted 19 lines
---
 drivers/memstick/core/mspro_block.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/memstick/core/mspro_block.c +1 -1
index cd6b8d4f2335..afb892e7ffc6 100644
@@ -276,7 +276,7 @@ static const char *mspro_block_attr_name(unsigned char tag)
 		return "attr_devinfo";
 	default:
 		return NULL;
-	};
+	}
 }
 
 typedef ssize_t (*sysfs_show_t)(struct device *dev,
#3 lore raw
Quoted 4 lines · Tom Rix
Quoted 2 lines · kajoljain

On 10/31/20 7:18 PM, [email protected] wrote:

Quoted 8 lines
Quoted 6 lines
Quoted 3 lines

From: Tom Rix <[email protected]>

A semicolon is not needed after a switch statement.

Hi Tom,
I was checking this patch. Not sure if it will come under as fix patch. Since this is not fixing
any logical issue do we still need to add fix tag?

My rule of thumb is a fix means the kernel needs to be recompiled.

Yes make sense. Thanks for confirming.

Thanks,
Kajol Jain

Quoted 28 lines

This isn't a fix.

Tom

Quoted 22 lines

Thanks,
Kajol Jain

Quoted 19 lines
---
 drivers/memstick/core/mspro_block.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/memstick/core/mspro_block.c +1 -1
index cd6b8d4f2335..afb892e7ffc6 100644
@@ -276,7 +276,7 @@ static const char *mspro_block_attr_name(unsigned char tag)
 		return "attr_devinfo";
 	default:
 		return NULL;
-	};
+	}
 }
 
 typedef ssize_t (*sysfs_show_t)(struct device *dev,
#4 lore raw
In reply to [email protected]
Quoted 6 lines · On Sat, 31 Oct 2020 at 14:48, <[email protected]> wrote:

From: Tom Rix <[email protected]>

A semicolon is not needed after a switch statement.

Applied for next, thanks!

Kind regards
Uffe

Quoted 20 lines
---
 drivers/memstick/core/mspro_block.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/memstick/core/mspro_block.c +1 -2
index cd6b8d4f2335..afb892e7ffc6 100644
@@ -276,7 +276,7 @@ static const char *mspro_block_attr_name(unsigned char tag)
                return "attr_devinfo";
        default:
                return NULL;
-       };
+       }
 }
 
 typedef ssize_t (*sysfs_show_t)(struct device *dev,
--

2.18.1