arm64: dts: imx8mn: Enable Asynchronous Sample Rate Converter
Subsystems (2)
PATCH 1/5 arm64: dts: imx8mn: Enable Asynchronous Sample Rate Converter
The driver exists for the Enhanced Asynchronous Sample Rate Converter (EASRC) Controller, but there isn't a device tree entry for it.
On the vendor kernel, they put this on a spba-bus for SDMA support.
Add the the node for the spba-bus with the easrc node inside.
arch/arm64/boot/dts/freescale/imx8mn.dtsi +28 -0
@@ -246,6 +246,34 @@ aips1: bus@30000000 { #size-cells = <1>; ranges; + spba-bus@30000000 { + compatible = "fsl,spba-bus", "simple-bus"; + #address-cells = <1>; + #size-cells = <1>; + reg = <0x30000000 0x100000>; + ranges; + + easrc: easrc@300C0000 { + compatible = "fsl,imx8mn-easrc"; + reg = <0x300C0000 0x10000>; + interrupts = <GIC_SPI 122 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&clk IMX8MN_CLK_ASRC_ROOT>; + clock-names = "mem"; + dmas = <&sdma2 16 23 0> , <&sdma2 17 23 0>, + <&sdma2 18 23 0> , <&sdma2 19 23 0>, + <&sdma2 20 23 0> , <&sdma2 21 23 0>, + <&sdma2 22 23 0> , <&sdma2 23 23 0>; + dma-names = "ctx0_rx", "ctx0_tx", + "ctx1_rx", "ctx1_tx", + "ctx2_rx", "ctx2_tx", + "ctx3_rx", "ctx3_tx"; + fsl,easrc-ram-script-name = "imx/easrc/easrc-imx8mn.bin"; + fsl,asrc-rate = <8000>; + fsl,asrc-width = <16>; + status = "disabled"; + }; + }; + gpio1: gpio@30200000 { compatible = "fsl,imx8mn-gpio", "fsl,imx35-gpio"; reg = <0x30200000 0x10000>;
Signature · 1 line
2.25.1
PATCH 2/5 arm64: defconfig: Enable ASRC and EASRC
The i.MX8M Nano supports the EASRC driver, and it requires ASRC. Enable both of them as modules.
arch/arm64/configs/defconfig +2 -0
@@ -674,7 +674,9 @@ CONFIG_SND_HDA_CODEC_HDMI=m CONFIG_SND_SOC=y CONFIG_SND_BCM2835_SOC_I2S=m CONFIG_SND_SOC_FSL_SAI=m +CONFIG_SND_SOC_FSL_ASRC=m CONFIG_SND_SOC_FSL_MICFIL=m +CONFIG_SND_SOC_FSL_EASRC=m CONFIG_SND_IMX_SOC=m CONFIG_SND_SOC_IMX_SPDIF=m CONFIG_SND_SOC_IMX_AUDMIX=m
Signature · 1 line
2.25.1
Shawn Guo
AppliedRe: [PATCH 2/5] arm64: defconfig: Enable ASRC and EASRC
Quoted 4 lines · Adam Ford
The i.MX8M Nano supports the EASRC driver, and it requires ASRC. Enable both of them as modules.
Signed-off-by Adam Ford <[email protected]>
Applied, thanks.
PATCH 3/5 arm64: dts: imx8mn: Add SAI nodes
In reply to Adam FordThe i.MX8M Nano has several SAI nodes available to it. Enable them.
arch/arm64/boot/dts/freescale/imx8mn.dtsi +77 -0
@@ -253,6 +253,83 @@ spba-bus@30000000 { reg = <0x30000000 0x100000>; ranges; + sai2: sai@30020000 { + compatible = "fsl,imx8mq-sai", + "fsl,imx6sx-sai"; + reg = <0x30020000 0x10000>; + interrupts = <GIC_SPI 96 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&clk IMX8MN_CLK_SAI2_IPG>, + <&clk IMX8MN_CLK_DUMMY>, + <&clk IMX8MN_CLK_SAI2_ROOT>, + <&clk IMX8MN_CLK_DUMMY>, <&clk IMX8MN_CLK_DUMMY>; + clock-names = "bus", "mclk0", "mclk1", "mclk2", "mclk3"; + dmas = <&sdma2 2 2 0>, <&sdma2 3 2 0>; + dma-names = "rx", "tx"; + status = "disabled"; + }; + + sai3: sai@30030000 { + compatible = "fsl,imx8mq-sai", + "fsl,imx6sx-sai"; + reg = <0x30030000 0x10000>; + interrupts = <GIC_SPI 50 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&clk IMX8MN_CLK_SAI3_IPG>, + <&clk IMX8MN_CLK_DUMMY>, + <&clk IMX8MN_CLK_SAI3_ROOT>, + <&clk IMX8MN_CLK_DUMMY>, <&clk IMX8MN_CLK_DUMMY>; + clock-names = "bus", "mclk0", "mclk1", "mclk2", "mclk3"; + dmas = <&sdma2 4 2 0>, <&sdma2 5 2 0>; + dma-names = "rx", "tx"; + status = "disabled"; + }; + + sai5: sai@30050000 { + compatible = "fsl,imx8mq-sai", + "fsl,imx6sx-sai"; + reg = <0x30050000 0x10000>; + interrupts = <GIC_SPI 90 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&clk IMX8MN_CLK_SAI5_IPG>, + <&clk IMX8MN_CLK_DUMMY>, + <&clk IMX8MN_CLK_SAI5_ROOT>, + <&clk IMX8MN_CLK_DUMMY>, <&clk IMX8MN_CLK_DUMMY>; + clock-names = "bus", "mclk0", "mclk1", "mclk2", "mclk3"; + dmas = <&sdma2 8 2 0>, <&sdma2 9 2 0>; + dma-names = "rx", "tx"; + fsl,shared-interrupt; + fsl,dataline = <0 0xf 0xf>; + status = "disabled"; + }; + + sai6: sai@30060000 { + compatible = "fsl,imx8mq-sai", + "fsl,imx6sx-sai"; + reg = <0x30060000 0x10000>; + interrupts = <GIC_SPI 90 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&clk IMX8MN_CLK_SAI6_IPG>, + <&clk IMX8MN_CLK_DUMMY>, + <&clk IMX8MN_CLK_SAI6_ROOT>, + <&clk IMX8MN_CLK_DUMMY>, <&clk IMX8MN_CLK_DUMMY>; + clock-names = "bus", "mclk0", "mclk1", "mclk2", "mclk3"; + dmas = <&sdma2 10 2 0>, <&sdma2 11 2 0>; + dma-names = "rx", "tx"; + status = "disabled"; + }; + + sai7: sai@300b0000 { + compatible = "fsl,imx8mq-sai", + "fsl,imx6sx-sai"; + reg = <0x300b0000 0x10000>; + interrupts = <GIC_SPI 111 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&clk IMX8MN_CLK_SAI7_IPG>, + <&clk IMX8MN_CLK_DUMMY>, + <&clk IMX8MN_CLK_SAI7_ROOT>, + <&clk IMX8MN_CLK_DUMMY>, <&clk IMX8MN_CLK_DUMMY>; + clock-names = "bus", "mclk0", "mclk1", "mclk2", "mclk3"; + dmas = <&sdma2 12 2 0>, <&sdma2 13 2 0>; + dma-names = "rx", "tx"; + status = "disabled"; + }; + easrc: easrc@300C0000 { compatible = "fsl,imx8mn-easrc"; reg = <0x300C0000 0x10000>;
Signature · 1 line
2.25.1
PATCH 4/5 arm64: dts: imx8mn: Add support for micfil
In reply to Adam FordThe i.MX8M Nano has supports the MICFIL digital interface. It's a 16-bit audio signal from a PDM microphone bitstream. The driver is already in the kernel, but the node is missing.
Add the micfil node.
arch/arm64/boot/dts/freescale/imx8mn.dtsi +19 -0
@@ -315,6 +315,25 @@ sai6: sai@30060000 { status = "disabled"; }; + micfil: micfil@30080000 { + compatible = "fsl,imx8mm-micfil"; + reg = <0x30080000 0x10000>; + interrupts = <GIC_SPI 109 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 110 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 44 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 45 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&clk IMX8MN_CLK_PDM_IPG>, + <&clk IMX8MN_CLK_PDM_ROOT>, + <&clk IMX8MN_AUDIO_PLL1_OUT>, + <&clk IMX8MN_AUDIO_PLL2_OUT>, + <&clk IMX8MN_CLK_EXT3>; + clock-names = "ipg_clk", "ipg_clk_app", + "pll8k", "pll11k", "clkext3"; + dmas = <&sdma2 24 25 0x80000000>; + dma-names = "rx"; + status = "disabled"; + }; + sai7: sai@300b0000 { compatible = "fsl,imx8mq-sai", "fsl,imx6sx-sai";
Signature · 1 line
2.25.1
PATCH 5/5 arm64: dts: imx8mn: Add node for SPDIF
In reply to Adam FordThe i.MX8M Nano can support SPDIF which is compatible to the IP used on the i.MX35.
Add the node.
arch/arm64/boot/dts/freescale/imx8mn.dtsi +24 -0
@@ -334,6 +334,30 @@ micfil: micfil@30080000 { status = "disabled"; }; + spdif1: spdif@30090000 { + compatible = "fsl,imx35-spdif"; + reg = <0x30090000 0x10000>; + interrupts = <GIC_SPI 6 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&clk IMX8MN_CLK_AUDIO_AHB>, /* core */ + <&clk IMX8MN_CLK_24M>, /* rxtx0 */ + <&clk IMX8MN_CLK_SPDIF1>, /* rxtx1 */ + <&clk IMX8MN_CLK_DUMMY>, /* rxtx2 */ + <&clk IMX8MN_CLK_DUMMY>, /* rxtx3 */ + <&clk IMX8MN_CLK_DUMMY>, /* rxtx4 */ + <&clk IMX8MN_CLK_AUDIO_AHB>, /* rxtx5 */ + <&clk IMX8MN_CLK_DUMMY>, /* rxtx6 */ + <&clk IMX8MN_CLK_DUMMY>, /* rxtx7 */ + <&clk IMX8MN_CLK_DUMMY>; /* spba */ + clock-names = "core", "rxtx0", + "rxtx1", "rxtx2", + "rxtx3", "rxtx4", + "rxtx5", "rxtx6", + "rxtx7", "spba"; + dmas = <&sdma2 28 18 0>, <&sdma2 29 18 0>; + dma-names = "rx", "tx"; + status = "disabled"; + }; + sai7: sai@300b0000 { compatible = "fsl,imx8mq-sai", "fsl,imx6sx-sai";
Signature · 1 line
2.25.1
Quoted 14 lines · Adam Ford
The driver exists for the Enhanced Asynchronous Sample Rate Converter (EASRC) Controller, but there isn't a device tree entry for it.
On the vendor kernel, they put this on a spba-bus for SDMA support.
Add the the node for the spba-bus with the easrc node inside.
Signed-off-by Adam Ford <[email protected]>arch/arm64/boot/dts/freescale/imx8mn.dtsi +0
-0
arch/arm64/boot/dts/freescale/imx8mn.dtsi aips1: bus@30000000 { · line 249
Quoted 4 lines
arch/arm64/boot/dts/freescale/imx8mn.dtsi +1
-0@@ -246,6 +246,34 @@ aips1: bus@30000000 { #size-cells = <1>; ranges; + spba-bus@30000000 {
spba: bus@30000000
arch/arm64/boot/dts/freescale/imx8mn.dtsi aips1: bus@30000000 { · line 250
Quoted 1 line
arch/arm64/boot/dts/freescale/imx8mn.dtsi +1
-0+ compatible = "fsl,spba-bus", "simple-bus";
"fsl,spba-bus" is undocumented. Document it or drop it.
Quoted 10 lines
arch/arm64/boot/dts/freescale/imx8mn.dtsi +10
-0+ #address-cells = <1>; + #size-cells = <1>; + reg = <0x30000000 0x100000>; + ranges; + + easrc: easrc@300C0000 { + compatible = "fsl,imx8mn-easrc"; + reg = <0x300C0000 0x10000>; + interrupts = <GIC_SPI 122 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&clk IMX8MN_CLK_ASRC_ROOT>;
arch/arm64/boot/dts/freescale/imx8mn.dtsi aips1: bus@30000000 { · line 270
Quoted 10 lines
arch/arm64/boot/dts/freescale/imx8mn.dtsi +10
-0+ clock-names = "mem"; + dmas = <&sdma2 16 23 0> , <&sdma2 17 23 0>, + <&sdma2 18 23 0> , <&sdma2 19 23 0>, + <&sdma2 20 23 0> , <&sdma2 21 23 0>, + <&sdma2 22 23 0> , <&sdma2 23 23 0>; + dma-names = "ctx0_rx", "ctx0_tx", + "ctx1_rx", "ctx1_tx", + "ctx2_rx", "ctx2_tx", + "ctx3_rx", "ctx3_tx"; + fsl,easrc-ram-script-name = "imx/easrc/easrc-imx8mn.bin";
Undocumented property?
Shawn
Quoted 12 lines
arch/arm64/boot/dts/freescale/imx8mn.dtsi +6
-0+ fsl,asrc-rate = <8000>; + fsl,asrc-width = <16>; + status = "disabled"; + }; + }; + gpio1: gpio@30200000 { compatible = "fsl,imx8mn-gpio", "fsl,imx35-gpio"; reg = <0x30200000 0x10000>;Signature · 1 line
2.25.1
Quoted 19 lines · Shawn Guo
Quoted 17 lines · Adam Ford
The driver exists for the Enhanced Asynchronous Sample Rate Converter (EASRC) Controller, but there isn't a device tree entry for it.
On the vendor kernel, they put this on a spba-bus for SDMA support.
Add the the node for the spba-bus with the easrc node inside.
Signed-off-by Adam Ford <[email protected]>arch/arm64/boot/dts/freescale/imx8mn.dtsi +0
-0@@ -246,6 +246,34 @@ aips1: bus@30000000 { #size-cells = <1>; ranges;
Quoted 3 lines
arch/arm64/boot/dts/freescale/imx8mn.dtsi aips1: bus@30000000 { · line 249
Quoted 1 line
arch/arm64/boot/dts/freescale/imx8mn.dtsi +1
-0+ spba-bus@30000000 {spba: bus@30000000
Go ahead and disregard my V2. I'll submit a V3. I sent the V2 before I got this feedback.
Quoted 4 lines
arch/arm64/boot/dts/freescale/imx8mn.dtsi aips1: bus@30000000 { · line 250
Quoted 2 lines
arch/arm64/boot/dts/freescale/imx8mn.dtsi +1
-0+ compatible = "fsl,spba-bus", "simple-bus";"fsl,spba-bus" is undocumented. Document it or drop it.
I just submitted a patch to document this bus. It's used on a bunch of imx boards, so I think it's important to document it. I assigned you as the maintainer of the binding doc since you're listed as the maintainer of the SDMA driver which is what's using the compatible flag. I hope that is the correct thing to do.
Quoted 22 lines
Quoted 11 lines
arch/arm64/boot/dts/freescale/imx8mn.dtsi +10
-0+ #address-cells = <1>; + #size-cells = <1>; + reg = <0x30000000 0x100000>; + ranges; + + easrc: easrc@300C0000 { + compatible = "fsl,imx8mn-easrc"; + reg = <0x300C0000 0x10000>; + interrupts = <GIC_SPI 122 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&clk IMX8MN_CLK_ASRC_ROOT>;arch/arm64/boot/dts/freescale/imx8mn.dtsi aips1: bus@30000000 { · line 270
Quoted 10 lines
arch/arm64/boot/dts/freescale/imx8mn.dtsi +10
-0+ clock-names = "mem"; + dmas = <&sdma2 16 23 0> , <&sdma2 17 23 0>, + <&sdma2 18 23 0> , <&sdma2 19 23 0>, + <&sdma2 20 23 0> , <&sdma2 21 23 0>, + <&sdma2 22 23 0> , <&sdma2 23 23 0>; + dma-names = "ctx0_rx", "ctx0_tx", + "ctx1_rx", "ctx1_tx", + "ctx2_rx", "ctx2_tx", + "ctx3_rx", "ctx3_tx"; + fsl,easrc-ram-script-name = "imx/easrc/easrc-imx8mn.bin";
Quoted 1 line
Undocumented property?
That's my fault. I accidentally copied the device tree entry from the vendor kernel instead of using the naming from the device tree binding document.
I fixed this in my V2, but I need to send a V3 anyway.
adam
Quoted 15 lines
Shawn
Quoted 12 lines
arch/arm64/boot/dts/freescale/imx8mn.dtsi +6
-1+ fsl,asrc-rate = <8000>; + fsl,asrc-width = <16>; + status = "disabled"; + }; + }; + gpio1: gpio@30200000 { compatible = "fsl,imx8mn-gpio", "fsl,imx35-gpio"; reg = <0x30200000 0x10000>; --2.25.1