Skip to contentSkip to conversation

eventdev: check input parameter for dump op

PATCH Applied David Marchand 3 participants 3 messages Nov 1, 2020 – Nov 2, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 eventdev: check input parameter for dump op

Rather than have drivers check for this, let's ensure the passed FILE * is not NULL.

---
 lib/librte_eventdev/rte_eventdev.c | 2 ++
 1 file changed, 2 insertions(+)
lib/librte_eventdev/rte_eventdev.c +2 -0
index 994bd1eaa9..afbadc535b 100644
@@ -1153,6 +1153,8 @@ rte_event_dev_dump(uint8_t dev_id, FILE *f)
 	RTE_EVENTDEV_VALID_DEVID_OR_ERR_RET(dev_id, -EINVAL);
 	dev = &rte_eventdevs[dev_id];
 	RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->dump, -ENOTSUP);
+	if (f == NULL)
+		return -EINVAL;
 
 	(*dev->dev_ops->dump)(dev, f);
 	return 0;
Signature · 1 line
2.23.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 33 lines

-----Original Message-----
From: David Marchand <[email protected]>
Sent: Sunday, November 1, 2020 2:37 PM
To: [email protected]
Cc: McDaniel, Timothy <[email protected]>; Jerin Jacob <[email protected]>
Subject: [PATCH] eventdev: check input parameter for dump op

Rather than have drivers check for this, let's ensure the passed FILE * is not NULL.

---
 lib/librte_eventdev/rte_eventdev.c | 2 ++
 1 file changed, 2 insertions(+)
lib/librte_eventdev/rte_eventdev.c +2 -1
index 994bd1eaa9..afbadc535b 100644
@@ -1153,6 +1153,8 @@ rte_event_dev_dump(uint8_t dev_id, FILE *f)
 	RTE_EVENTDEV_VALID_DEVID_OR_ERR_RET(dev_id, -EINVAL);
 	dev = &rte_eventdevs[dev_id];
 	RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->dump, -ENOTSUP);
+	if (f == NULL)
+		return -EINVAL;
 
 	(*dev->dev_ops->dump)(dev, f);
 	return 0;
--
Quoted 1 line

2.23.0

Looks good to me.

Applied
#2 lore raw
Quoted 11 lines · Timothy
Quoted 11 lines

-----Original Message-----
From: David Marchand <[email protected]>
Sent: Sunday, November 1, 2020 2:37 PM
To: [email protected]
Cc: McDaniel, Timothy <[email protected]>; Jerin Jacob <[email protected]>
Subject: [PATCH] eventdev: check input parameter for dump op

Quoted 4 lines
Quoted 4 lines

Rather than have drivers check for this, let's ensure the passed FILE * is not NULL.

Applied to dpdk-next-eventdev/for-main. Thanks.

Quoted 24 lines
Quoted 19 lines
---
 lib/librte_eventdev/rte_eventdev.c | 2 ++
 1 file changed, 2 insertions(+)
lib/librte_eventdev/rte_eventdev.c +2 -1
index 994bd1eaa9..afbadc535b 100644
@@ -1153,6 +1153,8 @@ rte_event_dev_dump(uint8_t dev_id, FILE *f)
      RTE_EVENTDEV_VALID_DEVID_OR_ERR_RET(dev_id, -EINVAL);
      dev = &rte_eventdevs[dev_id];
      RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->dump, -ENOTSUP);
+     if (f == NULL)
+             return -EINVAL;
 
      (*dev->dev_ops->dump)(dev, f);
      return 0;
--
Quoted 1 line

2.23.0

Looks good to me.