gpu/drm: delete same check in if condition
Subsystems (2)
PATCH 1/1 gpu/drm: delete same check in if condition
In function drm_bridge_connector_get_modes_edid, drm_edid_is_valid will check weather (!edid), no need to check again in the if branch.
Signed-off-by Bernard Zhao <[email protected]>
--- drivers/gpu/drm/drm_bridge_connector.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/drm_bridge_connector.c +1 -1
@@ -241,7 +241,7 @@ static int drm_bridge_connector_get_modes_edid(struct drm_connector *connector, goto no_edid; edid = bridge->funcs->get_edid (bridge, connector); -if (!edid || !drm_edid_is_valid (edid)) { +if (!drm_edid_is_valid (edid)) {kfree (edid); goto no_edid; }
Signature · 1 line
2.29.0
Hi
Am 02.11.20 um 04:07 schrieb Bernard Zhao:
Quoted 5 lines
In function
drm_bridge_connector_get_modes_edid,drm_edid_is_validwill check weather (!edid), no need to check again in the if branch.Signed-off-by Bernard Zhao <[email protected]>
Reviewed-by Thomas Zimmermann <[email protected]>
Thanks! I'll add the patch to drm-misc-next.
Best regards
Thomas
Quoted 18 lines
--- drivers/gpu/drm/drm_bridge_connector.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/drm_bridge_connector.c +1
-1@@ -241,7 +241,7 @@ static int drm_bridge_connector_get_modes_edid(struct drm_connector *connector, goto no_edid; edid = bridge->funcs->get_edid (bridge, connector); -if (!edid || !drm_edid_is_valid (edid)) { +if (!drm_edid_is_valid (edid)) {kfree (edid); goto no_edid; }
Signature · 6 lines
Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 Nürnberg, Germany (HRB 36809, AG Nürnberg) Geschäftsführer: Felix Imendörffer