Skip to contentSkip to conversation

mx7ulp: clock: Remove unuseful information

PATCH New Fabio Estevam 2 participants 4 messages Oct 7, 2020 – Nov 2, 2020

Subsystems (3)
lore
Share & tools
lore

Fabio Estevam

author reviewer
#0 lore raw

PATCH 1/2 mx7ulp: clock: Remove unuseful information

The command 'clocks' shows the following output:

=> clocks
PLL_A7_SPLL 528 MHz
PLL_A7_APLL 529 MHz
PLL_USB 0 MHz

....

[do_mx7_showclocks] addr = 0x9FFB61F1

The last line is not useful at all, so just remove it.

---
 arch/arm/mach-imx/mx7ulp/clock.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
arch/arm/mach-imx/mx7ulp/clock.c +1 -3
index a987ff22df..1a504d0b9a 100644
@@ -333,7 +333,7 @@ void hab_caam_clock_enable(unsigned char enable)
 int do_mx7_showclocks(struct cmd_tbl *cmdtp, int flag, int argc,
 		      char *const argv[])
 {
-	u32 addr = 0;
+
 	u32 freq;
 	freq = decode_pll(PLL_A7_SPLL);
 	printf("PLL_A7_SPLL    %8d MHz\n", freq / 1000000);
@@ -356,8 +356,6 @@ int do_mx7_showclocks(struct cmd_tbl *cmdtp, int flag, int argc,
 	printf("USDHC2     %8d kHz\n", mxc_get_clock(MXC_ESDHC2_CLK) / 1000);
 	printf("I2C4       %8d kHz\n", mxc_get_clock(MXC_I2C_CLK) / 1000);
 
-	addr = (u32) clock_init;
-	printf("[%s] addr = 0x%08X\r\n", __func__, addr);
 	scg_a7_info();
 
 	return 0;
Signature · 1 line
2.17.1
author reviewer
#1 lore raw

PATCH 2/2 mx7ulp: clock: Align the PLL_USB frequency

The command 'clocks' shows the following output:

=> clocks
PLL_A7_SPLL 528 MHz
PLL_A7_APLL 529 MHz
PLL_USB 0 MHz

Add some extra spaces so that the PLL_USB information gets aligned with the previous reported frequencies.

---
 arch/arm/mach-imx/mx7ulp/clock.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/mach-imx/mx7ulp/clock.c +1 -1
index 1a504d0b9a..51aaa5001e 100644
@@ -342,7 +342,7 @@ int do_mx7_showclocks(struct cmd_tbl *cmdtp, int flag, int argc,
 	printf("PLL_A7_APLL    %8d MHz\n", freq / 1000000);
 
 	freq = decode_pll(PLL_USB);
-	printf("PLL_USB    %8d MHz\n", freq / 1000000);
+	printf("PLL_USB        %8d MHz\n", freq / 1000000);
 
 	printf("\n");
 
Signature · 1 line
2.17.1
#2 lore raw

PATCH 2/2 mx7ulp: clock: Align the PLL_USB frequency

Quoted 8 lines

The command 'clocks' shows the following output:
=> clocks
PLL_A7_SPLL 528 MHz
PLL_A7_APLL 529 MHz
PLL_USB 0 MHz
Add some extra spaces so that the PLL_USB information gets aligned with the previous reported frequencies.

Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
#3 lore raw

PATCH 1/2 mx7ulp: clock: Remove unuseful information

In reply to Fabio Estevam
Quoted 9 lines

The command 'clocks' shows the following output:
=> clocks
PLL_A7_SPLL 528 MHz
PLL_A7_APLL 529 MHz
PLL_USB 0 MHz
....
[do_mx7_showclocks] addr = 0x9FFB61F1
The last line is not useful at all, so just remove it.

Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================