Skip to contentSkip to conversation

pc: comment stule fixup

PATCH Superseded Michael S. Tsirkin 3 participants 3 messages Nov 2, 2020

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 pc: comment stule fixup

Fix up checkpatch comment style warnings.

---
 hw/i386/pc.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
hw/i386/pc.c +3 -3
index 416fb0e0f6..5872ae6095 100644
@@ -1150,9 +1150,9 @@ void pc_basic_device_init(struct PCMachineState *pcms,
             exit(1);
         }
         /* For pc-piix-*, hpet's intcap is always IRQ2. For pc-q35-1.7
-            * and earlier, use IRQ2 for compat. Otherwise, use IRQ16~23,
-            * IRQ8 and IRQ2.
-            */
+         * and earlier, use IRQ2 for compat. Otherwise, use IRQ16~23,
+         * IRQ8 and IRQ2.
+         */
         uint8_t compat = object_property_get_uint(OBJECT(hpet),
                 HPET_INTCAP, NULL);
         if (!compat) {
Signature · 1 line
MST
#1 lore raw
Quoted 1 line · Michael S. Tsirkin

Fix up checkpatch comment style warnings.

Typo stule -> style in subject ;)

Quoted 11 lines
---
 hw/i386/pc.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
hw/i386/pc.c +0 -0
index 416fb0e0f6..5872ae6095 100644

hw/i386/pc.c void pc_basic_device_init(struct PCMachineState *pcms, · line 1152

Quoted 3 lines
hw/i386/pc.c +0 -0
@@ -1150,9 +1150,9 @@ void pc_basic_device_init(struct PCMachineState *pcms,
             exit(1);
         }
         /* For pc-piix-*, hpet's intcap is always IRQ2. For pc-q35-1.7

Since it needs a respin, maybe convert the 1st line too?

Quoted 10 lines
hw/i386/pc.c +3 -3
-            * and earlier, use IRQ2 for compat. Otherwise, use IRQ16~23,
-            * IRQ8 and IRQ2.
-            */
+         * and earlier, use IRQ2 for compat. Otherwise, use IRQ16~23,
+         * IRQ8 and IRQ2.
+         */
         uint8_t compat = object_property_get_uint(OBJECT(hpet),
                 HPET_INTCAP, NULL);
         if (!compat) {
#2 lore raw
In reply to Michael S. Tsirkin
Quoted 14 lines · Michael S. Tsirkin

Fix up checkpatch comment style warnings.

---
 hw/i386/pc.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
hw/i386/pc.c +0 -0
index 416fb0e0f6..5872ae6095 100644
@@ -1150,9 +1150,9 @@ void pc_basic_device_init(struct PCMachineState *pcms,
             exit(1);
         }

hw/i386/pc.c void pc_basic_device_init(struct PCMachineState *pcms, · line 1158

Quoted 10 lines
hw/i386/pc.c +3 -3
         /* For pc-piix-*, hpet's intcap is always IRQ2. For pc-q35-1.7
-            * and earlier, use IRQ2 for compat. Otherwise, use IRQ16~23,
-            * IRQ8 and IRQ2.
-            */
+         * and earlier, use IRQ2 for compat. Otherwise, use IRQ16~23,
+         * IRQ8 and IRQ2.
+         */
         uint8_t compat = object_property_get_uint(OBJECT(hpet),
                 HPET_INTCAP, NULL);
         if (!compat) {

Since you're touching this already...

CODING_STYLE.rst:

Multiline comment blocks should have a row of stars on the left, and the initial /``*`` and terminating ``*``/ both on their own lines:

.. code-block:: c

/*
* like
* this
*/