Skip to contentSkip to conversation

sdbus-c++-tools: fix reproducible builds

PATCH In review Adrian Freihofer 2 participants 3 messages Nov 2, 2020 – Nov 14, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 sdbus-c++-tools: fix reproducible builds

If the reproducible build class is active the following error occurs:

ERROR: sdbus-c++-tools-native-0.8.1-r0 do_unpack: Error executing a python function in exec_python_func() autogenerated:
...snip
Exception: subprocess.CalledProcessError: Command '['git', 'log', '-1', '--pretty=%ct']' returned non-zero exit status 128.

Remove the subpath to get git executed in the right derectory.

---
 meta-oe/recipes-core/sdbus-c++/sdbus-c++-tools_0.8.3.bb | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
meta-oe/recipes-core/sdbus-c++/sdbus-c++-tools_0.8.3.bb +2 -2
index 3b87c2265..ec720dc0c 100644
@@ -9,8 +9,8 @@ inherit cmake
 DEPENDS += "expat"
 
 SRCREV = "6e8e5aadb674cccea5bdd55141db5dad887fbacd"
-SRC_URI = "git://github.com/Kistler-Group/sdbus-cpp.git;protocol=https;branch=master;subpath=tools"
+SRC_URI = "git://github.com/Kistler-Group/sdbus-cpp.git;protocol=https;branch=master"
 
-S = "${WORKDIR}/tools"
+S = "${WORKDIR}/git/tools"
 
 BBCLASSEXTEND = "native nativesdk"
Signature · 1 line
2.26.2
#1 lore raw
Quoted 9 lines · Adrian Freihofer

If the reproducible build class is active the following error occurs:

ERROR: sdbus-c++-tools-native-0.8.1-r0 do_unpack: Error executing a python function in exec_python_func() autogenerated:
...snip
Exception: subprocess.CalledProcessError: Command '['git', 'log', '-1', '--pretty=%ct']' returned non-zero exit status 128.

Remove the subpath to get git executed in the right derectory.

this looks like a problem in core metadata rather, I am fine to accept this as a workaround but I think you should bring this discussion to oe-core

Quoted 26 lines
---
 meta-oe/recipes-core/sdbus-c++/sdbus-c++-tools_0.8.3.bb | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
meta-oe/recipes-core/sdbus-c++/sdbus-c++-tools_0.8.3.bb +2 -3
index 3b87c2265..ec720dc0c 100644
@@ -9,8 +9,8 @@ inherit cmake
 DEPENDS += "expat"
 
 SRCREV = "6e8e5aadb674cccea5bdd55141db5dad887fbacd"
-SRC_URI = "git://github.com/Kistler-Group/sdbus-cpp.git;protocol=https;branch=master;subpath=tools"
+SRC_URI = "git://github.com/Kistler-Group/sdbus-cpp.git;protocol=https;branch=master"
 
-S = "${WORKDIR}/tools"
+S = "${WORKDIR}/git/tools"
 
 BBCLASSEXTEND = "native nativesdk"
--

2.26.2

#2 lore raw
Quoted 8 lines · Khem Raj
Quoted 6 lines · Adrian Freihofer

If the reproducible build class is active the following error occurs:

ERROR: sdbus-c++-tools-native-0.8.1-r0 do_unpack: Error executing a python function in exec_python_func() autogenerated:
...snip
Exception: subprocess.CalledProcessError: Command '['git', 'log', '-1', '--pretty=%ct']' returned non-zero exit status 128.

Quoted 6 lines
Quoted 2 lines

Remove the subpath to get git executed in the right derectory.

this looks like a problem in core metadata rather, I am fine to accept this as a workaround but I think you should bring this discussion to oe-core

Khem, you're right. Please ignore the patch. After I understood the problem in detail,I went through all patches for reproducible builds on the poky master branch. I'm sure the problem is already solved properly with Yocto 3.2.

I will ask for cherry-picking the related patches to dunfell on the core mailing list. Thank you for the hint.

Quoted 27 lines
Quoted 27 lines
---
 meta-oe/recipes-core/sdbus-c++/sdbus-c++-tools_0.8.3.bb | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
meta-oe/recipes-core/sdbus-c++/sdbus-c++-tools_0.8.3.bb +2 -3
index 3b87c2265..ec720dc0c 100644
@@ -9,8 +9,8 @@ inherit cmake
 DEPENDS += "expat"
 
 SRCREV = "6e8e5aadb674cccea5bdd55141db5dad887fbacd"
-SRC_URI = "git://github.com/Kistler-Group/sdbus-cpp.git;protocol=https;branch=master;subpath=tools"
+SRC_URI = "git://github.com/Kistler-Group/sdbus-cpp.git;protocol=https;branch=master"
 
-S = "${WORKDIR}/tools"
+S = "${WORKDIR}/git/tools"
 
 BBCLASSEXTEND = "native nativesdk"
--

2.26.2