drm/amdgpu: update module paramter doc of amdgpu_dpm
Subsystems (3)
PATCH 1/1 drm/amdgpu: update module paramter doc of amdgpu_dpm
the vega20 isn't supported swsmu.
--- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c +1 -1
@@ -279,7 +279,7 @@ module_param_string(lockup_timeout, amdgpu_lockup_timeout, sizeof(amdgpu_lockup_/** * DOC: dpm (int) * Override for dynamic power management setting -* (0 = disable, 1 = enable, 2 = enable sw smu driver for vega20) +* (0 = disable, 1 = enable) * The default is -1 (auto). */ MODULE_PARM_DESC (dpm,"DPM support (1 = enable, 0 = disable, -1 = auto)" );
Signature · 6 lines
2.17.1 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
PATCH 1/1 drm/amd/swsmu: correct wrong feature bit mapping
1.
when smc feature bit isn't mapped,
the feature state isn't showed on sysfs node of pp_features. 2.
add pp_features table title
--- drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c | 27 ++++++++++++++++---------- 1 file changed, 17 insertions(+), 10 deletions(-)
drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c +17 -10
@@ -431,10 +431,9 @@ size_t smu_cmn_get_pp_feature_mask(struct smu_context *smu, char *buf) {uint32_t feature_mask[2 ] = {0 }; -int32_t feature_index =0 ; +int feature_index =0 ;uint32_t count =0 ; -uint32_t sort_feature[SMU_FEATURE_COUNT ]; -uint64_t hw_feature_count =0 ; +int8_t sort_feature[SMU_FEATURE_COUNT ];size_t size =0 ;int ret =0 , i;
@@ -447,23 +446,31 @@ size_t smu_cmn_get_pp_feature_mask(struct smu_context *smu, size =sprintf (buf + size,"features high: 0x%08x low: 0x%08x\n" , feature_mask[1 ], feature_mask[0 ]); +memset (sort_feature,-1 ,sizeof (sort_feature)); +for (i =0 ; i <SMU_FEATURE_COUNT ; i++) { feature_index =smu_cmn_to_asic_specific_index (smu,CMN2ASIC_MAPPING_FEATURE , i);if (feature_index <0 )continue ; + sort_feature[feature_index] = i; - hw_feature_count++; } -for (i =0 ; i < hw_feature_count; i++) { + size +=sprintf (buf + size,"%-2s. %-20s %-3s : %-s\n" , +"No" ,"Feature" ,"Bit" ,"State" ); + +for (i =0 ; i <SMU_FEATURE_COUNT ; i++) { +if (sort_feature[i] <0 ) +continue ; + size +=sprintf (buf + size,"%02d. %-20s (%2d) : %s\n" , - count++, -smu_get_feature_name (smu, sort_feature[i]), - i, - !!smu_cmn_feature_is_enabled (smu, sort_feature[i]) ? -"enabled" :"disabled" ); + count++, +smu_get_feature_name (smu, sort_feature[i]), + i, + !!smu_cmn_feature_is_enabled (smu, sort_feature[i]) ? +"enabled" :"disabled" ); }return size;
Signature · 6 lines
2.17.1 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Re: [PATCH] drm/amd/swsmu: correct wrong feature bit mapping
sorry, please ignore this patch, the patch has been merged.
Best Regards,
Kevin
________________________________
From: Wang, Kevin(Yang) <[email protected]>
Sent: Tuesday, November 3, 2020 1:54 PM
To: [email protected] <[email protected]>
Cc: Feng, Kenneth <[email protected]>; Wang, Kevin(Yang) <[email protected]>
Subject: [PATCH] drm/amd/swsmu: correct wrong feature bit mapping
1.
when smc feature bit isn't mapped,
the feature state isn't showed on sysfs node of pp_features. 2.
add pp_features table title
--- drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c | 27 ++++++++++++++++---------- 1 file changed, 17 insertions(+), 10 deletions(-)
drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c +17 -10
@@ -431,10 +431,9 @@ size_t smu_cmn_get_pp_feature_mask(struct smu_context *smu, char *buf) {uint32_t feature_mask[2 ] = {0 }; -int32_t feature_index =0 ; +int feature_index =0 ;uint32_t count =0 ; -uint32_t sort_feature[SMU_FEATURE_COUNT ]; -uint64_t hw_feature_count =0 ; +int8_t sort_feature[SMU_FEATURE_COUNT ];size_t size =0 ;int ret =0 , i;
@@ -447,23 +446,31 @@ size_t smu_cmn_get_pp_feature_mask(struct smu_context *smu, size =sprintf (buf + size,"features high: 0x%08x low: 0x%08x\n" , feature_mask[1 ], feature_mask[0 ]); +memset (sort_feature,-1 ,sizeof (sort_feature)); +for (i =0 ; i <SMU_FEATURE_COUNT ; i++) { feature_index =smu_cmn_to_asic_specific_index (smu,CMN2ASIC_MAPPING_FEATURE , i);if (feature_index <0 )continue ; + sort_feature[feature_index] = i; - hw_feature_count++; } -for (i =0 ; i < hw_feature_count; i++) { + size +=sprintf (buf + size,"%-2s. %-20s %-3s : %-s\n" , +"No" ,"Feature" ,"Bit" ,"State" ); + +for (i =0 ; i <SMU_FEATURE_COUNT ; i++) { +if (sort_feature[i] <0 ) +continue ; + size +=sprintf (buf + size,"%02d. %-20s (%2d) : %s\n" , - count++, -smu_get_feature_name (smu, sort_feature[i]), - i, - !!smu_cmn_feature_is_enabled (smu, sort_feature[i]) ? -"enabled" :"disabled" ); + count++, +smu_get_feature_name (smu, sort_feature[i]), + i, + !!smu_cmn_feature_is_enabled (smu, sort_feature[i]) ? +"enabled" :"disabled" ); }return size;
--
2.17.1
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
________________________________
From: amd-gfx <[email protected]> on behalf of Kevin Wang <[email protected]>
Sent: Tuesday, November 3, 2020 12:54 AM
To: [email protected] <[email protected]>
Cc: Wang, Kevin(Yang) <[email protected]>; Feng, Kenneth <[email protected]>
Subject: [PATCH] drm/amdgpu: update module paramter doc of amdgpu_dpm
the vega20 isn't supported swsmu.
--- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c +1 -1
@@ -279,7 +279,7 @@ module_param_string(lockup_timeout, amdgpu_lockup_timeout, sizeof(amdgpu_lockup_/** * DOC: dpm (int) * Override for dynamic power management setting -* (0 = disable, 1 = enable, 2 = enable sw smu driver for vega20) +* (0 = disable, 1 = enable) * The default is -1 (auto). */ MODULE_PARM_DESC (dpm,"DPM support (1 = enable, 0 = disable, -1 = auto)" );
--
2.17.1
_______________________________________________
amd-gfx mailing list
[email protected]
https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&data=04%7C01%7Calexander.deucher%40amd.com%7C4ae8b1a81d21425639d008d87fbcf7a4%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637399796905142189%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=fuXa0uSIEISgNh%2FUxxU3HlEDJDb9E41UGW7EouDVm5k%3D&reserved=0
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx