drm/amd/amdgpu: specify the power strategy for vcn use
Subsystems (2)
PATCH 1/1 drm/amd/amdgpu: specify the power strategy for vcn use
The power/performance control strategy is specific for vcn use case. Then this can optimize the power/performance when the workload is on vcn.
--- drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c +6 -1
@@ -361,6 +361,8 @@ static void amdgpu_vcn_idle_work_handler(struct work_struct *work)amdgpu_gfx_off_ctrl (adev, true);amdgpu_device_ip_set_powergating_state (adev,AMD_IP_BLOCK_TYPE_VCN ,AMD_PG_STATE_GATE ); +amdgpu_dpm_switch_power_profile (adev,PP_SMC_POWER_PROFILE_VIDEO , + false); }else {schedule_delayed_work (&adev->vcn.idle_work,VCN_IDLE_TIMEOUT ); }
@@ -372,8 +374,11 @@ void amdgpu_vcn_ring_begin_use(struct amdgpu_ring *ring)atomic_inc (&adev->vcn.total_submission_cnt); -if (!cancel_delayed_work_sync (&adev->vcn.idle_work)) +if (!cancel_delayed_work_sync (&adev->vcn.idle_work)) {amdgpu_gfx_off_ctrl (adev, false); +amdgpu_dpm_switch_power_profile (adev,PP_SMC_POWER_PROFILE_VIDEO , + true); + }mutex_lock (&adev->vcn.vcn_pg_lock); amdgpu_device_ip_set_powergating_state(adev, AMD_IP_BLOCK_TYPE_VCN,
Signature · 6 lines
2.17.1 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
comment inline.
________________________________
From: amd-gfx <[email protected]> on behalf of Kenneth Feng <[email protected]>
Sent: Tuesday, November 3, 2020 4:07 PM
To: [email protected] <[email protected]>
Cc: Feng, Kenneth <[email protected]>
Subject: [PATCH] drm/amd/amdgpu: specify the power strategy for vcn use
The power/performance control strategy is specific for vcn use case. Then this can optimize the power/performance when the workload is on vcn.
--- drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c +2 -0
@@ -361,6 +361,8 @@ static void amdgpu_vcn_idle_work_handler(struct work_struct *work)amdgpu_gfx_off_ctrl (adev, true);amdgpu_device_ip_set_powergating_state (adev,AMD_IP_BLOCK_TYPE_VCN ,AMD_PG_STATE_GATE ); +amdgpu_dpm_switch_power_profile (adev,PP_SMC_POWER_PROFILE_VIDEO , + false);
[kevin]:
we'd better to check the return value here, if we really don't care the result, we can print a warning log for debug later.
the patch is:
} else {
schedule_delayed_work(&adev->vcn.idle_work, VCN_IDLE_TIMEOUT);
}@@ -372,8 +374,11 @@ void amdgpu_vcn_ring_begin_use(struct amdgpu_ring *ring)
atomic_inc(&adev->vcn.total_submission_cnt);
- if (!cancel_delayed_work_sync(&adev->vcn.idle_work))
+ if (!cancel_delayed_work_sync(&adev->vcn.idle_work)) {
amdgpu_gfx_off_ctrl(adev, false);+ amdgpu_dpm_switch_power_profile(adev, PP_SMC_POWER_PROFILE_VIDEO,
+ true);
+ }
mutex_lock(&adev->vcn.vcn_pg_lock);
amdgpu_device_ip_set_powergating_state(adev, AMD_IP_BLOCK_TYPE_VCN,--
2.17.1
_______________________________________________
amd-gfx mailing list
[email protected]
https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&data=04%7C01%7CKevin1.Wang%40amd.com%7C72db727fcede4117919008d87fcf9c39%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637399876957953297%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=FRDabYo1xJiS3agbO5a478%2FPO0cDrfcYMfLDS%2BudrX8%3D&reserved=0
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx