vfio/pci: Refine Intel IGD OpRegion support

PATCH In review Fred Gao 4 participants 8 messages Sep 29, 2020 – Nov 3, 2020

Subsystems (2)

KVM VFIO driver

lore

Share & tools

lore

Fred Gao

author

2020-09-29 08:15 UTC #0 lore raw

PATCH v2 1/1 vfio/pci: Refine Intel IGD OpRegion support

Bypass the IGD initialization for Intel's dgfx devices with own expansion ROM and the host/LPC bridge config space are no longer accessed.

v2: simply test if discrete or integrated gfx device
with root bus. (Alex Williamson)

Cc Zhenyu Wang <[email protected]>

Cc Xiong Zhang <[email protected]>

Cc Hang Yuan <[email protected]>

Cc Stuart Summers <[email protected]>

Signed-off-by Lucas De Marchi <[email protected]>

Signed-off-by Fred Gao <[email protected]>

---
 drivers/vfio/pci/vfio_pci.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

drivers/vfio/pci/vfio_pci.c +3 -2

index f634c81998bb..9258ccfadb79 100644
@@ -336,10 +336,11 @@ static int vfio_pci_enable(struct vfio_pci_device *vdev)
 	if (!vfio_vga_disabled() && vfio_pci_is_vga(pdev))
 		vdev->has_vga = true;
 
-
+	/* Intel's dgfx should not appear on root bus */
 	if (vfio_pci_is_vga(pdev) &&
 	    pdev->vendor == PCI_VENDOR_ID_INTEL &&
-	    IS_ENABLED(CONFIG_VFIO_PCI_IGD)) {
+	    IS_ENABLED(CONFIG_VFIO_PCI_IGD) &&
+	    pci_is_root_bus(pdev->bus)) {
 		ret = vfio_pci_igd_init(vdev);
 		if (ret) {
 			pci_warn(pdev, "Failed to setup Intel IGD regions\n");

Signature · 1 line

2.24.1.1.gb6d4d82bd5

Zhenyu Wang

Reviewed-by on v2 1/1

2020-09-29 09:09 UTC #1 lore raw

Quoted 6 lines · Fred Gao

Bypass the IGD initialization for Intel's dgfx devices with own expansion ROM and the host/LPC bridge config space are no longer accessed.
v2: simply test if discrete or integrated gfx device
with root bus. (Alex Williamson)

Patch title is somehow misleading that better change to what this one does that skip VFIO IGD setup for Intel discrete graphics card.

With that,

Reviewed-by Zhenyu Wang <[email protected]>

Quoted 31 lines

Cc Zhenyu Wang <[email protected]>

Cc Xiong Zhang <[email protected]>

Cc Hang Yuan <[email protected]>

Cc Stuart Summers <[email protected]>

Signed-off-by Lucas De Marchi <[email protected]>

Signed-off-by Fred Gao <[email protected]>

---
 drivers/vfio/pci/vfio_pci.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

drivers/vfio/pci/vfio_pci.c +3 -2

index f634c81998bb..9258ccfadb79 100644
@@ -336,10 +336,11 @@ static int vfio_pci_enable(struct vfio_pci_device *vdev)
 	if (!vfio_vga_disabled() && vfio_pci_is_vga(pdev))
 		vdev->has_vga = true;
 
-
+	/* Intel's dgfx should not appear on root bus */
 	if (vfio_pci_is_vga(pdev) &&
 	    pdev->vendor == PCI_VENDOR_ID_INTEL &&
-	    IS_ENABLED(CONFIG_VFIO_PCI_IGD)) {
+	    IS_ENABLED(CONFIG_VFIO_PCI_IGD) &&
+	    pci_is_root_bus(pdev->bus)) {
 		ret = vfio_pci_igd_init(vdev);
 		if (ret) {
 			pci_warn(pdev, "Failed to setup Intel IGD regions\n");

Signature · 1 line

2.24.1.1.gb6d4d82bd5

Signature · 1 line

$gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827

Patchwork

2020-09-29 19:19 UTC #2 lore raw

[Intel-gfx] ✓ Fi.CI.IGT: success for vfio/pci: Refine Intel IGD OpRegion support (rev2)

In reply to Fred Gao

== Series Details ==

Series: vfio/pci: Refine Intel IGD OpRegion support (rev2)
URL : https://patchwork.freedesktop.org/series/79293/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_9071_full -> Patchwork_18587_full
====================================================

Summary
-------

**SUCCESS**

No regressions found.

Known issues
------------

Here are the changes found in Patchwork_18587_full that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@i915_selftest@mock@contexts:
- shard-apl: [PASS][1] -> [INCOMPLETE][2] ([i915#1635] / [i915#2278])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9071/shard-apl3/igt@i915_selftest@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18587/shard-apl7/igt@i915_selftest@[email protected]

* igt@kms_big_fb@y-tiled-8bpp-rotate-0:
- shard-kbl: [PASS][3] -> [DMESG-WARN][4] ([i915#1982])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9071/shard-kbl2/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18587/shard-kbl4/igt@[email protected]

* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size:
- shard-skl: [PASS][5] -> [FAIL][6] ([i915#2346])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9071/shard-skl3/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18587/shard-skl10/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html

* igt@kms_cursor_legacy@short-flip-before-cursor-atomic-transitions:
- shard-skl: [PASS][7] -> [DMESG-WARN][8] ([i915#1982]) +5 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9071/shard-skl9/igt@kms_cursor_legacy@short-flip-before-cursor-atomic-transitions.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18587/shard-skl4/igt@kms_cursor_legacy@short-flip-before-cursor-atomic-transitions.html

* igt@kms_flip@flip-vs-expired-vblank-interruptible@c-edp1:
- shard-skl: [PASS][9] -> [FAIL][10] ([i915#79])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9071/shard-skl3/igt@kms_flip@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18587/shard-skl10/igt@kms_flip@[email protected]

* igt@kms_flip@flip-vs-suspend-interruptible@b-edp1:
- shard-skl: [PASS][11] -> [INCOMPLETE][12] ([i915#198])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9071/shard-skl5/igt@kms_flip@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18587/shard-skl5/igt@kms_flip@[email protected]

* igt@kms_flip@plain-flip-fb-recreate-interruptible@c-hdmi-a1:
- shard-glk: [PASS][13] -> [FAIL][14] ([i915#2122])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9071/shard-glk7/igt@kms_flip@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18587/shard-glk7/igt@kms_flip@[email protected]

* igt@kms_frontbuffer_tracking@fbc-suspend:
- shard-kbl: [PASS][15] -> [DMESG-WARN][16] ([i915#180]) +8 similar issues
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9071/shard-kbl7/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18587/shard-kbl3/igt@[email protected]

* igt@kms_hdr@bpc-switch-dpms:
- shard-skl: [PASS][17] -> [FAIL][18] ([i915#1188])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9071/shard-skl3/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18587/shard-skl7/igt@[email protected]

* igt@kms_lease@atomic_implicit_crtc:
- shard-snb: [PASS][19] -> [SKIP][20] ([fdo#109271])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9071/shard-snb1/igt@kms_lease@atomic_implicit_crtc.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18587/shard-snb5/igt@kms_lease@atomic_implicit_crtc.html

* igt@kms_plane@plane-panning-bottom-right-pipe-a-planes:
- shard-iclb: [PASS][21] -> [DMESG-WARN][22] ([i915#1982])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9071/shard-iclb4/igt@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18587/shard-iclb2/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-a-coverage-7efc:
- shard-skl: [PASS][23] -> [DMESG-FAIL][24] ([fdo#108145] / [i915#1982])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9071/shard-skl4/igt@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18587/shard-skl1/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min:
- shard-skl: [PASS][25] -> [FAIL][26] ([fdo#108145] / [i915#265])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9071/shard-skl3/igt@[email protected]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18587/shard-skl7/igt@[email protected]

* igt@kms_psr@psr2_suspend:
- shard-iclb: [PASS][27] -> [SKIP][28] ([fdo#109441]) +1 similar issue
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9071/shard-iclb2/igt@kms_psr@psr2_suspend.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18587/shard-iclb6/igt@kms_psr@psr2_suspend.html

* igt@kms_setmode@basic:
- shard-glk: [PASS][29] -> [FAIL][30] ([i915#31])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9071/shard-glk6/igt@[email protected]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18587/shard-glk4/igt@[email protected]

* igt@kms_universal_plane@universal-plane-gen9-features-pipe-d:
- shard-tglb: [PASS][31] -> [DMESG-WARN][32] ([i915#1982])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9071/shard-tglb6/igt@[email protected]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18587/shard-tglb6/igt@[email protected]

#### Possible fixes ####

* {igt@api_intel_bb@render-ccs}:
- shard-skl: [INCOMPLETE][33] ([i915#2499]) -> [PASS][34]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9071/shard-skl8/igt@[email protected]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18587/shard-skl5/igt@[email protected]

* {igt@gem_ctx_persistence@heartbeat-close}:
- shard-tglb: [FAIL][35] ([i915#2519]) -> [PASS][36]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9071/shard-tglb6/igt@[email protected]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18587/shard-tglb6/igt@[email protected]

* {igt@gem_ctx_persistence@heartbeat-many}:
- shard-tglb: [FAIL][37] ([i915#2520]) -> [PASS][38]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9071/shard-tglb5/igt@[email protected]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18587/shard-tglb1/igt@[email protected]

* igt@gem_exec_whisper@basic-fds-priority-all:
- shard-skl: [DMESG-WARN][39] ([i915#1982]) -> [PASS][40] +4 similar issues
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9071/shard-skl7/igt@[email protected]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18587/shard-skl2/igt@[email protected]

* igt@gem_exec_whisper@basic-forked:
- shard-glk: [DMESG-WARN][41] ([i915#118] / [i915#95]) -> [PASS][42] +2 similar issues
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9071/shard-glk7/igt@[email protected]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18587/shard-glk7/igt@[email protected]

* igt@gem_huc_copy@huc-copy:
- shard-tglb: [SKIP][43] ([i915#2190]) -> [PASS][44]
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9071/shard-tglb6/igt@[email protected]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18587/shard-tglb7/igt@[email protected]

* igt@gem_userptr_blits@sync-unmap-cycles:
- shard-skl: [TIMEOUT][45] ([i915#2424]) -> [PASS][46]
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9071/shard-skl7/igt@[email protected]
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18587/shard-skl2/igt@[email protected]

* {igt@kms_async_flips@alternate-sync-async-flip}:
- shard-tglb: [FAIL][47] ([i915#2521]) -> [PASS][48]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9071/shard-tglb1/igt@[email protected]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18587/shard-tglb5/igt@[email protected]

* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions:
- shard-skl: [FAIL][49] ([i915#2346]) -> [PASS][50]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9071/shard-skl2/igt@[email protected]
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18587/shard-skl8/igt@[email protected]

* igt@kms_flip@basic-flip-vs-wf_vblank@a-dp1:
- shard-kbl: [DMESG-WARN][51] ([i915#1982]) -> [PASS][52] +2 similar issues
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9071/shard-kbl2/igt@kms_flip@[email protected]
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18587/shard-kbl4/igt@kms_flip@[email protected]

* igt@kms_flip@flip-vs-suspend-interruptible@a-dp1:
- shard-kbl: [DMESG-WARN][53] ([i915#180]) -> [PASS][54] +8 similar issues
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9071/shard-kbl1/igt@kms_flip@[email protected]
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18587/shard-kbl6/igt@kms_flip@[email protected]

* igt@kms_flip@plain-flip-ts-check-interruptible@a-edp1:
- shard-skl: [FAIL][55] ([i915#2122]) -> [PASS][56]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9071/shard-skl6/igt@kms_flip@[email protected]
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18587/shard-skl8/igt@kms_flip@[email protected]

* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-gtt:
- shard-tglb: [DMESG-WARN][57] ([i915#1982]) -> [PASS][58]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9071/shard-tglb3/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-gtt.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18587/shard-tglb2/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-gtt.html

* igt@kms_hdr@bpc-switch-suspend:
- shard-skl: [FAIL][59] ([i915#1188]) -> [PASS][60]
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9071/shard-skl9/igt@[email protected]
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18587/shard-skl4/igt@[email protected]

* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c:
- shard-skl: [INCOMPLETE][61] ([i915#198]) -> [PASS][62]
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9071/shard-skl5/igt@[email protected]
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18587/shard-skl3/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-b-coverage-7efc:
- shard-skl: [FAIL][63] ([fdo#108145] / [i915#265]) -> [PASS][64]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9071/shard-skl1/igt@[email protected]
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18587/shard-skl7/igt@[email protected]

* igt@kms_psr@psr2_cursor_plane_onoff:
- shard-iclb: [SKIP][65] ([fdo#109441]) -> [PASS][66] +1 similar issue
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9071/shard-iclb4/igt@kms_psr@psr2_cursor_plane_onoff.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18587/shard-iclb2/igt@kms_psr@psr2_cursor_plane_onoff.html

#### Warnings ####

* igt@i915_pm_dc@dc3co-vpb-simulation:
- shard-iclb: [SKIP][67] ([i915#588]) -> [SKIP][68] ([i915#658])
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9071/shard-iclb2/igt@[email protected]
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18587/shard-iclb6/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
- shard-skl: [FAIL][69] ([fdo#108145] / [i915#265]) -> [DMESG-FAIL][70] ([fdo#108145] / [i915#1982])
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9071/shard-skl6/igt@[email protected]
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18587/shard-skl8/igt@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

Participating hosts (11 -> 12)
------------------------------

Additional (1): pig-snb-2600

Build changes
-------------

* Linux: CI_DRM_9071 -> Patchwork_18587

CI-20190529: 20190529
CI_DRM_9071: d739b31bdbc0a8342f7d51acdbe987d7f256c6a4 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5790: 722a3eb9734f04030508d244df9dff55c5ab686c @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_18587: f4acdad71f8789025e75d787854acf54b8783b37 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18587/index.html

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Alex Williamson

2020-09-29 22:06 UTC #3 lore raw

In reply to Fred Gao

Quoted 24 lines · On Wed, 30 Sep 2020 00:10:38 +0800 Fred Gao <[email protected]> wrote:

Bypass the IGD initialization for Intel's dgfx devices with own expansion ROM and the host/LPC bridge config space are no longer accessed.
v2: simply test if discrete or integrated gfx device
with root bus. (Alex Williamson)
Cc Zhenyu Wang <[email protected]>
Cc Xiong Zhang <[email protected]>
Cc Hang Yuan <[email protected]>
Cc Stuart Summers <[email protected]>
Signed-off-by Lucas De Marchi <[email protected]>
Signed-off-by Fred Gao <[email protected]>
---
 drivers/vfio/pci/vfio_pci.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/vfio/pci/vfio_pci.c +0 -0
index f634c81998bb..9258ccfadb79 100644
@@ -336,10 +336,11 @@ static int vfio_pci_enable(struct vfio_pci_device *vdev)
 	if (!vfio_vga_disabled() && vfio_pci_is_vga(pdev))
 		vdev->has_vga = true;
 

drivers/vfio/pci/vfio_pci.c static int vfio_pci_enable(struct vfio_pci_device *vdev) · line 346

Quoted 10 lines

drivers/vfio/pci/vfio_pci.c +3 -2

-
+	/* Intel's dgfx should not appear on root bus */
 	if (vfio_pci_is_vga(pdev) &&
 	    pdev->vendor == PCI_VENDOR_ID_INTEL &&
-	    IS_ENABLED(CONFIG_VFIO_PCI_IGD)) {
+	    IS_ENABLED(CONFIG_VFIO_PCI_IGD) &&
+	    pci_is_root_bus(pdev->bus)) {
 		ret = vfio_pci_igd_init(vdev);
 		if (ret) {
 			pci_warn(pdev, "Failed to setup Intel IGD regions\n");

The comment seems rather misplaced here, it only refers to one switch, several lines down within the set of conditions, but looks like a header for the entire branch. I think it would be better to either expand the comment to describe the entire branch, including the exclusion, or try to fit the exclusion comment alongside the test, ie.

	/*
	 * Intel IGD requires quirks to support guest drivers.  IGD is
	 * identified as an Intel VGA device on the root bus.
	 */

	    pci_is_root_bus(pdev->bus)) { /* Skip discrete gfx */

The commit title should really include something about excluding discrete graphics from IGD quirks as well. It might help downstreams backport it for support.

It also occurs to me that relying on the physical topology only works at the bare metal level. We could for example assign a dgfx device at address 00:02.0 in the guest. Nested assignment of that device would trigger calling vfio_pci_igd_init() and fail. I see igd has a PCIe capability type of PCI_EXP_TYPE_RC_END and I'd expect dgfx to have a type of PCI_EXP_TYPE_LEG_END, but unfortunately QEMU does too good of a job emulating the PCIe capability and will mangle these to suit the guest topology. I wonder then if our best course is to make the above branch more lenient, for example pruning the failure paths such that we could use -ENODEV as a non-terminal error like is done for the NVLink quirks below this code block. Failure to find an OpRegion might be our differentiation, where on bare metal we might have both igd and dgfx, so we'd need the root bus test, but assigning dgfx to a VM and placing it on the VM root bus wouldn't generate an OpRegion, so both levels would take the dgfx path. IGD placed on a non-root bus in the guest could probably just be considered a misconfiguration by the user... Thanks,

Alex

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Fred Gao

author

2020-11-02 10:06 UTC #4 lore raw

PATCH v3 1/1 vfio/pci: Bypass IGD init in case of -ENODEV

In reply to Fred Gao

Bypass the IGD initialization when -ENODEV returns, that should be the case if opregion is not available for IGD or within discrete graphics device's option ROM, or host/lpc bridge is not found.

Then use of -ENODEV here means no special device resources found which needs special care for VFIO, but we still allow other normal device resource access.

Cc Zhenyu Wang <[email protected]>

Cc Xiong Zhang <[email protected]>

Cc Hang Yuan <[email protected]>

Cc Stuart Summers <[email protected]>

Signed-off-by Fred Gao <[email protected]>

---
 drivers/vfio/pci/vfio_pci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

drivers/vfio/pci/vfio_pci.c +1 -1

index f634c81998bb..c88cf9937469 100644
@@ -341,7 +341,7 @@ static int vfio_pci_enable(struct vfio_pci_device *vdev)
 	    pdev->vendor == PCI_VENDOR_ID_INTEL &&
 	    IS_ENABLED(CONFIG_VFIO_PCI_IGD)) {
 		ret = vfio_pci_igd_init(vdev);
-		if (ret) {
+		if (ret && ret != -ENODEV) {
 			pci_warn(pdev, "Failed to setup Intel IGD regions\n");
 			goto disable_exit;
 		}

Signature · 6 lines

2.24.1.1.gb6d4d82bd5

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Alex Williamson

Applied

2020-11-03 18:21 UTC #5 lore raw

Re: [Intel-gfx] [PATCH v3] vfio/pci: Bypass IGD init in case of -ENODEV

Quoted 9 lines · On Tue, 3 Nov 2020 02:01:20 +0800 Fred Gao <[email protected]> wrote:

Bypass the IGD initialization when -ENODEV returns, that should be the case if opregion is not available for IGD or within discrete graphics device's option ROM, or host/lpc bridge is not found.
Then use of -ENODEV here means no special device resources found which needs special care for VFIO, but we still allow other normal device resource access.

Quoted 8 lines

Cc Zhenyu Wang <[email protected]>
Cc Xiong Zhang <[email protected]>
Cc Hang Yuan <[email protected]>
Cc Stuart Summers <[email protected]>
Signed-off-by Fred Gao <[email protected]>
---
 drivers/vfio/pci/vfio_pci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Applied to vfio for-linus branch for v5.10. Thanks,

Alex

Quoted 14 lines

drivers/vfio/pci/vfio_pci.c +1 -1

index f634c81998bb..c88cf9937469 100644
@@ -341,7 +341,7 @@ static int vfio_pci_enable(struct vfio_pci_device *vdev)
 	    pdev->vendor == PCI_VENDOR_ID_INTEL &&
 	    IS_ENABLED(CONFIG_VFIO_PCI_IGD)) {
 		ret = vfio_pci_igd_init(vdev);
-		if (ret) {
+		if (ret && ret != -ENODEV) {
 			pci_warn(pdev, "Failed to setup Intel IGD regions\n");
 			goto disable_exit;
 		}

Patchwork

2020-11-02 11:48 UTC #6 lore raw

[Intel-gfx] ✓ Fi.CI.BAT: success for vfio/pci: Refine Intel IGD OpRegion support (rev3)

In reply to Fred Gao

== Series Details ==

Series: vfio/pci: Refine Intel IGD OpRegion support (rev3)
URL : https://patchwork.freedesktop.org/series/79293/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_9242 -> Patchwork_18825
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18825/index.html

New tests
---------

New tests have been introduced between CI_DRM_9242 and Patchwork_18825:

### New CI tests (1) ###

* boot:
- Statuses : 38 pass(s)
- Exec time: [0.0] s

Known issues
------------

Here are the changes found in Patchwork_18825 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@i915_module_load@reload:
- fi-byt-j1900: [PASS][1] -> [DMESG-WARN][2] ([i915#1982])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9242/fi-byt-j1900/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18825/fi-byt-j1900/igt@[email protected]
- fi-skl-lmem: [PASS][3] -> [DMESG-WARN][4] ([i915#2605])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9242/fi-skl-lmem/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18825/fi-skl-lmem/igt@[email protected]

#### Possible fixes ####

* igt@core_hotunplug@unbind-rebind:
- fi-skl-lmem: [DMESG-WARN][5] ([i915#2605]) -> [PASS][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9242/fi-skl-lmem/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18825/fi-skl-lmem/igt@[email protected]
- fi-icl-u2: [DMESG-WARN][7] ([i915#1982]) -> [PASS][8] +1 similar issue
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9242/fi-icl-u2/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18825/fi-icl-u2/igt@[email protected]
- fi-icl-y: [DMESG-WARN][9] ([i915#1982]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9242/fi-icl-y/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18825/fi-icl-y/igt@[email protected]

* igt@i915_pm_rpm@basic-pci-d3-state:
- fi-apl-guc: [DMESG-WARN][11] ([i915#1635] / [i915#1982]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9242/fi-apl-guc/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18825/fi-apl-guc/igt@[email protected]

[i915#1635]: https://gitlab.freedesktop.org/drm/intel/issues/1635
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2605]: https://gitlab.freedesktop.org/drm/intel/issues/2605

Participating hosts (42 -> 38)
------------------------------

Missing (4): fi-ilk-m540 fi-bsw-cyan fi-bdw-samus fi-hsw-4200u

Build changes
-------------

* Linux: CI_DRM_9242 -> Patchwork_18825

CI-20190529: 20190529
CI_DRM_9242: 43ba45463378aca64ef7a85c9d487913f8239b8f @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5830: 12d370cb57e0cfcb781c87ad9e15e68b17a1f41f @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_18825: 06f2b2ea5338d5fe863062974724098307f12244 @ git://anongit.freedesktop.org/gfx-ci/linux

== Linux commits ==

06f2b2ea5338 vfio/pci: Bypass IGD init in case of -ENODEV

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18825/index.html

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Patchwork

2020-11-02 16:14 UTC #7 lore raw

[Intel-gfx] ✓ Fi.CI.IGT: success for vfio/pci: Refine Intel IGD OpRegion support (rev3)

In reply to Fred Gao

== Series Details ==

Series: vfio/pci: Refine Intel IGD OpRegion support (rev3)
URL : https://patchwork.freedesktop.org/series/79293/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_9242_full -> Patchwork_18825_full
====================================================

Summary
-------

**WARNING**

Minor unknown changes coming with Patchwork_18825_full need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in Patchwork_18825_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in Patchwork_18825_full:

### IGT changes ###

#### Warnings ####

* igt@core_hotunplug@hotrebind-lateclose:
- shard-hsw: [WARN][1] ([i915#2283]) -> [FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9242/shard-hsw1/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18825/shard-hsw1/igt@[email protected]

New tests
---------

New tests have been introduced between CI_DRM_9242_full and Patchwork_18825_full:

### New CI tests (1) ###

* boot:
- Statuses : 200 pass(s)
- Exec time: [0.0] s

Known issues
------------

Here are the changes found in Patchwork_18825_full that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_exec_whisper@basic-contexts-priority-all:
- shard-glk: [PASS][3] -> [DMESG-WARN][4] ([i915#118] / [i915#95])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9242/shard-glk1/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18825/shard-glk5/igt@[email protected]

* igt@i915_module_load@reload:
- shard-tglb: [PASS][5] -> [DMESG-WARN][6] ([i915#1982] / [k.org#205379])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9242/shard-tglb8/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18825/shard-tglb3/igt@[email protected]

* igt@kms_busy@basic-flip-pipe-b:
- shard-tglb: [PASS][7] -> [DMESG-WARN][8] ([i915#1982]) +4 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9242/shard-tglb2/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18825/shard-tglb5/igt@[email protected]

* igt@kms_cursor_crc@pipe-b-cursor-256x256-sliding:
- shard-skl: [PASS][9] -> [FAIL][10] ([i915#54]) +2 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9242/shard-skl6/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18825/shard-skl8/igt@[email protected]

* igt@kms_cursor_edge_walk@pipe-b-64x64-top-edge:
- shard-apl: [PASS][11] -> [DMESG-WARN][12] ([i915#1635] / [i915#1982]) +2 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9242/shard-apl8/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18825/shard-apl7/igt@[email protected]

* igt@kms_cursor_edge_walk@pipe-c-256x256-right-edge:
- shard-glk: [PASS][13] -> [DMESG-WARN][14] ([i915#1982])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9242/shard-glk5/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18825/shard-glk4/igt@[email protected]

* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size:
- shard-skl: [PASS][15] -> [FAIL][16] ([i915#2346])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9242/shard-skl9/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18825/shard-skl9/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html

* igt@kms_flip@flip-vs-expired-vblank@b-edp1:
- shard-skl: [PASS][17] -> [FAIL][18] ([i915#79])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9242/shard-skl7/igt@kms_flip@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18825/shard-skl4/igt@kms_flip@[email protected]

* igt@kms_flip@flip-vs-suspend@a-edp1:
- shard-iclb: [PASS][19] -> [INCOMPLETE][20] ([i915#2483])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9242/shard-iclb3/igt@kms_flip@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18825/shard-iclb3/igt@kms_flip@[email protected]

* igt@kms_flip@plain-flip-fb-recreate-interruptible@c-edp1:
- shard-skl: [PASS][21] -> [DMESG-WARN][22] ([i915#1982]) +7 similar issues
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9242/shard-skl7/igt@kms_flip@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18825/shard-skl7/igt@kms_flip@[email protected]

* igt@kms_flip@plain-flip-fb-recreate@a-edp1:
- shard-skl: [PASS][23] -> [FAIL][24] ([i915#2122])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9242/shard-skl1/igt@kms_flip@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18825/shard-skl2/igt@kms_flip@[email protected]

* igt@kms_hdr@bpc-switch-dpms:
- shard-skl: [PASS][25] -> [FAIL][26] ([i915#1188]) +1 similar issue
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9242/shard-skl10/igt@[email protected]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18825/shard-skl6/igt@[email protected]

* igt@kms_psr2_su@page_flip:
- shard-iclb: [PASS][27] -> [SKIP][28] ([fdo#109642] / [fdo#111068])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9242/shard-iclb2/igt@kms_psr2_su@page_flip.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18825/shard-iclb8/igt@kms_psr2_su@page_flip.html

* igt@kms_psr@psr2_primary_page_flip:
- shard-iclb: [PASS][29] -> [SKIP][30] ([fdo#109441]) +3 similar issues
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9242/shard-iclb2/igt@kms_psr@psr2_primary_page_flip.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18825/shard-iclb8/igt@kms_psr@psr2_primary_page_flip.html

* igt@kms_vblank@pipe-a-query-idle-hang:
- shard-kbl: [PASS][31] -> [DMESG-WARN][32] ([i915#1982]) +1 similar issue
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9242/shard-kbl7/igt@[email protected]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18825/shard-kbl7/igt@[email protected]

#### Possible fixes ####

* igt@gem_huc_copy@huc-copy:
- shard-tglb: [SKIP][33] ([i915#2190]) -> [PASS][34]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9242/shard-tglb6/igt@[email protected]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18825/shard-tglb7/igt@[email protected]

* igt@gem_partial_pwrite_pread@writes-after-reads-uncached:
- shard-hsw: [FAIL][35] ([i915#1888]) -> [PASS][36]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9242/shard-hsw1/igt@[email protected]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18825/shard-hsw1/igt@[email protected]

* igt@i915_pm_backlight@fade_with_suspend:
- shard-skl: [INCOMPLETE][37] -> [PASS][38] +2 similar issues
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9242/shard-skl9/igt@i915_pm_backlight@fade_with_suspend.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18825/shard-skl2/igt@i915_pm_backlight@fade_with_suspend.html

* igt@i915_pm_rc6_residency@rc6-idle:
- shard-hsw: [WARN][39] ([i915#1519]) -> [PASS][40]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9242/shard-hsw6/igt@[email protected]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18825/shard-hsw1/igt@[email protected]

* {igt@kms_async_flips@async-flip-with-page-flip-events}:
- shard-glk: [FAIL][41] ([i915#2521]) -> [PASS][42]
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9242/shard-glk4/igt@[email protected]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18825/shard-glk1/igt@[email protected]
- shard-apl: [FAIL][43] ([i915#1635] / [i915#2521]) -> [PASS][44]
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9242/shard-apl8/igt@[email protected]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18825/shard-apl8/igt@[email protected]

* igt@kms_atomic_transition@plane-use-after-nonblocking-unbind-fencing@hdmi-a-1-pipe-a:
- shard-glk: [DMESG-WARN][45] ([i915#1982]) -> [PASS][46]
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9242/shard-glk8/igt@kms_atomic_transition@[email protected]
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18825/shard-glk9/igt@kms_atomic_transition@[email protected]

* igt@kms_atomic_transition@plane-use-after-nonblocking-unbind-fencing@vga-1-pipe-a:
- shard-hsw: [DMESG-WARN][47] ([i915#1982]) -> [PASS][48] +1 similar issue
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9242/shard-hsw6/igt@kms_atomic_transition@[email protected]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18825/shard-hsw2/igt@kms_atomic_transition@[email protected]

* igt@kms_cursor_crc@pipe-a-cursor-256x85-offscreen:
- shard-skl: [FAIL][49] ([i915#54]) -> [PASS][50] +5 similar issues
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9242/shard-skl1/igt@[email protected]
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18825/shard-skl8/igt@[email protected]

* igt@kms_cursor_crc@pipe-c-cursor-suspend:
- shard-skl: [INCOMPLETE][51] ([i915#300]) -> [PASS][52]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9242/shard-skl4/igt@[email protected]
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18825/shard-skl4/igt@[email protected]

* igt@kms_cursor_legacy@cursor-vs-flip-toggle:
- shard-hsw: [FAIL][53] ([i915#2370]) -> [PASS][54]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9242/shard-hsw1/igt@[email protected]
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18825/shard-hsw1/igt@[email protected]

* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions:
- shard-skl: [FAIL][55] ([i915#2346]) -> [PASS][56]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9242/shard-skl9/igt@[email protected]
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18825/shard-skl9/igt@[email protected]

* igt@kms_draw_crc@draw-method-rgb565-pwrite-untiled:
- shard-skl: [DMESG-WARN][57] ([i915#1982]) -> [PASS][58] +3 similar issues
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9242/shard-skl1/igt@[email protected]
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18825/shard-skl2/igt@[email protected]

* igt@kms_flip@absolute-wf_vblank@a-dp1:
- shard-kbl: [DMESG-WARN][59] ([i915#1982]) -> [PASS][60] +1 similar issue
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9242/shard-kbl4/igt@kms_flip@[email protected]
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18825/shard-kbl4/igt@kms_flip@[email protected]

* igt@kms_flip@flip-vs-expired-vblank-interruptible@c-edp1:
- shard-skl: [FAIL][61] ([i915#79]) -> [PASS][62]
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9242/shard-skl10/igt@kms_flip@[email protected]
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18825/shard-skl7/igt@kms_flip@[email protected]

* igt@kms_flip@plain-flip-fb-recreate@c-edp1:
- shard-skl: [FAIL][63] ([i915#2122]) -> [PASS][64]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9242/shard-skl1/igt@kms_flip@[email protected]
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18825/shard-skl2/igt@kms_flip@[email protected]

* igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-indfb-draw-blt:
- shard-iclb: [DMESG-WARN][65] ([i915#1982]) -> [PASS][66]
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9242/shard-iclb6/igt@[email protected]
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18825/shard-iclb4/igt@[email protected]

* igt@kms_pipe_crc_basic@disable-crc-after-crtc-pipe-c:
- shard-skl: [FAIL][67] -> [PASS][68]
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9242/shard-skl2/igt@[email protected]
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18825/shard-skl10/igt@[email protected]

* igt@kms_psr@psr2_primary_mmap_cpu:
- shard-iclb: [SKIP][69] ([fdo#109441]) -> [PASS][70] +1 similar issue
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9242/shard-iclb7/igt@kms_psr@psr2_primary_mmap_cpu.html
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18825/shard-iclb2/igt@kms_psr@psr2_primary_mmap_cpu.html

* igt@kms_vblank@pipe-b-wait-forked-busy-hang:
- shard-apl: [DMESG-WARN][71] ([i915#1635] / [i915#1982]) -> [PASS][72] +1 similar issue
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9242/shard-apl7/igt@[email protected]
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18825/shard-apl4/igt@[email protected]

* igt@perf@non-system-wide-paranoid:
- shard-hsw: [SKIP][73] ([fdo#109271]) -> [PASS][74]
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9242/shard-hsw1/igt@[email protected]
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18825/shard-hsw1/igt@[email protected]

#### Warnings ####

* igt@i915_pm_backlight@fade_with_suspend:
- shard-tglb: [DMESG-WARN][75] ([i915#1436]) -> [INCOMPLETE][76] ([i915#1436] / [i915#456])
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9242/shard-tglb1/igt@i915_pm_backlight@fade_with_suspend.html
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18825/shard-tglb5/igt@i915_pm_backlight@fade_with_suspend.html

* igt@kms_flip@flip-vs-suspend-interruptible@a-edp1:
- shard-tglb: [DMESG-WARN][77] ([i915#2411]) -> [INCOMPLETE][78] ([i915#1436] / [i915#456])
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9242/shard-tglb6/igt@kms_flip@[email protected]
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18825/shard-tglb7/igt@kms_flip@[email protected]

* igt@kms_flip@plain-flip-fb-recreate-interruptible@b-edp1:
- shard-skl: [DMESG-WARN][79] ([i915#1982]) -> [FAIL][80] ([i915#2122])
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9242/shard-skl7/igt@kms_flip@[email protected]
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18825/shard-skl7/igt@kms_flip@[email protected]

* igt@kms_plane_alpha_blend@pipe-a-alpha-7efc:
- shard-apl: [DMESG-FAIL][81] ([fdo#108145] / [i915#1635] / [i915#1982]) -> [FAIL][82] ([fdo#108145] / [i915#1635] / [i915#265])
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9242/shard-apl6/igt@[email protected]
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18825/shard-apl8/igt@[email protected]

* igt@runner@aborted:
- shard-tglb: [FAIL][83] ([i915#2439]) -> ([FAIL][84], [FAIL][85]) ([i915#2248] / [i915#2439])
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9242/shard-tglb1/igt@[email protected]
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18825/shard-tglb7/igt@[email protected]
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18825/shard-tglb5/igt@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

Participating hosts (11 -> 11)
------------------------------

No changes in participating hosts

Build changes
-------------

* Linux: CI_DRM_9242 -> Patchwork_18825

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18825/index.html

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx