cpufreq: Add missing modalias for tristate drivers
Subsystems (10)
cover cpufreq: Add missing modalias for tristate drivers
Some of cpufreq drivers are tristate, can be compiled as modules, but do not have defined modalias for automatic loading. This patch series add for all those cpufreq drivers missing MODULE_DEVICE_TABLE macro, based on OF definitions, or MODULE_ALIAS for platform drivers.
MODULE_DEVICE_TABLE is not explictily added only for speedstep-centrino, speedstep-ich and speedstep-smi drivers as it was removed in commit b11d77fa300d9 ("cpufreq: Convert to new X86 CPU match macros").
Pali Rohár (9):
cpufreq: ap806: Add missing MODULE_DEVICE_TABLE
cpufreq: highbank: Add missing MODULE_DEVICE_TABLE
cpufreq: mediatek: Add missing MODULE_DEVICE_TABLE
cpufreq: qcom: Add missing MODULE_DEVICE_TABLE
cpufreq: st: Add missing MODULE_DEVICE_TABLE
cpufreq: sun50i: Add missing MODULE_DEVICE_TABLE
cpufreq: loongson1: Add missing MODULE_ALIAS
cpufreq: scpi: Add missing MODULE_ALIAS
cpufreq: vexpress-spc: Add missing MODULE_ALIAS
drivers/cpufreq/armada-8k-cpufreq.c | 6 ++++++ drivers/cpufreq/highbank-cpufreq.c | 7 +++++++ drivers/cpufreq/loongson1-cpufreq.c | 1 + drivers/cpufreq/mediatek-cpufreq.c | 1 + drivers/cpufreq/qcom-cpufreq-nvmem.c | 1 + drivers/cpufreq/scpi-cpufreq.c | 1 + drivers/cpufreq/sti-cpufreq.c | 7 +++++++ drivers/cpufreq/sun50i-cpufreq-nvmem.c | 1 + drivers/cpufreq/vexpress-spc-cpufreq.c | 1 + 9 files changed, 26 insertions(+)
Signature · 1 line
2.20.1
PATCH 1/9 cpufreq: ap806: Add missing MODULE_DEVICE_TABLE
This patch adds missing MODULE_DEVICE_TABLE definition which generates correct modalias for automatic loading of this cpufreq driver when it is compiled as an external module.
--- drivers/cpufreq/armada-8k-cpufreq.c | 6 ++++++ 1 file changed, 6 insertions(+)
drivers/cpufreq/armada-8k-cpufreq.c +6 -0
@@ -204,6 +204,12 @@ static void __exit armada_8k_cpufreq_exit(void) }module_exit (armada_8k_cpufreq_exit); +static const struct of_device_id __maybe_unused armada_8k_cpufreq_of_match[] = { + { .compatible ="marvell,ap806-cpu-clock" }, + { }, +}; +MODULE_DEVICE_TABLE (of, armada_8k_cpufreq_of_match); +MODULE_AUTHOR ("Gregory Clement <[email protected]>" );MODULE_DESCRIPTION ("Armada 8K cpufreq driver" );MODULE_LICENSE ("GPL" );
Signature · 1 line
2.20.1
PATCH 2/9 cpufreq: highbank: Add missing MODULE_DEVICE_TABLE
In reply to Pali RohárThis patch adds missing MODULE_DEVICE_TABLE definition which generates correct modalias for automatic loading of this cpufreq driver when it is compiled as an external module.
--- drivers/cpufreq/highbank-cpufreq.c | 7 +++++++ 1 file changed, 7 insertions(+)
drivers/cpufreq/highbank-cpufreq.c +7 -0
@@ -101,6 +101,13 @@ static int hb_cpufreq_driver_init(void) }module_init (hb_cpufreq_driver_init); +static const struct of_device_id __maybe_unused hb_cpufreq_of_match[] = { + { .compatible ="calxeda,highbank" }, + { .compatible ="calxeda,ecx-2000" }, + { }, +}; +MODULE_DEVICE_TABLE (of, hb_cpufreq_of_match); +MODULE_AUTHOR ("Mark Langsdorf <[email protected]>" );MODULE_DESCRIPTION ("Calxeda Highbank cpufreq driver" );MODULE_LICENSE ("GPL" );
Signature · 1 line
2.20.1
PATCH 3/9 cpufreq: mediatek: Add missing MODULE_DEVICE_TABLE
In reply to Pali RohárThis patch adds missing MODULE_DEVICE_TABLE definition which generates correct modalias for automatic loading of this cpufreq driver when it is compiled as an external module.
--- drivers/cpufreq/mediatek-cpufreq.c | 1 + 1 file changed, 1 insertion(+)
drivers/cpufreq/mediatek-cpufreq.c +1 -0
@@ -540,6 +540,7 @@ static const struct of_device_id mtk_cpufreq_machines[] __initconst = { { } }; +MODULE_DEVICE_TABLE (of, mtk_cpufreq_machines);static int __init mtk_cpufreq_driver_init (void ) {
Signature · 1 line
2.20.1
PATCH 4/9 cpufreq: qcom: Add missing MODULE_DEVICE_TABLE
In reply to Pali RohárThis patch adds missing MODULE_DEVICE_TABLE definition which generates correct modalias for automatic loading of this cpufreq driver when it is compiled as an external module.
--- drivers/cpufreq/qcom-cpufreq-nvmem.c | 1 + 1 file changed, 1 insertion(+)
drivers/cpufreq/qcom-cpufreq-nvmem.c +1 -0
@@ -464,6 +464,7 @@ static const struct of_device_id qcom_cpufreq_match_list[] __initconst = { { .compatible = "qcom,msm8960", .data = &match_data_krait }, {}, }; +MODULE_DEVICE_TABLE (of, qcom_cpufreq_match_list);/* * Since the driver depends on smem and nvmem drivers, which may
Signature · 1 line
2.20.1
PATCH 5/9 cpufreq: st: Add missing MODULE_DEVICE_TABLE
In reply to Pali RohárThis patch adds missing MODULE_DEVICE_TABLE definition which generates correct modalias for automatic loading of this cpufreq driver when it is compiled as an external module.
--- drivers/cpufreq/sti-cpufreq.c | 7 +++++++ 1 file changed, 7 insertions(+)
drivers/cpufreq/sti-cpufreq.c +7 -0
@@ -292,6 +292,13 @@ static int sti_cpufreq_init(void) }module_init (sti_cpufreq_init); +static const struct of_device_id __maybe_unused sti_cpufreq_of_match[] = { + { .compatible ="st,stih407" }, + { .compatible ="st,stih410" }, + { }, +}; +MODULE_DEVICE_TABLE (of, sti_cpufreq_of_match); +MODULE_DESCRIPTION ("STMicroelectronics CPUFreq/OPP driver" );MODULE_AUTHOR ("Ajitpal Singh <[email protected]>" );MODULE_AUTHOR ("Lee Jones <[email protected]>" );
Signature · 1 line
2.20.1
PATCH 6/9 cpufreq: sun50i: Add missing MODULE_DEVICE_TABLE
In reply to Pali RohárThis patch adds missing MODULE_DEVICE_TABLE definition which generates correct modalias for automatic loading of this cpufreq driver when it is compiled as an external module.
--- drivers/cpufreq/sun50i-cpufreq-nvmem.c | 1 + 1 file changed, 1 insertion(+)
drivers/cpufreq/sun50i-cpufreq-nvmem.c +1 -0
@@ -167,6 +167,7 @@ static const struct of_device_id sun50i_cpufreq_match_list[] = { { .compatible = "allwinner,sun50i-h6" }, {} }; +MODULE_DEVICE_TABLE (of, sun50i_cpufreq_match_list);static const struct of_device_id *sun50i_cpufreq_match_node (void ) {
Signature · 1 line
2.20.1
Re: [PATCH 6/9] cpufreq: sun50i: Add missing MODULE_DEVICE_TABLE
Quoted 16 lines · Pali Rohár
This patch adds missing
MODULE_DEVICE_TABLEdefinition which generates correct modalias for automatic loading of this cpufreq driver when it is compiled as an external module.Signed-off-by Pali Rohár <[email protected]>Fixes f328584f7bff8 ("cpufreq: Add sun50i nvmem based CPU scaling driver")--- drivers/cpufreq/sun50i-cpufreq-nvmem.c | 1 + 1 file changed, 1 insertion(+)drivers/cpufreq/sun50i-cpufreq-nvmem.c +0
-0
drivers/cpufreq/sun50i-cpufreq-nvmem.c static const struct of_device_id sun50i_cpufreq_match_list[] = { · line 170
Quoted 4 lines
drivers/cpufreq/sun50i-cpufreq-nvmem.c +1
-0@@ -167,6 +167,7 @@ static const struct of_device_id sun50i_cpufreq_match_list[] = { { .compatible = "allwinner,sun50i-h6" }, {} }; +MODULE_DEVICE_TABLE (of, sun50i_cpufreq_match_list);
Thx!
PATCH 7/9 cpufreq: loongson1: Add missing MODULE_ALIAS
In reply to Pali RohárThis patch adds missing MODULE_ALIAS for automatic loading of this cpufreq driver when it is compiled as an external module.
--- drivers/cpufreq/loongson1-cpufreq.c | 1 + 1 file changed, 1 insertion(+)
drivers/cpufreq/loongson1-cpufreq.c +1 -0
@@ -216,6 +216,7 @@ static struct platform_driver ls1x_cpufreq_platdrv = {module_platform_driver (ls1x_cpufreq_platdrv); +MODULE_ALIAS ("platform:ls1x-cpufreq" );MODULE_AUTHOR ("Kelvin Cheung <[email protected]>" );MODULE_DESCRIPTION ("Loongson1 CPUFreq driver" );MODULE_LICENSE ("GPL" );
Signature · 1 line
2.20.1
PATCH 8/9 cpufreq: scpi: Add missing MODULE_ALIAS
In reply to Pali RohárThis patch adds missing MODULE_ALIAS for automatic loading of this cpufreq driver when it is compiled as an external module.
--- drivers/cpufreq/scpi-cpufreq.c | 1 + 1 file changed, 1 insertion(+)
drivers/cpufreq/scpi-cpufreq.c +1 -0
@@ -233,6 +233,7 @@ static struct platform_driver scpi_cpufreq_platdrv = { };module_platform_driver (scpi_cpufreq_platdrv); +MODULE_ALIAS ("platform:scpi-cpufreq" );MODULE_AUTHOR ("Sudeep Holla <[email protected]>" );MODULE_DESCRIPTION ("ARM SCPI CPUFreq interface driver" );MODULE_LICENSE ("GPL v2" );
Signature · 1 line
2.20.1
PATCH 9/9 cpufreq: vexpress-spc: Add missing MODULE_ALIAS
In reply to Pali RohárThis patch adds missing MODULE_ALIAS for automatic loading of this cpufreq driver when it is compiled as an external module.
--- drivers/cpufreq/vexpress-spc-cpufreq.c | 1 + 1 file changed, 1 insertion(+)
drivers/cpufreq/vexpress-spc-cpufreq.c +1 -0
@@ -591,6 +591,7 @@ static struct platform_driver ve_spc_cpufreq_platdrv = { };module_platform_driver (ve_spc_cpufreq_platdrv); +MODULE_ALIAS ("platform:vexpress-spc-cpufreq" );MODULE_AUTHOR ("Viresh Kumar <[email protected]>" );MODULE_AUTHOR ("Sudeep Holla <[email protected]>" );MODULE_DESCRIPTION ("Vexpress SPC ARM big LITTLE cpufreq driver" );
Signature · 1 line
2.20.1
Rafael J. Wysocki
maintainerQuoted 32 lines · Pali Rohár
Some of cpufreq drivers are tristate, can be compiled as modules, but do not have defined modalias for automatic loading. This patch series add for all those cpufreq drivers missing
MODULE_DEVICE_TABLEmacro, based on OF definitions, orMODULE_ALIASfor platform drivers.
MODULE_DEVICE_TABLEis not explictily added only for speedstep-centrino, speedstep-ich and speedstep-smi drivers as it was removed in commitb11d77fa300d9("cpufreq: Convert to new X86 CPU match macros").Pali Rohár (9):
cpufreq: ap806: Add missingMODULE_DEVICE_TABLE
cpufreq: highbank: Add missingMODULE_DEVICE_TABLE
cpufreq: mediatek: Add missingMODULE_DEVICE_TABLE
cpufreq: qcom: Add missingMODULE_DEVICE_TABLE
cpufreq: st: Add missingMODULE_DEVICE_TABLE
cpufreq: sun50i: Add missingMODULE_DEVICE_TABLE
cpufreq: loongson1: Add missingMODULE_ALIAS
cpufreq: scpi: Add missingMODULE_ALIAS
cpufreq: vexpress-spc: Add missingMODULE_ALIASdrivers/cpufreq/armada-8k-cpufreq.c | 6 ++++++ drivers/cpufreq/highbank-cpufreq.c | 7 +++++++ drivers/cpufreq/loongson1-cpufreq.c | 1 + drivers/cpufreq/mediatek-cpufreq.c | 1 + drivers/cpufreq/qcom-cpufreq-nvmem.c | 1 + drivers/cpufreq/scpi-cpufreq.c | 1 + drivers/cpufreq/sti-cpufreq.c | 7 +++++++ drivers/cpufreq/sun50i-cpufreq-nvmem.c | 1 + drivers/cpufreq/vexpress-spc-cpufreq.c | 1 + 9 files changed, 26 insertions(+)
Quoted 1 line
--
Viresh, any comments?
Viresh Kumar
maintainerQuoted 33 lines · Rafael J. Wysocki
Quoted 32 lines · Pali Rohár
Some of cpufreq drivers are tristate, can be compiled as modules, but do not have defined modalias for automatic loading. This patch series add for all those cpufreq drivers missing
MODULE_DEVICE_TABLEmacro, based on OF definitions, orMODULE_ALIASfor platform drivers.
MODULE_DEVICE_TABLEis not explictily added only for speedstep-centrino, speedstep-ich and speedstep-smi drivers as it was removed in commitb11d77fa300d9("cpufreq: Convert to new X86 CPU match macros").Pali Rohár (9):
cpufreq: ap806: Add missingMODULE_DEVICE_TABLE
cpufreq: highbank: Add missingMODULE_DEVICE_TABLE
cpufreq: mediatek: Add missingMODULE_DEVICE_TABLE
cpufreq: qcom: Add missingMODULE_DEVICE_TABLE
cpufreq: st: Add missingMODULE_DEVICE_TABLE
cpufreq: sun50i: Add missingMODULE_DEVICE_TABLE
cpufreq: loongson1: Add missingMODULE_ALIAS
cpufreq: scpi: Add missingMODULE_ALIAS
cpufreq: vexpress-spc: Add missingMODULE_ALIASdrivers/cpufreq/armada-8k-cpufreq.c | 6 ++++++ drivers/cpufreq/highbank-cpufreq.c | 7 +++++++ drivers/cpufreq/loongson1-cpufreq.c | 1 + drivers/cpufreq/mediatek-cpufreq.c | 1 + drivers/cpufreq/qcom-cpufreq-nvmem.c | 1 + drivers/cpufreq/scpi-cpufreq.c | 1 + drivers/cpufreq/sti-cpufreq.c | 7 +++++++ drivers/cpufreq/sun50i-cpufreq-nvmem.c | 1 + drivers/cpufreq/vexpress-spc-cpufreq.c | 1 + 9 files changed, 26 insertions(+)
Quoted 3 lines
Quoted 1 line
--
Viresh, any comments?
I found the patches to be fine and marked it to be applied soon in mutt. I was waiting for the maintainers of the drivers to respond, after that I would have applied it for 5.11.
Signature · 1 line
viresh
Rafael J. Wysocki
maintainerQuoted 35 lines · Viresh Kumar
Quoted 33 lines · Rafael J. Wysocki
Quoted 32 lines · Pali Rohár
Some of cpufreq drivers are tristate, can be compiled as modules, but do not have defined modalias for automatic loading. This patch series add for all those cpufreq drivers missing
MODULE_DEVICE_TABLEmacro, based on OF definitions, orMODULE_ALIASfor platform drivers.
MODULE_DEVICE_TABLEis not explictily added only for speedstep-centrino, speedstep-ich and speedstep-smi drivers as it was removed in commitb11d77fa300d9("cpufreq: Convert to new X86 CPU match macros").Pali Rohár (9):
cpufreq: ap806: Add missingMODULE_DEVICE_TABLE
cpufreq: highbank: Add missingMODULE_DEVICE_TABLE
cpufreq: mediatek: Add missingMODULE_DEVICE_TABLE
cpufreq: qcom: Add missingMODULE_DEVICE_TABLE
cpufreq: st: Add missingMODULE_DEVICE_TABLE
cpufreq: sun50i: Add missingMODULE_DEVICE_TABLE
cpufreq: loongson1: Add missingMODULE_ALIAS
cpufreq: scpi: Add missingMODULE_ALIAS
cpufreq: vexpress-spc: Add missingMODULE_ALIASdrivers/cpufreq/armada-8k-cpufreq.c | 6 ++++++ drivers/cpufreq/highbank-cpufreq.c | 7 +++++++ drivers/cpufreq/loongson1-cpufreq.c | 1 + drivers/cpufreq/mediatek-cpufreq.c | 1 + drivers/cpufreq/qcom-cpufreq-nvmem.c | 1 + drivers/cpufreq/scpi-cpufreq.c | 1 + drivers/cpufreq/sti-cpufreq.c | 7 +++++++ drivers/cpufreq/sun50i-cpufreq-nvmem.c | 1 + drivers/cpufreq/vexpress-spc-cpufreq.c | 1 + 9 files changed, 26 insertions(+)
Quoted 7 lines
Quoted 3 lines
Quoted 1 line
--
Viresh, any comments?
I found the patches to be fine and marked it to be applied soon in mutt. I was waiting for the maintainers of the drivers to respond, after that I would have applied it for 5.11.
OK, so please take all of them then (some of them are not ARM-related AFAICS).
Quoted 20 lines · Pali Rohár
Some of cpufreq drivers are tristate, can be compiled as modules, but do not have defined modalias for automatic loading. This patch series add for all those cpufreq drivers missing
MODULE_DEVICE_TABLEmacro, based on OF definitions, orMODULE_ALIASfor platform drivers.
MODULE_DEVICE_TABLEis not explictily added only for speedstep-centrino, speedstep-ich and speedstep-smi drivers as it was removed in commitb11d77fa300d9("cpufreq: Convert to new X86 CPU match macros").Pali Rohár (9):
cpufreq: ap806: Add missingMODULE_DEVICE_TABLE
cpufreq: highbank: Add missingMODULE_DEVICE_TABLE
cpufreq: mediatek: Add missingMODULE_DEVICE_TABLE
cpufreq: qcom: Add missingMODULE_DEVICE_TABLE
cpufreq: st: Add missingMODULE_DEVICE_TABLE
cpufreq: sun50i: Add missingMODULE_DEVICE_TABLE
cpufreq: loongson1: Add missingMODULE_ALIAS
cpufreq: scpi: Add missingMODULE_ALIAS
cpufreq: vexpress-spc: Add missingMODULE_ALIAS
Quoted 10 lines
drivers/cpufreq/armada-8k-cpufreq.c | 6 ++++++ drivers/cpufreq/highbank-cpufreq.c | 7 +++++++ drivers/cpufreq/loongson1-cpufreq.c | 1 + drivers/cpufreq/mediatek-cpufreq.c | 1 + drivers/cpufreq/qcom-cpufreq-nvmem.c | 1 + drivers/cpufreq/scpi-cpufreq.c | 1 + drivers/cpufreq/sti-cpufreq.c | 7 +++++++ drivers/cpufreq/sun50i-cpufreq-nvmem.c | 1 + drivers/cpufreq/vexpress-spc-cpufreq.c | 1 + 9 files changed, 26 insertions(+)
Applied. Thanks.
Signature · 1 line
viresh