Skip to contentSkip to conversation

coresight: Remove unnecessary THIS_MODULE of funnel and replicator driver

PATCH In review Qi Liu 2 participants 2 messages Nov 3, 2020

Subsystems (2)
lore
Share & tools
lore

Qi Liu

author
#0 lore raw

PATCH 1/1 coresight: Remove unnecessary THIS_MODULE of funnel and replicator driver

As THIS_MODULE has been set in platform_driver_register(), so remove it from static funnel driver and static replicator driver to avoid set it twice.

---
 drivers/hwtracing/coresight/coresight-funnel.c     | 2 +-
 drivers/hwtracing/coresight/coresight-replicator.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/hwtracing/coresight/coresight-funnel.c +1 -1
index af40814..39be46b 100644
@@ -356,7 +356,7 @@ static struct platform_driver static_funnel_driver = {
 	.remove          = static_funnel_remove,
 	.driver         = {
 		.name   = "coresight-static-funnel",
-		.owner	= THIS_MODULE,
+		/* THIS_MODULE is taken care of by platform_driver_register() */
 		.of_match_table = static_funnel_match,
 		.acpi_match_table = ACPI_PTR(static_funnel_ids),
 		.pm	= &funnel_dev_pm_ops,
drivers/hwtracing/coresight/coresight-replicator.c +1 -1
index 62afdde..6772f23 100644
@@ -374,7 +374,7 @@ static struct platform_driver static_replicator_driver = {
 	.remove         = static_replicator_remove,
 	.driver         = {
 		.name   = "coresight-static-replicator",
-		.owner	= THIS_MODULE,
+		/* THIS_MODULE is taken care of by platform_driver_register() */
 		.of_match_table = of_match_ptr(static_replicator_match),
 		.acpi_match_table = ACPI_PTR(static_replicator_acpi_ids),
 		.pm	= &replicator_dev_pm_ops,

--
2.8.1

#1 lore raw
Quoted 28 lines · Qi Liu

As THIS_MODULE has been set in platform_driver_register(), so remove it from static funnel driver and static replicator driver to avoid set it twice.

---
 drivers/hwtracing/coresight/coresight-funnel.c     | 2 +-
 drivers/hwtracing/coresight/coresight-replicator.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/hwtracing/coresight/coresight-funnel.c +1 -1
index af40814..39be46b 100644
@@ -356,7 +356,7 @@ static struct platform_driver static_funnel_driver = {
 	.remove          = static_funnel_remove,
 	.driver         = {
 		.name   = "coresight-static-funnel",
-		.owner	= THIS_MODULE,
+		/* THIS_MODULE is taken care of by platform_driver_register() */
 		.of_match_table = static_funnel_match,
 		.acpi_match_table = ACPI_PTR(static_funnel_ids),
 		.pm	= &funnel_dev_pm_ops,
drivers/hwtracing/coresight/coresight-replicator.c +0 -0
index 62afdde..6772f23 100644

drivers/hwtracing/coresight/coresight-replicator.c static struct platform_driver static_replicator_driver = { · line 377

Quoted 5 lines
drivers/hwtracing/coresight/coresight-replicator.c +1 -1
@@ -374,7 +374,7 @@ static struct platform_driver static_replicator_driver = {
 	.remove         = static_replicator_remove,
 	.driver         = {
 		.name   = "coresight-static-replicator",
-		.owner	= THIS_MODULE,
+		/* THIS_MODULE is taken care of by platform_driver_register() */

I have applied your patch. Next time please version you revisions.

Thanks,
Mathieu

Quoted 6 lines
drivers/hwtracing/coresight/coresight-replicator.c +0 -1
 		.of_match_table = of_match_ptr(static_replicator_match),
 		.acpi_match_table = ACPI_PTR(static_replicator_acpi_ids),
 		.pm	= &replicator_dev_pm_ops,
--

2.8.1