dt-bindings:iio: yet more txt to yam conversions

From: Jonathan Cameron <[email protected]>

Simple direct conversion from txt to yaml as part of a general aim of converting all IIO bindings to this machine readable format.

Signed-off-by Jonathan Cameron <[email protected]>

Cc Phil Reid <[email protected]>

---
  .../bindings/iio/potentiometer/ad5272.txt     | 27 ----------
  .../iio/potentiometer/adi,ad5272.yaml         | 50 +++++++++++++++++++
  2 files changed, 50 insertions(+), 27 deletions(-)

Documentation/devicetree/bindings/iio/potentiometer/ad5272.txt deleted +0 -27

deleted file mode 100644
index f9b2eef946aa..000000000000
@@ -1,27 +0,0 @@
-* Analog Devices AD5272 digital potentiometer
-
-The node for this device must be a child node of a I2C controller, hence
-all mandatory properties for your controller must be specified. See directory:
-
-        Documentation/devicetree/bindings/i2c
-
-for more details.
-
-Required properties:
-	- compatible:  	Must be one of the following, depending on the model:
-			adi,ad5272-020
-			adi,ad5272-050
-			adi,ad5272-100
-			adi,ad5274-020
-			adi,ad5274-100
-
-Optional properties:
- - reset-gpios: GPIO specification for the RESET input. This is an
-		active low signal to the AD5272.
-
-Example:
-ad5272: potentiometer@2f {
-	reg = <0x2F>;
-	compatible = "adi,ad5272-020";
-	reset-gpios = <&gpio3 6 GPIO_ACTIVE_HIGH>;
-};

Documentation/devicetree/bindings/iio/potentiometer/adi,ad5272.yaml new file +50 -0

new file mode 100644
index 000000000000..b9b7d383bff1
@@ -0,0 +1,50 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/iio/potentiometer/adi,ad5272.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Analog Devices AD5272 digital potentiometer
+
+maintainers:
+  - Phil Reid <[email protected]>
+
+description: |
+  Datasheet: https://www.analog.com/en/products/ad5272.html
+
+properties:
+  compatible:
+    enum:
+      - adi,ad5272-020
+      - adi,ad5272-050
+      - adi,ad5272-100
+      - adi,ad5274-020
+      - adi,ad5274-100
+
+  reg:
+    maxItems: 1
+
+  reset-gpios:
+    description:
+      Active low signal to the AD5272 RESET input.
+
+additionalProperties: false
+
+required:
+  - compatible
+  - reg
+
+examples:
+  - |
+    #include <dt-bindings/gpio/gpio.h>
+    i2c {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        potentiometer@2f {
+            compatible = "adi,ad5272-020";
+            reg = <0x2F>;
+            reset-gpios = <&gpio3 6 GPIO_ACTIVE_HIGH>;
+        };
+    };
+...

From: Jonathan Cameron <[email protected]>

Simple direct conversion from txt to yaml as part of a general aim of converting all IIO bindings to this machine readable format.

Signed-off-by Jonathan Cameron <[email protected]>

Cc Phil Reid <[email protected]>

---
 .../bindings/iio/potentiometer/ad5272.txt     | 27 ----------
 .../iio/potentiometer/adi,ad5272.yaml         | 50 +++++++++++++++++++
 2 files changed, 50 insertions(+), 27 deletions(-)

Documentation/devicetree/bindings/iio/potentiometer/ad5272.txt deleted +0 -27

deleted file mode 100644
index f9b2eef946aa..000000000000
@@ -1,27 +0,0 @@
-* Analog Devices AD5272 digital potentiometer
-
-The node for this device must be a child node of a I2C controller, hence
-all mandatory properties for your controller must be specified. See directory:
-
-        Documentation/devicetree/bindings/i2c
-
-for more details.
-
-Required properties:
-	- compatible:  	Must be one of the following, depending on the model:
-			adi,ad5272-020
-			adi,ad5272-050
-			adi,ad5272-100
-			adi,ad5274-020
-			adi,ad5274-100
-
-Optional properties:
- - reset-gpios: GPIO specification for the RESET input. This is an
-		active low signal to the AD5272.
-
-Example:
-ad5272: potentiometer@2f {
-	reg = <0x2F>;
-	compatible = "adi,ad5272-020";
-	reset-gpios = <&gpio3 6 GPIO_ACTIVE_HIGH>;
-};

Documentation/devicetree/bindings/iio/potentiometer/adi,ad5272.yaml new file +19 -0

new file mode 100644
index 000000000000..b9b7d383bff1
@@ -0,0 +1,50 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/iio/potentiometer/adi,ad5272.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Analog Devices AD5272 digital potentiometer
+
+maintainers:
+  - Phil Reid <[email protected]>
+
+description: |
+  Datasheet: https://www.analog.com/en/products/ad5272.html
+
+properties:
+  compatible:
+    enum:
+      - adi,ad5272-020
+      - adi,ad5272-050

Documentation/devicetree/bindings/iio/potentiometer/adi,ad5272.yaml new file +8 -0

+
+additionalProperties: false
+
+required:
+  - compatible
+  - reg
+
+examples:

Documentation/devicetree/bindings/iio/potentiometer/adi,ad5272.yaml new file +3 -0

+        };
+    };
+...

Signature · 1 line

2.28.0

Quoted 70 lines · Jonathan Cameron

From: Jonathan Cameron <[email protected]>

Simple direct conversion from txt to yaml as part of a general aim of converting all IIO bindings to this machine readable format.

Signed-off-by Jonathan Cameron <[email protected]>

Cc Phil Reid <[email protected]>

---
 .../bindings/iio/potentiometer/ad5272.txt     | 27 ----------
 .../iio/potentiometer/adi,ad5272.yaml         | 50 +++++++++++++++++++
 2 files changed, 50 insertions(+), 27 deletions(-)

Documentation/devicetree/bindings/iio/potentiometer/ad5272.txt deleted +0 -27

deleted file mode 100644
index f9b2eef946aa..000000000000
@@ -1,27 +0,0 @@
-* Analog Devices AD5272 digital potentiometer
-
-The node for this device must be a child node of a I2C controller, hence
-all mandatory properties for your controller must be specified. See directory:
-
-        Documentation/devicetree/bindings/i2c
-
-for more details.
-
-Required properties:
-	- compatible:  	Must be one of the following, depending on the model:
-			adi,ad5272-020
-			adi,ad5272-050
-			adi,ad5272-100
-			adi,ad5274-020
-			adi,ad5274-100
-
-Optional properties:
- - reset-gpios: GPIO specification for the RESET input. This is an
-		active low signal to the AD5272.
-
-Example:
-ad5272: potentiometer@2f {
-	reg = <0x2F>;
-	compatible = "adi,ad5272-020";
-	reset-gpios = <&gpio3 6 GPIO_ACTIVE_HIGH>;
-};

Documentation/devicetree/bindings/iio/potentiometer/adi,ad5272.yaml new file +19 -0

new file mode 100644
index 000000000000..b9b7d383bff1
@@ -0,0 +1,50 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/iio/potentiometer/adi,ad5272.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Analog Devices AD5272 digital potentiometer
+
+maintainers:
+  - Phil Reid <[email protected]>
+
+description: |
+  Datasheet: https://www.analog.com/en/products/ad5272.html
+
+properties:
+  compatible:
+    enum:
+      - adi,ad5272-020
+      - adi,ad5272-050

Documentation/devicetree/bindings/iio/potentiometer/adi,ad5272.yaml line 29

Quoted 10 lines

Documentation/devicetree/bindings/iio/potentiometer/adi,ad5272.yaml new file +10 -0

+      - adi,ad5272-100
+      - adi,ad5274-020
+      - adi,ad5274-100
+
+  reg:
+    maxItems: 1
+
+  reset-gpios:
+    description:
+      Active low signal to the AD5272 RESET input.  

Not a new problem, but active low or...

Quoted 12 lines

Documentation/devicetree/bindings/iio/potentiometer/adi,ad5272.yaml new file +12 -0

+
+additionalProperties: false
+
+required:
+  - compatible
+  - reg
+
+examples:
+  - |
+    #include <dt-bindings/gpio/gpio.h>
+    i2c {
+        #address-cells = <1>;

Documentation/devicetree/bindings/iio/potentiometer/adi,ad5272.yaml line 47

Quoted 6 lines

Documentation/devicetree/bindings/iio/potentiometer/adi,ad5272.yaml new file +6 -0

+        #size-cells = <0>;
+
+        potentiometer@2f {
+            compatible = "adi,ad5272-020";
+            reg = <0x2F>;
+            reset-gpios = <&gpio3 6 GPIO_ACTIVE_HIGH>;  

active high?

Quoted 7 lines

Documentation/devicetree/bindings/iio/potentiometer/adi,ad5272.yaml new file +3 -0

+        };
+    };
+...

Signature · 1 line

2.28.0

Quoted 96 lines · On Tue, 3 Nov 2020 10:10:39 -0600 Rob Herring <[email protected]> wrote:

Quoted 70 lines · Jonathan Cameron

From: Jonathan Cameron <[email protected]>

Simple direct conversion from txt to yaml as part of a general aim of converting all IIO bindings to this machine readable format.

Signed-off-by Jonathan Cameron <[email protected]>

Cc Phil Reid <[email protected]>

---
  .../bindings/iio/potentiometer/ad5272.txt     | 27 ----------
  .../iio/potentiometer/adi,ad5272.yaml         | 50 +++++++++++++++++++
  2 files changed, 50 insertions(+), 27 deletions(-)

Documentation/devicetree/bindings/iio/potentiometer/ad5272.txt deleted +0 -27

deleted file mode 100644
index f9b2eef946aa..000000000000
@@ -1,27 +0,0 @@
-* Analog Devices AD5272 digital potentiometer
-
-The node for this device must be a child node of a I2C controller, hence
-all mandatory properties for your controller must be specified. See directory:
-
-        Documentation/devicetree/bindings/i2c
-
-for more details.
-
-Required properties:
-	- compatible:  	Must be one of the following, depending on the model:
-			adi,ad5272-020
-			adi,ad5272-050
-			adi,ad5272-100
-			adi,ad5274-020
-			adi,ad5274-100
-
-Optional properties:
- - reset-gpios: GPIO specification for the RESET input. This is an
-		active low signal to the AD5272.
-
-Example:
-ad5272: potentiometer@2f {
-	reg = <0x2F>;
-	compatible = "adi,ad5272-020";
-	reset-gpios = <&gpio3 6 GPIO_ACTIVE_HIGH>;
-};

Documentation/devicetree/bindings/iio/potentiometer/adi,ad5272.yaml new file +19 -0

new file mode 100644
index 000000000000..b9b7d383bff1
@@ -0,0 +1,50 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/iio/potentiometer/adi,ad5272.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Analog Devices AD5272 digital potentiometer
+
+maintainers:
+  - Phil Reid <[email protected]>
+
+description: |
+  Datasheet: https://www.analog.com/en/products/ad5272.html
+
+properties:
+  compatible:
+    enum:
+      - adi,ad5272-020
+      - adi,ad5272-050

Documentation/devicetree/bindings/iio/potentiometer/adi,ad5272.yaml line 29

Quoted 10 lines

Documentation/devicetree/bindings/iio/potentiometer/adi,ad5272.yaml new file +10 -0

+      - adi,ad5272-100
+      - adi,ad5274-020
+      - adi,ad5274-100
+
+  reg:
+    maxItems: 1
+
+  reset-gpios:
+    description:
+      Active low signal to the AD5272 RESET input.

Not a new problem, but active low or...

Quoted 12 lines

Documentation/devicetree/bindings/iio/potentiometer/adi,ad5272.yaml new file +12 -0

+
+additionalProperties: false
+
+required:
+  - compatible
+  - reg
+
+examples:
+  - |
+    #include <dt-bindings/gpio/gpio.h>
+    i2c {
+        #address-cells = <1>;

Quoted 8 lines

Documentation/devicetree/bindings/iio/potentiometer/adi,ad5272.yaml line 47

Quoted 6 lines

Documentation/devicetree/bindings/iio/potentiometer/adi,ad5272.yaml new file +6 -0

+        #size-cells = <0>;
+
+        potentiometer@2f {
+            compatible = "adi,ad5272-020";
+            reg = <0x2F>;
+            reset-gpios = <&gpio3 6 GPIO_ACTIVE_HIGH>;

active high?

Good spot! @Phil. Looks like the driver is setting the reset line to
0 and then to 1 to come out of reset. So effectively inverting the logic.
I'm tempted to be cynical and suggest we just drop the comment above and leave it vague but is there a better way we can clarify this?

Quoted 8 lines

Quoted 8 lines

Documentation/devicetree/bindings/iio/potentiometer/adi,ad5272.yaml new file +3 -0

+        };
+    };
+...

Signature · 1 line

2.28.0

Quoted 108 lines · Jonathan Cameron

Quoted 96 lines · On Tue, 3 Nov 2020 10:10:39 -0600 Rob Herring <[email protected]> wrote:

Quoted 70 lines · Jonathan Cameron

From: Jonathan Cameron <[email protected]>

Simple direct conversion from txt to yaml as part of a general aim of converting all IIO bindings to this machine readable format.

Signed-off-by Jonathan Cameron <[email protected]>

Cc Phil Reid <[email protected]>

---
  .../bindings/iio/potentiometer/ad5272.txt     | 27 ----------
  .../iio/potentiometer/adi,ad5272.yaml         | 50 +++++++++++++++++++
  2 files changed, 50 insertions(+), 27 deletions(-)

Documentation/devicetree/bindings/iio/potentiometer/ad5272.txt deleted +0 -27

deleted file mode 100644
index f9b2eef946aa..000000000000
@@ -1,27 +0,0 @@
-* Analog Devices AD5272 digital potentiometer
-
-The node for this device must be a child node of a I2C controller, hence
-all mandatory properties for your controller must be specified. See directory:
-
-        Documentation/devicetree/bindings/i2c
-
-for more details.
-
-Required properties:
-   - compatible:   Must be one of the following, depending on the model:
-                   adi,ad5272-020
-                   adi,ad5272-050
-                   adi,ad5272-100
-                   adi,ad5274-020
-                   adi,ad5274-100
-
-Optional properties:
- - reset-gpios: GPIO specification for the RESET input. This is an
-           active low signal to the AD5272.
-
-Example:
-ad5272: potentiometer@2f {
-   reg = <0x2F>;
-   compatible = "adi,ad5272-020";
-   reset-gpios = <&gpio3 6 GPIO_ACTIVE_HIGH>;
-};

Documentation/devicetree/bindings/iio/potentiometer/adi,ad5272.yaml new file +19 -0

new file mode 100644
index 000000000000..b9b7d383bff1
@@ -0,0 +1,50 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/iio/potentiometer/adi,ad5272.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Analog Devices AD5272 digital potentiometer
+
+maintainers:
+  - Phil Reid <[email protected]>
+
+description: |
+  Datasheet: https://www.analog.com/en/products/ad5272.html
+
+properties:
+  compatible:
+    enum:
+      - adi,ad5272-020
+      - adi,ad5272-050

Documentation/devicetree/bindings/iio/potentiometer/adi,ad5272.yaml line 29

Quoted 10 lines

Documentation/devicetree/bindings/iio/potentiometer/adi,ad5272.yaml new file +10 -0

+      - adi,ad5272-100
+      - adi,ad5274-020
+      - adi,ad5274-100
+
+  reg:
+    maxItems: 1
+
+  reset-gpios:
+    description:
+      Active low signal to the AD5272 RESET input.

Not a new problem, but active low or...

Quoted 12 lines

Documentation/devicetree/bindings/iio/potentiometer/adi,ad5272.yaml new file +12 -0

+
+additionalProperties: false
+
+required:
+  - compatible
+  - reg
+
+examples:
+  - |
+    #include <dt-bindings/gpio/gpio.h>
+    i2c {
+        #address-cells = <1>;

Quoted 8 lines

Documentation/devicetree/bindings/iio/potentiometer/adi,ad5272.yaml line 47

Quoted 6 lines

Documentation/devicetree/bindings/iio/potentiometer/adi,ad5272.yaml new file +6 -0

+        #size-cells = <0>;
+
+        potentiometer@2f {
+            compatible = "adi,ad5272-020";
+            reg = <0x2F>;
+            reset-gpios = <&gpio3 6 GPIO_ACTIVE_HIGH>;

active high?

Quoted 4 lines

Good spot! @Phil. Looks like the driver is setting the reset line to
0 and then to 1 to come out of reset. So effectively inverting the logic.
I'm tempted to be cynical and suggest we just drop the comment above and leave it vague but is there a better way we can clarify this?

Had a look at a few other iio drivers in regards how they handle the same thing. A few do the same thing, ie: the drivers are written to set gpio low to assert reset. So they need the device tree gpio config to be active high to work correctly. Not sure if this prevents users setting things up as open collector.

Quoted 115 lines · Phil Reid

Quoted 108 lines · Jonathan Cameron

Quoted 96 lines · On Tue, 3 Nov 2020 10:10:39 -0600 Rob Herring <[email protected]> wrote:

Quoted 70 lines · Jonathan Cameron

From: Jonathan Cameron <[email protected]>

Simple direct conversion from txt to yaml as part of a general aim of converting all IIO bindings to this machine readable format.

Signed-off-by Jonathan Cameron <[email protected]>

Cc Phil Reid <[email protected]>

---
   .../bindings/iio/potentiometer/ad5272.txt     | 27 ----------
   .../iio/potentiometer/adi,ad5272.yaml         | 50 +++++++++++++++++++
   2 files changed, 50 insertions(+), 27 deletions(-)

Documentation/devicetree/bindings/iio/potentiometer/ad5272.txt deleted +0 -27

deleted file mode 100644
index f9b2eef946aa..000000000000
@@ -1,27 +0,0 @@
-* Analog Devices AD5272 digital potentiometer
-
-The node for this device must be a child node of a I2C controller, hence
-all mandatory properties for your controller must be specified. See directory:
-
-        Documentation/devicetree/bindings/i2c
-
-for more details.
-
-Required properties:
-   - compatible:   Must be one of the following, depending on the model:
-                   adi,ad5272-020
-                   adi,ad5272-050
-                   adi,ad5272-100
-                   adi,ad5274-020
-                   adi,ad5274-100
-
-Optional properties:
- - reset-gpios: GPIO specification for the RESET input. This is an
-           active low signal to the AD5272.
-
-Example:
-ad5272: potentiometer@2f {
-   reg = <0x2F>;
-   compatible = "adi,ad5272-020";
-   reset-gpios = <&gpio3 6 GPIO_ACTIVE_HIGH>;
-};

Documentation/devicetree/bindings/iio/potentiometer/adi,ad5272.yaml new file +19 -0

new file mode 100644
index 000000000000..b9b7d383bff1
@@ -0,0 +1,50 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/iio/potentiometer/adi,ad5272.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Analog Devices AD5272 digital potentiometer
+
+maintainers:
+  - Phil Reid <[email protected]>
+
+description: |
+  Datasheet: https://www.analog.com/en/products/ad5272.html
+
+properties:
+  compatible:
+    enum:
+      - adi,ad5272-020
+      - adi,ad5272-050

Documentation/devicetree/bindings/iio/potentiometer/adi,ad5272.yaml line 29

Quoted 10 lines

Documentation/devicetree/bindings/iio/potentiometer/adi,ad5272.yaml new file +10 -0

+      - adi,ad5272-100
+      - adi,ad5274-020
+      - adi,ad5274-100
+
+  reg:
+    maxItems: 1
+
+  reset-gpios:
+    description:
+      Active low signal to the AD5272 RESET input.

Not a new problem, but active low or...

Quoted 12 lines

Documentation/devicetree/bindings/iio/potentiometer/adi,ad5272.yaml new file +12 -0

+
+additionalProperties: false
+
+required:
+  - compatible
+  - reg
+
+examples:
+  - |
+    #include <dt-bindings/gpio/gpio.h>
+    i2c {
+        #address-cells = <1>;

Quoted 8 lines

Documentation/devicetree/bindings/iio/potentiometer/adi,ad5272.yaml line 47

Quoted 6 lines

Documentation/devicetree/bindings/iio/potentiometer/adi,ad5272.yaml new file +6 -0

+        #size-cells = <0>;
+
+        potentiometer@2f {
+            compatible = "adi,ad5272-020";
+            reg = <0x2F>;
+            reset-gpios = <&gpio3 6 GPIO_ACTIVE_HIGH>;

active high?

Quoted 4 lines

Good spot! @Phil. Looks like the driver is setting the reset line to
0 and then to 1 to come out of reset. So effectively inverting the logic.
I'm tempted to be cynical and suggest we just drop the comment above and leave it vague but is there a better way we can clarify this?

Quoted 4 lines

Had a look at a few other iio drivers in regards how they handle the same thing. A few do the same thing, ie: the drivers are written to set gpio low to assert reset. So they need the device tree gpio config to be active high to work correctly. Not sure if this prevents users setting things up as open collector.

The driver is wrong. 'gpiod_set_value(reset_gpio, 1);' should assert reset as '1' here is set to (reset) active state as defined in the DT.

Given no upstream users, maybe it can be fixed...

We need to make 'reset-gpios' implemented by a reset controller and stop letting drivers get it wrong.

Quoted 126 lines · Rob Herring

Quoted 115 lines · Phil Reid

Quoted 108 lines · Jonathan Cameron

Quoted 96 lines · On Tue, 3 Nov 2020 10:10:39 -0600 Rob Herring <[email protected]> wrote:

Quoted 70 lines · Jonathan Cameron

From: Jonathan Cameron <[email protected]>

Simple direct conversion from txt to yaml as part of a general aim of converting all IIO bindings to this machine readable format.

Signed-off-by Jonathan Cameron <[email protected]>

Cc Phil Reid <[email protected]>

---
   .../bindings/iio/potentiometer/ad5272.txt     | 27 ---------- .../iio/potentiometer/adi,ad5272.yaml         | 50 +++++++++++++++++++

   2 files changed, 50 insertions(+), 27 deletions(-)

Documentation/devicetree/bindings/iio/potentiometer/ad5272.txt deleted +0 -27

deleted file mode 100644
index f9b2eef946aa..000000000000
@@ -1,27 +0,0 @@
-* Analog Devices AD5272 digital potentiometer
-
-The node for this device must be a child node of a I2C controller, hence
-all mandatory properties for your controller must be specified. See directory:
-
-        Documentation/devicetree/bindings/i2c
-
-for more details.
-
-Required properties:
-   - compatible:   Must be one of the following, depending on the model:
-                   adi,ad5272-020
-                   adi,ad5272-050
-                   adi,ad5272-100
-                   adi,ad5274-020
-                   adi,ad5274-100
-
-Optional properties:
- - reset-gpios: GPIO specification for the RESET input. This is an
-           active low signal to the AD5272.
-
-Example:
-ad5272: potentiometer@2f {
-   reg = <0x2F>;
-   compatible = "adi,ad5272-020";
-   reset-gpios = <&gpio3 6 GPIO_ACTIVE_HIGH>;
-};

Documentation/devicetree/bindings/iio/potentiometer/adi,ad5272.yaml new file +19 -0

new file mode 100644
index 000000000000..b9b7d383bff1
@@ -0,0 +1,50 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/iio/potentiometer/adi,ad5272.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Analog Devices AD5272 digital potentiometer
+
+maintainers:
+  - Phil Reid <[email protected]>
+
+description: |
+  Datasheet: https://www.analog.com/en/products/ad5272.html
+
+properties:
+  compatible:
+    enum:
+      - adi,ad5272-020
+      - adi,ad5272-050

Documentation/devicetree/bindings/iio/potentiometer/adi,ad5272.yaml line 29

Quoted 10 lines

Documentation/devicetree/bindings/iio/potentiometer/adi,ad5272.yaml new file +10 -0

+      - adi,ad5272-100
+      - adi,ad5274-020
+      - adi,ad5274-100
+
+  reg:
+    maxItems: 1
+
+  reset-gpios:
+    description:
+      Active low signal to the AD5272 RESET input.

Not a new problem, but active low or...

Quoted 12 lines

Documentation/devicetree/bindings/iio/potentiometer/adi,ad5272.yaml new file +12 -0

+
+additionalProperties: false
+
+required:
+  - compatible
+  - reg
+
+examples:
+  - |
+    #include <dt-bindings/gpio/gpio.h>
+    i2c {
+        #address-cells = <1>;

Quoted 8 lines

Documentation/devicetree/bindings/iio/potentiometer/adi,ad5272.yaml line 47

Quoted 6 lines

Documentation/devicetree/bindings/iio/potentiometer/adi,ad5272.yaml new file +6 -0

+        #size-cells = <0>;
+
+        potentiometer@2f {
+            compatible = "adi,ad5272-020";
+            reg = <0x2F>;
+            reset-gpios = <&gpio3 6 GPIO_ACTIVE_HIGH>;

active high?

Quoted 4 lines

Good spot!  @Phil.  Looks like the driver is setting the reset line to 0 and then to 1 to come out of reset.   So effectively inverting the logic. I'm tempted to be cynical and suggest we just drop the comment above and leave it vague but is there a better way we can clarify this?

Quoted 4 lines

Had a look at a few other iio drivers in regards how they handle the same thing. A few do the same thing, ie: the drivers are written to set gpio low to assert reset. So they need the device tree gpio config to be active high to work correctly. Not sure if this prevents users setting things up as open collector.

The driver is wrong. 'gpiod_set_value(reset_gpio, 1);' should assert reset as '1' here is set to (reset) active state as defined in the DT.

Given no upstream users, maybe it can be fixed...

Quoted 3 lines

We need to make 'reset-gpios' implemented by a reset controller and stop letting drivers get it wrong.

Yes I agree, the driver is wrong, think I just copied one of the other drivers for the pattern. I'd be happy to change it, there's probably few (if any) users.

Having a software interface to assert the reset would be nice.

Quoted 131 lines · Phil Reid

Quoted 129 lines · Rob Herring

Quoted 115 lines · Phil Reid

Quoted 108 lines · Jonathan Cameron

Quoted 96 lines · On Tue, 3 Nov 2020 10:10:39 -0600 Rob Herring <[email protected]> wrote:

Quoted 70 lines · Jonathan Cameron

From: Jonathan Cameron <[email protected]>

Simple direct conversion from txt to yaml as part of a general aim of converting all IIO bindings to this machine readable format.

Signed-off-by Jonathan Cameron <[email protected]>

Cc Phil Reid <[email protected]>

---
   .../bindings/iio/potentiometer/ad5272.txt     | 27 ---------- .../iio/potentiometer/adi,ad5272.yaml         | 50 +++++++++++++++++++

   2 files changed, 50 insertions(+), 27 deletions(-)

Documentation/devicetree/bindings/iio/potentiometer/ad5272.txt deleted +0 -27

deleted file mode 100644
index f9b2eef946aa..000000000000
@@ -1,27 +0,0 @@
-* Analog Devices AD5272 digital potentiometer
-
-The node for this device must be a child node of a I2C controller, hence
-all mandatory properties for your controller must be specified. See directory:
-
-        Documentation/devicetree/bindings/i2c
-
-for more details.
-
-Required properties:
-   - compatible:   Must be one of the following, depending on the model:
-                   adi,ad5272-020
-                   adi,ad5272-050
-                   adi,ad5272-100
-                   adi,ad5274-020
-                   adi,ad5274-100
-
-Optional properties:
- - reset-gpios: GPIO specification for the RESET input. This is an
-           active low signal to the AD5272.
-
-Example:
-ad5272: potentiometer@2f {
-   reg = <0x2F>;
-   compatible = "adi,ad5272-020";
-   reset-gpios = <&gpio3 6 GPIO_ACTIVE_HIGH>;
-};

Documentation/devicetree/bindings/iio/potentiometer/adi,ad5272.yaml new file +19 -0

new file mode 100644
index 000000000000..b9b7d383bff1
@@ -0,0 +1,50 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/iio/potentiometer/adi,ad5272.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Analog Devices AD5272 digital potentiometer
+
+maintainers:
+  - Phil Reid <[email protected]>
+
+description: |
+  Datasheet: https://www.analog.com/en/products/ad5272.html
+
+properties:
+  compatible:
+    enum:
+      - adi,ad5272-020
+      - adi,ad5272-050

Documentation/devicetree/bindings/iio/potentiometer/adi,ad5272.yaml line 29

Quoted 10 lines

Documentation/devicetree/bindings/iio/potentiometer/adi,ad5272.yaml new file +10 -0

+      - adi,ad5272-100
+      - adi,ad5274-020
+      - adi,ad5274-100
+
+  reg:
+    maxItems: 1
+
+  reset-gpios:
+    description:
+      Active low signal to the AD5272 RESET input.  

Not a new problem, but active low or...

Quoted 12 lines

Documentation/devicetree/bindings/iio/potentiometer/adi,ad5272.yaml new file +12 -0

+
+additionalProperties: false
+
+required:
+  - compatible
+  - reg
+
+examples:
+  - |
+    #include <dt-bindings/gpio/gpio.h>
+    i2c {
+        #address-cells = <1>;

Quoted 8 lines

Documentation/devicetree/bindings/iio/potentiometer/adi,ad5272.yaml line 47

Quoted 6 lines

Documentation/devicetree/bindings/iio/potentiometer/adi,ad5272.yaml new file +6 -0

+        #size-cells = <0>;
+
+        potentiometer@2f {
+            compatible = "adi,ad5272-020";
+            reg = <0x2F>;
+            reset-gpios = <&gpio3 6 GPIO_ACTIVE_HIGH>;  

active high?

Quoted 4 lines

Good spot!  @Phil.  Looks like the driver is setting the reset line to 0 and then to 1 to come out of reset.   So effectively inverting the logic. I'm tempted to be cynical and suggest we just drop the comment above and leave it vague but is there a better way we can clarify this?

Quoted 4 lines

Had a look at a few other iio drivers in regards how they handle the same thing. A few do the same thing, ie: the drivers are written to set gpio low to assert reset. So they need the device tree gpio config to be active high to work correctly. Not sure if this prevents users setting things up as open collector.

The driver is wrong. 'gpiod_set_value(reset_gpio, 1);' should assert reset as '1' here is set to (reset) active state as defined in the DT.

Given no upstream users, maybe it can be fixed...

We need to make 'reset-gpios' implemented by a reset controller and stop letting drivers get it wrong.

Quoted 6 lines

Yes I agree, the driver is wrong, think I just copied one of the other drivers for the pattern. I'd be happy to change it, there's probably few (if any) users.

Having a software interface to assert the reset would be nice.

If there's no comments against the change, I'll submit a patch in the next day or so.

Quoted 4 lines

Quoted 3 lines

Having a software interface to assert the reset would be nice.

If there's no comments against the change, I'll submit a patch in the next day or so.

Hi Phil,

So I've fixed the binding example up to have the sense as ACTIVE_LOW as discussed. If you have time to flip the sense round in the driver to match that it would be great and I'd propose we then mark that as suitable for stable so that we get it backported into existing trees. We could also spin a patch to the txt binding but perhaps that is more effort than is needed here. If I get time before you do I might send a proposed fix patch.

Hopefully anyone then using it will get the sense right and we won't accidentally break anyone.

At some point soon I'll also try and audit similar cases and hopefully we will get those fixed up as well. Obviously if anyone else wants to take a look at that it would be much appreciated!

From: Jonathan Cameron <[email protected]>

This binding is very simple, but I think the very large number of compatible values make it unsuitable for moving to trivial-devices.yaml. Main change in the conversion was reordering the compatible list to numerical order.

Signed-off-by Jonathan Cameron <[email protected]>

Cc Slawomir Stepien <[email protected]>

---
 .../bindings/iio/potentiometer/mcp4131.txt    |  84 ---------------
 .../iio/potentiometer/microchip,mcp4131.yaml  | 102 ++++++++++++++++++
 2 files changed, 102 insertions(+), 84 deletions(-)

Documentation/devicetree/bindings/iio/potentiometer/mcp4131.txt deleted +0 -84

deleted file mode 100644
index 3ccba16f7035..000000000000
@@ -1,84 +0,0 @@
-* Microchip MCP413X/414X/415X/416X/423X/424X/425X/426X Digital Potentiometer
-  driver
-
-The node for this driver must be a child node of a SPI controller, hence
-all mandatory properties described in
-
-        Documentation/devicetree/bindings/spi/spi-bus.txt
-
-must be specified.
-
-Required properties:
-	- compatible:  	Must be one of the following, depending on the
-			model:
-			"microchip,mcp4131-502"
-			"microchip,mcp4131-103"
-			"microchip,mcp4131-503"
-			"microchip,mcp4131-104"
-			"microchip,mcp4132-502"
-			"microchip,mcp4132-103"
-			"microchip,mcp4132-503"
-			"microchip,mcp4132-104"
-			"microchip,mcp4141-502"
-			"microchip,mcp4141-103"
-			"microchip,mcp4141-503"
-			"microchip,mcp4141-104"
-			"microchip,mcp4142-502"
-			"microchip,mcp4142-103"
-			"microchip,mcp4142-503"
-			"microchip,mcp4142-104"
-			"microchip,mcp4151-502"
-			"microchip,mcp4151-103"
-			"microchip,mcp4151-503"
-			"microchip,mcp4151-104"
-			"microchip,mcp4152-502"
-			"microchip,mcp4152-103"
-			"microchip,mcp4152-503"
-			"microchip,mcp4152-104"
-			"microchip,mcp4161-502"
-			"microchip,mcp4161-103"
-			"microchip,mcp4161-503"
-			"microchip,mcp4161-104"
-			"microchip,mcp4162-502"
-			"microchip,mcp4162-103"
-			"microchip,mcp4162-503"
-			"microchip,mcp4162-104"
-			"microchip,mcp4231-502"
-			"microchip,mcp4231-103"
-			"microchip,mcp4231-503"
-			"microchip,mcp4231-104"
-			"microchip,mcp4232-502"
-			"microchip,mcp4232-103"
-			"microchip,mcp4232-503"
-			"microchip,mcp4232-104"
-			"microchip,mcp4241-502"
-			"microchip,mcp4241-103"
-			"microchip,mcp4241-503"
-			"microchip,mcp4241-104"
-			"microchip,mcp4242-502"
-			"microchip,mcp4242-103"
-			"microchip,mcp4242-503"
-			"microchip,mcp4242-104"
-			"microchip,mcp4251-502"
-			"microchip,mcp4251-103"
-			"microchip,mcp4251-503"
-			"microchip,mcp4251-104"
-			"microchip,mcp4252-502"
-			"microchip,mcp4252-103"
-			"microchip,mcp4252-503"
-			"microchip,mcp4252-104"
-			"microchip,mcp4261-502"
-			"microchip,mcp4261-103"
-			"microchip,mcp4261-503"
-			"microchip,mcp4261-104"
-			"microchip,mcp4262-502"
-			"microchip,mcp4262-103"
-			"microchip,mcp4262-503"
-			"microchip,mcp4262-104"
-
-Example:
-mcp4131: mcp4131@0 {
-	compatible = "mcp4131-502";
-	reg = <0>;
-	spi-max-frequency = <500000>;
-};

Documentation/devicetree/bindings/iio/potentiometer/microchip,mcp4131.yaml new file +102 -0

new file mode 100644
index 000000000000..834d17ae3730
@@ -0,0 +1,102 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/iio/potentiometer/microchip,mcp4131.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Microchip MCP413X/414X/415X/416X/423X/424X/425X/426X Digital Potentiometer
+maintainers:
+  - Slawomir Stepien <[email protected]>
+
+properties:
+  compatible:
+    enum:
+      - microchip,mcp4131-103
+      - microchip,mcp4131-104
+      - microchip,mcp4131-502
+      - microchip,mcp4131-503
+      - microchip,mcp4132-103
+      - microchip,mcp4132-104
+      - microchip,mcp4132-502
+      - microchip,mcp4132-503
+      - microchip,mcp4141-103
+      - microchip,mcp4141-104
+      - microchip,mcp4141-502
+      - microchip,mcp4141-503
+      - microchip,mcp4142-103
+      - microchip,mcp4142-104
+      - microchip,mcp4142-502
+      - microchip,mcp4142-503
+      - microchip,mcp4151-103
+      - microchip,mcp4151-104
+      - microchip,mcp4151-502
+      - microchip,mcp4151-503
+      - microchip,mcp4152-103
+      - microchip,mcp4152-104
+      - microchip,mcp4152-502
+      - microchip,mcp4152-503
+      - microchip,mcp4161-103
+      - microchip,mcp4161-104
+      - microchip,mcp4161-502
+      - microchip,mcp4161-503
+      - microchip,mcp4162-103
+      - microchip,mcp4162-104
+      - microchip,mcp4162-502
+      - microchip,mcp4162-503
+      - microchip,mcp4231-103
+      - microchip,mcp4231-104
+      - microchip,mcp4231-502
+      - microchip,mcp4231-503
+      - microchip,mcp4232-103
+      - microchip,mcp4232-104
+      - microchip,mcp4232-502
+      - microchip,mcp4232-503
+      - microchip,mcp4241-103
+      - microchip,mcp4241-104
+      - microchip,mcp4241-502
+      - microchip,mcp4241-503
+      - microchip,mcp4242-103
+      - microchip,mcp4242-104
+      - microchip,mcp4242-502
+      - microchip,mcp4242-503
+      - microchip,mcp4251-103
+      - microchip,mcp4251-104
+      - microchip,mcp4251-502
+      - microchip,mcp4251-503
+      - microchip,mcp4252-103
+      - microchip,mcp4252-104
+      - microchip,mcp4252-502
+      - microchip,mcp4252-503
+      - microchip,mcp4261-103
+      - microchip,mcp4261-104
+      - microchip,mcp4261-502
+      - microchip,mcp4261-503
+      - microchip,mcp4262-103
+      - microchip,mcp4262-104
+      - microchip,mcp4262-502
+      - microchip,mcp4262-503
+
+  reg:
+    maxItems: 1
+
+  spi-max-frequency: true
+
+additionalProperties: false
+
+required:
+  - compatible
+  - reg
+
+examples:
+  - |
+    spi {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        potentiometer@0 {
+            compatible = "mcp4131-502";
+            reg = <0>;
+            spi-max-frequency = <500000>;
+        };
+    };
+...

From: Jonathan Cameron <[email protected]>

This binding is very simple, but I think the very large number of compatible values make it unsuitable for moving to trivial-devices.yaml. Main change in the conversion was reordering the compatible list to numerical order.

Signed-off-by Jonathan Cameron <[email protected]>

Cc Slawomir Stepien <[email protected]>

---
 .../bindings/iio/potentiometer/mcp4131.txt    |  84 ---------------
 .../iio/potentiometer/microchip,mcp4131.yaml  | 102 ++++++++++++++++++
 2 files changed, 102 insertions(+), 84 deletions(-)

Documentation/devicetree/bindings/iio/potentiometer/mcp4131.txt deleted +0 -84

deleted file mode 100644
index 3ccba16f7035..000000000000
@@ -1,84 +0,0 @@
-* Microchip MCP413X/414X/415X/416X/423X/424X/425X/426X Digital Potentiometer
-  driver
-
-The node for this driver must be a child node of a SPI controller, hence
-all mandatory properties described in
-
-        Documentation/devicetree/bindings/spi/spi-bus.txt
-
-must be specified.
-
-Required properties:
-	- compatible:  	Must be one of the following, depending on the
-			model:
-			"microchip,mcp4131-502"
-			"microchip,mcp4131-103"
-			"microchip,mcp4131-503"
-			"microchip,mcp4131-104"
-			"microchip,mcp4132-502"
-			"microchip,mcp4132-103"
-			"microchip,mcp4132-503"
-			"microchip,mcp4132-104"
-			"microchip,mcp4141-502"
-			"microchip,mcp4141-103"
-			"microchip,mcp4141-503"
-			"microchip,mcp4141-104"
-			"microchip,mcp4142-502"
-			"microchip,mcp4142-103"
-			"microchip,mcp4142-503"
-			"microchip,mcp4142-104"
-			"microchip,mcp4151-502"
-			"microchip,mcp4151-103"
-			"microchip,mcp4151-503"
-			"microchip,mcp4151-104"
-			"microchip,mcp4152-502"
-			"microchip,mcp4152-103"
-			"microchip,mcp4152-503"
-			"microchip,mcp4152-104"
-			"microchip,mcp4161-502"
-			"microchip,mcp4161-103"
-			"microchip,mcp4161-503"
-			"microchip,mcp4161-104"
-			"microchip,mcp4162-502"
-			"microchip,mcp4162-103"
-			"microchip,mcp4162-503"
-			"microchip,mcp4162-104"
-			"microchip,mcp4231-502"
-			"microchip,mcp4231-103"
-			"microchip,mcp4231-503"
-			"microchip,mcp4231-104"
-			"microchip,mcp4232-502"
-			"microchip,mcp4232-103"
-			"microchip,mcp4232-503"
-			"microchip,mcp4232-104"
-			"microchip,mcp4241-502"
-			"microchip,mcp4241-103"
-			"microchip,mcp4241-503"
-			"microchip,mcp4241-104"
-			"microchip,mcp4242-502"
-			"microchip,mcp4242-103"
-			"microchip,mcp4242-503"
-			"microchip,mcp4242-104"
-			"microchip,mcp4251-502"
-			"microchip,mcp4251-103"
-			"microchip,mcp4251-503"
-			"microchip,mcp4251-104"
-			"microchip,mcp4252-502"
-			"microchip,mcp4252-103"
-			"microchip,mcp4252-503"
-			"microchip,mcp4252-104"
-			"microchip,mcp4261-502"
-			"microchip,mcp4261-103"
-			"microchip,mcp4261-503"
-			"microchip,mcp4261-104"
-			"microchip,mcp4262-502"
-			"microchip,mcp4262-103"
-			"microchip,mcp4262-503"
-			"microchip,mcp4262-104"
-
-Example:
-mcp4131: mcp4131@0 {
-	compatible = "mcp4131-502";
-	reg = <0>;
-	spi-max-frequency = <500000>;
-};

Documentation/devicetree/bindings/iio/potentiometer/microchip,mcp4131.yaml new file +0 -0

new file mode 100644
index 000000000000..834d17ae3730

Documentation/devicetree/bindings/iio/potentiometer/microchip,mcp4131.yaml new file +95 -0

+maintainers:
+  - Slawomir Stepien <[email protected]>
+
+properties:
+  compatible:
+    enum:
+      - microchip,mcp4131-103
+      - microchip,mcp4131-104
+      - microchip,mcp4131-502
+      - microchip,mcp4131-503
+      - microchip,mcp4132-103
+      - microchip,mcp4132-104
+      - microchip,mcp4132-502
+      - microchip,mcp4132-503
+      - microchip,mcp4141-103
+      - microchip,mcp4141-104
+      - microchip,mcp4141-502
+      - microchip,mcp4141-503
+      - microchip,mcp4142-103
+      - microchip,mcp4142-104
+      - microchip,mcp4142-502
+      - microchip,mcp4142-503
+      - microchip,mcp4151-103
+      - microchip,mcp4151-104
+      - microchip,mcp4151-502
+      - microchip,mcp4151-503
+      - microchip,mcp4152-103
+      - microchip,mcp4152-104
+      - microchip,mcp4152-502
+      - microchip,mcp4152-503
+      - microchip,mcp4161-103
+      - microchip,mcp4161-104
+      - microchip,mcp4161-502
+      - microchip,mcp4161-503
+      - microchip,mcp4162-103
+      - microchip,mcp4162-104
+      - microchip,mcp4162-502
+      - microchip,mcp4162-503
+      - microchip,mcp4231-103
+      - microchip,mcp4231-104
+      - microchip,mcp4231-502
+      - microchip,mcp4231-503
+      - microchip,mcp4232-103
+      - microchip,mcp4232-104
+      - microchip,mcp4232-502
+      - microchip,mcp4232-503
+      - microchip,mcp4241-103
+      - microchip,mcp4241-104
+      - microchip,mcp4241-502
+      - microchip,mcp4241-503
+      - microchip,mcp4242-103
+      - microchip,mcp4242-104
+      - microchip,mcp4242-502
+      - microchip,mcp4242-503
+      - microchip,mcp4251-103
+      - microchip,mcp4251-104
+      - microchip,mcp4251-502
+      - microchip,mcp4251-503
+      - microchip,mcp4252-103
+      - microchip,mcp4252-104
+      - microchip,mcp4252-502
+      - microchip,mcp4252-503
+      - microchip,mcp4261-103
+      - microchip,mcp4261-104
+      - microchip,mcp4261-502
+      - microchip,mcp4261-503
+      - microchip,mcp4262-103
+      - microchip,mcp4262-104
+      - microchip,mcp4262-502
+      - microchip,mcp4262-503
+
+  reg:
+    maxItems: 1
+
+  spi-max-frequency: true
+
+additionalProperties: false
+
+required:
+  - compatible
+  - reg
+
+examples:
+  - |
+    spi {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        potentiometer@0 {
+            compatible = "mcp4131-502";
+            reg = <0>;
+            spi-max-frequency = <500000>;
+        };
+    };
+...

Signature · 1 line

2.28.0

From: Jonathan Cameron <[email protected]>

Renamed to be more specific as I would be surprised if this is the only sensorhub Samsung have ever shipped.
Fixed missing reg property in the example

Signed-off-by Jonathan Cameron <[email protected]>

Cc Karol Wrona <[email protected]>

---
 .../iio/samsung,sensorhub-rinato.yaml         | 72 +++++++++++++++++++
 .../devicetree/bindings/iio/sensorhub.txt     | 24 -------
 2 files changed, 72 insertions(+), 24 deletions(-)

Documentation/devicetree/bindings/iio/samsung,sensorhub-rinato.yaml new file +72 -0

new file mode 100644
index 000000000000..62366cbd37e5
@@ -0,0 +1,72 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/iio/samsung,sensorhub-rinato.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Samsung Sensorhub driver
+
+maintainers:
+  - Karol Wrona <[email protected]>
+
+description: |
+  Sensorhub is a MCU which manages several sensors and also plays the role
+  of a virtual sensor device.
+
+properties:
+  compatible:
+    enum:
+      - samsung,sensorhub-rinato
+      - samsung,sensorhub-thermostat
+
+  reg:
+    maxItems: 1
+
+  interrupts:
+    maxItems: 1
+
+  ap-mcu-gpios:
+    maxItems: 1
+    description:
+      Application Processor to sensorhub line - used during communication
+
+  mcu-ap-gpios:
+    maxItems: 1
+    description:
+      Sensorhub to Application Processor - used during communication
+
+  mcu-reset-gpios:
+    maxItems: 1
+    description:
+      Reset the sensorhub.
+
+  spi-max-frequency: true
+
+additionalProperties: false
+
+required:
+  - compatible
+  - reg
+  - interrupts
+  - ap-mcu-gpios
+  - mcu-ap-gpios
+  - mcu-reset-gpios
+
+examples:
+  - |
+    spi {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        sensorhub@0 {
+            compatible = "samsung,sensorhub-rinato";
+            reg = <0>;
+            spi-max-frequency = <5000000>;
+            interrupt-parent = <&gpx0>;
+            interrupts = <2 0>;
+            ap-mcu-gpios = <&gpx0 0 0>;
+            mcu-ap-gpios = <&gpx0 4 0>;
+            mcu-reset-gpios = <&gpx0 5 0>;
+        };
+    };
+...

Documentation/devicetree/bindings/iio/sensorhub.txt deleted +0 -24

deleted file mode 100644
index b6ac0457d4ea..000000000000
@@ -1,24 +0,0 @@
-Samsung Sensorhub driver
-
-Sensorhub is a MCU which manages several sensors and also plays the role
-of a virtual sensor device.
-
-Required properties:
-- compatible: "samsung,sensorhub-rinato" or "samsung,sensorhub-thermostat"
-- spi-max-frequency: max SPI clock frequency
-- interrupts: communication interrupt
-- ap-mcu-gpios: [out] ap to sensorhub line - used during communication
-- mcu-ap-gpios: [in] sensorhub to ap - used during communication
-- mcu-reset-gpios: [out] sensorhub reset
-
-Example:
-
-	shub_spi: shub {
-		compatible = "samsung,sensorhub-rinato";
-		spi-max-frequency = <5000000>;
-		interrupt-parent = <&gpx0>;
-		interrupts = <2 0>;
-		ap-mcu-gpios = <&gpx0 0 0>;
-		mcu-ap-gpios = <&gpx0 4 0>;
-		mcu-reset-gpios = <&gpx0 5 0>;
-	};

From: Jonathan Cameron <[email protected]>

A few questions came up whilst converting this one.
1) What is actually required?
- Checking Linux driver, interrupt is not, and the tx-supply could be supplied by a stub regulator as long as it's always on. As such I have reduced the required list to just compatible and reg.
2) What is the regulator called?
- It's tx-supply in the binding doc, but the driver request tx_sup I've left this alone for now. Andrew could you confirm what is intended for this?

Signed-off-by Jonathan Cameron <[email protected]>

Cc Andrew F. Davis <[email protected]>

---
 .../bindings/iio/health/afe4403.txt           | 33 ------------
 .../bindings/iio/health/ti,afe4403.yaml       | 54 +++++++++++++++++++
 2 files changed, 54 insertions(+), 33 deletions(-)

Documentation/devicetree/bindings/iio/health/afe4403.txt deleted +0 -33

deleted file mode 100644
index 8e412054d6d5..000000000000
@@ -1,33 +0,0 @@
-Texas Instruments AFE4403 Heart rate and Pulse Oximeter
-
-Required properties:
- - compatible		: Should be "ti,afe4403".
- - reg			: SPI chip select address of device.
- - tx-supply		: Regulator supply to transmitting LEDs.
- - interrupts		: The interrupt line the device ADC_RDY pin is
-			  connected to. For details refer to,
-			  ../../interrupt-controller/interrupts.txt.
-
-Optional properties:
- - reset-gpios		: GPIO used to reset the device.
-			  For details refer to, ../../gpio/gpio.txt.
-
-For other required and optional properties of SPI slave nodes
-please refer to ../../spi/spi-bus.txt.
-
-Example:
-
-&spi0 {
-	heart_mon@0 {
-		compatible = "ti,afe4403";
-		reg = <0>;
-		spi-max-frequency = <10000000>;
-
-		tx-supply = <&vbat>;
-
-		interrupt-parent = <&gpio1>;
-		interrupts = <28 IRQ_TYPE_EDGE_RISING>;
-
-		reset-gpios = <&gpio1 16 GPIO_ACTIVE_LOW>;
-	};
-};

Documentation/devicetree/bindings/iio/health/ti,afe4403.yaml new file +54 -0

new file mode 100644
index 000000000000..5c86db65c033
@@ -0,0 +1,54 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/iio/health/ti,afe4403.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Texas Instruments AFE4403 Heart rate and Pulse Oximeter
+
+maintainers:
+  - Andrew F. Davis <[email protected]>
+
+properties:
+  compatible:
+    const: ti,afe4403
+
+  reg:
+    maxItems: 1
+
+  tx-supply:
+    description: Supply to transmitting LEDs.
+
+  interrupts:
+    maxItems: 1
+    description: Connected to ADC_RDY pin.
+
+  reset-gpios: true
+
+  spi-max-frequency: true
+
+additionalProperties: false
+
+required:
+  - compatible
+  - reg
+
+examples:
+  - |
+    #include <dt-bindings/gpio/gpio.h>
+    #include <dt-bindings/interrupt-controller/irq.h>
+    spi {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        heart_mon@0 {
+            compatible = "ti,afe4403";
+            reg = <0>;
+            spi-max-frequency = <10000000>;
+            tx-supply = <&vbat>;
+            interrupt-parent = <&gpio1>;
+            interrupts = <28 IRQ_TYPE_EDGE_RISING>;
+            reset-gpios = <&gpio1 16 GPIO_ACTIVE_LOW>;
+        };
+    };
+...

Quoted 11 lines · On Sat, 31 Oct 2020 18:48:15 +0000 Jonathan Cameron <[email protected]> wrote:

From: Jonathan Cameron <[email protected]>

A few questions came up whilst converting this one.
1) What is actually required?
- Checking Linux driver, interrupt is not, and the tx-supply could be supplied by a stub regulator as long as it's always on. As such I have reduced the required list to just compatible and reg.
2) What is the regulator called?
- It's tx-supply in the binding doc, but the driver request tx_sup I've left this alone for now. Andrew could you confirm what is intended for this?

Andrew's email seems to be bouncing so I've reached out to him via another means. Will wait to see if that works before applying this or the next patch given the questions.

Thanks,

Jonathan

Quoted 107 lines

Signed-off-by Jonathan Cameron <[email protected]>

Cc Andrew F. Davis <[email protected]>

---
 .../bindings/iio/health/afe4403.txt           | 33 ------------
 .../bindings/iio/health/ti,afe4403.yaml       | 54 +++++++++++++++++++
 2 files changed, 54 insertions(+), 33 deletions(-)

Documentation/devicetree/bindings/iio/health/afe4403.txt deleted +0 -33

deleted file mode 100644
index 8e412054d6d5..000000000000
@@ -1,33 +0,0 @@
-Texas Instruments AFE4403 Heart rate and Pulse Oximeter
-
-Required properties:
- - compatible		: Should be "ti,afe4403".
- - reg			: SPI chip select address of device.
- - tx-supply		: Regulator supply to transmitting LEDs.
- - interrupts		: The interrupt line the device ADC_RDY pin is
-			  connected to. For details refer to,
-			  ../../interrupt-controller/interrupts.txt.
-
-Optional properties:
- - reset-gpios		: GPIO used to reset the device.
-			  For details refer to, ../../gpio/gpio.txt.
-
-For other required and optional properties of SPI slave nodes
-please refer to ../../spi/spi-bus.txt.
-
-Example:
-
-&spi0 {
-	heart_mon@0 {
-		compatible = "ti,afe4403";
-		reg = <0>;
-		spi-max-frequency = <10000000>;
-
-		tx-supply = <&vbat>;
-
-		interrupt-parent = <&gpio1>;
-		interrupts = <28 IRQ_TYPE_EDGE_RISING>;
-
-		reset-gpios = <&gpio1 16 GPIO_ACTIVE_LOW>;
-	};
-};

Documentation/devicetree/bindings/iio/health/ti,afe4403.yaml new file +54 -0

new file mode 100644
index 000000000000..5c86db65c033
@@ -0,0 +1,54 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/iio/health/ti,afe4403.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Texas Instruments AFE4403 Heart rate and Pulse Oximeter
+
+maintainers:
+  - Andrew F. Davis <[email protected]>
+
+properties:
+  compatible:
+    const: ti,afe4403
+
+  reg:
+    maxItems: 1
+
+  tx-supply:
+    description: Supply to transmitting LEDs.
+
+  interrupts:
+    maxItems: 1
+    description: Connected to ADC_RDY pin.
+
+  reset-gpios: true
+
+  spi-max-frequency: true
+
+additionalProperties: false
+
+required:
+  - compatible
+  - reg
+
+examples:
+  - |
+    #include <dt-bindings/gpio/gpio.h>
+    #include <dt-bindings/interrupt-controller/irq.h>
+    spi {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        heart_mon@0 {
+            compatible = "ti,afe4403";
+            reg = <0>;
+            spi-max-frequency = <10000000>;
+            tx-supply = <&vbat>;
+            interrupt-parent = <&gpio1>;
+            interrupts = <28 IRQ_TYPE_EDGE_RISING>;
+            reset-gpios = <&gpio1 16 GPIO_ACTIVE_LOW>;
+        };
+    };
+...  

From: Jonathan Cameron <[email protected]>

This basically has same questions as for the afe4403. We could combine the two bindings, but as the drivers are separate and it would be a little fiddly due to different buses let's keep the separating.
To repeat questions from the ti,afe4403 binding.

A few questions came up whilst converting this one.
1) What is actually required?
- Checking Linux driver, interrupt is not, and the tx-supply could be supplied by a stub regulator as long as it's always on. As such I have reduced the required list to just compatible and reg.
2) What is the regulator called?
- It's tx-supply in the binding doc, but the driver request tx_sup I've left this alone for now. Andrew could you confirm what is intended for this?

Signed-off-by Jonathan Cameron <[email protected]>

Cc Andrew F. Davis <[email protected]>

---
 .../bindings/iio/health/afe4404.txt           | 29 -----------
 .../bindings/iio/health/ti,afe4404.yaml       | 51 +++++++++++++++++++
 2 files changed, 51 insertions(+), 29 deletions(-)

Documentation/devicetree/bindings/iio/health/afe4404.txt deleted +0 -29

deleted file mode 100644
index 0b52830a0d9c..000000000000
@@ -1,29 +0,0 @@
-Texas Instruments AFE4404 Heart rate and Pulse Oximeter
-
-Required properties:
- - compatible		: Should be "ti,afe4404".
- - reg			: I2C address of the device.
- - tx-supply		: Regulator supply to transmitting LEDs.
- - interrupts		: The interrupt line the device ADC_RDY pin is
-			  connected to. For details refer to,
-			  ../interrupt-controller/interrupts.txt.
-
-Optional properties:
- - reset-gpios		: GPIO used to reset the device.
-			  For details refer to, ../gpio/gpio.txt.
-
-Example:
-
-&i2c2 {
-	heart_mon@58 {
-		compatible = "ti,afe4404";
-		reg = <0x58>;
-
-		tx-supply = <&vbat>;
-
-		interrupt-parent = <&gpio1>;
-		interrupts = <28 IRQ_TYPE_EDGE_RISING>;
-
-		reset-gpios = <&gpio1 16 GPIO_ACTIVE_LOW>;
-	};
-};

Documentation/devicetree/bindings/iio/health/ti,afe4404.yaml new file +51 -0

new file mode 100644
index 000000000000..187b99b22312
@@ -0,0 +1,51 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/iio/health/ti,afe4404.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Texas Instruments AFE4404 Heart rate and Pulse Oximeter
+
+maintainers:
+  - Andrew F. Davis <[email protected]>
+
+properties:
+  compatible:
+    const: ti,afe4403
+
+  reg:
+    maxItems: 1
+
+  tx-supply:
+    description: Supply to transmitting LEDs.
+
+  interrupts:
+    maxItems: 1
+    description: Connected to ADC_RDY pin.
+
+  reset-gpios: true
+
+additionalProperties: false
+
+required:
+  - compatible
+  - reg
+
+examples:
+  - |
+    #include <dt-bindings/gpio/gpio.h>
+    #include <dt-bindings/interrupt-controller/irq.h>
+    i2c {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        heart_mon@58 {
+            compatible = "ti,afe4404";
+            reg = <0x58>;
+            tx-supply = <&vbat>;
+            interrupt-parent = <&gpio1>;
+            interrupts = <28 IRQ_TYPE_EDGE_RISING>;
+            reset-gpios = <&gpio1 16 GPIO_ACTIVE_LOW>;
+        };
+    };
+...

From: Jonathan Cameron <[email protected]>

This basically has same questions as for the afe4403. We could combine the two bindings, but as the drivers are separate and it would be a little fiddly due to different buses let's keep the separating.
To repeat questions from the ti,afe4403 binding.

A few questions came up whilst converting this one.
1) What is actually required?
- Checking Linux driver, interrupt is not, and the tx-supply could be supplied by a stub regulator as long as it's always on. As such I have reduced the required list to just compatible and reg.
2) What is the regulator called?
- It's tx-supply in the binding doc, but the driver request tx_sup I've left this alone for now. Andrew could you confirm what is intended for this?

Signed-off-by Jonathan Cameron <[email protected]>

Cc Andrew F. Davis <[email protected]>

---
 .../bindings/iio/health/afe4404.txt           | 29 -----------
 .../bindings/iio/health/ti,afe4404.yaml       | 51 +++++++++++++++++++
 2 files changed, 51 insertions(+), 29 deletions(-)

Documentation/devicetree/bindings/iio/health/afe4404.txt deleted +0 -29

deleted file mode 100644
index 0b52830a0d9c..000000000000
@@ -1,29 +0,0 @@
-Texas Instruments AFE4404 Heart rate and Pulse Oximeter
-
-Required properties:
- - compatible          : Should be "ti,afe4404".
- - reg                 : I2C address of the device.
- - tx-supply           : Regulator supply to transmitting LEDs.
- - interrupts          : The interrupt line the device ADC_RDY pin is
-                         connected to. For details refer to,
-                         ../interrupt-controller/interrupts.txt.
-
-Optional properties:
- - reset-gpios         : GPIO used to reset the device.
-                         For details refer to, ../gpio/gpio.txt.
-
-Example:
-
-&i2c2 {
-       heart_mon@58 {
-               compatible = "ti,afe4404";
-               reg = <0x58>;
-
-               tx-supply = <&vbat>;
-
-               interrupt-parent = <&gpio1>;
-               interrupts = <28 IRQ_TYPE_EDGE_RISING>;
-
-               reset-gpios = <&gpio1 16 GPIO_ACTIVE_LOW>;
-       };
-};

Documentation/devicetree/bindings/iio/health/ti,afe4404.yaml new file +4 -0

new file mode 100644
index 000000000000..187b99b22312
@@ -0,0 +1,51 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/iio/health/ti,afe4404.yaml#

Quoted 70 lines · Jonathan Cameron

From: Jonathan Cameron <[email protected]>

This basically has same questions as for the afe4403. We could combine the two bindings, but as the drivers are separate and it would be a little fiddly due to different buses let's keep the separating.
To repeat questions from the ti,afe4403 binding.

A few questions came up whilst converting this one.
1) What is actually required?
- Checking Linux driver, interrupt is not, and the tx-supply could be supplied by a stub regulator as long as it's always on. As such I have reduced the required list to just compatible and reg.
2) What is the regulator called?
- It's tx-supply in the binding doc, but the driver request tx_sup I've left this alone for now. Andrew could you confirm what is intended for this?

Signed-off-by Jonathan Cameron <[email protected]>

Cc Andrew F. Davis <[email protected]>

---
 .../bindings/iio/health/afe4404.txt           | 29 -----------
 .../bindings/iio/health/ti,afe4404.yaml       | 51 +++++++++++++++++++
 2 files changed, 51 insertions(+), 29 deletions(-)

Documentation/devicetree/bindings/iio/health/afe4404.txt deleted +0 -29

deleted file mode 100644
index 0b52830a0d9c..000000000000
@@ -1,29 +0,0 @@
-Texas Instruments AFE4404 Heart rate and Pulse Oximeter
-
-Required properties:
- - compatible          : Should be "ti,afe4404".
- - reg                 : I2C address of the device.
- - tx-supply           : Regulator supply to transmitting LEDs.
- - interrupts          : The interrupt line the device ADC_RDY pin is
-                         connected to. For details refer to,
-                         ../interrupt-controller/interrupts.txt.
-
-Optional properties:
- - reset-gpios         : GPIO used to reset the device.
-                         For details refer to, ../gpio/gpio.txt.
-
-Example:
-
-&i2c2 {
-       heart_mon@58 {
-               compatible = "ti,afe4404";
-               reg = <0x58>;
-
-               tx-supply = <&vbat>;
-
-               interrupt-parent = <&gpio1>;
-               interrupts = <28 IRQ_TYPE_EDGE_RISING>;
-
-               reset-gpios = <&gpio1 16 GPIO_ACTIVE_LOW>;
-       };
-};

Documentation/devicetree/bindings/iio/health/ti,afe4404.yaml new file +4 -0

new file mode 100644
index 000000000000..187b99b22312
@@ -0,0 +1,51 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/iio/health/ti,afe4404.yaml#

Documentation/devicetree/bindings/iio/health/ti,afe4404.yaml line 14

Quoted 10 lines

Documentation/devicetree/bindings/iio/health/ti,afe4404.yaml new file +10 -0

+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Texas Instruments AFE4404 Heart rate and Pulse Oximeter
+
+maintainers:
+  - Andrew F. Davis <[email protected]>
+
+properties:
+  compatible:
+    const: ti,afe4403  

Typo here, which causes this warning:

Documentation/devicetree/bindings/iio/health/ti,afe4403.example.dt.yaml:
heart_mon@0: 'spi-max-frequency' does not match any of the regexes:
'pinctrl-[0-9]+'

Took me a minute staring at ti,afe4403.yaml to figure out what was happening.

Rob

From: Jonathan Cameron <[email protected]>

Straight forward conversion. As with other bindings I've dropped any standrd description, but kept the unusual bits, in thisscase the maxim,led-current-microamp and it's description.

Signed-off-by Jonathan Cameron <[email protected]>

---
 .../bindings/iio/health/max30100.txt          | 28 ----------
 .../bindings/iio/health/maxim,max30100.yaml   | 52 +++++++++++++++++++
 2 files changed, 52 insertions(+), 28 deletions(-)

Documentation/devicetree/bindings/iio/health/max30100.txt deleted +0 -28

deleted file mode 100644
index 0054908a6e74..000000000000
@@ -1,28 +0,0 @@
-Maxim MAX30100 heart rate and pulse oximeter sensor
-
-* https://datasheets.maximintegrated.com/en/ds/MAX30100.pdf
-
-Required properties:
-  - compatible: must be "maxim,max30100"
-  - reg: the I2C address of the sensor
-  - interrupts: the sole interrupt generated by the device
-
-  Refer to interrupt-controller/interrupts.txt for generic
-  interrupt client node bindings.
-
-Optional properties:
-  - maxim,led-current-microamp: configuration for LED current in microamperes
-    while the engine is running. First indexed value is the configuration for
-    the RED LED, and second value is for the IR LED.
-
-    Refer to the datasheet for the allowed current values.
-
-Example:
-
-max30100@57 {
-       compatible = "maxim,max30100";
-       reg = <0x57>;
-       maxim,led-current-microamp = <24000 50000>;
-       interrupt-parent = <&gpio1>;
-       interrupts = <16 2>;
-};

Documentation/devicetree/bindings/iio/health/maxim,max30100.yaml new file +0 -0

new file mode 100644
index 000000000000..5684f2f61bcc

Documentation/devicetree/bindings/iio/health/maxim,max30100.yaml new file +42 -1

+
+properties:
+  compatible:
+    const: maxim,max30100
+
+  reg:
+    maxItems: 1
+
+  interrupts:
+    maxItems: 1
+    description: Connected to ADC_RDY pin.
+
+  maxim,led-current-microamp:
+    $ref: /schemas/types.yaml#/definitions/uint32-array
+    minItems: 2
+    maxItems: 2
+    description: |
+      LED current whilst the engine is running. First indexed value is
+      the configuration for the RED LED, and second value is for the IR LED.
+
+additionalProperties: false
+
+required:
+  - compatible
+  - reg
+  - interrupts
+
+examples:
+  - |
+    i2c {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        heart-rate@57 {
+            compatible = "maxim,max30100";
+            reg = <0x57>;
+            maxim,led-current-microamp = <24000 50000>;
+            interrupt-parent = <&gpio1>;
+            interrupts = <16 2>;
+        };
+    };
+...
--

2.28.0

Quoted 53 lines · Jonathan Cameron

From: Jonathan Cameron <[email protected]>

Straight forward conversion. As with other bindings I've dropped any standrd description, but kept the unusual bits, in thisscase the maxim,led-current-microamp and it's description.

Signed-off-by Jonathan Cameron <[email protected]>

---
 .../bindings/iio/health/max30100.txt          | 28 ----------
 .../bindings/iio/health/maxim,max30100.yaml   | 52 +++++++++++++++++++
 2 files changed, 52 insertions(+), 28 deletions(-)

Documentation/devicetree/bindings/iio/health/max30100.txt deleted +0 -28

deleted file mode 100644
index 0054908a6e74..000000000000
@@ -1,28 +0,0 @@
-Maxim MAX30100 heart rate and pulse oximeter sensor
-
-* https://datasheets.maximintegrated.com/en/ds/MAX30100.pdf
-
-Required properties:
-  - compatible: must be "maxim,max30100"
-  - reg: the I2C address of the sensor
-  - interrupts: the sole interrupt generated by the device
-
-  Refer to interrupt-controller/interrupts.txt for generic
-  interrupt client node bindings.
-
-Optional properties:
-  - maxim,led-current-microamp: configuration for LED current in microamperes
-    while the engine is running. First indexed value is the configuration for
-    the RED LED, and second value is for the IR LED.
-
-    Refer to the datasheet for the allowed current values.
-
-Example:
-
-max30100@57 {
-       compatible = "maxim,max30100";
-       reg = <0x57>;
-       maxim,led-current-microamp = <24000 50000>;
-       interrupt-parent = <&gpio1>;
-       interrupts = <16 2>;
-};

Documentation/devicetree/bindings/iio/health/maxim,max30100.yaml new file +0 -0

new file mode 100644
index 000000000000..5684f2f61bcc

Documentation/devicetree/bindings/iio/health/maxim,max30100.yaml line 10

Quoted 10 lines

Documentation/devicetree/bindings/iio/health/maxim,max30100.yaml new file +10 -0

@@ -0,0 +1,52 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/iio/health/maxim,max30100.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Maxim MAX30100 heart rate and pulse oximeter sensor
+
+maintainers:
+  - Matt Ranostay <[email protected]>  

Please change to my Konsulko email, but otherwise LGTM

Acked-by Matt Ranostay <[email protected]>

Quoted 46 lines

Documentation/devicetree/bindings/iio/health/maxim,max30100.yaml new file +42 -1

+
+properties:
+  compatible:
+    const: maxim,max30100
+
+  reg:
+    maxItems: 1
+
+  interrupts:
+    maxItems: 1
+    description: Connected to ADC_RDY pin.
+
+  maxim,led-current-microamp:
+    $ref: /schemas/types.yaml#/definitions/uint32-array
+    minItems: 2
+    maxItems: 2
+    description: |
+      LED current whilst the engine is running. First indexed value is
+      the configuration for the RED LED, and second value is for the IR LED.
+
+additionalProperties: false
+
+required:
+  - compatible
+  - reg
+  - interrupts
+
+examples:
+  - |
+    i2c {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        heart-rate@57 {
+            compatible = "maxim,max30100";
+            reg = <0x57>;
+            maxim,led-current-microamp = <24000 50000>;
+            interrupt-parent = <&gpio1>;
+            interrupts = <16 2>;
+        };
+    };
+...
--

2.28.0

Quoted 67 lines · On Sat, 31 Oct 2020 14:41:56 -0700 Matt Ranostay <[email protected]>…

Quoted 53 lines · Jonathan Cameron

From: Jonathan Cameron <[email protected]>

Straight forward conversion. As with other bindings I've dropped any standrd description, but kept the unusual bits, in thisscase the maxim,led-current-microamp and it's description.

Signed-off-by Jonathan Cameron <[email protected]>

---
 .../bindings/iio/health/max30100.txt          | 28 ----------
 .../bindings/iio/health/maxim,max30100.yaml   | 52 +++++++++++++++++++
 2 files changed, 52 insertions(+), 28 deletions(-)

Documentation/devicetree/bindings/iio/health/max30100.txt deleted +0 -28

deleted file mode 100644
index 0054908a6e74..000000000000
@@ -1,28 +0,0 @@
-Maxim MAX30100 heart rate and pulse oximeter sensor
-
-* https://datasheets.maximintegrated.com/en/ds/MAX30100.pdf
-
-Required properties:
-  - compatible: must be "maxim,max30100"
-  - reg: the I2C address of the sensor
-  - interrupts: the sole interrupt generated by the device
-
-  Refer to interrupt-controller/interrupts.txt for generic
-  interrupt client node bindings.
-
-Optional properties:
-  - maxim,led-current-microamp: configuration for LED current in microamperes
-    while the engine is running. First indexed value is the configuration for
-    the RED LED, and second value is for the IR LED.
-
-    Refer to the datasheet for the allowed current values.
-
-Example:
-
-max30100@57 {
-       compatible = "maxim,max30100";
-       reg = <0x57>;
-       maxim,led-current-microamp = <24000 50000>;
-       interrupt-parent = <&gpio1>;
-       interrupts = <16 2>;
-};

Documentation/devicetree/bindings/iio/health/maxim,max30100.yaml new file +0 -0

new file mode 100644
index 000000000000..5684f2f61bcc

Documentation/devicetree/bindings/iio/health/maxim,max30100.yaml line 10

Quoted 10 lines

Documentation/devicetree/bindings/iio/health/maxim,max30100.yaml new file +10 -0

@@ -0,0 +1,52 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/iio/health/maxim,max30100.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Maxim MAX30100 heart rate and pulse oximeter sensor
+
+maintainers:
+  - Matt Ranostay <[email protected]>    

Please change to my Konsulko email, but otherwise LGTM

Quoted 1 line

Acked-by Matt Ranostay <[email protected]>

Fixed and also dropped the $ref for the *microamp item below as that's already covered by dt-schema as Rob pointed out for another occurrence.

Applied to the togreg branch of iio.git and pushed out as testing for all the normal reasons.

Thanks,

Jonathan

Quoted 46 lines

Quoted 46 lines

Documentation/devicetree/bindings/iio/health/maxim,max30100.yaml new file +42 -1

+
+properties:
+  compatible:
+    const: maxim,max30100
+
+  reg:
+    maxItems: 1
+
+  interrupts:
+    maxItems: 1
+    description: Connected to ADC_RDY pin.
+
+  maxim,led-current-microamp:
+    $ref: /schemas/types.yaml#/definitions/uint32-array
+    minItems: 2
+    maxItems: 2
+    description: |
+      LED current whilst the engine is running. First indexed value is
+      the configuration for the RED LED, and second value is for the IR LED.
+
+additionalProperties: false
+
+required:
+  - compatible
+  - reg
+  - interrupts
+
+examples:
+  - |
+    i2c {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        heart-rate@57 {
+            compatible = "maxim,max30100";
+            reg = <0x57>;
+            maxim,led-current-microamp = <24000 50000>;
+            interrupt-parent = <&gpio1>;
+            interrupts = <16 2>;
+        };
+    };
+...
--

2.28.0

From: Jonathan Cameron <[email protected]>

Straight forward binding. Title was a bit of a challenge to keep short as this binding covers sensors for two entirely different purposes.

Signed-off-by Jonathan Cameron <[email protected]>

Cc Matt Ranostay <[email protected]>

---
 .../bindings/iio/health/max30102.txt          | 33 --------
 .../bindings/iio/health/maxim,max30102.yaml   | 75 +++++++++++++++++++
 2 files changed, 75 insertions(+), 33 deletions(-)

Documentation/devicetree/bindings/iio/health/max30102.txt deleted +0 -33

deleted file mode 100644
index 7ef7ae40ae4f..000000000000
@@ -1,33 +0,0 @@
-Maxim MAX30102 heart rate and pulse oximeter sensor
-Maxim MAX30105 optical particle-sensing module
-
-* https://datasheets.maximintegrated.com/en/ds/MAX30102.pdf
-* https://datasheets.maximintegrated.com/en/ds/MAX30105.pdf
-
-Required properties:
-  - compatible: must be "maxim,max30102" or "maxim,max30105"
-  - reg: the I2C address of the sensor
-  - interrupts: the sole interrupt generated by the device
-
-  Refer to interrupt-controller/interrupts.txt for generic
-  interrupt client node bindings.
-
-Optional properties:
-  - maxim,red-led-current-microamp: configuration for red LED current
-  - maxim,ir-led-current-microamp: configuration for IR LED current
-  - maxim,green-led-current-microamp: configuration for green LED current
-    (max30105 only)
-
-    Note that each step is approximately 200 microamps, ranging from 0 uA to
-    50800 uA.
-
-Example:
-
-max30102@57 {
-       compatible = "maxim,max30102";
-       reg = <0x57>;
-       maxim,red-led-current-microamp = <7000>;
-       maxim,ir-led-current-microamp = <7000>;
-       interrupt-parent = <&gpio1>;
-       interrupts = <16 2>;
-};

Documentation/devicetree/bindings/iio/health/maxim,max30102.yaml new file +0 -0

new file mode 100644
index 000000000000..67d40f4a91a7

Documentation/devicetree/bindings/iio/health/maxim,max30102.yaml new file +65 -1

+
+properties:
+  compatible:
+    enum:
+      - maxim,max30102
+      - maxim,max30105
+
+  reg:
+    maxItems: 1
+
+  interrupts:
+    maxItems: 1
+    description: Connected to ADC_RDY pin.
+
+  maxim,red-led-current-microamp:
+    $ref: /schemas/types.yaml#/definitions/uint32
+    description: RED LED current. Each step is approximately 200 microamps.
+    minimum: 0
+    maximum: 50800
+
+  maxim,ir-led-current-microamp:
+    $ref: /schemas/types.yaml#/definitions/uint32
+    description: IR LED current. Each step is approximately 200 microamps.
+    minimum: 0
+    maximum: 50800
+
+  maxim,green-led-current-microamp:
+    $ref: /schemas/types.yaml#/definitions/uint32
+    description: Green LED current. Each step is approximately 200 microamps.
+    minimum: 0
+    maximum: 50800
+
+allOf:
+  - if:
+      properties:
+        compatible:
+          contains:
+            const: maxim,max30100
+    then:
+      properties:
+        maxim,green-led-current-microamp: false
+
+additionalProperties: false
+
+required:
+  - compatible
+  - reg
+  - interrupts
+
+examples:
+  - |
+    i2c {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        heart-rate@57 {
+            compatible = "maxim,max30102";
+            reg = <0x57>;
+            maxim,red-led-current-microamp = <7000>;
+            maxim,ir-led-current-microamp = <7000>;
+            interrupt-parent = <&gpio1>;
+            interrupts = <16 2>;
+        };
+    };
+...
--

2.28.0

Quoted 58 lines · Jonathan Cameron

From: Jonathan Cameron <[email protected]>

Straight forward binding. Title was a bit of a challenge to keep short as this binding covers sensors for two entirely different purposes.

Signed-off-by Jonathan Cameron <[email protected]>

Cc Matt Ranostay <[email protected]>

---
 .../bindings/iio/health/max30102.txt          | 33 --------
 .../bindings/iio/health/maxim,max30102.yaml   | 75 +++++++++++++++++++
 2 files changed, 75 insertions(+), 33 deletions(-)

Documentation/devicetree/bindings/iio/health/max30102.txt deleted +0 -33

deleted file mode 100644
index 7ef7ae40ae4f..000000000000
@@ -1,33 +0,0 @@
-Maxim MAX30102 heart rate and pulse oximeter sensor
-Maxim MAX30105 optical particle-sensing module
-
-* https://datasheets.maximintegrated.com/en/ds/MAX30102.pdf
-* https://datasheets.maximintegrated.com/en/ds/MAX30105.pdf
-
-Required properties:
-  - compatible: must be "maxim,max30102" or "maxim,max30105"
-  - reg: the I2C address of the sensor
-  - interrupts: the sole interrupt generated by the device
-
-  Refer to interrupt-controller/interrupts.txt for generic
-  interrupt client node bindings.
-
-Optional properties:
-  - maxim,red-led-current-microamp: configuration for red LED current
-  - maxim,ir-led-current-microamp: configuration for IR LED current
-  - maxim,green-led-current-microamp: configuration for green LED current
-    (max30105 only)
-
-    Note that each step is approximately 200 microamps, ranging from 0 uA to
-    50800 uA.
-
-Example:
-
-max30102@57 {
-       compatible = "maxim,max30102";
-       reg = <0x57>;
-       maxim,red-led-current-microamp = <7000>;
-       maxim,ir-led-current-microamp = <7000>;
-       interrupt-parent = <&gpio1>;
-       interrupts = <16 2>;
-};

Documentation/devicetree/bindings/iio/health/maxim,max30102.yaml new file +0 -0

new file mode 100644
index 000000000000..67d40f4a91a7

Documentation/devicetree/bindings/iio/health/maxim,max30102.yaml line 10

Quoted 10 lines

Documentation/devicetree/bindings/iio/health/maxim,max30102.yaml new file +10 -0

@@ -0,0 +1,75 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/iio/health/maxim,max30102.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Maxim MAX30102 heart rate and pulse oximeter and MAX30105 particle-sensor
+
+maintainers:
+  - Matt Ranostay <[email protected]>  

Change to my Konsulko email please, otherwise LGTM

Acked-by Matt Ranostay <[email protected]>

Quoted 69 lines

Documentation/devicetree/bindings/iio/health/maxim,max30102.yaml new file +65 -1

+
+properties:
+  compatible:
+    enum:
+      - maxim,max30102
+      - maxim,max30105
+
+  reg:
+    maxItems: 1
+
+  interrupts:
+    maxItems: 1
+    description: Connected to ADC_RDY pin.
+
+  maxim,red-led-current-microamp:
+    $ref: /schemas/types.yaml#/definitions/uint32
+    description: RED LED current. Each step is approximately 200 microamps.
+    minimum: 0
+    maximum: 50800
+
+  maxim,ir-led-current-microamp:
+    $ref: /schemas/types.yaml#/definitions/uint32
+    description: IR LED current. Each step is approximately 200 microamps.
+    minimum: 0
+    maximum: 50800
+
+  maxim,green-led-current-microamp:
+    $ref: /schemas/types.yaml#/definitions/uint32
+    description: Green LED current. Each step is approximately 200 microamps.
+    minimum: 0
+    maximum: 50800
+
+allOf:
+  - if:
+      properties:
+        compatible:
+          contains:
+            const: maxim,max30100
+    then:
+      properties:
+        maxim,green-led-current-microamp: false
+
+additionalProperties: false
+
+required:
+  - compatible
+  - reg
+  - interrupts
+
+examples:
+  - |
+    i2c {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        heart-rate@57 {
+            compatible = "maxim,max30102";
+            reg = <0x57>;
+            maxim,red-led-current-microamp = <7000>;
+            maxim,ir-led-current-microamp = <7000>;
+            interrupt-parent = <&gpio1>;
+            interrupts = <16 2>;
+        };
+    };
+...
--

2.28.0

From: Jonathan Cameron <[email protected]>

Very simple binding that we could move into trivial-devices.yaml with a small loss of documentation.

Signed-off-by Jonathan Cameron <[email protected]>

Cc Matt Ranostay <[email protected]>

---
 .../bindings/iio/light/apds9960.txt           | 21 ---------
 .../bindings/iio/light/avago,apds9960.yaml    | 44 +++++++++++++++++++
 2 files changed, 44 insertions(+), 21 deletions(-)

Documentation/devicetree/bindings/iio/light/apds9960.txt deleted +0 -21

deleted file mode 100644
index c53ddb81c4aa..000000000000
@@ -1,21 +0,0 @@
-* Avago APDS9960 gesture/RGB/ALS/proximity sensor
-
-https://www.avagotech.com/docs/AV02-4191EN
-
-Required properties:
-
-  - compatible: must be "avago,apds9960"
-  - reg: the I2c address of the sensor
-  - interrupts : the sole interrupt generated by the device
-
-  Refer to interrupt-controller/interrupts.txt for generic interrupt client
-  node bindings.
-
-Example:
-
-apds9960@39 {
-       compatible = "avago,apds9960";
-       reg = <0x39>;
-       interrupt-parent = <&gpio1>;
-       interrupts = <16 1>;
-};

Documentation/devicetree/bindings/iio/light/avago,apds9960.yaml new file +44 -1

new file mode 100644
index 000000000000..eae8c7327c0f
@@ -0,0 +1,44 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/iio/light/avago,apds9960.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Avago APDS9960 gesture/RGB/ALS/proximity sensor
+
+maintainers:
+  - Matt Ranostay <[email protected]>
+
+description: |
+  Datasheet at https://www.avagotech.com/docs/AV02-4191EN
+
+properties:
+  compatible:
+    const: avago,apds9960
+
+  reg:
+    maxItems: 1
+
+  interrupts:
+    maxItems: 1
+
+additionalProperties: false
+
+required:
+  - compatible
+  - reg
+
+examples:
+  - |
+    i2c {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        light-sensor@39 {
+            compatible = "avago,apds9960";
+            reg = <0x39>;
+            interrupt-parent = <&gpio1>;
+            interrupts = <16 1>;
+        };
+    };
+...
--

2.28.0

Quoted 3 lines · Jonathan Cameron

From: Jonathan Cameron <[email protected]>

Quoted 5 lines

Very simple binding that we could move into trivial-devices.yaml with a small loss of documentation.

Signed-off-by Jonathan Cameron <[email protected]>

Cc Matt Ranostay <[email protected]>

Acked-by Matt Ranostay <[email protected]>

Quoted 85 lines

---
 .../bindings/iio/light/apds9960.txt           | 21 ---------
 .../bindings/iio/light/avago,apds9960.yaml    | 44 +++++++++++++++++++
 2 files changed, 44 insertions(+), 21 deletions(-)

Documentation/devicetree/bindings/iio/light/apds9960.txt deleted +0 -21

deleted file mode 100644
index c53ddb81c4aa..000000000000
@@ -1,21 +0,0 @@
-* Avago APDS9960 gesture/RGB/ALS/proximity sensor
-
-https://www.avagotech.com/docs/AV02-4191EN
-
-Required properties:
-
-  - compatible: must be "avago,apds9960"
-  - reg: the I2c address of the sensor
-  - interrupts : the sole interrupt generated by the device
-
-  Refer to interrupt-controller/interrupts.txt for generic interrupt client
-  node bindings.
-
-Example:
-
-apds9960@39 {
-       compatible = "avago,apds9960";
-       reg = <0x39>;
-       interrupt-parent = <&gpio1>;
-       interrupts = <16 1>;
-};

Documentation/devicetree/bindings/iio/light/avago,apds9960.yaml new file +44 -1

new file mode 100644
index 000000000000..eae8c7327c0f
@@ -0,0 +1,44 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/iio/light/avago,apds9960.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Avago APDS9960 gesture/RGB/ALS/proximity sensor
+
+maintainers:
+  - Matt Ranostay <[email protected]>
+
+description: |
+  Datasheet at https://www.avagotech.com/docs/AV02-4191EN
+
+properties:
+  compatible:
+    const: avago,apds9960
+
+  reg:
+    maxItems: 1
+
+  interrupts:
+    maxItems: 1
+
+additionalProperties: false
+
+required:
+  - compatible
+  - reg
+
+examples:
+  - |
+    i2c {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        light-sensor@39 {
+            compatible = "avago,apds9960";
+            reg = <0x39>;
+            interrupt-parent = <&gpio1>;
+            interrupts = <16 1>;
+        };
+    };
+...
--

2.28.0

Quoted 8 lines · Matt Ranostay

Quoted 6 lines · Jonathan Cameron

From: Jonathan Cameron <[email protected]>

Very simple binding that we could move into trivial-devices.yaml with a small loss of documentation.

Quoted 4 lines

Quoted 2 lines

Signed-off-by Jonathan Cameron <[email protected]>

Cc Matt Ranostay <[email protected]>

Acked-by Matt Ranostay <[email protected]>

Actually still Acked-by but could you change my email below to my Konsulko one?

Thanks,

Matt

Quoted 85 lines

Quoted 85 lines

---
 .../bindings/iio/light/apds9960.txt           | 21 ---------
 .../bindings/iio/light/avago,apds9960.yaml    | 44 +++++++++++++++++++
 2 files changed, 44 insertions(+), 21 deletions(-)

Documentation/devicetree/bindings/iio/light/apds9960.txt deleted +0 -21

deleted file mode 100644
index c53ddb81c4aa..000000000000
@@ -1,21 +0,0 @@
-* Avago APDS9960 gesture/RGB/ALS/proximity sensor
-
-https://www.avagotech.com/docs/AV02-4191EN
-
-Required properties:
-
-  - compatible: must be "avago,apds9960"
-  - reg: the I2c address of the sensor
-  - interrupts : the sole interrupt generated by the device
-
-  Refer to interrupt-controller/interrupts.txt for generic interrupt client
-  node bindings.
-
-Example:
-
-apds9960@39 {
-       compatible = "avago,apds9960";
-       reg = <0x39>;
-       interrupt-parent = <&gpio1>;
-       interrupts = <16 1>;
-};

Documentation/devicetree/bindings/iio/light/avago,apds9960.yaml new file +44 -1

new file mode 100644
index 000000000000..eae8c7327c0f
@@ -0,0 +1,44 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/iio/light/avago,apds9960.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Avago APDS9960 gesture/RGB/ALS/proximity sensor
+
+maintainers:
+  - Matt Ranostay <[email protected]>
+
+description: |
+  Datasheet at https://www.avagotech.com/docs/AV02-4191EN
+
+properties:
+  compatible:
+    const: avago,apds9960
+
+  reg:
+    maxItems: 1
+
+  interrupts:
+    maxItems: 1
+
+additionalProperties: false
+
+required:
+  - compatible
+  - reg
+
+examples:
+  - |
+    i2c {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        light-sensor@39 {
+            compatible = "avago,apds9960";
+            reg = <0x39>;
+            interrupt-parent = <&gpio1>;
+            interrupts = <16 1>;
+        };
+    };
+...
--

2.28.0

From: Jonathan Cameron <[email protected]>

Simple conversion. Maintainers as per original binding file authors, but that was a long time back so as with others, if email addresses bounce I'll switch this to me.

Signed-off-by Jonathan Cameron <[email protected]>

Cc Jacek Anaszewski <[email protected]>

Cc Kyungmin Park <[email protected]>

---
 .../bindings/iio/light/gp2ap020a00f.txt       | 21 --------
 .../iio/light/sharp,gp2ap020a00f.yaml         | 49 +++++++++++++++++++
 2 files changed, 49 insertions(+), 21 deletions(-)

Documentation/devicetree/bindings/iio/light/gp2ap020a00f.txt deleted +0 -21

deleted file mode 100644
index 9231c82317ad..000000000000
@@ -1,21 +0,0 @@
-* Sharp GP2AP020A00F I2C Proximity/ALS sensor
-
-The proximity detector sensor requires power supply
-for its built-in led. It is also defined by this binding.
-
-Required properties:
-
-  - compatible : should be "sharp,gp2ap020a00f"
-  - reg : the I2C slave address of the light sensor
-  - interrupts : interrupt specifier for the sole interrupt generated
-		 by the device
-  - vled-supply : VLED power supply, as covered in ../regulator/regulator.txt
-
-Example:
-
-gp2ap020a00f@39 {
-	compatible = "sharp,gp2ap020a00f";
-	reg = <0x39>;
-	interrupts = <2 0>;
-	vled-supply = <...>;
-};

Documentation/devicetree/bindings/iio/light/sharp,gp2ap020a00f.yaml new file +49 -0

new file mode 100644
index 000000000000..d6a4b47467f2
@@ -0,0 +1,49 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/iio/light/sharp,gp2ap020a00f.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Sharp GP2AP020A00F I2C Proximity/ALS sensor
+
+maintainers:
+  - Jacek Anaszewski <[email protected]>
+  - Kyungmin Park <[email protected]>
+
+description: |
+  The proximity detector sensor requires power supply for its built-in led.
+
+properties:
+  compatible:
+    const: sharp,gp2ap020a00f
+
+  reg:
+    maxItems: 1
+
+  interrupts:
+    maxItems: 1
+
+  vled-supply: true
+
+additionalProperties: false
+
+required:
+  - compatible
+  - reg
+  - interrupts
+  - vled-supply
+
+examples:
+  - |
+    i2c {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        light-sensor@39 {
+            compatible = "sharp,gp2ap020a00f";
+            reg = <0x39>;
+            interrupts = <2 0>;
+            vled-supply = <&als_reg>;
+        };
+    };
+...

From: Jonathan Cameron <[email protected]>

I don't have an up to date address for Adriana Reus so I've put myself as the binding maintainer for this one. I'm happy to hand over to Adriana or anyone else who wants take it on!

This has a lot of optional tuning parameters. The docs are modified to try and put the default values in the description of each one rather than a forwards reference to the example.

Signed-off-by Jonathan Cameron <[email protected]>

---
 .../bindings/iio/light/upisemi,us5182.yaml    | 75 +++++++++++++++++++
 .../devicetree/bindings/iio/light/us5182d.txt | 45 -----------
 2 files changed, 75 insertions(+), 45 deletions(-)

Documentation/devicetree/bindings/iio/light/upisemi,us5182.yaml new file +13 -0

new file mode 100644
index 000000000000..b9dc8ae25bf0
@@ -0,0 +1,75 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/iio/light/upisemi,us5182.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: UPISEMI us5182d I2C ALS and Proximity sensor
+
+maintainers:
+  - Jonathan Cameron <[email protected]>
+
+properties:
+  compatible:

Documentation/devicetree/bindings/iio/light/upisemi,us5182.yaml new file +33 -0

+
+  upisemi,continuous:
+    $ref: /schemas/types.yaml#definitions/flag
+    description: |
+      This chip has two power modes: one-shot (chip takes one measurement and
+      then shuts itself down) and continuous (chip takes continuous
+      measurements). The one-shot mode is more power-friendly but the
+      continuous mode may be more reliable. If this property is specified
+      the continuous mode will be used instead of the default one-shot one for
+      raw reads.
+
+additionalProperties: false
+
+required:
+  - compatible
+  - reg
+
+examples:
+  - |
+    i2c {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        light-sensor@39 {
+            compatible = "upisemi,usd5182";
+            reg = <0x39>;
+            upisemi,glass-coef = < 1000 >;
+            upisemi,dark-ths = /bits/ 16 <170 200 512 512 800 2000 4000 8000>;
+            upisemi,upper-dark-gain = /bits/ 8 <0x00>;
+            upisemi,lower-dark-gain = /bits/ 8 <0x16>;
+        };
+    };
+...

Documentation/devicetree/bindings/iio/light/us5182d.txt deleted +0 -45

deleted file mode 100644
index a61979997f37..000000000000
@@ -1,45 +0,0 @@
-* UPISEMI us5182d I2C ALS and Proximity sensor
-
-Required properties:
-- compatible: must be "upisemi,usd5182"
-- reg: the I2C address of the device
-
-Optional properties:
-- upisemi,glass-coef: glass attenuation factor - compensation factor of
-                      resolution 1000 for material transmittance.
-
-- upisemi,dark-ths: array of 8 elements containing 16-bit thresholds (adc
-                    counts) corresponding to every scale.
-
-- upisemi,upper-dark-gain: 8-bit dark gain compensation factor(4 int and 4
-                           fractional bits - Q4.4) applied when light > threshold
-
-- upisemi,lower-dark-gain: 8-bit dark gain compensation factor(4 int and 4
-                           fractional bits - Q4.4) applied when light < threshold
-
-- upisemi,continuous: This chip has two power modes: one-shot (chip takes one
-                      measurement and then shuts itself down) and continuous (
-                      chip takes continuous measurements). The one-shot mode is
-                      more power-friendly but the continuous mode may be more
-                      reliable. If this property is specified the continuous
-                      mode will be used instead of the default one-shot one for
-                      raw reads.
-
-If the optional properties are not specified these factors will default to the
-values in the below example.
-The glass-coef defaults to no compensation for the covering material.
-The threshold array defaults to experimental values that work with US5182D
-sensor on evaluation board - roughly between 12-32 lux.
-There will be no dark-gain compensation by default when ALS > thresh
-(0 * dark-gain), and a 1.35 compensation factor when ALS < thresh.
-
-Example:
-
-    usd5182@39 {
-                compatible = "upisemi,usd5182";
-                reg = <0x39>;
-                upisemi,glass-coef = < 1000 >;
-                upisemi,dark-ths = /bits/ 16 <170 200 512 512 800 2000 4000 8000>;
-                upisemi,upper-dark-gain = /bits/ 8 <0x00>;
-                upisemi,lower-dark-gain = /bits/ 8 <0x16>;
-    };

Signature · 1 line

2.28.0

From: Jonathan Cameron <[email protected]>

Only significant change in here was dropping the statement that the i2c address should be 60. The datasheet suggests there are variants available with several different addresses.

Signed-off-by Jonathan Cameron <[email protected]>

Cc Parthiban Nallathambi <[email protected]>

---
 .../bindings/iio/light/vcnl4035.txt           | 18 --------
 .../bindings/iio/light/vishay,vcnl4035.yaml   | 45 +++++++++++++++++++
 2 files changed, 45 insertions(+), 18 deletions(-)

Documentation/devicetree/bindings/iio/light/vcnl4035.txt deleted +0 -18

deleted file mode 100644
index c07c7f052556..000000000000
@@ -1,18 +0,0 @@
-VISHAY VCNL4035 -  Ambient Light and proximity sensor
-
-Link to datasheet: https://www.vishay.com/docs/84251/vcnl4035x01.pdf
-
-Required properties:
-
-	-compatible: should be "vishay,vcnl4035"
-	-reg: I2C address of the sensor, should be 0x60
-	-interrupts: interrupt mapping for GPIO IRQ (level active low)
-
-Example:
-
-light-sensor@60 {
-	compatible = "vishay,vcnl4035";
-	reg = <0x60>;
-	interrupt-parent = <&gpio4>;
-	interrupts = <11 IRQ_TYPE_LEVEL_LOW>;
-};

Documentation/devicetree/bindings/iio/light/vishay,vcnl4035.yaml new file +45 -0

new file mode 100644
index 000000000000..e41c25817dd8
@@ -0,0 +1,45 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/iio/light/vishay,vcnl4035.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: VISHAY VCNL4035 ambient Light and proximity sensor
+
+maintainers:
+  - Parthiban Nallathambi <[email protected]>
+
+description: |
+  Datasheet at https://www.vishay.com/docs/84251/vcnl4035x01.pdf
+
+properties:
+  compatible:
+    const: vishay,vcnl4035
+
+  reg:
+    maxItems: 1
+
+  interrupts:
+    maxItems: 1
+
+additionalProperties: false
+
+required:
+  - compatible
+  - reg
+
+examples:
+  - |
+    #include <dt-bindings/interrupt-controller/irq.h>
+    i2c {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        light-sensor@60 {
+            compatible = "vishay,vcnl4035";
+            reg = <0x60>;
+            interrupt-parent = <&gpio4>;
+            interrupts = <11 IRQ_TYPE_LEVEL_LOW>;
+        };
+    };
+...

From: Jonathan Cameron <[email protected]>

I'm not sure anyone would use this part primarily as an ALS, given the time of flight laser also present, but I'll stick with the original decision on where to put the binding.

Added interrupts property as the device has a GPIO interrupt even if the driver is not currently using it.

Signed-off-by Jonathan Cameron <[email protected]>

Cc Manivannan Sadhasivam <[email protected]>

Cc Peter Meerwald-Stadler <[email protected]>

---
 .../bindings/iio/light/st,vl6180.yaml         | 45 +++++++++++++++++++
 .../devicetree/bindings/iio/light/vl6180.txt  | 15 -------
 2 files changed, 45 insertions(+), 15 deletions(-)

Documentation/devicetree/bindings/iio/light/st,vl6180.yaml new file +45 -0

new file mode 100644
index 000000000000..27c36ab7990d
@@ -0,0 +1,45 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/iio/light/st,vl6180.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: STMicro VL6180 ALS, range and proximity sensor
+
+maintainers:
+  - Manivannan Sadhasivam <[email protected]>
+  - Peter Meerwald-Stadler <[email protected]>
+
+description: |
+  Proximity sensing module incorporating time of flight sensor
+  Datasheet at https://www.st.com/resource/en/datasheet/vl6180x.pdf
+
+properties:
+  compatible:
+    const: st,vl6180
+
+  reg:
+    maxItems: 1
+
+  interrupts:
+    maxItems: 1
+
+additionalProperties: false
+
+required:
+  - compatible
+  - reg
+
+examples:
+  - |
+    #include <dt-bindings/interrupt-controller/irq.h>
+    i2c {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        proximity@29 {
+            compatible = "st,vl6180";
+            reg = <0x29>;
+        };
+    };
+...

Documentation/devicetree/bindings/iio/light/vl6180.txt deleted +0 -15

deleted file mode 100644
index fb9137d85df9..000000000000
@@ -1,15 +0,0 @@
-STMicro VL6180 -  ALS, range and proximity sensor
-
-Link to datasheet: https://www.st.com/resource/en/datasheet/vl6180x.pdf
-
-Required properties:
-
-	-compatible: should be "st,vl6180"
-	-reg: the I2C address of the sensor
-
-Example:
-
-vl6180@29 {
-	compatible = "st,vl6180";
-	reg = <0x29>;
-};

Signature · 1 line

2.28.0

From: Jonathan Cameron <[email protected]>

Simple conversion. I have pruned descriptions that did not add much useful detail. Note that the mount-matrix description will form part of a generic IIO binding. No need to repeat that in every driver that uses it.

Signed-off-by Jonathan Cameron <[email protected]>

Cc Linus Walleij <[email protected]>

Quoted 5 lines · Jonathan Cameron

From: Jonathan Cameron <[email protected]>

Simple conversion. I have pruned descriptions that did not add much useful detail. Note that the mount-matrix description will form part of a generic IIO binding. No need to repeat that in every driver that uses it.

Writing the mount-matrix YAML binding is going to be interesting!

Quoted 3 lines

Signed-off-by Jonathan Cameron <[email protected]>

Cc Linus Walleij <[email protected]>

Reviewed-by Linus Walleij <[email protected]>

Yours,
Linus Walleij