Skip to contentSkip to conversation

libxkbcommon: add missing dependency on libxml2

PATCH In review Martin Jansa 2 participants 3 messages Nov 3, 2020 – Nov 5, 2020 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

PATCH 1/1 libxkbcommon: add missing dependency on libxml2

* it was introduced with xkbregistry support in:
https://github.com/xkbcommon/libxkbcommon/commit/afb26e7df9090a0b765eb294b6efff448f763b6f
and as xkbregistry is enabled by default libxkbcommon is failing since the upgrade to 1.0.1 in builds where libxml2 wasn't included in RSS (e.g. when wayland isn't in DISTRO_FEATURES -> in PACKAGECONFIG)

---
 meta/recipes-graphics/xorg-lib/libxkbcommon_1.0.1.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-graphics/xorg-lib/libxkbcommon_1.0.1.bb +1 -1
index 4ef20b0721..353856e1c4 100644
@@ -5,7 +5,7 @@ HOMEPAGE = "http://www.xkbcommon.org"
 LIC_FILES_CHKSUM = "file://LICENSE;md5=e525ed9809e1f8a07cf4bce8b09e8b87"
 LICENSE = "MIT & MIT-style"
 
-DEPENDS = "util-macros flex-native bison-native"
+DEPENDS = "util-macros flex-native bison-native libxml2"
 
 SRC_URI = "http://xkbcommon.org/download/${BPN}-${PV}.tar.xz"
 
Signature · 1 line
2.27.0
#2 lore raw

I have the same issue, looking at libxkbcommon [1], it suggest to package the libxkbregistry separately and since the libxml2 adds a lot of dependencies may be is better to disable by default via -Denable-xkbregistry=false and add another recipe to build it if needed.

Regards,
Anibal

Quoted 34 lines · Martin Jansa

* it was introduced with xkbregistry support in:

https://github.com/xkbcommon/libxkbcommon/commit/afb26e7df9090a0b765eb294b6efff448f763b6f
and as xkbregistry is enabled by default libxkbcommon is failing since the upgrade to 1.0.1 in builds where libxml2 wasn't included in RSS (e.g. when wayland isn't in DISTRO_FEATURES -> in PACKAGECONFIG)

---
 meta/recipes-graphics/xorg-lib/libxkbcommon_1.0.1.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-graphics/xorg-lib/libxkbcommon_1.0.1.bb +1 -2
index 4ef20b0721..353856e1c4 100644
@@ -5,7 +5,7 @@ HOMEPAGE = "http://www.xkbcommon.org"
 LIC_FILES_CHKSUM = "file://LICENSE;md5=e525ed9809e1f8a07cf4bce8b09e8b87"
 LICENSE = "MIT & MIT-style"
 
-DEPENDS = "util-macros flex-native bison-native"
+DEPENDS = "util-macros flex-native bison-native libxml2"
 
 SRC_URI = "http://xkbcommon.org/download/${BPN}-${PV}.tar.xz"
 
--

2.27.0

#3 lore raw
Quoted 5 lines · Anibal Limon

I have the same issue, looking at libxkbcommon [1], it suggest to package the libxkbregistry separately and since the libxml2 adds a lot of dependencies may be is better to disable by default via -Denable-xkbregistry=false and add another recipe to build it if needed.

Forget the link,

[1] https://github.com/xkbcommon/libxkbcommon/blob/master/PACKAGING#L74

Quoted 40 lines

Regards,
Anibal

Quoted 34 lines · Martin Jansa

* it was introduced with xkbregistry support in:

https://github.com/xkbcommon/libxkbcommon/commit/afb26e7df9090a0b765eb294b6efff448f763b6f
and as xkbregistry is enabled by default libxkbcommon is failing since the upgrade to 1.0.1 in builds where libxml2 wasn't included in RSS (e.g. when wayland isn't in DISTRO_FEATURES -> in PACKAGECONFIG)

---
 meta/recipes-graphics/xorg-lib/libxkbcommon_1.0.1.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-graphics/xorg-lib/libxkbcommon_1.0.1.bb +1 -2
index 4ef20b0721..353856e1c4 100644
@@ -5,7 +5,7 @@ HOMEPAGE = "http://www.xkbcommon.org"
 LIC_FILES_CHKSUM = "file://LICENSE;md5=e525ed9809e1f8a07cf4bce8b09e8b87"
 LICENSE = "MIT & MIT-style"
 
-DEPENDS = "util-macros flex-native bison-native"
+DEPENDS = "util-macros flex-native bison-native libxml2"
 
 SRC_URI = "http://xkbcommon.org/download/${BPN}-${PV}.tar.xz"
 
--

2.27.0