Skip to contentSkip to conversation

package/grpc: add host gcc >= 4.9 comment

PATCH New Fabrice Fontaine 2 participants 4 messages Nov 4, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 package/grpc: add host gcc >= 4.9 comment

Commit e98610f039b88a5d164b19343d5ecef2d1c01f6d forgot to update comment

---
 package/grpc/Config.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/grpc/Config.in +1 -1
index 6151f4b3d1..d1bf0d078d 100644
@@ -20,7 +20,7 @@ config BR2_PACKAGE_GRPC
 
 	  http://github.com/grpc/grpc
 
-comment "grpc needs a toolchain w/ C++, threads, dynamic library, gcc >= 4.9"
+comment "grpc needs a toolchain w/ C++, threads, dynamic library, gcc >= 4.9, host gcc >= 4.9"
 	depends on BR2_PACKAGE_LIBABSEIL_CPP_ARCH_SUPPORTS
 	depends on BR2_TOOLCHAIN_HAS_SYNC_4 || BR2_TOOLCHAIN_HAS_ATOMIC
 	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_HAS_THREADS \
Signature · 1 line
2.28.0
#1 lore raw

PATCH 2/2 package/collectd: fix grpc dependency

Commit e98610f039b88a5d164b19343d5ecef2d1c01f6d forgot to propagate libabseil-cpp dependencies to BR2_PACKAGE_COLLECTD_GRPC

Fixes:
- http://autobuild.buildroot.org/results/c9bacfb52ae46ab78a5f9097a8df83e10d23ccc4

---
 package/collectd/Config.in | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)
package/collectd/Config.in +5 -3
index 7037a8b383..3e854ba518 100644
@@ -605,15 +605,17 @@ config BR2_PACKAGE_COLLECTD_GRPC
 	depends on BR2_TOOLCHAIN_HAS_SYNC_4 || BR2_TOOLCHAIN_HAS_ATOMIC # grpc
 	depends on BR2_INSTALL_LIBSTDCPP # grpc -> protobuf
 	depends on BR2_PACKAGE_PROTOBUF_ARCH_SUPPORTS # grpc -> protobuf
-	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 # grpc -> protobuf
+	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 # grpc -> libabseil-cpp
+	depends on BR2_HOST_GCC_AT_LEAST_4_9 # grpc -> host-libabseil-cpp
 	depends on BR2_PACKAGE_LIBABSEIL_CPP_ARCH_SUPPORTS # grpc
 	select BR2_PACKAGE_GRPC
 	help
 	  Send/receive values using the gRPC protocol.
 
-comment "grpc needs a toolchain w/ C++, gcc >= 4.8"
+comment "grpc needs a toolchain w/ C++, gcc >= 4.9, host gcc >= 4.9"
 	depends on BR2_TOOLCHAIN_HAS_SYNC_4 || BR2_TOOLCHAIN_HAS_ATOMIC
-	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_GCC_AT_LEAST_4_8
+	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 \
+		|| !BR2_HOST_GCC_AT_LEAST_4_9
 	depends on BR2_PACKAGE_PROTOBUF_ARCH_SUPPORTS
 	depends on BR2_PACKAGE_LIBABSEIL_CPP_ARCH_SUPPORTS # grpc
 
Signature · 1 line
2.28.0
#2 lore raw

PATCH 2/2 package/collectd: fix grpc dependency

Quoted 9 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Fabrice" == Fabrice Fontaine <[email protected]> writes:

Commit e98610f039b88a5d164b19343d5ecef2d1c01f6d forgot to propagate libabseil-cpp dependencies to BR2_PACKAGE_COLLECTD_GRPC

Fixes:
- http://autobuild.buildroot.org/results/c9bacfb52ae46ab78a5f9097a8df83e10d23ccc4

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard