Skip to contentSkip to conversation

Makefile: Fix calling make with V=1

PATCH New Pali Rohár 3 participants 3 messages Nov 4, 2020 – Nov 6, 2020 Kbuild

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Makefile: Fix calling make with V=1

Calling 'make V=1 all' on Ubuntu 18.04 with gcc version 9.2.1 and GNU Make version 4.1 fails on error:

scripts/Kbuild.include:220: *** Recursive variable 'echo-cmd' references itself (eventually). Stop.

As a workaround expand 'echo-cmd' variable via 'call' construction instead of expanding it directly.

---
 Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Makefile +1 -1
index 94feb7d9a5..b90fe8b865 100644
@@ -1309,7 +1309,7 @@ init_sp_bss_offset_check: u-boot.dtb FORCE
 	fi
 endif
 
-shell_cmd = { $(echo-cmd) $(cmd_$(1)); }
+shell_cmd = { $(call echo-cmd,$(1)) $(cmd_$(1)); }
 
 quiet_cmd_objcopy_uboot = OBJCOPY $@
 cmd_objcopy_uboot = $(cmd_objcopy) && $(call shell_cmd,static_rela,$<,$@,$(CONFIG_SYS_TEXT_BASE)) || { rm -f $@; false; }
Signature · 1 line
2.20.1
#1 lore raw

PATCH 1/1 Makefile: Fix calling make with V=1

Hi Pali

Quoted 9 lines

From: Pali Roh?r <[email protected]>
Sent: mercredi 4 novembre 2020 10:35

Calling 'make V=1 all' on Ubuntu 18.04 with gcc version 9.2.1 and GNU Make version 4.1 fails on error:

scripts/Kbuild.include:220: *** Recursive variable 'echo-cmd' references itself
(eventually). Stop.

Quoted 9 lines

As a workaround expand 'echo-cmd' variable via 'call' construction instead of expanding it directly.

---
 Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

This patch fixe for me (stm32mp15_basic_defconfig or stm32mp15_trusted_defconfig). the issue introduced by previous patch

Fixes ae897022d7bd ("Makefile: Fix u-boot-nodtb.bin target")

Thanks.

Patrick

#2 lore raw

PATCH 1/1 Makefile: Fix calling make with V=1

In reply to Pali Rohár
Quoted 10 lines · Pali Roh?r

Calling 'make V=1 all' on Ubuntu 18.04 with gcc version 9.2.1 and GNU Make version 4.1 fails on error:

scripts/Kbuild.include:220: *** Recursive variable 'echo-cmd' references itself (eventually). Stop.

As a workaround expand 'echo-cmd' variable via 'call' construction instead of expanding it directly.

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20201106/21d0b982/attachment.sig>