Skip to contentSkip to conversation

vim: add nativesdk to BBCLASSEXTEND

PATCH Superseded Nathan Rossi 2 participants 4 messages Nov 4, 2020 – Nov 5, 2020

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 vim: add nativesdk to BBCLASSEXTEND

---
 meta/recipes-support/vim/vim_8.2.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-support/vim/vim_8.2.bb +1 -1
index 709b6ddb55..7e4654e472 100644
@@ -3,7 +3,7 @@ require vim.inc
 PROVIDES = "xxd"
 
 PACKAGECONFIG_class-native = ""
-BBCLASSEXTEND = "native"
+BBCLASSEXTEND = "native nativesdk"
 
 ALTERNATIVE_${PN}_append = " xxd"
 ALTERNATIVE_TARGET[xxd] = "${bindir}/xxd"

---
2.28.0

#1 lore raw

Hello Nathan,

Quoted 10 lines · Nathan Rossi
---
 meta/recipes-support/vim/vim_8.2.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-support/vim/vim_8.2.bb +0 -0
index 709b6ddb55..7e4654e472 100644

meta/recipes-support/vim/vim_8.2.bb require vim.inc · line 6

Quoted 5 lines
meta/recipes-support/vim/vim_8.2.bb +1 -1
@@ -3,7 +3,7 @@ require vim.inc
 PROVIDES = "xxd"
 
 PACKAGECONFIG_class-native = ""
-BBCLASSEXTEND = "native"
+BBCLASSEXTEND = "native nativesdk"

Apologies if this is self-evident, but why should nativesdk be added here? A commit message explaining the why would be quite helpful.

Quoted 10 lines
meta/recipes-support/vim/vim_8.2.bb +0 -1
 ALTERNATIVE_${PN}_append = " xxd"
 ALTERNATIVE_TARGET[xxd] = "${bindir}/xxd"
---

2.28.0

Signature · 4 lines
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
#2 lore raw
Quoted 16 lines · Ahmad Fatoum

Hello Nathan,

Quoted 12 lines · Nathan Rossi
---
 meta/recipes-support/vim/vim_8.2.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-support/vim/vim_8.2.bb +0 -0
index 709b6ddb55..7e4654e472 100644
@@ -3,7 +3,7 @@ require vim.inc
 PROVIDES = "xxd"
 
Quoted 5 lines

meta/recipes-support/vim/vim_8.2.bb require vim.inc · line 6

Quoted 3 lines
meta/recipes-support/vim/vim_8.2.bb +1 -1
 PACKAGECONFIG_class-native = ""
-BBCLASSEXTEND = "native"
+BBCLASSEXTEND = "native nativesdk"

Apologies if this is self-evident, but why should nativesdk be added here?

It should be added so that vim can be included as part of a buildtools-tarball/sdk. It is useful to be able to provide an editor in a relatocable form, for when hosts do not provide an editor. It is also useful for the xxd tool.

Quoted 1 line

A commit message explaining the why would be quite helpful.

Sorry, I've made quite a few of these mechanical add nativesdk patches recently, and in the past. The reason for the change is almost always for sdk/buildtools-tarball. I can add the above description if that explanation is sufficient?

Regards,
Nathan

Quoted 17 lines
Quoted 11 lines
meta/recipes-support/vim/vim_8.2.bb +0 -1
 ALTERNATIVE_${PN}_append = " xxd"
 ALTERNATIVE_TARGET[xxd] = "${bindir}/xxd"
---

2.28.0

--

Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
#3 lore raw

Hello,

Quoted 20 lines · Nathan Rossi
Quoted 13 lines · Ahmad Fatoum
Quoted 12 lines · Nathan Rossi
---
 meta/recipes-support/vim/vim_8.2.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-support/vim/vim_8.2.bb +0 -0
index 709b6ddb55..7e4654e472 100644
@@ -3,7 +3,7 @@ require vim.inc
 PROVIDES = "xxd"
 
Quoted 5 lines

meta/recipes-support/vim/vim_8.2.bb require vim.inc · line 6

Quoted 3 lines
meta/recipes-support/vim/vim_8.2.bb +1 -1
 PACKAGECONFIG_class-native = ""
-BBCLASSEXTEND = "native"
+BBCLASSEXTEND = "native nativesdk"

Apologies if this is self-evident, but why should nativesdk be added here?

Quoted 4 lines

It should be added so that vim can be included as part of a buildtools-tarball/sdk. It is useful to be able to provide an editor in a relatocable form, for when hosts do not provide an editor. It is also useful for the xxd tool.

I see. Thanks!

Quoted 6 lines
Quoted 1 line

A commit message explaining the why would be quite helpful.

Sorry, I've made quite a few of these mechanical add nativesdk patches recently, and in the past. The reason for the change is almost always for sdk/buildtools-tarball. I can add the above description if that explanation is sufficient?

I'd appreciate that. I am trying to read along to get more familiar with OE and commit messages make this considerably easier.

Cheers,
Ahmad

Quoted 22 lines

Regards,
Nathan

Quoted 17 lines
Quoted 11 lines
meta/recipes-support/vim/vim_8.2.bb +0 -1
 ALTERNATIVE_${PN}_append = " xxd"
 ALTERNATIVE_TARGET[xxd] = "${bindir}/xxd"
---

2.28.0

--

Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
Signature · 4 lines
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |