Skip to contentSkip to conversation

net: ks8851: Implement EEPROM MAC address readout

PATCH New Marek Vasut 2 participants 5 messages Oct 8, 2020 – Nov 9, 2020 Network drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net: ks8851: Implement EEPROM MAC address readout

In case there is an EEPROM attached to the KS8851 MAC and the EEPROM contains a valid MAC address, the MAC address is loaded into the NIC registers on power on. Read the MAC address out of the NIC registers and provide it to U-Boot.

Cc Eugen Hristev <[email protected]>
Cc Joe Hershberger <[email protected]>
---
 drivers/net/ks8851_mll.c | 29 +++++++++++++++++++++++++++++
 1 file changed, 29 insertions(+)
drivers/net/ks8851_mll.c +29 -0
index d22668446d..58e065cdcc 100644
@@ -622,6 +622,34 @@ static int ks8851_write_hwaddr(struct udevice *dev)
 	return 0;
 }
 
+static int ks8851_read_rom_hwaddr(struct udevice *dev)
+{
+	struct ks_net *ks = dev_get_priv(dev);
+	struct eth_pdata *pdata = dev_get_platdata(dev);
+	u16 addrl, addrm, addrh;
+
+	/* No EEPROM means no valid MAC address. */
+	if (!(ks_rdreg16(ks, KS_CCR) & CCR_EEPROM))
+		return -EINVAL;
+
+	/*
+	 * If the EEPROM contains valid MAC address, it is loaded into
+	 * the NIC on power on. Read the MAC out of the NIC registers.
+	 */
+	addrl = ks_rdreg16(ks, KS_MARL);
+	addrm = ks_rdreg16(ks, KS_MARM);
+	addrh = ks_rdreg16(ks, KS_MARH);
+
+	pdata->enetaddr[0] = (addrh >> 8) & 0xff;
+	pdata->enetaddr[1] = addrh & 0xff;
+	pdata->enetaddr[2] = (addrm >> 8) & 0xff;
+	pdata->enetaddr[3] = addrm & 0xff;
+	pdata->enetaddr[4] = (addrl >> 8) & 0xff;
+	pdata->enetaddr[5] = addrl & 0xff;
+
+	return !is_valid_ethaddr(pdata->enetaddr);
+}
+
 static int ks8851_bind(struct udevice *dev)
 {
 	return device_set_name(dev, dev->name);
@@ -654,6 +682,7 @@ static const struct eth_ops ks8851_ops = {
 	.send		= ks8851_send,
 	.recv		= ks8851_recv,
 	.write_hwaddr	= ks8851_write_hwaddr,
+	.read_rom_hwaddr = ks8851_read_rom_hwaddr,
 };
 
 static const struct udevice_id ks8851_ids[] = {
Signature · 1 line
2.28.0
#1 lore raw

PATCH 1/1 net: ks8851: Implement EEPROM MAC address readout

Quoted 4 lines · Marek Vasut

In case there is an EEPROM attached to the KS8851 MAC and the EEPROM contains a valid MAC address, the MAC address is loaded into the NIC registers on power on. Read the MAC address out of the NIC registers and provide it to U-Boot.

Any news on this patch? It has been on the list for a month with zero feedback.

[...]

#2 lore raw

PATCH 1/1 net: ks8851: Implement EEPROM MAC address readout

Quoted 8 lines · Marek Vasut
Quoted 4 lines · Marek Vasut

In case there is an EEPROM attached to the KS8851 MAC and the EEPROM contains a valid MAC address, the MAC address is loaded into the NIC registers on power on. Read the MAC address out of the NIC registers and provide it to U-Boot.

Any news on this patch? It has been on the list for a month with zero feedback.

Probably time to put together a PR for me then, thanks.

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20201104/008d4a27/attachment.sig>
#3 lore raw

PATCH 1/1 net: ks8851: Implement EEPROM MAC address readout

Quoted 11 lines · Tom Rini
Quoted 8 lines · Marek Vasut
Quoted 4 lines · Marek Vasut

In case there is an EEPROM attached to the KS8851 MAC and the EEPROM contains a valid MAC address, the MAC address is loaded into the NIC registers on power on. Read the MAC address out of the NIC registers and provide it to U-Boot.

Any news on this patch? It has been on the list for a month with zero feedback.

Probably time to put together a PR for me then, thanks.

It's a single patch, so feel free to just pick it.

#4 lore raw

PATCH 1/1 net: ks8851: Implement EEPROM MAC address readout

In reply to Marek Vasut
Quoted 8 lines · Marek Vasut

In case there is an EEPROM attached to the KS8851 MAC and the EEPROM contains a valid MAC address, the MAC address is loaded into the NIC registers on power on. Read the MAC address out of the NIC registers and provide it to U-Boot.

Cc Eugen Hristev <[email protected]>
Cc Joe Hershberger <[email protected]>

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20201109/be15edba/attachment.sig>