Skip to contentSkip to conversation

phy: amlogic: Add support for AXG MIPI D-PHY

PATCH Superseded Neil Armstrong 2 participants 6 messages Nov 4, 2020 – Nov 16, 2020

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

v3 cover phy: amlogic: Add support for AXG MIPI D-PHY

The Amlogic AXg SoCs embeds a MIPI D-PHY to communicate with DSI panels, this adds the bindings.

This D-PHY depends on a separate analog PHY.

Changes since v2 at [2];
- Rebase on v5.10-rc1

Changes since v1 at [1]:
- Fix bindings and add review tag

[1] https://lkml.kernel.org/r/[email protected]
[2] https://lkml.kernel.org/r/[email protected]

Neil Armstrong (2):
dt-bindings: phy: add Amlogic AXG MIPI D-PHY bindings
phy: amlogic: Add AXG MIPI D-PHY driver

 .../bindings/phy/amlogic,axg-mipi-dphy.yaml   |  70 +++
 drivers/phy/amlogic/Kconfig                   |  12 +
 drivers/phy/amlogic/Makefile                  |   1 +
 drivers/phy/amlogic/phy-meson-axg-mipi-dphy.c | 413 ++++++++++++++++++
 4 files changed, 496 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/phy/amlogic,axg-mipi-dphy.yaml
 create mode 100644 drivers/phy/amlogic/phy-meson-axg-mipi-dphy.c
Signature · 1 line
2.25.1
#1 lore raw

PATCH v3 1/2 dt-bindings: phy: add Amlogic AXG MIPI D-PHY bindings

The Amlogic AXg SoCs embeds a MIPI D-PHY to communicate with DSI panels, this adds the bindings.

This D-PHY depends on a separate analog PHY.

---
 .../bindings/phy/amlogic,axg-mipi-dphy.yaml   | 70 +++++++++++++++++++
 1 file changed, 70 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/phy/amlogic,axg-mipi-dphy.yaml
Documentation/devicetree/bindings/phy/amlogic,axg-mipi-dphy.yaml new file +70 -0
new file mode 100644
index 000000000000..be485f500887
@@ -0,0 +1,70 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+# Copyright 2020 BayLibre, SAS
+%YAML 1.2
+---
+$id: "http://devicetree.org/schemas/phy/amlogic,axg-mipi-dphy.yaml#"
+$schema: "http://devicetree.org/meta-schemas/core.yaml#"
+
+title: Amlogic AXG MIPI D-PHY
+
+maintainers:
+  - Neil Armstrong <[email protected]>
+
+properties:
+  compatible:
+    enum:
+      - amlogic,axg-mipi-dphy
+
+  reg:
+    maxItems: 1
+
+  clocks:
+    maxItems: 1
+
+  clock-names:
+    items:
+      - const: pclk
+
+  resets:
+    maxItems: 1
+
+  reset-names:
+    items:
+      - const: phy
+
+  "#phy-cells":
+    const: 0
+
+  phys:
+    maxItems: 1
+
+  phy-names:
+    items:
+      - const: analog
+
+required:
+  - compatible
+  - reg
+  - clocks
+  - clock-names
+  - resets
+  - reset-names
+  - phys
+  - phy-names
+  - "#phy-cells"
+
+additionalProperties: false
+
+examples:
+  - |
+    phy@ff640000 {
+            compatible = "amlogic,axg-mipi-dphy";
+            reg = <0xff640000 0x100>;
+            clocks = <&clk_mipi_dsi_phy>;
+            clock-names = "pclk";
+            resets = <&reset_phy>;
+            reset-names = "phy";
+            phys = <&mipi_pcie_analog_dphy>;
+            phy-names = "analog";
+            #phy-cells = <0>;
+    };
Signature · 1 line
2.25.1
#2 lore raw

PATCH v3 2/2 phy: amlogic: Add AXG MIPI D-PHY driver

In reply to Neil Armstrong

The Amlogic AXG SoCs embeds a MIPI D-PHY used to communicate with DSI panels.

---
 drivers/phy/amlogic/Kconfig                   |  12 +
 drivers/phy/amlogic/Makefile                  |   1 +
 drivers/phy/amlogic/phy-meson-axg-mipi-dphy.c | 413 ++++++++++++++++++
 3 files changed, 426 insertions(+)
 create mode 100644 drivers/phy/amlogic/phy-meson-axg-mipi-dphy.c
drivers/phy/amlogic/Kconfig +12 -0
index 617cf073e9aa..99e8a4c7f1f3 100644
@@ -70,3 +70,15 @@ config PHY_MESON_AXG_MIPI_PCIE_ANALOG
 	  Enable this to support the Meson MIPI + PCIE analog PHY
 	  found in Meson AXG SoCs.
 	  If unsure, say N.
+
+config PHY_MESON_AXG_MIPI_DPHY
+	tristate "Meson AXG MIPI DPHY driver"
+	default ARCH_MESON
+	depends on OF && (ARCH_MESON || COMPILE_TEST)
+	select GENERIC_PHY
+	select REGMAP_MMIO
+	select GENERIC_PHY_MIPI_DPHY
+	help
+	  Enable this to support the Meson MIPI DPHY found in Meson AXG
+	  SoCs.
+	  If unsure, say N.
drivers/phy/amlogic/Makefile +1 -0
index 99702a45e9be..8fa07fbd0d92 100644
@@ -5,3 +5,4 @@ obj-$(CONFIG_PHY_MESON_G12A_USB2)		+= phy-meson-g12a-usb2.o
 obj-$(CONFIG_PHY_MESON_G12A_USB3_PCIE)		+= phy-meson-g12a-usb3-pcie.o
 obj-$(CONFIG_PHY_MESON_AXG_PCIE)		+= phy-meson-axg-pcie.o
 obj-$(CONFIG_PHY_MESON_AXG_MIPI_PCIE_ANALOG)	+= phy-meson-axg-mipi-pcie-analog.o
+obj-$(CONFIG_PHY_MESON_AXG_MIPI_DPHY)		+= phy-meson-axg-mipi-dphy.o
drivers/phy/amlogic/phy-meson-axg-mipi-dphy.c new file +413 -0

413 lines not on this page · raw message

Signature · 1 line
2.25.1
#3 lore raw
In reply to Neil Armstrong

Hi Vinod, Kishon,

Quoted 18 lines · Neil Armstrong

The Amlogic AXg SoCs embeds a MIPI D-PHY to communicate with DSI panels, this adds the bindings.

This D-PHY depends on a separate analog PHY.

Changes since v2 at [2];
- Rebase on v5.10-rc1

Changes since v1 at [1]:
- Fix bindings and add review tag

[1] https://lkml.kernel.org/r/[email protected]
[2] https://lkml.kernel.org/r/[email protected]

Neil Armstrong (2):
dt-bindings: phy: add Amlogic AXG MIPI D-PHY bindings
phy: amlogic: Add AXG MIPI D-PHY driver

Quoted 8 lines
 .../bindings/phy/amlogic,axg-mipi-dphy.yaml   |  70 +++
 drivers/phy/amlogic/Kconfig                   |  12 +
 drivers/phy/amlogic/Makefile                  |   1 +
 drivers/phy/amlogic/phy-meson-axg-mipi-dphy.c | 413 ++++++++++++++++++
 4 files changed, 496 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/phy/amlogic,axg-mipi-dphy.yaml
 create mode 100644 drivers/phy/amlogic/phy-meson-axg-mipi-dphy.c

Could you review this serie ?

Neil

_______________________________________________
linux-amlogic mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-amlogic

maintainer
#4 lore raw
Quoted 8 lines · Neil Armstrong

Hi Vinod, Kishon,

Quoted 4 lines · Neil Armstrong

The Amlogic AXg SoCs embeds a MIPI D-PHY to communicate with DSI panels, this adds the bindings.

This D-PHY depends on a separate analog PHY.

Am not sure why but these two do not seem to be in my inbox, can you please resend this and the other one please

Signature · 6 lines
~Vinod

_______________________________________________
linux-amlogic mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-amlogic
#5 lore raw
Quoted 4 lines · Vinod Koul
Quoted 3 lines · Neil Armstrong

Hi Vinod, Kishon,

Quoted 9 lines
Quoted 5 lines · Neil Armstrong
Quoted 4 lines

The Amlogic AXg SoCs embeds a MIPI D-PHY to communicate with DSI panels, this adds the bindings.

This D-PHY depends on a separate analog PHY.

Am not sure why but these two do not seem to be in my inbox, can you please resend this and the other one please

ok

_______________________________________________
linux-amlogic mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-amlogic