Skip to contentSkip to conversation

clk: tegra30: Use 300MHz for video decoder by default

PATCH In review Dmitry Osipenko 2 participants 4 messages Nov 4, 2020 – Nov 25, 2020

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 clk: tegra30: Use 300MHz for video decoder by default

The 600MHz is a too high clock rate for some SoC versions for the video decoder hardware and this may cause stability issues. Use 300MHz for the video decoder by default, which is supported by all hardware versions.

Fixes ed1a2459e20c ("clk: tegra: Add Tegra20/30 EMC clock implementation")
---
 drivers/clk/tegra/clk-tegra30.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/clk/tegra/clk-tegra30.c +1 -1
index 37244a7e68c2..98923c4674bf 100644
@@ -1248,7 +1248,7 @@ static struct tegra_clk_init_table init_table[] __initdata = {
 	{ TEGRA30_CLK_GR3D, TEGRA30_CLK_PLL_C, 300000000, 0 },
 	{ TEGRA30_CLK_GR3D2, TEGRA30_CLK_PLL_C, 300000000, 0 },
 	{ TEGRA30_CLK_PLL_U, TEGRA30_CLK_CLK_MAX, 480000000, 0 },
-	{ TEGRA30_CLK_VDE, TEGRA30_CLK_PLL_C, 600000000, 0 },
+	{ TEGRA30_CLK_VDE, TEGRA30_CLK_PLL_C, 300000000, 0 },
 	{ TEGRA30_CLK_SPDIF_IN_SYNC, TEGRA30_CLK_CLK_MAX, 24000000, 0 },
 	{ TEGRA30_CLK_I2S0_SYNC, TEGRA30_CLK_CLK_MAX, 24000000, 0 },
 	{ TEGRA30_CLK_I2S1_SYNC, TEGRA30_CLK_CLK_MAX, 24000000, 0 },
Signature · 1 line
2.27.0
maintainer
#1 lore raw

Quoting Dmitry Osipenko (2020-11-04 05:48:10)

Quoted 7 lines

The 600MHz is a too high clock rate for some SoC versions for the video decoder hardware and this may cause stability issues. Use 300MHz for the video decoder by default, which is supported by all hardware versions.

Fixes ed1a2459e20c ("clk: tegra: Add Tegra20/30 EMC clock implementation")

---

Should this go to clk-fixes? Thierry?

#2 lore raw

15.11.2020 00:16, Stephen Boyd пишет:

Quoted 11 lines

Quoting Dmitry Osipenko (2020-11-04 05:48:10)

Quoted 7 lines

The 600MHz is a too high clock rate for some SoC versions for the video decoder hardware and this may cause stability issues. Use 300MHz for the video decoder by default, which is supported by all hardware versions.

Fixes ed1a2459e20c ("clk: tegra: Add Tegra20/30 EMC clock implementation")

---

Should this go to clk-fixes? Thierry?

Either way should be good. The fix isn't critical because 600MHz seems to be working okay on unsupported hardware.

Potentially this could vary depending on a board, but then I don't think that there are actively-supported boards which would notice this change.

Likely that this patch will be backported by a bot anyways because of the fixes tag.

maintainer
#3 lore raw

Quoting Dmitry Osipenko (2020-11-15 06:10:04)

Quoted 10 lines

15.11.2020 00:16, Stephen Boyd пишет:

Quoted 9 lines

Quoting Dmitry Osipenko (2020-11-04 05:48:10)

Quoted 7 lines

The 600MHz is a too high clock rate for some SoC versions for the video decoder hardware and this may cause stability issues. Use 300MHz for the video decoder by default, which is supported by all hardware versions.

Fixes ed1a2459e20c ("clk: tegra: Add Tegra20/30 EMC clock implementation")

---

Quoted 9 lines
Quoted 2 lines

Should this go to clk-fixes? Thierry?

Either way should be good. The fix isn't critical because 600MHz seems to be working okay on unsupported hardware.

Potentially this could vary depending on a board, but then I don't think that there are actively-supported boards which would notice this change.

Ok sounds like Thierry can pick it up.