vhost: slot_idx needs to be initialised to fix gcc compile error
PATCH 1/1 vhost: slot_idx needs to be initialised to fix gcc compile error
When DPDK is compiled with gcc < 9 with the optimization level set to 1 gcc sees slot_idx as possibly being uninitialised. To correct this error slot_idx has been initialised to 0.
Signed-off-by Conor Walsh <[email protected]>
--- lib/librte_vhost/virtio_net.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
lib/librte_vhost/virtio_net.c +1 -1
@@ -1491,7 +1491,7 @@ virtio_dev_rx_async_submit_split(struct virtio_net *dev,struct iovec *dst_iovec = vec_pool + (VHOST_MAX_ASYNC_VEC >>1 );struct rte_vhost_iov_iter *src_it = it_pool;struct rte_vhost_iov_iter *dst_it = it_pool +1 ; -uint16_t n_free_slot, slot_idx; +uint16_t n_free_slot, slot_idx =0 ;uint16_t pkt_err =0 ;uint16_t segs_await =0 ;struct async_inflight_info *pkts_info = vq->async_pkts_info;
Signature · 1 line
2.25.1
Hi Conor,
Quoted 15 lines · Conor Walsh
When DPDK is compiled with gcc < 9 with the optimization level set to 1 gcc sees
slot_idxas possibly being uninitialised. To correct this errorslot_idxhas been initialised to 0.Signed-off-by Conor Walsh <[email protected]>--- lib/librte_vhost/virtio_net.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)lib/librte_vhost/virtio_net.c +0
-0
lib/librte_vhost/virtio_net.c virtio_dev_rx_async_submit_split(struct virtio_net *dev, · line 1497
Quoted 8 lines
lib/librte_vhost/virtio_net.c +1
-1@@ -1491,7 +1491,7 @@ virtio_dev_rx_async_submit_split(struct virtio_net *dev,struct iovec *dst_iovec = vec_pool + (VHOST_MAX_ASYNC_VEC >>1 );struct rte_vhost_iov_iter *src_it = it_pool;struct rte_vhost_iov_iter *dst_it = it_pool +1 ; -uint16_t n_free_slot, slot_idx; +uint16_t n_free_slot, slot_idx =0 ;uint16_t pkt_err =0 ;uint16_t segs_await =0 ;struct async_inflight_info *pkts_info = vq->async_pkts_info;
Same patch has already been submitted and merged:
https://patches.dpdk.org/patch/82281/
Thanks,
Maxime