Skip to contentSkip to conversation

eal: fix missing installation of mcslock headers

PATCH Applied Olivier Matz 4 participants 7 messages Nov 4, 2020 – Nov 5, 2020 Arm/Amlogic Meson SoC support

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 eal: fix missing installation of mcslock headers

Add missing arch-specific headers in meson.build.

Fixes 2173f3333b61 ("mcslock: add MCS queued lock implementation")
---
 lib/librte_eal/arm/include/meson.build | 1 +
 lib/librte_eal/ppc/include/meson.build | 1 +
 lib/librte_eal/x86/include/meson.build | 1 +
 3 files changed, 3 insertions(+)
lib/librte_eal/arm/include/meson.build +1 -0
index 73b750a18f..70b2382c0b 100644
@@ -14,6 +14,7 @@ arch_headers = files(
 	'rte_cycles.h',
 	'rte_io_64.h',
 	'rte_io.h',
+	'rte_mcslock.h',
 	'rte_memcpy_32.h',
 	'rte_memcpy_64.h',
 	'rte_memcpy.h',
lib/librte_eal/ppc/include/meson.build +1 -0
index ab4bd28092..e46ae899e6 100644
@@ -8,6 +8,7 @@ arch_headers = files(
 	'rte_cpuflags.h',
 	'rte_cycles.h',
 	'rte_io.h',
+	'rte_mcslock.h',
 	'rte_memcpy.h',
 	'rte_pause.h',
 	'rte_prefetch.h',
lib/librte_eal/x86/include/meson.build +1 -0
index f0e998c2fe..9be5b318de 100644
@@ -11,6 +11,7 @@ arch_headers = files(
 	'rte_cpuflags.h',
 	'rte_cycles.h',
 	'rte_io.h',
+	'rte_mcslock.h',
 	'rte_memcpy.h',
 	'rte_prefetch.h',
 	'rte_pause.h',
Signature · 1 line
2.25.1
#1 lore raw

PATCH 2/2 eal: fix missing installation of ticketlock headers

Add missing arch-specific headers in meson.build.

Fixes ca49b92079df ("ticketlock: enable generic ticketlock on all arch")
---
 lib/librte_eal/arm/include/meson.build | 1 +
 lib/librte_eal/ppc/include/meson.build | 1 +
 lib/librte_eal/x86/include/meson.build | 1 +
 3 files changed, 3 insertions(+)
lib/librte_eal/arm/include/meson.build +1 -0
index 70b2382c0b..844fa324f3 100644
@@ -26,6 +26,7 @@ arch_headers = files(
 	'rte_prefetch.h',
 	'rte_rwlock.h',
 	'rte_spinlock.h',
+	'rte_ticketlock.h',
 	'rte_vect.h',
 )
 install_headers(arch_headers, subdir: get_option('include_subdir_arch'))
lib/librte_eal/ppc/include/meson.build +1 -0
index e46ae899e6..dcd91e2f85 100644
@@ -14,6 +14,7 @@ arch_headers = files(
 	'rte_prefetch.h',
 	'rte_rwlock.h',
 	'rte_spinlock.h',
+	'rte_ticketlock.h',
 	'rte_vect.h',
 )
 install_headers(arch_headers, subdir: get_option('include_subdir_arch'))
lib/librte_eal/x86/include/meson.build +1 -0
index 9be5b318de..b25b176bcc 100644
@@ -18,6 +18,7 @@ arch_headers = files(
 	'rte_rtm.h',
 	'rte_rwlock.h',
 	'rte_spinlock.h',
+	'rte_ticketlock.h',
 	'rte_vect.h',
 )
 install_headers(arch_headers, subdir: get_option('include_subdir_arch'))
Signature · 1 line
2.25.1
Acked-by on v1 2/2
#2 lore raw

Re: [dpdk-dev] [PATCH 2/2] eal: fix missing installation of ticketlock headers

Quoted 7 lines · Olivier Matz

Add missing arch-specific headers in meson.build.

Fixes ca49b92079df ("ticketlock: enable generic ticketlock on all arch")

Issue can be seen with:

examples/helloworld/main.c +2 -0
index 8a4cee60ff..627becb01b 100644
@@ -14,6 +14,8 @@
 #include <rte_per_lcore.h>
 #include <rte_lcore.h>
 #include <rte_debug.h>
+#include <rte_mcslock.h>
+#include <rte_ticketlock.h>
 
 static int
 lcore_hello(__rte_unused void *arg)

For the series:

Signature · 1 line
David Marchand
Acked-by David Christensen Acked-by Ruifeng Wang Applied
#3 lore raw

Re: [dpdk-dev] [PATCH 2/2] eal: fix missing installation of ticketlock headers

Quoted 9 lines · David Marchand
Quoted 7 lines · Olivier Matz

Add missing arch-specific headers in meson.build.

Fixes ca49b92079df ("ticketlock: enable generic ticketlock on all arch")

Applied, thanks Olivier.

Signature · 1 line
David Marchand
Acked-by on v1 2/2
#4 lore raw

Re: [dpdk-dev] [PATCH 2/2] eal: fix missing installation of ticketlock headers

In reply to Olivier Matz
Quoted 29 lines · Olivier Matz

Add missing arch-specific headers in meson.build.

Fixes ca49b92079df ("ticketlock: enable generic ticketlock on all arch")
---
  lib/librte_eal/arm/include/meson.build | 1 +
  lib/librte_eal/ppc/include/meson.build | 1 +
  lib/librte_eal/x86/include/meson.build | 1 +
  3 files changed, 3 insertions(+)
lib/librte_eal/arm/include/meson.build +1 -0
index 70b2382c0b..844fa324f3 100644
@@ -26,6 +26,7 @@ arch_headers = files(
  	'rte_prefetch.h',
  	'rte_rwlock.h',
  	'rte_spinlock.h',
+	'rte_ticketlock.h',
  	'rte_vect.h',
  )
  install_headers(arch_headers, subdir: get_option('include_subdir_arch'))
lib/librte_eal/ppc/include/meson.build +0 -0
index e46ae899e6..dcd91e2f85 100644

lib/librte_eal/ppc/include/meson.build arch_headers = files( · line 20

Quoted 7 lines
lib/librte_eal/ppc/include/meson.build +1 -0
@@ -14,6 +14,7 @@ arch_headers = files(
  	'rte_prefetch.h',
  	'rte_rwlock.h',
  	'rte_spinlock.h',
+	'rte_ticketlock.h',
  	'rte_vect.h',
  )
  install_headers(arch_headers, subdir: get_option('include_subdir_arch'))
Acked-by on v1 2/2
#5 lore raw

Re: [dpdk-dev] [PATCH 2/2] eal: fix missing installation of ticketlock headers

In reply to Olivier Matz
Quoted 67 lines

-----Original Message-----
From: Olivier Matz <[email protected]>
Sent: Thursday, November 5, 2020 1:04 AM
To: [email protected]
Cc: [email protected]; Ruifeng Wang <[email protected]>; Jan Viktorin <[email protected]>; David Christensen <[email protected]>; Bruce Richardson <[email protected]>; Konstantin Ananyev <[email protected]>; Honnappa Nagarahalli <[email protected]>; Phil Yang <[email protected]>; Gavin Hu <[email protected]>; Steve Capper <[email protected]>; Joyce Kong <[email protected]>; [email protected]
Subject: [PATCH 2/2] eal: fix missing installation of ticketlock headers

Add missing arch-specific headers in meson.build.

Fixes ca49b92079df ("ticketlock: enable generic ticketlock on all arch")
---
 lib/librte_eal/arm/include/meson.build | 1 +
lib/librte_eal/ppc/include/meson.build | 1 +
lib/librte_eal/x86/include/meson.build | 1 +
 3 files changed, 3 insertions(+)
lib/librte_eal/arm/include/meson.build +1 -0
index 70b2382c0b..844fa324f3 100644
@@ -26,6 +26,7 @@ arch_headers = files(
 	'rte_prefetch.h',
 	'rte_rwlock.h',
 	'rte_spinlock.h',
+	'rte_ticketlock.h',
 	'rte_vect.h',
 )
 install_headers(arch_headers, subdir: get_option('include_subdir_arch'))
lib/librte_eal/ppc/include/meson.build +1 -0
index e46ae899e6..dcd91e2f85 100644
@@ -14,6 +14,7 @@ arch_headers = files(
 	'rte_prefetch.h',
 	'rte_rwlock.h',
 	'rte_spinlock.h',
+	'rte_ticketlock.h',
 	'rte_vect.h',
 )
 install_headers(arch_headers, subdir: get_option('include_subdir_arch'))
lib/librte_eal/x86/include/meson.build +1 -1
index 9be5b318de..b25b176bcc 100644
@@ -18,6 +18,7 @@ arch_headers = files(
 	'rte_rtm.h',
 	'rte_rwlock.h',
 	'rte_spinlock.h',
+	'rte_ticketlock.h',
 	'rte_vect.h',
 )
 install_headers(arch_headers, subdir: get_option('include_subdir_arch'))
--
Quoted 1 line

2.25.1

Acked-by on v1 1/2
#6 lore raw
In reply to Olivier Matz
Quoted 67 lines

-----Original Message-----
From: Olivier Matz <[email protected]>
Sent: Thursday, November 5, 2020 1:04 AM
To: [email protected]
Cc: [email protected]; Ruifeng Wang <[email protected]>; Jan Viktorin <[email protected]>; David Christensen <[email protected]>; Bruce Richardson <[email protected]>; Konstantin Ananyev <[email protected]>; Honnappa Nagarahalli <[email protected]>; Phil Yang <[email protected]>; Gavin Hu <[email protected]>; Steve Capper <[email protected]>; Joyce Kong <[email protected]>; [email protected]
Subject: [PATCH 1/2] eal: fix missing installation of mcslock headers

Add missing arch-specific headers in meson.build.

Fixes 2173f3333b61 ("mcslock: add MCS queued lock implementation")
---
 lib/librte_eal/arm/include/meson.build | 1 +
lib/librte_eal/ppc/include/meson.build | 1 +
lib/librte_eal/x86/include/meson.build | 1 +
 3 files changed, 3 insertions(+)
lib/librte_eal/arm/include/meson.build +1 -0
index 73b750a18f..70b2382c0b 100644
@@ -14,6 +14,7 @@ arch_headers = files(
 	'rte_cycles.h',
 	'rte_io_64.h',
 	'rte_io.h',
+	'rte_mcslock.h',
 	'rte_memcpy_32.h',
 	'rte_memcpy_64.h',
 	'rte_memcpy.h',
lib/librte_eal/ppc/include/meson.build +1 -0
index ab4bd28092..e46ae899e6 100644
@@ -8,6 +8,7 @@ arch_headers = files(
 	'rte_cpuflags.h',
 	'rte_cycles.h',
 	'rte_io.h',
+	'rte_mcslock.h',
 	'rte_memcpy.h',
 	'rte_pause.h',
 	'rte_prefetch.h',
lib/librte_eal/x86/include/meson.build +1 -1
index f0e998c2fe..9be5b318de 100644
@@ -11,6 +11,7 @@ arch_headers = files(
 	'rte_cpuflags.h',
 	'rte_cycles.h',
 	'rte_io.h',
+	'rte_mcslock.h',
 	'rte_memcpy.h',
 	'rte_prefetch.h',
 	'rte_pause.h',
--
Quoted 1 line

2.25.1