doc: Add tester.config
Luiz Augusto von Dentz
maintainerPATCH v2 1/8 doc: Add tester.config
From: Luiz Augusto von Dentz <[email protected]>
This adds tester.config which can be used as a reference to create kernel images to be run with test-runner.
--- doc/tester.config | 48 +++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 48 insertions(+) create mode 100644 doc/tester.config
doc/tester.config new file +48 -0
@@ -0,0 +1,48 @@ +CONFIG_VIRTIO=y +CONFIG_VIRTIO_PCI=y + +CONFIG_NET=y +CONFIG_INET=y + +CONFIG_NET_9P=y +CONFIG_NET_9P_VIRTIO=y + +CONFIG_9P_FS=y +CONFIG_9P_FS_POSIX_ACL=y + +CONFIG_SERIAL_8250=y +CONFIG_SERIAL_8250_CONSOLE=y +CONFIG_SERIAL_8250_PCI=y +CONFIG_SERIAL_8250_NR_UARTS=4 + +CONFIG_TMPFS=y +CONFIG_TMPFS_POSIX_ACL=y +CONFIG_TMPFS_XATTR=y + +CONFIG_DEVTMPFS=y +CONFIG_DEBUG_FS=y + +CONFIG_BT=y +CONFIG_BT_BREDR=y +CONFIG_BT_RFCOMM=y +CONFIG_BT_BNEP=y +CONFIG_BT_HIDP=y +CONFIG_BT_LE=y + +CONFIG_BT_HCIVHCI=y + +CONFIG_CRYPTO_CMAC=y +CONFIG_CRYPTO_USER_API=y +CONFIG_CRYPTO_USER_API_HASH=y +CONFIG_CRYPTO_USER_API_SKCIPHER=y + +CONFIG_UNIX=y + +CONFIG_UHID=y + +CONFIG_LOCKDEP_SUPPORT=y +CONFIG_DEBUG_SPINLOCK=y +CONFIG_DEBUG_LOCK_ALLOC=y +CONFIG_PROVE_LOCKING=y +CONFIG_LOCKDEP=y +CONFIG_DEBUG_MUTEXES=y
Signature · 1 line
2.26.2
Luiz Augusto von Dentz
maintainerPATCH v2 2/8 test-runner: Fix using removed options
From: Luiz Augusto von Dentz <[email protected]>
This removes -nodefconfig and -balloon which are not longer valid options:
qemu-system-x86_64: -nodefconfig: invalid option
qemu-system-x86_64: -balloon: invalid option
--- tools/test-runner.c | 2 -- 1 file changed, 2 deletions(-)
tools/test-runner.c +0 -2
@@ -181,7 +181,6 @@ static void prepare_sandbox(void)static char *const qemu_argv[] = {"" ,"-nodefaults" , -"-nodefconfig" ,"-no-user-config" ,"-monitor" ,"none" ,"-display" ,"none" ,
@@ -190,7 +189,6 @@ static char *const qemu_argv[] = {"-nographic" ,"-vga" ,"none" ,"-net" ,"none" , -"-balloon" ,"none" ,"-no-acpi" ,"-no-hpet" , "-no-reboot",
Signature · 1 line
2.26.2
Luiz Augusto von Dentz
maintainerPATCH v2 3/8 mgmt-tester: Print out the HCI received and expected cmd value
In reply to Luiz Augusto von DentzFrom: Luiz Augusto von Dentz <[email protected]>
This make it simpler to debug when the kernel has been updated and parameters no longer match:
--- tools/mgmt-tester.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
tools/mgmt-tester.c +3 -1
@@ -6381,7 +6381,9 @@ static void command_hci_callback(uint16_t opcode, const void *param, }if (memcmp (param, expect_hci_param, length) !=0 ) { -tester_warn ("Unexpected HCI command parameter value" ); +tester_warn ("Unexpected HCI command parameter value:" ); +util_hexdump ('>' , param, length, print_debug,"" ); +util_hexdump ('!' , expect_hci_param, length, print_debug,"" );tester_test_failed ();return ; }
Signature · 1 line
2.26.2
Luiz Augusto von Dentz
maintainerPATCH v2 4/8 mgmt-tester: Update set_connectable_off_adv_param
In reply to Luiz Augusto von DentzFrom: Luiz Augusto von Dentz <[email protected]>
Parameters have been changed in the kernel which now uses the following:
< HCI Command: LE Set Advertising Parameters (0x08|0x0006) plen 15
Min advertising interval: 62.500 msec (0x0064)
Max advertising interval: 93.750 msec (0x0096)
Type: Scannable undirected - ADV_SCAN_IND (0x02)
Own address type: Random (0x01)
Direct address type: Public (0x00)
Direct address: 00:00:00:00:00:00 (OUI 00-00-00)
Channel map: 37, 38, 39 (0x07)
Filter policy: Allow Scan Request from Any, Allow Connect Request from Any (0x00)
---
tools/mgmt-tester.c | 42 +++++++++++++++++++++---------------------
1 file changed, 21 insertions(+), 21 deletions(-)tools/mgmt-tester.c +21 -21
@@ -898,10 +898,10 @@ static uint16_t settings_powered_le_connectable_advertising[] = {MGMT_OP_SET_ADVERTISING , MGMT_OP_SET_POWERED, 0 }; -static uint8_t set_connectable_off_adv_param[] = { -0x00 ,0x08 ,/* min_interval */ -0x00 ,0x08 ,/* max_interval */ -0x03 ,/* type */ +static uint8_t set_connectable_off_scan_adv_param[] = { +0x64 ,0x00 ,/* min_interval */ +0x96 ,0x00 ,/* max_interval */ +0x02 ,/* type */ 0x01 ,/* own_addr_type */ 0x00 ,/* direct_addr_type */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, /* direct_addr */
@@ -919,8 +919,8 @@ static const struct generic_data set_connectable_off_le_test_2 = { .expect_len = sizeof(set_connectable_off_le_settings_2), .expect_settings_unset = MGMT_SETTING_CONNECTABLE, .expect_hci_command = BT_HCI_CMD_LE_SET_ADV_PARAMETERS, - .expect_hci_param = set_connectable_off_adv_param, - .expect_hci_len = sizeof(set_connectable_off_adv_param), + .expect_hci_param = set_connectable_off_scan_adv_param, + .expect_hci_len = sizeof(set_connectable_off_scan_adv_param), };static uint16_t settings_powered_le_discoverable[] = {
@@ -946,8 +946,8 @@ static const struct generic_data set_connectable_off_le_test_3 = { .expect_len = sizeof(set_connectable_off_le_settings_2), .expect_settings_unset = MGMT_SETTING_CONNECTABLE, .expect_hci_command = BT_HCI_CMD_LE_SET_ADV_PARAMETERS, - .expect_hci_param = set_connectable_off_adv_param, - .expect_hci_len = sizeof(set_connectable_off_adv_param), + .expect_hci_param = set_connectable_off_scan_adv_param, + .expect_hci_len = sizeof(set_connectable_off_scan_adv_param), };static const struct generic_data set_connectable_off_le_test_4 = {
@@ -961,8 +961,8 @@ static const struct generic_data set_connectable_off_le_test_4 = { .expect_len = sizeof(set_connectable_off_le_settings_2), .expect_settings_unset = MGMT_SETTING_CONNECTABLE, .expect_hci_command = BT_HCI_CMD_LE_SET_ADV_PARAMETERS, - .expect_hci_param = set_connectable_off_adv_param, - .expect_hci_len = sizeof(set_connectable_off_adv_param), + .expect_hci_param = set_connectable_off_scan_adv_param, + .expect_hci_len = sizeof(set_connectable_off_scan_adv_param), };static const char set_fast_conn_on_param[] = {0x01 };
@@ -4738,17 +4738,6 @@ static uint16_t settings_powered_le_connectable[] = {MGMT_OP_SET_LE , MGMT_OP_SET_CONNECTABLE, 0 }; -static uint8_t set_connectable_off_scan_adv_param[] = { -0x00 ,0x08 ,/* min_interval */ -0x00 ,0x08 ,/* max_interval */ -0x02 ,/* type */ -0x01 ,/* own_addr_type */ -0x00 ,/* direct_addr_type */ -0x00 ,0x00 ,0x00 ,0x00 ,0x00 ,0x00 ,/* direct_addr */ -0x07 ,/* channel_map */ -0x00 ,/* filter_policy */ -}; -static const struct generic_data add_advertising_success_13 = { .setup_settings = settings_powered_le, .send_opcode = MGMT_OP_ADD_ADVERTISING,
@@ -4762,6 +4751,17 @@ static const struct generic_data add_advertising_success_13 = { .expect_hci_len = sizeof(set_connectable_off_scan_adv_param), }; +static uint8_t set_connectable_off_adv_param[] = { +0x64 ,0x00 ,/* min_interval */ +0x96 ,0x00 ,/* max_interval */ +0x03 ,/* type */ +0x01 ,/* own_addr_type */ +0x00 ,/* direct_addr_type */ +0x00 ,0x00 ,0x00 ,0x00 ,0x00 ,0x00 ,/* direct_addr */ +0x07 ,/* channel_map */ +0x00 ,/* filter_policy */ +}; +static const struct generic_data add_advertising_success_14 = { .setup_settings = settings_powered_le, .send_opcode =MGMT_OP_ADD_ADVERTISING ,
Signature · 1 line
2.26.2
Luiz Augusto von Dentz
maintainerPATCH v2 5/8 mgmt-tester: Fix ext advertisement handle
In reply to Luiz Augusto von DentzFrom: Luiz Augusto von Dentz <[email protected]>
Handle has been change to 0x01 not 0x00:
< HCI Command: LE Set Extended Advertising Enable (0x08|0x0039) plen 6
Extended advertising: Enabled (0x01)
Number of sets: 1 (0x01)
Entry 0
Handle: 0x01
Duration: 0 ms (0x00)
Max ext adv events: 0
---
tools/mgmt-tester.c | 42 +++++++++++++++++++++---------------------
1 file changed, 21 insertions(+), 21 deletions(-)tools/mgmt-tester.c +21 -21
@@ -6950,7 +6950,7 @@ static const struct generic_data add_ext_advertising_fail_4 = {static const uint8_t set_ext_adv_data_uuid[] = {/* handle */ -0x00 , +0x01 ,/* complete data */ 0x03 ,/* controller should not fragment */
@@ -6982,7 +6982,7 @@ static const struct generic_data add_ext_advertising_success_1 = { };static const uint8_t set_ext_adv_data_test1[] = { -0x00 ,/* handle */ +0x01 ,/* handle */ 0x03 ,/* complete data */ 0x01 ,/* controller should not fragment */ 0x07 ,/* adv data len */
@@ -7010,7 +7010,7 @@ static const struct generic_data add_ext_advertising_success_pwron_data = {static const char set_ext_adv_on_set_adv_enable_param[] = {0x01 ,/* Enable */ 0x01 ,/* No of sets */ -0x00 ,/* Handle */ +0x01 ,/* Handle */ 0x00 ,0x00 ,/* Duration */ 0x00 ,/* Max events */ };
@@ -7082,7 +7082,7 @@ static const struct generic_data add_ext_advertising_success_6 = { };static const uint8_t set_ext_scan_rsp_uuid[] = { -0x00 ,/* handle */ +0x01 ,/* handle */ 0x03 ,/* complete data */ 0x01 ,/* controller should not fragment */ 0x0a ,/* scan rsp data len */
@@ -7115,7 +7115,7 @@ static const struct generic_data add_ext_advertising_success_7 = { };static uint8_t set_connectable_on_ext_adv_param[] = { -0x00 ,/* Handle */ +0x01 ,/* Handle */ 0x13 ,0x00 ,/* Event type */ 0x00 ,0x08 ,0x00 ,/* min_interval */ 0x00 ,0x08 ,0x00 ,/* max_interval */
@@ -7146,7 +7146,7 @@ static const struct generic_data add_ext_advertising_success_8 = { };static const uint8_t set_ext_adv_data_general_discov[] = { -0x00 ,/* handle */ +0x01 ,/* handle */ 0x03 ,/* complete data */ 0x01 ,/* controller should not fragment */ 0x0c ,/* adv data len */
@@ -7165,7 +7165,7 @@ static const uint8_t set_ext_adv_data_general_discov[] = { };static const uint8_t set_ext_adv_data_limited_discov[] = { -0x00 ,/* handle */ +0x01 ,/* handle */ 0x03 ,/* complete data */ 0x01 ,/* controller should not fragment */ 0x0c ,/* adv data len */
@@ -7180,7 +7180,7 @@ static const uint8_t set_ext_adv_data_limited_discov[] = { };static const uint8_t set_ext_adv_data_uuid_txpwr[] = { -0x00 ,/* handle */ +0x01 ,/* handle */ 0x03 ,/* complete data */ 0x01 ,/* controller should not fragment */ 0x0c ,/* adv data len */
@@ -7251,7 +7251,7 @@ static const struct generic_data add_ext_advertising_success_12 = { };static uint8_t set_connectable_off_scan_ext_adv_param[] = { -0x00 ,/* Handle */ +0x01 ,/* Handle */ 0x12 ,0x00 ,/* Event type */ 0x00 ,0x08 ,0x00 ,/* min_interval */ 0x00 ,0x08 ,0x00 ,/* max_interval */
@@ -7282,7 +7282,7 @@ static const struct generic_data add_ext_advertising_success_13 = { };static uint8_t set_connectable_off_ext_adv_param[] = { -0x00 ,/* Handle */ +0x01 ,/* Handle */ 0x10 ,0x00 ,/* Event type */ 0x00 ,0x08 ,0x00 ,/* min_interval */ 0x00 ,0x08 ,0x00 ,/* max_interval */
@@ -7424,7 +7424,7 @@ static const struct generic_data remove_ext_advertising_success_2 = { };static const uint8_t set_ext_adv_data_test2[] = { -0x00 ,/* handle */ +0x01 ,/* handle */ 0x03 ,/* complete data */ 0x01 ,/* controller should not fragment */ 0x07 ,/* adv data len */
@@ -7531,7 +7531,7 @@ static const struct generic_data add_ext_advertising_scrsp_appear_null = { };static const uint8_t ext_scan_rsp_data_empty[] = { -0x00 ,/* handle */ +0x01 ,/* handle */ 0x03 ,/* complete data */ 0x01 ,/* controller should not fragment */ 0x01 ,/* scan rsp data len */
@@ -7556,7 +7556,7 @@ static const struct generic_data add_ext_advertising_no_name_set = { };static const uint8_t set_ext_scan_rsp_data_name_fits_in_scrsp[] = { -0x00 ,/* handle */ +0x01 ,/* handle */ 0x03 ,/* complete data */ 0x01 ,/* controller should not fragment */ 0x0c ,/* Scan rsp data len */
@@ -7585,7 +7585,7 @@ static const struct generic_data add_ext_advertising_name_fits_in_scrsp = { };static const uint8_t set_ext_scan_rsp_data_shortened_name_fits[] = { -0x00 ,/* handle */ +0x01 ,/* handle */ 0x03 ,/* complete data */ 0x01 ,/* controller should not fragment */ 0x0d ,/* Scan rsp data len */
@@ -7615,7 +7615,7 @@ static const struct generic_data add_ext_advertising_shortened_name_in_scrsp = { };static const uint8_t set_ext_scan_rsp_data_param_name_data_ok[] = { -0x00 ,/* handle */ +0x01 ,/* handle */ 0x03 ,/* complete data */ 0x01 ,/* controller should not fragment */ 0x1e ,/* Scan rsp data len */
@@ -7660,7 +7660,7 @@ static const struct generic_data add_ext_advertising_name_data_inv = { };static const uint8_t set_ext_scan_rsp_data_name_data_appear[] = { -0x00 ,/* handle */ +0x01 ,/* handle */ 0x03 ,/* complete data */ 0x01 ,/* controller should not fragment */ 0x1e ,/* Scan rsp data len */
@@ -7710,7 +7710,7 @@ static const uint8_t add_advertising_1m_param_uuid[] = { };static uint8_t set_connectable_off_ext_1m_adv_param[] = { -0x00 ,/* Handle */ +0x01 ,/* Handle */ 0x00 ,0x00 ,/* Event type */ 0x00 ,0x08 ,0x00 ,/* min_interval */ 0x00 ,0x08 ,0x00 ,/* max_interval */
@@ -7758,7 +7758,7 @@ static const uint8_t add_advertising_2m_param_uuid[] = { };static uint8_t set_connectable_off_ext_2m_adv_param[] = { -0x00 ,/* Handle */ +0x01 ,/* Handle */ 0x00 ,0x00 ,/* Event type */ 0x00 ,0x08 ,0x00 ,/* min_interval */ 0x00 ,0x08 ,0x00 ,/* max_interval */
@@ -7806,7 +7806,7 @@ static const uint8_t add_advertising_coded_param_uuid[] = { };static uint8_t set_connectable_off_ext_coded_adv_param[] = { -0x00 ,/* Handle */ +0x01 ,/* Handle */ 0x00 ,0x00 ,/* Event type */ 0x00 ,0x08 ,0x00 ,/* min_interval */ 0x00 ,0x08 ,0x00 ,/* max_interval */
@@ -7857,7 +7857,7 @@ static const uint8_t add_advertising_param_scanrsp_1m[] = { };static uint8_t set_connectable_off_scan_ext_pdu_adv_param[] = { -0x00 ,/* Handle */ +0x01 ,/* Handle */ 0x02 ,0x00 ,/* Event type */ 0x00 ,0x08 ,0x00 ,/* min_interval */ 0x00 ,0x08 ,0x00 ,/* max_interval */
@@ -7888,7 +7888,7 @@ static const struct generic_data add_ext_advertising_success_scannable = { };static uint8_t set_connectable_on_ext_pdu_adv_param[] = { -0x00 ,/* Handle */ +0x01 ,/* Handle */ 0x01 ,0x00 ,/* Event type */ 0x00 ,0x08 ,0x00 ,/* min_interval */ 0x00 ,0x08 ,0x00 ,/* max_interval */
Signature · 1 line
2.26.2
Luiz Augusto von Dentz
maintainerPATCH v2 6/8 mgmt-tester: Don't run tests which command fails
In reply to Luiz Augusto von DentzFrom: Luiz Augusto von Dentz <[email protected]>
This indicates that emulator don't support the test and until proper support is added the test shall not be run.
--- tools/mgmt-tester.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
tools/mgmt-tester.c +1 -1
@@ -6304,7 +6304,7 @@ static void command_generic_callback(uint8_t status, uint16_t length, test->send_opcode, mgmt_errstr(status), status);if (status != test->expect_status) { -tester_test_failed (); +tester_test_abort ();return ; }
Signature · 1 line
2.26.2
Luiz Augusto von Dentz
maintainerPATCH v2 7/8 mgmt-tester: Fix failing pairing tests
In reply to Luiz Augusto von DentzFrom: Luiz Augusto von Dentz <[email protected]>
Just-works pairing does request user confirmation.
--- tools/mgmt-tester.c | 6 ------ 1 file changed, 6 deletions(-)
tools/mgmt-tester.c +0 -6
@@ -6051,12 +6051,6 @@ static void user_confirm_request_callback(uint16_t index, uint16_t length,struct mgmt_cp_user_confirm_reply cp;uint16_t opcode; -if (test->just_works) { -tester_warn ("User Confirmation received for just-works case" ); -tester_test_failed (); -return ; - } -memset (&cp,0 ,sizeof (cp));memcpy (&cp.addr, &ev->addr,sizeof (cp.addr));
Signature · 1 line
2.26.2
Luiz Augusto von Dentz
maintainerPATCH v2 8/8 emulator: Return error for ext adv feature not supported
In reply to Luiz Augusto von DentzFrom: Luiz Augusto von Dentz <[email protected]>
This return an error if LE Set Extended Advertising Enable is used with unsupported features.
--- emulator/btdev.c | 15 +++++++++++++-- 1 file changed, 13 insertions(+), 2 deletions(-)
emulator/btdev.c +13 -2
@@ -3760,8 +3760,19 @@ static void default_cmd(struct btdev *btdev, uint16_t opcode,if (btdev->le_adv_enable == lseae->enable) status =BT_HCI_ERR_COMMAND_DISALLOWED ;else { - btdev->le_adv_enable = lseae->enable; - status =BT_HCI_ERR_SUCCESS ; +const struct bt_hci_cmd_ext_adv_set *eas; + +if (lseae->num_of_sets) { + eas = data +sizeof (*lseae); +if (eas->duration || lseae->num_of_sets >1 ) + status =BT_HCI_ERR_INVALID_PARAMETERS ; +else + status =BT_HCI_ERR_SUCCESS ; + }else + status =BT_HCI_ERR_SUCCESS ; + +if (status ==BT_HCI_ERR_SUCCESS ) + btdev->le_adv_enable = lseae->enable; }cmd_complete (btdev, opcode, &status,sizeof (status));if (status ==BT_HCI_ERR_SUCCESS && btdev->le_adv_enable)
Signature · 1 line
2.26.2
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=377723
---Test result---
##############################
Test: CheckPatch - FAIL
Output:
mgmt-tester: Update set_connectable_off_adv_param
WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) #16:
Filter policy: Allow Scan Request from Any, Allow Connect Request from Any (0x00)
- total: 0 errors, 1 warnings, 78 lines checked
NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.
"[PATCH] mgmt-tester: Update set_connectable_off_adv_param" has style problems, please review.
NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPLIT_STRING SSCANF_TO_KSTRTO
NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
##############################
Test: CheckGitLint - FAIL
Output:
mgmt-tester: Update set_connectable_off_adv_param
13: B1 Line exceeds max length (89>80): " Filter policy: Allow Scan Request from Any, Allow Connect Request from Any (0x00)"
##############################
Test: CheckBuild - PASS
##############################
Test: MakeCheck - PASS
---
Regards,
Linux Bluetooth
Luiz Augusto von Dentz
maintainerHi,
Quoted 39 lines · On Wed, Nov 4, 2020 at 4:54 PM <[email protected]> wrote:
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=377723---Test result---
##############################
Test: CheckPatch - FAIL
Output:
mgmt-tester: Updateset_connectable_off_adv_param
WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) #16:Filter policy: Allow Scan Request from Any, Allow Connect Request from Any (0x00)- total: 0 errors, 1 warnings, 78 lines checked
NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace."[PATCH] mgmt-tester: Update
set_connectable_off_adv_param" has style problems, please review.NOTE: Ignored message types:
COMMIT_MESSAGECOMPLEX_MACROCONST_STRUCTFILE_PATH_CHANGESMISSING_SIGN_OFFPREFER_PACKEDSPLIT_STRINGSSCANF_TO_KSTRTONOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH inMAINTAINERS.##############################
Test: CheckGitLint - FAIL
Output:
mgmt-tester: Updateset_connectable_off_adv_param
13: B1 Line exceeds max length (89>80): " Filter policy: Allow Scan Request from Any, Allow Connect Request from Any (0x00)"
Quoted 5 lines
##############################
Test: CheckBuild - PASS##############################
Test: MakeCheck - PASS
Pushed.
Signature · 1 line
Luiz Augusto von Dentz