Skip to contentSkip to conversation

common/rc: allow setting $SCRATCH_FS_MOUNT_OPTS

PATCH In review Jeff Layton 2 participants 3 messages Nov 5, 2020 – Nov 9, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 common/rc: allow setting $SCRATCH_FS_MOUNT_OPTS

We already have a $TEST_FS_MOUNT_OPTS which gets applied only to the test mount, but we don't have a corresponding variable for the scratch mount. Add one.

---
 common/rc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
common/rc +1 -1
index 65ebfe201139..23874d1e5b8e 100644
@@ -308,7 +308,7 @@ _scratch_mount_options()
 {
 	_scratch_options mount
 
-	echo `_common_dev_mount_options $*` $SCRATCH_OPTIONS \
+	echo `_common_dev_mount_options $*` $SCRATCH_OPTIONS $SCRATCH_FS_MOUNT_OPTS \
 					$SCRATCH_DEV $SCRATCH_MNT
 }
 
Signature · 1 line
2.28.0
#1 lore raw
Quoted 3 lines · Jeff Layton

We already have a $TEST_FS_MOUNT_OPTS which gets applied only to the test mount, but we don't have a corresponding variable for the scratch mount. Add one.

MOUNT_OPTIONS is used for the scratch mount, and _common_dev_mount_options includes it. Would you please confirm if that works for you?

Thanks,
Eryu

Quoted 21 lines
---
 common/rc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
common/rc +1 -1
index 65ebfe201139..23874d1e5b8e 100644
@@ -308,7 +308,7 @@ _scratch_mount_options()
 {
 	_scratch_options mount
 
-	echo `_common_dev_mount_options $*` $SCRATCH_OPTIONS \
+	echo `_common_dev_mount_options $*` $SCRATCH_OPTIONS $SCRATCH_FS_MOUNT_OPTS \
 					$SCRATCH_DEV $SCRATCH_MNT
 }
 
Signature · 1 line
2.28.0
#2 lore raw
Quoted 5 lines · Eryu Guan
Quoted 3 lines · Jeff Layton

We already have a $TEST_FS_MOUNT_OPTS which gets applied only to the test mount, but we don't have a corresponding variable for the scratch mount. Add one.

Quoted 7 lines

MOUNT_OPTIONS is used for the scratch mount, and _common_dev_mount_options includes it. Would you please confirm if that works for you?

Thanks,
Eryu

Yes, it does. I had had a problem with that at one point, but I don't currently recall what it was. In any case, feel free to drop this one.

Thanks,
Jeff

Quoted 26 lines
Quoted 26 lines

---
 common/rc | 2 +-

 1 file changed, 1 insertion(+), 1 deletion(-)
common/rc +0 -0
index 65ebfe201139..23874d1e5b8e 100644
@@ -308,7 +308,7 @@ _scratch_mount_options()
  {

  _scratch_options mount

common/rc +1 -1
-	echo `_common_dev_mount_options $*` $SCRATCH_OPTIONS \
+	echo `_common_dev_mount_options $*` $SCRATCH_OPTIONS $SCRATCH_FS_MOUNT_OPTS \

  $SCRATCH_DEV $SCRATCH_MNT }

Signature · 1 line
2.28.0
Signature · 1 line
Jeff Layton <[email protected]>