drm/vc4: replace idr_init() by idr_init_base()
Subsystems (3)
PATCH v2 1/1 drm/vc4: replace idr_init() by idr_init_base()
idr_init() uses base 0 which is an invalid identifier for this driver. The idr_alloc for this driver uses VC4_PERFMONID_MIN as start value for ID range and it is #defined to 1. The new function idr_init_base allows IDR to set the ID lookup from base 1. This avoids all lookups that otherwise starts from 0 since 0 is always unused / available.
References: commit 6ce711f27500 ("idr: Make 1-based IDRs more efficient")
---
Changes since v1:
- Change suggested by Eric Anholt
1. Use VC4_PERFMONID_MIN instead of magic number 1
drivers/gpu/drm/vc4/vc4_perfmon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/vc4/vc4_perfmon.c +1 -1
@@ -77,7 +77,7 @@ struct vc4_perfmon *vc4_perfmon_find(struct vc4_file *vc4file, int id)void vc4_perfmon_open_file (struct vc4_file *vc4file) {mutex_init (&vc4file->perfmon.lock); -idr_init (&vc4file->perfmon.idr); +idr_init_base (&vc4file->perfmon.idr,VC4_PERFMONID_MIN ); }static int vc4_perfmon_idr_del (int id,void *elem,void *data)
Signature · 1 line
2.25.1
Quoted 32 lines · Deepak R Varma
idr_init()uses base 0 which is an invalid identifier for this driver. Theidr_allocfor this driver usesVC4_PERFMONID_MINas start value for ID range and it is #defined to 1. The new functionidr_init_baseallows IDR to set the ID lookup from base 1. This avoids all lookups that otherwise starts from 0 since 0 is always unused / available.References: commit
6ce711f27500("idr: Make 1-based IDRs more efficient")Signed-off-by Deepak R Varma <[email protected]>---
Changes since v1:
- Change suggested by Eric Anholt
1. UseVC4_PERFMONID_MINinstead of magic number 1drivers/gpu/drm/vc4/vc4_perfmon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/vc4/vc4_perfmon.c +1
-2@@ -77,7 +77,7 @@ struct vc4_perfmon *vc4_perfmon_find(struct vc4_file *vc4file, int id)void vc4_perfmon_open_file (struct vc4_file *vc4file) {mutex_init (&vc4file->perfmon.lock); -idr_init (&vc4file->perfmon.idr); +idr_init_base (&vc4file->perfmon.idr,VC4_PERFMONID_MIN ); }static int vc4_perfmon_idr_del (int id,void *elem,void *data) --
Quoted 1 line
2.25.1
hopefully Maxime can apply it.
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Maxime Ripard
AppliedQuoted 31 lines · Eric Anholt
Quoted 30 lines · Deepak R Varma
idr_init()uses base 0 which is an invalid identifier for this driver. Theidr_allocfor this driver usesVC4_PERFMONID_MINas start value for ID range and it is #defined to 1. The new functionidr_init_baseallows IDR to set the ID lookup from base 1. This avoids all lookups that otherwise starts from 0 since 0 is always unused / available.References: commit
6ce711f27500("idr: Make 1-based IDRs more efficient")Signed-off-by Deepak R Varma <[email protected]>---
Changes since v1:
- Change suggested by Eric Anholt
1. UseVC4_PERFMONID_MINinstead of magic number 1drivers/gpu/drm/vc4/vc4_perfmon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/vc4/vc4_perfmon.c +1
-1@@ -77,7 +77,7 @@ struct vc4_perfmon *vc4_perfmon_find(struct vc4_file *vc4file, int id)void vc4_perfmon_open_file (struct vc4_file *vc4file) {mutex_init (&vc4file->perfmon.lock); -idr_init (&vc4file->perfmon.idr); +idr_init_base (&vc4file->perfmon.idr,VC4_PERFMONID_MIN ); }
Quoted 7 lines
Quoted 3 lines
drivers/gpu/drm/vc4/vc4_perfmon.c +0
-1static int vc4_perfmon_idr_del (int id,void *elem,void *data) --2.25.1
Reviewed-by Eric Anholt <[email protected]>hopefully Maxime can apply it.
Applied, thanks!
Maxime
Quoted 38 lines · Maxime Ripard
Quoted 37 lines · Eric Anholt
Quoted 32 lines · Deepak R Varma
idr_init()uses base 0 which is an invalid identifier for this driver. Theidr_allocfor this driver usesVC4_PERFMONID_MINas start value for ID range and it is #defined to 1. The new functionidr_init_baseallows IDR to set the ID lookup from base 1. This avoids all lookups that otherwise starts from 0 since 0 is always unused / available.References: commit
6ce711f27500("idr: Make 1-based IDRs more efficient")Signed-off-by Deepak R Varma <[email protected]>---
Changes since v1:
- Change suggested by Eric Anholt
1. UseVC4_PERFMONID_MINinstead of magic number 1drivers/gpu/drm/vc4/vc4_perfmon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/vc4/vc4_perfmon.c +1
-2@@ -77,7 +77,7 @@ struct vc4_perfmon *vc4_perfmon_find(struct vc4_file *vc4file, int id)void vc4_perfmon_open_file (struct vc4_file *vc4file) {mutex_init (&vc4file->perfmon.lock); -idr_init (&vc4file->perfmon.idr); +idr_init_base (&vc4file->perfmon.idr,VC4_PERFMONID_MIN ); }static int vc4_perfmon_idr_del (int id,void *elem,void *data) --Quoted 1 line
2.25.1
Reviewed-by Eric Anholt <[email protected]>
Quoted 3 lines
Quoted 1 line
hopefully Maxime can apply it.
Applied, thanks!
Thank you all. Appreciate your time.
./drv
Quoted 1 line
Maxime