Skip to contentSkip to conversation

kunit: tool: unmark test_data as binary blobs

PATCH In review Brendan Higgins 2 participants 2 messages Nov 5, 2020 – Nov 7, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 kunit: tool: unmark test_data as binary blobs

The tools/testing/kunit/test_data/ directory was marked as binary because some of the test_data files cause checkpatch warnings. Fix this by dropping the .gitattributes file.

Fixes afc63da64f1e ("kunit: kunit_parser: make parser more robust")
---
 tools/testing/kunit/.gitattributes | 1 -
 1 file changed, 1 deletion(-)
 delete mode 100644 tools/testing/kunit/.gitattributes
tools/testing/kunit/.gitattributes deleted +0 -1
deleted file mode 100644
index 5b7da1fc3b8f1..0000000000000
@@ -1 +0,0 @@
-test_data/* binary

base-commit: 4ef8451b332662d004df269d4cdeb7d9f31419b5

Signature · 1 line
2.29.1.341.ge80a0c044ae-goog
Reviewed-by on v1 1/1
#1 lore raw
Quoted 8 lines · Brendan Higgins

The tools/testing/kunit/test_data/ directory was marked as binary because some of the test_data files cause checkpatch warnings. Fix this by dropping the .gitattributes file.

Fixes afc63da64f1e ("kunit: kunit_parser: make parser more robust")

---

Thanks. I wasn't able to find any issues which required those files to be binary.

For the record, a link to the original issue, which appeared to be with whitespace (spaces before tabs) in git apply:
https://lkml.org/lkml/2020/3/13/920

Cheers,
-- David