Skip to contentSkip to conversation

imx: ahab: fix implicit declaration warning

PATCH New Oliver Graute 2 participants 6 messages Nov 6, 2020 – Dec 8, 2020

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 imx: ahab: fix implicit declaration warning

Fix the following warning:

arch/arm/mach-imx/imx8/ahab.c:105:3: warning: implicit declaration of function ?flush_dcache_range? [-Wimplicit-function-declaration]
flush_dcache_range(s, e);
^~~~~~~~~~~~~~~~~~

Include cpu_func.h header which declares the flush_dcache_range() function.

Cc Stefano Babic <[email protected]>
Cc uboot-imx <[email protected]>
---
 arch/arm/mach-imx/imx8/ahab.c | 1 +
 1 file changed, 1 insertion(+)
arch/arm/mach-imx/imx8/ahab.c +1 -0
index 5dbe1d56e0..abd648a60c 100644
@@ -14,6 +14,7 @@
 #include <asm/arch/sys_proto.h>
 #include <asm/arch/image.h>
 #include <console.h>
+#include <cpu_func.h>
 
 DECLARE_GLOBAL_DATA_PTR;
 
Signature · 1 line
2.17.1
#1 lore raw

PATCH 1/1 imx: ahab: fix compiler warnings in debug

arch/arm/mach-imx/imx8/ahab.c: In function ?authenticate_os_container?:
arch/arm/mach-imx/imx8/ahab.c:96:9: warning: format ?%x? expects argument of type ?unsigned int?, but argument 9 has type ?ulong {aka long unsigned int}? [-Wformat=]
debug("img %d, dst 0x%x, src 0x%x, size 0x%x\n",

Fix those by using "%lu" specified.

Cc Stefano Babic <[email protected]>
Cc uboot-imx <[email protected]>
---
 arch/arm/mach-imx/imx8/ahab.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/mach-imx/imx8/ahab.c +1 -1
index abd648a60c..c77beb2b16 100644
@@ -93,7 +93,7 @@ int authenticate_os_container(ulong addr)
 					    sizeof(struct container_hdr) +
 					    i * sizeof(struct boot_img_t));
 
-		debug("img %d, dst 0x%x, src 0x%x, size 0x%x\n",
+		debug("img %d, dst 0x%x, src 0x%lux, size 0x%x\n",
 		      i, (uint32_t) img->dst, img->offset + addr, img->size);
 
 		memcpy((void *)img->dst, (const void *)(img->offset + addr),
Signature · 1 line
2.17.1
#2 lore raw

PATCH 1/1 imx: ahab: fix compiler warnings in debug

Quoted 8 lines

arch/arm/mach-imx/imx8/ahab.c: In function ?authenticate_os_container?:
arch/arm/mach-imx/imx8/ahab.c:96:9: warning: format ?%x? expects argument of type ?unsigned int?, but argument 9 has type ?ulong {aka long unsigned int}? [-Wformat=]
debug("img %d, dst 0x%x, src 0x%x, size 0x%x\n",
Fix those by using "%lu" specified.

Cc Stefano Babic <[email protected]>
Cc uboot-imx <[email protected]>

Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
#3 lore raw

PATCH 1/1 imx: ahab: Fix compiler warnings in printf

In reply to Oliver Graute

arch/arm/mach-imx/imx8/ahab.c:110:63: warning: format ?%x? expects argument of type ?unsigned int?, but argument 2 has type ?u64 {aka long long unsigned int}? [-Wformat=]

Fix those by using %llx

Cc Stefano Babic <[email protected]>
Cc uboot-imx <[email protected]>
---
 arch/arm/mach-imx/imx8/ahab.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/mach-imx/imx8/ahab.c +1 -1
index c77beb2b16..4bb7c46921 100644
@@ -107,7 +107,7 @@ int authenticate_os_container(ulong addr)
 		/* Find the memreg and set permission for seco pt */
 		err = sc_rm_find_memreg(-1, &mr, s, e);
 		if (err) {
-			printf("Error: can't find memreg for image load address 0x%x, error %d\n", img->dst, err);
+			printf("Error: can't find memreg for image load address 0x%llx, error %d\n", img->dst, err);
 			ret = -ENOMEM;
 			goto exit;
 		}
Signature · 1 line
2.17.1
#4 lore raw

PATCH 1/1 imx: ahab: Fix compiler warnings in printf

Quoted 7 lines

arch/arm/mach-imx/imx8/ahab.c:110:63: warning: format ?%x? expects argument of type ?unsigned int?, but argument 2 has type ?u64 {aka long long unsigned int}? [-Wformat=]
Fix those by using %llx

Cc Stefano Babic <[email protected]>
Cc uboot-imx <[email protected]>

Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
#5 lore raw

PATCH 1/1 imx: ahab: fix implicit declaration warning

In reply to Oliver Graute
Quoted 9 lines

Fix the following warning:
arch/arm/mach-imx/imx8/ahab.c:105:3: warning: implicit declaration of function ?flush_dcache_range? [-Wimplicit-function-declaration]

   flush_dcache_range(s, e);
   ^~~~~~~~~~~~~~~~~~

Include cpu_func.h header which declares the flush_dcache_range() function.

Cc Stefano Babic <[email protected]>
Cc uboot-imx <[email protected]>

Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================